strong_like_bull 0.0.1 → 0.0.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: 8b0393c6ceebf9d7248d563b6dd8230fbbe55c25
-  data.tar.gz: d696c836d5f3e5a79c34ca7d56b70c3e89f89a8e
+SHA256:
+  metadata.gz: 8d77c3395f1e522af013ce0b2881cdaaee74d783a0b29484d414f41511682692
+  data.tar.gz: 14230a740a04f9f4c04aa0b55d35009e1de61ee0ddf7965e97bea66a0dcc9663
 SHA512:
-  metadata.gz: e53260b390969696c03c0d8de9d9418a749d4368012a9522ca0c87e48843281bce37918b8a64c96e12177e66bd90c514470f02ae8ca76ca4e77c8e2494dd2bf4
-  data.tar.gz: 018f697777a1727559713549c7c2dfa5838cf59a22dddacdee5d1c25fdc9d78d25c6afdad5a9e23d725dc83641ffb6d86456890fe6974a92dd1de0eb62322194
+  metadata.gz: 595c78dffff3b1268959e83106282d15892b8dd9a22a59153afa27e03ada98e97ad8028dbf499f0001297c46fc94d4b40a507679d4ee93aa63f4905b55cd1946
+  data.tar.gz: 151fb4f1b60fcb3d6a04475f711d31643ac03b0c00f91262e8b3974d3f9f263c1c441e23eafc9af6030063bbc3b14083e68fa663b8fb8a8295d09d082110a8d3

data/.ruby-version

@@ -1 +1 @@
-2.1.5
+2.7.0

data/CHANGELOG.md

@@ -0,0 +1,2 @@
+0.0.2
+* StrongLikeBull now properly works on Rails >= 5

data/Gemfile

@@ -2,3 +2,10 @@ source 'https://rubygems.org'
 
 # Specify your gem's dependencies in strong_like_bull.gemspec
 gemspec
+
+gem "rails", github: "rails/rails", branch: "6-0-stable"
+
+group :development, :test do
+  gem "rspec", "~> 3.6.0"
+  gem "byebug"
+end

data/README.md

@@ -21,13 +21,14 @@ Or install it yourself as:
 ## Usage
 
 In application_controller.rb or a specific controller, add the following line:
+
     include StrongLikeBull
 
 In any controller action where you want a recommendation for the strong parameters permitted parameters based on the request parameters, add the following inside the action:
 
     def CONTROLLER_ACTION
-        log_suggested_strong_parameters_format(PARAMETER_NAME_TO_INSPECT)
-        # perform action
+      log_suggested_strong_parameters_format(PARAMETER_NAME_TO_INSPECT)
+      # perform action
     end
 
 When the controller action gets hit, it will log the recommended strong params permitted params to use in the following format:
@@ -44,8 +45,8 @@ StrongLikeBull only serves to recommend params to permit based on what is passed
 If you wanted the recommended params to permit for the update action of a Posts Controller, it would like:
 
     def update
-        log_suggested_strong_parameters_format(:post)
-        # perform update
+      log_suggested_strong_parameters_format(:post)
+      # perform update
     end
 
 The above example would assume the a a parameter is passed to the controller called "post" which contained all the fields we want to permit. The request parameters might look something like this:
@@ -59,6 +60,6 @@ If those request parameters were passed to the update action above, we'd see the
 Using that suggested format, we could then modify our update action to the following:
 
     def update
-        permitted_params = params.require(:post).permit [:name, {:tags=>[]}, :description]
-        # perform update
+      permitted_params = params.require(:post).permit [:name, {:tags=>[]}, :description]
+      # perform update
     end

data/lib/strong_like_bull.rb

@@ -6,13 +6,14 @@ module StrongLikeBull
   end
 
   def suggested_strong_parameters_format(key)
-    hash = params[key]
+    hash = params.respond_to?(:to_unsafe_h) ? params.to_unsafe_h : params
+    hash = hash[key]
     recursive_suggested_strong_parameters_format(hash) if hash
   end
 
   private
   def recursive_suggested_strong_parameters_format(object)
-    if object.is_a? Hash
+    if object.is_a?(Hash)
       if object.keys.first.match(/^\d+$/)
         hash = {}
         object.values.each do |value|

data/lib/strong_like_bull/version.rb

@@ -1,3 +1,3 @@
 module StrongLikeBull
-  VERSION = "0.0.1"
+  VERSION = "0.0.2"
 end

data/spec/integration/strong_like_bull_spec.rb

@@ -2,19 +2,20 @@ require "spec_helper"
 require "action_controller"
 
 describe "StrongLikeBull" do
-  before :each do
-    @object = Object.new
-    @object.extend(StrongLikeBull)
-  end
+  subject {
+    Object.new.tap do |object|
+      object.extend(StrongLikeBull)
+    end
+  }
 
   it "should be able to suggest the appropriate format for the example from http://www.railsexperiments.com/using-strong-parameters-with-nested-forms/" do
     inner_params = HashWithIndifferentAccess.new username: "john", data: { foo: "bar" }
     expected_format = [:username, data: [:foo]]
     params = ActionController::Parameters.new(user: inner_params)
     # sanity check that our expected format indeed does extract the inner_params out
-    expect(params.require(:user).permit(expected_format)).to eql inner_params
-    @object.expects(:params).returns params
-    expect(@object.suggested_strong_parameters_format(:user)).to eql expected_format
+    expect(params.require(:user).permit(expected_format)).to match_hash inner_params
+    allow(subject).to receive(:params).and_return params
+    expect(subject.suggested_strong_parameters_format(:user)).to eql expected_format
   end
 
   it "should be able to suggest the appropriate format for the nested params example from https://github.com/rails/strong_parameters/" do
@@ -24,9 +25,9 @@ describe "StrongLikeBull" do
     expected_format = [:name, {:emails => []}, :friends => [ :name, { :family => [ :name ] },  { :hobbies => [] }]]
     params = ActionController::Parameters.new(user: inner_params )
     # sanity check that our expected format indeed does extract the inner_params out
-    expect(params.require(:user).permit(expected_format)).to eql inner_params
-    @object.expects(:params).returns params
-    expect(@object.suggested_strong_parameters_format(:user)).to eql expected_format
+    expect(params.require(:user).permit(expected_format)).to match_hash inner_params
+    allow(subject).to receive(:params).and_return params
+    expect(subject.suggested_strong_parameters_format(:user)).to eql expected_format
   end
 
   it "should be able to suggest the appropriate format for a complex example from work (with field names randomized)" do
@@ -45,9 +46,9 @@ describe "StrongLikeBull" do
                        {:random_field_18=>[:random_field_19, :value, :id, {:random_field_20=>[:id]}]}]
     params = ActionController::Parameters.new(variant: inner_params )
     # sanity check that our expected format indeed does extract the inner_params out
-    expect(params.require(:variant).permit(expected_format)).to eql inner_params
-    @object.expects(:params).returns params
-    expect(@object.suggested_strong_parameters_format(:variant)).to eql expected_format
+    expect(params.require(:variant).permit(expected_format)).to match_hash inner_params
+    allow(subject).to receive(:params).and_return params
+    expect(subject.suggested_strong_parameters_format(:variant)).to eql expected_format
   end
 
   it "should be able to suggest the appropriate format for a second complex example from work (with field names randomized)" do
@@ -81,9 +82,9 @@ describe "StrongLikeBull" do
                        :random_field_33, {:random_field_34 => [:title_tag, :description, :h1]}]
     params = ActionController::Parameters.new(product: inner_params )
     # sanity check that our expected format indeed does extract the inner_params out
-    expect(params.require(:product).permit(expected_format)).to eql inner_params
-    @object.expects(:params).returns params
-    expect(@object.suggested_strong_parameters_format(:product)).to eql expected_format
+    expect(params.require(:product).permit(expected_format)).to match_hash inner_params
+    allow(subject).to receive(:params).and_return params
+    expect(subject.suggested_strong_parameters_format(:product)).to eql expected_format
   end
 
   it "should be able to suggest the appropriate format for a third complex example from work (with field names randomized)" do
@@ -166,21 +167,25 @@ describe "StrongLikeBull" do
                          :random_field_91, :random_field_92, {:random_field_93=>[:random_field_94, :_destroy, :id, :random_field_98, :random_field_97, :random_field_95, :random_field_96]},
                          {:random_field_102=>[:random_field_20, :random_field_21, :random_field_22, :random_field_23, :random_field_24, :random_field_25, :random_field_97, :random_field_85, :id, :_destroy]}, :random_field_99, :random_field_100, :random_field_101,
                          {:random_field_103=>[:random_field_104, :random_field_105, :random_field_106]}, :random_field_107]
-    @object.expects(:params).returns params
+    allow(subject).to receive(:params).and_return params
     # sanity check that our expected format indeed does extract the inner_params out
-    expect(params.require(:product).permit(expected_format)).to eql inner_params
-    expect(@object.suggested_strong_parameters_format(:product)).to eql expected_format
+    expect(params.require(:product).permit(expected_format)).to match_hash inner_params
+    expect(subject.suggested_strong_parameters_format(:product)).to eql expected_format
   end
 
   it "should combine the attributes of nested hashes" do
-    inner_params = HashWithIndifferentAccess.new :products => [{:id => 50, :name => "Name 1"},
-                                                               {:id => 51, :name => "Name 2", :description => "My description"},
-                                                               {:name => "Name 3", :caption => "My caption"}]
-    params = ActionController::Parameters.new(object: inner_params )
+    inner_params = {
+      products: [
+        {:id => 50, :name => "Name 1"},
+        {:id => 51, :name => "Name 2", :description => "My description"},
+        {:name => "Name 3", :caption => "My caption"}
+      ]
+    }
+    params = ActionController::Parameters.new(object: inner_params)
     expected_format = [{:products => [:id, :name, :description, :caption]}]
-    @object.expects(:params).returns params
+    allow(subject).to receive(:params).and_return params
     # sanity check that our expected format indeed does extract the inner_params out
-    expect(params.require(:object).permit(expected_format)).to eql inner_params
-    expect(@object.suggested_strong_parameters_format(:object)).to eql expected_format
+    expect(params.require(:object).permit(expected_format)).to match_hash inner_params
+    expect(subject.suggested_strong_parameters_format(:object)).to eql expected_format
   end
 end

data/spec/spec_helper.rb

@@ -3,7 +3,11 @@ require 'bundler/setup'
 require 'byebug'
 require 'strong_like_bull'
 
+RSpec::Matchers.define :match_hash do |expected|
+  match { |actual| expect(actual.to_unsafe_h).to match(expected) }
+end
+
 RSpec.configure do |config|
-  config.mock_with :mocha
+  config.mock_with :rspec
 end
 

data/strong_like_bull.gemspec

@@ -4,26 +4,19 @@ $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 require 'strong_like_bull/version'
 
 Gem::Specification.new do |spec|
-  spec.name          = "strong_like_bull"
+  spec.name          = 'strong_like_bull'
   spec.version       = StrongLikeBull::VERSION
-  spec.authors       = ["Andrew Hunter"]
-  spec.email         = ["andrew.hunter@livingsocial.com"]
+  spec.authors       = ['Andrew Hunter']
+  spec.email         = ['andrew.hunter@livingsocial.com']
   spec.summary       = %q{Upgrade to strong parameters the easy way}
   spec.description   = %q{Makes it super simple to add strong parameters into your application by examining request parameters and recommending what feeds should be permitted.}
-  spec.homepage      = ""
-  spec.license       = "MIT"
+  spec.homepage      = ''
+  spec.license       = 'MIT'
 
   spec.files         = `git ls-files -z`.split("\x0")
   spec.executables   = spec.files.grep(%r{^bin/}) { |f| File.basename(f) }
   spec.test_files    = spec.files.grep(%r{^(test|spec|features)/})
-  spec.require_paths = ["lib"]
+  spec.require_paths = ['lib']
 
-  spec.add_dependency "rails", ">= 3.0.0"
-
-  spec.add_development_dependency "bundler", "~> 1.7"
-  spec.add_development_dependency "rake", "~> 10.0"
-  spec.add_development_dependency "simplecov"
-  spec.add_development_dependency "rspec-rails"
-  spec.add_development_dependency "mocha"
-  spec.add_development_dependency "byebug"
+  spec.add_dependency 'rails', '>= 3.0.0'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: strong_like_bull
 version: !ruby/object:Gem::Version
-  version: 0.0.1
+  version: 0.0.2
 platform: ruby
 authors:
 - Andrew Hunter
-autorequire: 
+autorequire:
 bindir: bin
 cert_chain: []
-date: 2015-06-11 00:00:00.000000000 Z
+date: 2021-01-13 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
@@ -24,90 +24,6 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: 3.0.0
-- !ruby/object:Gem::Dependency
-  name: bundler
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '1.7'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '1.7'
-- !ruby/object:Gem::Dependency
-  name: rake
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '10.0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '10.0'
-- !ruby/object:Gem::Dependency
-  name: simplecov
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-- !ruby/object:Gem::Dependency
-  name: rspec-rails
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-- !ruby/object:Gem::Dependency
-  name: mocha
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-- !ruby/object:Gem::Dependency
-  name: byebug
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
 description: Makes it super simple to add strong parameters into your application
   by examining request parameters and recommending what feeds should be permitted.
 email:
@@ -117,8 +33,8 @@ extensions: []
 extra_rdoc_files: []
 files:
 - ".gitignore"
-- ".ruby-gemset"
 - ".ruby-version"
+- CHANGELOG.md
 - Gemfile
 - LICENSE.txt
 - README.md
@@ -132,7 +48,7 @@ homepage: ''
 licenses:
 - MIT
 metadata: {}
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -147,9 +63,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.4.3
-signing_key: 
+rubygems_version: 3.1.2
+signing_key:
 specification_version: 4
 summary: Upgrade to strong parameters the easy way
 test_files:

data/.ruby-gemset

@@ -1 +0,0 @@
-strong_like_bull