strong_actions 0.0.8 → 0.0.9

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: ec98b307601e5b612378cdf15bb408ecd46d8d3e
-  data.tar.gz: c83e0369fc8ad26013a4aa038ad136bc98365eac
+  metadata.gz: 2cb9467219528ebebcfced8aba69697ccce65389
+  data.tar.gz: 968f1316ff553ee8f9075acb4797e8d875f0a467
 SHA512:
-  metadata.gz: d62efe31e6643ac089a48ba3afc40a43392e712b191a23e616e610d9625a78ae0da61ed39002770a694444ead9a52c2872464f1a95c066e7387908aa6642c240
-  data.tar.gz: 38cc34be27b1ab9edf7c61f9b85992c8585501a47a6d66e4e06e89660fc44c19b984f4a9dc39ae9dd880ccce9a8a49fd49545f5b52673e26980a5be50d5f6c7f
+  metadata.gz: 4a6a0c9caf21a3d6d95a3a3cdaeb4f75c1fdce95f9ca2ed5cf8965b0c365097d7080f4a9338fd804c55c133b3755ad5be23a4b63fc2f7525728ae7f5c62467b3
+  data.tar.gz: 2b72b1197594bda0b7cdbb9f0b5a58504922999f0214405eb073ab5e72b0011b3ec3ac6ef350579e64e94cde3bbbb5cd4e23db54cd9a955c2b12d48e79d46281

data/.travis.yml

@@ -2,8 +2,8 @@ sudo: false
 language: ruby
 cache: bundler
 rvm:
+  - 2.4.0
   - 2.3.3
   - 2.2.6
-  - 2.1.9
 script:
   - bundle exec rake test

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    strong_actions (0.0.8)
+    strong_actions (0.0.9)
       actionpack (>= 4.1, < 5.1)
       activesupport (>= 4.1, < 5.1)
       railties (>= 4.1, < 5.1)
@@ -9,34 +9,34 @@ PATH
 GEM
   remote: https://rubygems.org/
   specs:
-    actionpack (5.0.1)
-      actionview (= 5.0.1)
-      activesupport (= 5.0.1)
+    actionpack (5.0.2)
+      actionview (= 5.0.2)
+      activesupport (= 5.0.2)
       rack (~> 2.0)
       rack-test (~> 0.6.3)
       rails-dom-testing (~> 2.0)
       rails-html-sanitizer (~> 1.0, >= 1.0.2)
-    actionview (5.0.1)
-      activesupport (= 5.0.1)
+    actionview (5.0.2)
+      activesupport (= 5.0.2)
       builder (~> 3.1)
       erubis (~> 2.7.0)
       rails-dom-testing (~> 2.0)
-      rails-html-sanitizer (~> 1.0, >= 1.0.2)
-    activesupport (5.0.1)
+      rails-html-sanitizer (~> 1.0, >= 1.0.3)
+    activesupport (5.0.2)
       concurrent-ruby (~> 1.0, >= 1.0.2)
       i18n (~> 0.7)
       minitest (~> 5.1)
       tzinfo (~> 1.1)
     builder (3.2.3)
-    concurrent-ruby (1.0.4)
+    concurrent-ruby (1.0.5)
     erubis (2.7.0)
-    i18n (0.8.0)
+    i18n (0.8.1)
     loofah (2.0.3)
       nokogiri (>= 1.5.9)
     method_source (0.8.2)
     mini_portile2 (2.1.0)
     minitest (5.10.1)
-    nokogiri (1.7.0.1)
+    nokogiri (1.7.1)
       mini_portile2 (~> 2.1.0)
     rack (2.0.1)
     rack-test (0.6.3)
@@ -46,16 +46,16 @@ GEM
       nokogiri (~> 1.6)
     rails-html-sanitizer (1.0.3)
       loofah (~> 2.0)
-    railties (5.0.1)
-      actionpack (= 5.0.1)
-      activesupport (= 5.0.1)
+    railties (5.0.2)
+      actionpack (= 5.0.2)
+      activesupport (= 5.0.2)
       method_source
       rake (>= 0.8.7)
       thor (>= 0.18.1, < 2.0)
-    rake (10.5.0)
+    rake (12.0.0)
     thor (0.19.4)
-    thread_safe (0.3.5)
-    tzinfo (1.2.2)
+    thread_safe (0.3.6)
+    tzinfo (1.2.3)
       thread_safe (~> 0.1)
 
 PLATFORMS
@@ -64,7 +64,7 @@ PLATFORMS
 DEPENDENCIES
   bundler (~> 1.7)
   minitest
-  rake (~> 10.0)
+  rake (~> 12.0)
   strong_actions!
 
 BUNDLED WITH

data/HISTORY.md

@@ -1,5 +1,8 @@
 # History
 
+## 0.0.9
+* fixed thread safety issue on multi-thread environment.
+
 ## 0.0.8
 * drop support for rails-4.0
 * add support for rails-5.0

data/lib/strong_actions/config.rb

@@ -7,6 +7,7 @@ module StrongActions
 
     def initialize
       @config_files ||= ['config/acl.yml']
+      @mutex  = Mutex.new
     end
 
     def config_files
@@ -28,18 +29,32 @@ module StrongActions
     private
 
     def definitions
-      if @acl.nil? or Rails.env.development?
-        @acl = {}
-        config_files.each do |config_file|
-          yml = YAML.load_file(config_file)
-          yml.each do |role, values|
-            raise "role #{role} is already defined." if @acl.has_key?(role)
-            @acl[role] = values
+      if should_load?
+        with_mutex do
+          if should_load?
+            @acl = {}
+            config_files.each do |config_file|
+              yml = YAML.load_file(config_file)
+              yml.each do |role, values|
+                raise "role #{role} is defined multiple times. config files are [#{config_files.join(', ')}]" if @acl.has_key?(role)
+                @acl[role] = values
+              end
+            end
           end
         end
       end
       @acl
     end
 
+    def should_load?
+      @acl.nil? or Rails.env.development?
+    end
+      
+    def with_mutex
+      @mutex.synchronize do
+        yield
+      end
+    end
+
   end
 end

data/lib/strong_actions/version.rb

@@ -1,3 +1,3 @@
 module StrongActions
-  VERSION = '0.0.8'
+  VERSION = '0.0.9'
 end

data/strong_actions.gemspec

@@ -25,5 +25,5 @@ Gem::Specification.new do |spec|
 
   spec.add_development_dependency "bundler", "~> 1.7"
   spec.add_development_dependency "minitest"
-  spec.add_development_dependency "rake", "~> 10.0"
+  spec.add_development_dependency "rake", "~> 12.0"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: strong_actions
 version: !ruby/object:Gem::Version
-  version: 0.0.8
+  version: 0.0.9
 platform: ruby
 authors:
 - ichy
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-02-07 00:00:00.000000000 Z
+date: 2017-04-01 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -104,14 +104,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '10.0'
+        version: '12.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '10.0'
+        version: '12.0'
 description: access control for rails controller/action
 email:
 - ichylinux@gmail.com