stripe_event 1.5.0 → 1.5.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: f6070a2804286e6d3f688f6051d68dddbf6c0aad
-  data.tar.gz: 073f86d95bf6dd878acf263627d2abc2e84cc545
+  metadata.gz: aa8f2db054ffda395b617ea68f31e2b424edbb2e
+  data.tar.gz: 06ac2c82777ac0034f1ed6816f2af05efc4b3f11
 SHA512:
-  metadata.gz: 55c9eaab6a57aff64563cdb7a6daf7c2352e738f3a067f6cea66aca7d0920fdd766d8d36b15e8c9020db8a1ee9c488387a78c23db954ba2527cb932043900746
-  data.tar.gz: f72b89d80bfd9a092da76988dbe6c038ed00558c72524df8e6740c769f4edf7af6c5921725d271b5dee2142342c9d690ea4958bf52aa8cb2f716f22c6e5b137d
+  metadata.gz: 9212f24254702fa2486e9a9f3f5e88cb90f662b1e3d990daa62749c33d513181b7fe405f8724b299e355f62c7bae758db2b09a9febb6630d144157b530bc5fd0
+  data.tar.gz: e211859259774381b070b21bb615db7bb0a7d384993d446209391921e7094492bfc39c9b800cf64fee830e958d55467ad103f890145c939b296b0c9e54b0942c

data/.travis.yml

@@ -1,18 +1,21 @@
 language: ruby
+cache: bundler
+sudo: false
 
 rvm:
-  - 1.9.3
-  - 2.1
-  - jruby-19mode
+  - 2.2
+  - 2.3.0
 
 gemfile:
-  - gemfiles/rails3.2.gemfile
   - gemfiles/rails4.1.gemfile
   - gemfiles/rails4.2.gemfile
 
-sudo: false
-
 matrix:
+  include:
+    - rvm: 2.1
+      gemfile: gemfiles/rails3.2.gemfile
+    - rvm: jruby-19mode
+      gemfile: gemfiles/rails3.2.gemfile
   fast_finish: true
 
 notifications:

data/CONTRIBUTING.md

@@ -0,0 +1,43 @@
+## Want to Contribute?
+
+Awesome. We love help, but before getting started, please read:
+
+**[Don't "Push" Your Pull Requests](http://www.igvita.com/2011/12/19/dont-push-your-pull-requests/)**
+
+## Ready for a Pull-Request?
+
+1. Fork the repo.
+
+2. Run the tests. We only take pull requests with passing tests, and it's great
+to know that you have a clean slate: `bundle && appraisal && bundle exec rake`
+
+3. Add a test for your change. Only refactoring and documentation changes
+require no new tests. If you are adding functionality or fixing a bug, we need
+a test!
+
+4. Make the test pass.
+
+5. Push to your fork and submit a pull request.
+
+At this point you're waiting on us. We like to at least comment on, if not
+accept, pull requests within three business days (and, typically, one business
+day). We may suggest some changes or improvements or alternatives.
+
+Some things that will increase the chance that your pull request is accepted,
+taken straight from the Ruby on Rails guide:
+
+## Conventions
+
+* Use Rails idioms and helpers.
+* Include tests that fail without your code, and pass with your code.
+* Update the documentation, the surrounding one, examples elsewhere, guides,
+  whatever is affected by your contribution
+
+Syntax:
+
+* Two spaces, no tabs.
+* No trailing whitespace. Blank lines should not have any space.
+* Prefer `&&`/`||` over `and`/`or`.
+* `MyClass.my_method(my_arg)` not `my_method( my_arg )` or `my_method my_arg`.
+* `a = b` not `a=b`.
+* Follow the conventions you see used in the source already.

data/README.md

@@ -1,5 +1,11 @@
 # StripeEvent
-[![Build Status](https://secure.travis-ci.org/integrallis/stripe_event.svg)](http://travis-ci.org/integrallis/stripe_event) [![Dependency Status](https://gemnasium.com/integrallis/stripe_event.svg)](https://gemnasium.com/integrallis/stripe_event) [![Gem Version](https://badge.fury.io/rb/stripe_event.svg)](http://badge.fury.io/rb/stripe_event) [![Code Climate](https://codeclimate.com/github/integrallis/stripe_event.svg)](https://codeclimate.com/github/integrallis/stripe_event) [![Coverage Status](https://coveralls.io/repos/integrallis/stripe_event/badge.svg)](https://coveralls.io/r/integrallis/stripe_event)
+
+[![Build Status](https://secure.travis-ci.org/integrallis/stripe_event.svg)](http://travis-ci.org/integrallis/stripe_event)
+[![Dependency Status](https://gemnasium.com/integrallis/stripe_event.svg)](https://gemnasium.com/integrallis/stripe_event)
+[![Gem Version](https://badge.fury.io/rb/stripe_event.svg)](http://badge.fury.io/rb/stripe_event)
+[![Code Climate](https://codeclimate.com/github/integrallis/stripe_event.svg)](https://codeclimate.com/github/integrallis/stripe_event)
+[![Coverage Status](https://coveralls.io/repos/integrallis/stripe_event/badge.svg)](https://coveralls.io/r/integrallis/stripe_event)
+[![Gem Downloads](https://img.shields.io/gem/dt/stripe_event.svg)](https://rubygems.org/gems/stripe_event)
 
 StripeEvent is built on the [ActiveSupport::Notifications API](http://api.rubyonrails.org/classes/ActiveSupport/Notifications.html). Incoming webhook requests are authenticated by [retrieving the event object](https://stripe.com/docs/api?lang=ruby#retrieve_event) from Stripe. Define subscribers to handle specific event types. Subscribers can be a block or an object that responds to `#call`.
 
@@ -19,7 +25,7 @@ mount StripeEvent::Engine, at: '/my-chosen-path' # provide a custom path
 
 ```ruby
 # config/initializers/stripe.rb
-Stripe.api_key = ENV['STRIPE_API_KEY'] # Set your api key
+Stripe.api_key = ENV['STRIPE_SECRET_KEY'] # e.g. sk_live_1234
 
 StripeEvent.configure do |events|
   events.subscribe 'charge.failed' do |event|
@@ -147,7 +153,7 @@ require 'json'
 require 'sinatra'
 require 'stripe_event'
 
-Stripe.api_key = ENV['STRIPE_API_KEY']
+Stripe.api_key = ENV['STRIPE_SECRET_KEY']
 
 StripeEvent.subscribe 'charge.failed' do |event|
   # Look ma, no Rails!
@@ -200,6 +206,10 @@ This button sends an example event to your webhook urls, including an `id` of `e
 
 Special thanks to all the [contributors](https://github.com/integrallis/stripe_event/graphs/contributors).
 
+### Versioning
+
+Semantic Versioning 2.0 as defined at <http://semver.org>.
+
 ### License
 
 [MIT License](https://github.com/integrallis/stripe_event/blob/master/LICENSE.md). Copyright 2012-2015 Integrallis Software.

data/app/controllers/stripe_event/webhook_controller.rb

@@ -1,18 +1,32 @@
 module StripeEvent
   class WebhookController < ActionController::Base
-    before_filter do
-      if StripeEvent.authentication_secret
-        authenticate_or_request_with_http_basic do |username, password|
-          password == StripeEvent.authentication_secret
-        end
-      end
+    if respond_to?(:before_action)
+      before_action :request_authentication
+    else
+      before_filter :request_authentication
     end
-    
+
     def event
       StripeEvent.instrument(params)
       head :ok
-    rescue StripeEvent::UnauthorizedError
+    rescue StripeEvent::UnauthorizedError => e
+      log_error(e)
       head :unauthorized
     end
+
+    private
+
+    def log_error(e)
+      logger.error e.message
+      e.backtrace.each { |line| logger.error "  #{line}" }
+    end
+
+    def request_authentication
+      if StripeEvent.authentication_secret
+        authenticate_or_request_with_http_basic do |username, password|
+          password == StripeEvent.authentication_secret
+        end
+      end
+    end
   end
 end

data/lib/stripe_event/version.rb

@@ -1,3 +1,3 @@
 module StripeEvent
-  VERSION = "1.5.0"
+  VERSION = "1.5.1"
 end

data/spec/controllers/webhook_controller_spec.rb

@@ -8,9 +8,11 @@ describe StripeEvent::WebhookController do
   end
 
   def webhook(params)
-    post :event, params.merge(use_route: :stripe_event)
+    post :event, params
   end
 
+  routes { StripeEvent::Engine.routes }
+
   it "succeeds with valid event data" do
     count = 0
     StripeEvent.subscribe('charge.succeeded') { |evt| count += 1 }

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: stripe_event
 version: !ruby/object:Gem::Version
-  version: 1.5.0
+  version: 1.5.1
 platform: ruby
 authors:
 - Danny Whalen
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-02-26 00:00:00.000000000 Z
+date: 2016-09-20 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -119,6 +119,7 @@ files:
 - ".travis.yml"
 - Appraisals
 - CHANGELOG.md
+- CONTRIBUTING.md
 - Gemfile
 - LICENSE.md
 - README.md
@@ -189,7 +190,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.5
+rubygems_version: 2.6.4
 signing_key: 
 specification_version: 4
 summary: Stripe webhook integration for Rails applications.