stripe_event 0.6.1 → 1.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 92e8ad6c1ab515d871b8aba7a4c6d15ecc0dd967
-  data.tar.gz: 027dd82b3834d95bb4255e43caebaf56d7b3082f
+  metadata.gz: 6d62c1dcd19a7c4efa5ac0a32ce6e0d01d65fb54
+  data.tar.gz: 98148c9f17cdaab997eb100e04ef4aaa7b417e4c
 SHA512:
-  metadata.gz: 8c5848d09cc4d4d14ac5e4f244444c3a2d987712055d2be058adc6d36e413f2b099c84d275a191b20a6ee64173b8f2015770dc0efb33ecf2df376bcb1030e53a
-  data.tar.gz: c13e2087d74ec7fe77131d527d990ca0273cffa12c018b36279765e86c1ee941b7101ef4553e7af53304e49963cad4d22e38c1ba5feaeab9145a69b9cc855405
+  metadata.gz: 907c5f1b0888fcf5093cb5853a916d4ca280cebb1b6eace62d4926f145262f8c8deb13eff2d617b4c61837348c7af635271a52e7e6387809999952a2036d1143
+  data.tar.gz: 256549e22835b44d8d933c46c636eb04cabf8d549899e535a4227b0befa53ec56687a6281308737710a3acdb4f42b79a2f9944977974f18b79fa092df1943648

data/.travis.yml

@@ -2,9 +2,9 @@ language: ruby
 rvm:
   - 1.9.2
   - 1.9.3
-  - rbx-19mode
-  - jruby-19mode
   - 2.0.0
+  - jruby-19mode
+  - jruby-head
 gemfile:
   - gemfiles/rails3.1.gemfile
   - gemfiles/rails3.2.gemfile

data/CHANGELOG.md

@@ -1,3 +1,13 @@
+### 1.0.0 (December 19, 2013)
+  * Internally namespace dispatched events to avoid maintaining a list of all possible event types.
+  * Subscribe to all event types with `StripeEvent.all` instead of `StripeEvent.subscribe`.
+  * Remove ability to subscribe to many event types with once call to `StripeEvent.subscribe`.
+  * Subscribers can be an object that responds to #call.
+  * Allow subscriber-generated `Stripe::StripeError`'s to bubble up. Thank you to [adamonduty](https://github.com/adamonduty) for the [patch](https://github.com/integrallis/stripe_event/pull/26).
+  * Only depend on `stripe` and `activesupport` gems.
+  * Add `rails` as a development dependency.
+  * Only `require 'stripe_event/engine'` if `Rails` constant exists to allow StripeEvent to be used outside of a Rails application.
+
 ### 0.6.1 (August 19, 2013)
   * Update event type list
   * Update test gemfiles

data/README.md

@@ -1,6 +1,6 @@
 # StripeEvent [![Build Status](https://secure.travis-ci.org/integrallis/stripe_event.png?branch=master)](http://travis-ci.org/integrallis/stripe_event) [![Dependency Status](https://gemnasium.com/integrallis/stripe_event.png)](https://gemnasium.com/integrallis/stripe_event) [![Gem Version](https://badge.fury.io/rb/stripe_event.png)](http://badge.fury.io/rb/stripe_event)
 
-StripeEvent is built on the [ActiveSupport::Notifications API](http://api.rubyonrails.org/classes/ActiveSupport/Notifications.html). Incoming webhook requests are authenticated by retrieving the [event object](https://stripe.com/docs/api?lang=ruby#event_object) from Stripe[[1]](https://answers.stripe.com/questions/what-is-the-recommended-way-to-authenticate-a-webhook-callback). Define subscriber blocks to handle one, many, or all event types.
+StripeEvent is built on the [ActiveSupport::Notifications API](http://api.rubyonrails.org/classes/ActiveSupport/Notifications.html). Incoming webhook requests are authenticated by [retrieving the event object](https://stripe.com/docs/api?lang=ruby#retrieve_event) from Stripe. Define subscribers to handle a single event type or all event types. Subscribers can be a block or any object that responds to `#call`.
 
 ## Install
 
@@ -23,19 +23,41 @@ Stripe.api_key = ENV['STRIPE_API_KEY'] # Set your api key
 StripeEvent.setup do
   subscribe 'charge.failed' do |event|
     # Define subscriber behavior based on the event object
-    event.class #=> Stripe::Event
-    event.type  #=> "charge.failed"
-    event.data  #=> { ... }
+    event.class       #=> Stripe::Event
+    event.type        #=> "charge.failed"
+    event.data.object #=> #<Stripe::Charge:0x3fcb34c115f8>
   end
 
-  subscribe 'customer.created', 'customer.updated' do |event|
-    # Handle multiple event types
+  all do |event|
+    # Handle all event types - logging, etc.
   end
+end
 
-  subscribe do |event|
-    # Handle all event types - logging, etc.
+# Subscriber objects that respond to #call
+
+class CustomerCreated
+  def call(event)
+    # Event handling
+  end
+end
+
+class BillingEventLogger
+  def initialize(logger = nil)
+    @logger = logger || begin
+      require 'logger'
+      Logger.new($stdout)
+    end
+  end
+
+  def call(event)
+    @logger.info "BILLING-EVENT: #{event.type} #{event.id}"
   end
 end
+
+StripeEvent.setup do
+  all BillingEventLogger.new(Rails.logger)
+  subscribe 'customer.created', CustomerCreated.new
+end
 ```
 
 ## Configuration
@@ -44,28 +66,81 @@ If you have built an application that has multiple Stripe accounts--say, each of
 
 ```ruby
 StripeEvent.event_retriever = lambda do |params|
-  secret_key = Account.find_by_stripe_user_id(params[:user_id]).secret_key
-  Stripe::Event.retrieve(params[:id], secret_key)
+  api_key = Account.find_by!(stripe_user_id: params[:user_id]).api_key
+  Stripe::Event.retrieve(params[:id], api_key)
+end
+
+# Or use any object that responds to #call
+
+class EventRetriever
+  def call(params)
+    api_key = retrieve_api_key(params[:user_id])
+    Stripe::Event.retrieve(params[:id], api_key)
+  end
+
+  def retrieve_api_key(stripe_user_id)
+    Account.find_by!(stripe_user_id: stripe_user_id).api_key
+  rescue ActiveRecord::RecordNotFound
+    # whoops something went wrong - error handling
+  end
 end
+
+StripeEvent.event_retriever = EventRetriever.new
 ```
 
-During development it may be useful to skip retrieving the event from Stripe, and deal with the params hash directly. Just remember that the data has not been authenticated.
+## Without Rails
+
+StripeEvent can be used outside of Rails applications as well. Here is a basic Sinatra implementation:
 
 ```ruby
-StripeEvent.event_retriever = lambda { |params| params }
+require 'json'
+require 'sinatra'
+require 'stripe_event'
+
+Stripe.api_key = ENV['STRIPE_API_KEY']
+
+StripeEvent.subscribe 'charge.failed' do |event|
+  # Look ma, no Rails!
+end
+
+post '/_billing_events' do
+  data = JSON.parse(request.body.read, symbolize_names: true)
+  StripeEvent.instrument(data)
+  200
+end
 ```
 
-### Register webhook url with Stripe
+## Testing
+
+Handling webhooks is a critical piece of modern billing systems. Verifying the behavior of StripeEvent subscribers can be done fairly easily by stubbing out the HTTP request used to authenticate the webhook request. Tools like [Webmock](https://github.com/bblimke/webmock) and [VCR](https://github.com/vcr/vcr) work well. [RequestBin](http://requestb.in/) is great for collecting the payloads. For exploratory phases of development, [UltraHook](http://www.ultrahook.com/) and other tools can forward webhook requests directly to localhost. You can check out [test-hooks](https://github.com/invisiblefunnel/test-hooks), and example Rails application to see how to test StripeEvent subscribers with RSpec request specs and Webmock. A quick look:
+
+```ruby
+# spec/requests/billing_events_spec.rb
+require 'spec_helper'
 
-![Setup webhook url](https://raw.github.com/integrallis/stripe_event/master/dashboard-webhook.png "webhook setup")
+describe "Billing Events" do
+  def stub_event(fixture_id, status = 200)
+    stub_request(:get, "https://api.stripe.com/v1/events/#{fixture_id}").
+      to_return(status: status, body: File.read("spec/support/fixtures/#{fixture_id}.json"))
+  end
 
-### Examples
+  describe "customer.created" do
+    before do
+      stub_event 'evt_customer_created'
+    end
 
-The [RailsApps](https://github.com/RailsApps) project by Daniel Kehoe has released an [example Rails 3.2 app](https://github.com/RailsApps/rails-stripe-membership-saas) with recurring billing using Stripe. The application uses StripeEvent to handle `customer.subscription.deleted` events.
+    it "is successful" do
+      post '/_billing_events', id: 'evt_customer_created'
+      expect(response.code).to eq "200"
+      # Additional expectations...
+    end
+  end
+end
+```
 
 ### Note: 'Test Webhooks' Button on Stripe Dashboard
 
-This button sends an example event to your webhook urls, including an `id` of `evt_00000000000000`. To confirm that Stripe sent the webhook, StripeEvent attempts to retrieve the event details from Stripe using the given `id`. In this case the event does not exist and StripeEvent responds with `401 Unauthorized`. Instead of using the 'Test Webhooks' button, trigger webhooks by using the Stripe Dashboard to create test payments, customers, etc.
+This button sends an example event to your webhook urls, including an `id` of `evt_00000000000000`. To confirm that Stripe sent the webhook, StripeEvent attempts to retrieve the event details from Stripe using the given `id`. In this case the event does not exist and StripeEvent responds with `401 Unauthorized`. Instead of using the 'Test Webhooks' button, trigger webhooks by using the Stripe API or Dashboard to create test payments, customers, etc.
 
 ### License
 

data/Rakefile

@@ -6,7 +6,7 @@ require 'rspec/core/rake_task'
 RSpec::Core::RakeTask.new(:spec)
 
 if ENV['CI']
-  task :default => :spec
+  task default: :spec
 else
   require 'appraisal'
   task :default do

data/app/controllers/stripe_event/webhook_controller.rb

@@ -3,7 +3,7 @@ module StripeEvent
     def event
       StripeEvent.instrument(params)
       head :ok
-    rescue Stripe::StripeError
+    rescue StripeEvent::UnauthorizedError
       head :unauthorized
     end
   end

data/config/routes.rb

@@ -1,3 +1,3 @@
 StripeEvent::Engine.routes.draw do
-  root :to => 'webhook#event', :via => :post
+  root to: 'webhook#event', via: :post
 end

data/gemfiles/rails3.1.gemfile.lock

@@ -1,8 +1,8 @@
 PATH
   remote: ..
   specs:
-    stripe_event (0.6.1)
-      rails (>= 3.1)
+    stripe_event (1.0.0)
+      activesupport (>= 3.1)
       stripe (~> 1.6)
 
 GEM
@@ -44,17 +44,17 @@ GEM
     builder (3.0.4)
     crack (0.4.1)
       safe_yaml (~> 0.9.0)
-    diff-lcs (1.2.4)
+    diff-lcs (1.2.5)
     erubis (2.7.0)
     hike (1.2.3)
-    i18n (0.6.5)
-    json (1.8.0)
+    i18n (0.6.9)
+    json (1.8.1)
     mail (2.4.4)
       i18n (>= 0.4.0)
       mime-types (~> 1.16)
       treetop (~> 1.4.8)
-    mime-types (1.24)
-    multi_json (1.7.9)
+    mime-types (1.25.1)
+    multi_json (1.8.2)
     polyglot (0.3.3)
     rack (1.3.10)
     rack-cache (1.2)
@@ -85,10 +85,10 @@ GEM
       json (~> 1.4)
     rest-client (1.6.7)
       mime-types (>= 1.16)
-    rspec-core (2.14.5)
-    rspec-expectations (2.14.2)
+    rspec-core (2.14.7)
+    rspec-expectations (2.14.4)
       diff-lcs (>= 1.1.3, < 2.0)
-    rspec-mocks (2.14.3)
+    rspec-mocks (2.14.4)
     rspec-rails (2.14.0)
       actionpack (>= 3.0)
       activesupport (>= 3.0)
@@ -96,12 +96,13 @@ GEM
       rspec-core (~> 2.14.0)
       rspec-expectations (~> 2.14.0)
       rspec-mocks (~> 2.14.0)
-    safe_yaml (0.9.5)
+    safe_yaml (0.9.7)
     sprockets (2.0.4)
       hike (~> 1.2)
       rack (~> 1.0)
       tilt (~> 1.1, != 1.3.0)
-    stripe (1.8.5)
+    stripe (1.9.9)
+      mime-types (~> 1.25)
       multi_json (>= 1.0.4, < 2)
       rest-client (~> 1.4)
     thor (0.14.6)
@@ -109,8 +110,8 @@ GEM
     treetop (1.4.15)
       polyglot
       polyglot (>= 0.3.1)
-    tzinfo (0.3.37)
-    webmock (1.13.0)
+    tzinfo (0.3.38)
+    webmock (1.16.0)
       addressable (>= 2.2.7)
       crack (>= 0.3.2)
 

data/gemfiles/rails3.2.gemfile.lock

@@ -1,19 +1,19 @@
 PATH
   remote: ..
   specs:
-    stripe_event (0.6.1)
-      rails (>= 3.1)
+    stripe_event (1.0.0)
+      activesupport (>= 3.1)
       stripe (~> 1.6)
 
 GEM
   remote: https://rubygems.org/
   specs:
-    actionmailer (3.2.14)
-      actionpack (= 3.2.14)
+    actionmailer (3.2.16)
+      actionpack (= 3.2.16)
       mail (~> 2.5.4)
-    actionpack (3.2.14)
-      activemodel (= 3.2.14)
-      activesupport (= 3.2.14)
+    actionpack (3.2.16)
+      activemodel (= 3.2.16)
+      activesupport (= 3.2.16)
       builder (~> 3.0.0)
       erubis (~> 2.7.0)
       journey (~> 1.0.4)
@@ -21,39 +21,39 @@ GEM
       rack-cache (~> 1.2)
       rack-test (~> 0.6.1)
       sprockets (~> 2.2.1)
-    activemodel (3.2.14)
-      activesupport (= 3.2.14)
+    activemodel (3.2.16)
+      activesupport (= 3.2.16)
       builder (~> 3.0.0)
-    activerecord (3.2.14)
-      activemodel (= 3.2.14)
-      activesupport (= 3.2.14)
+    activerecord (3.2.16)
+      activemodel (= 3.2.16)
+      activesupport (= 3.2.16)
       arel (~> 3.0.2)
       tzinfo (~> 0.3.29)
-    activeresource (3.2.14)
-      activemodel (= 3.2.14)
-      activesupport (= 3.2.14)
-    activesupport (3.2.14)
+    activeresource (3.2.16)
+      activemodel (= 3.2.16)
+      activesupport (= 3.2.16)
+    activesupport (3.2.16)
       i18n (~> 0.6, >= 0.6.4)
       multi_json (~> 1.0)
     addressable (2.3.5)
     appraisal (0.5.2)
       bundler
       rake
-    arel (3.0.2)
+    arel (3.0.3)
     builder (3.0.4)
     crack (0.4.1)
       safe_yaml (~> 0.9.0)
-    diff-lcs (1.2.4)
+    diff-lcs (1.2.5)
     erubis (2.7.0)
     hike (1.2.3)
-    i18n (0.6.5)
+    i18n (0.6.9)
     journey (1.0.4)
-    json (1.8.0)
+    json (1.8.1)
     mail (2.5.4)
       mime-types (~> 1.16)
       treetop (~> 1.4.8)
-    mime-types (1.24)
-    multi_json (1.7.9)
+    mime-types (1.25.1)
+    multi_json (1.8.2)
     polyglot (0.3.3)
     rack (1.4.5)
     rack-cache (1.2)
@@ -62,17 +62,17 @@ GEM
       rack
     rack-test (0.6.2)
       rack (>= 1.0)
-    rails (3.2.14)
-      actionmailer (= 3.2.14)
-      actionpack (= 3.2.14)
-      activerecord (= 3.2.14)
-      activeresource (= 3.2.14)
-      activesupport (= 3.2.14)
+    rails (3.2.16)
+      actionmailer (= 3.2.16)
+      actionpack (= 3.2.16)
+      activerecord (= 3.2.16)
+      activeresource (= 3.2.16)
+      activesupport (= 3.2.16)
       bundler (~> 1.0)
-      railties (= 3.2.14)
-    railties (3.2.14)
-      actionpack (= 3.2.14)
-      activesupport (= 3.2.14)
+      railties (= 3.2.16)
+    railties (3.2.16)
+      actionpack (= 3.2.16)
+      activesupport (= 3.2.16)
       rack-ssl (~> 1.3.2)
       rake (>= 0.8.7)
       rdoc (~> 3.4)
@@ -82,10 +82,10 @@ GEM
       json (~> 1.4)
     rest-client (1.6.7)
       mime-types (>= 1.16)
-    rspec-core (2.14.5)
-    rspec-expectations (2.14.2)
+    rspec-core (2.14.7)
+    rspec-expectations (2.14.4)
       diff-lcs (>= 1.1.3, < 2.0)
-    rspec-mocks (2.14.3)
+    rspec-mocks (2.14.4)
     rspec-rails (2.14.0)
       actionpack (>= 3.0)
       activesupport (>= 3.0)
@@ -93,13 +93,14 @@ GEM
       rspec-core (~> 2.14.0)
       rspec-expectations (~> 2.14.0)
       rspec-mocks (~> 2.14.0)
-    safe_yaml (0.9.5)
+    safe_yaml (0.9.7)
     sprockets (2.2.2)
       hike (~> 1.2)
       multi_json (~> 1.0)
       rack (~> 1.0)
       tilt (~> 1.1, != 1.3.0)
-    stripe (1.8.5)
+    stripe (1.9.9)
+      mime-types (~> 1.25)
       multi_json (>= 1.0.4, < 2)
       rest-client (~> 1.4)
     thor (0.18.1)
@@ -107,8 +108,8 @@ GEM
     treetop (1.4.15)
       polyglot
       polyglot (>= 0.3.1)
-    tzinfo (0.3.37)
-    webmock (1.13.0)
+    tzinfo (0.3.38)
+    webmock (1.16.0)
       addressable (>= 2.2.7)
       crack (>= 0.3.2)
 

data/gemfiles/rails4.0.gemfile.lock

@@ -1,32 +1,32 @@
 PATH
   remote: ..
   specs:
-    stripe_event (0.6.1)
-      rails (>= 3.1)
+    stripe_event (1.0.0)
+      activesupport (>= 3.1)
       stripe (~> 1.6)
 
 GEM
   remote: https://rubygems.org/
   specs:
-    actionmailer (4.0.0)
-      actionpack (= 4.0.0)
-      mail (~> 2.5.3)
-    actionpack (4.0.0)
-      activesupport (= 4.0.0)
+    actionmailer (4.0.2)
+      actionpack (= 4.0.2)
+      mail (~> 2.5.4)
+    actionpack (4.0.2)
+      activesupport (= 4.0.2)
       builder (~> 3.1.0)
       erubis (~> 2.7.0)
       rack (~> 1.5.2)
       rack-test (~> 0.6.2)
-    activemodel (4.0.0)
-      activesupport (= 4.0.0)
+    activemodel (4.0.2)
+      activesupport (= 4.0.2)
       builder (~> 3.1.0)
-    activerecord (4.0.0)
-      activemodel (= 4.0.0)
+    activerecord (4.0.2)
+      activemodel (= 4.0.2)
       activerecord-deprecated_finders (~> 1.0.2)
-      activesupport (= 4.0.0)
+      activesupport (= 4.0.2)
       arel (~> 4.0.0)
     activerecord-deprecated_finders (1.0.3)
-    activesupport (4.0.0)
+    activesupport (4.0.2)
       i18n (~> 0.6, >= 0.6.4)
       minitest (~> 4.2)
       multi_json (~> 1.3)
@@ -36,45 +36,45 @@ GEM
     appraisal (0.5.2)
       bundler
       rake
-    arel (4.0.0)
-    atomic (1.1.13)
+    arel (4.0.1)
+    atomic (1.1.14)
     builder (3.1.4)
     crack (0.4.1)
       safe_yaml (~> 0.9.0)
-    diff-lcs (1.2.4)
+    diff-lcs (1.2.5)
     erubis (2.7.0)
     hike (1.2.3)
-    i18n (0.6.5)
+    i18n (0.6.9)
     mail (2.5.4)
       mime-types (~> 1.16)
       treetop (~> 1.4.8)
-    mime-types (1.24)
+    mime-types (1.25.1)
     minitest (4.7.5)
-    multi_json (1.7.9)
+    multi_json (1.8.2)
     polyglot (0.3.3)
     rack (1.5.2)
     rack-test (0.6.2)
       rack (>= 1.0)
-    rails (4.0.0)
-      actionmailer (= 4.0.0)
-      actionpack (= 4.0.0)
-      activerecord (= 4.0.0)
-      activesupport (= 4.0.0)
+    rails (4.0.2)
+      actionmailer (= 4.0.2)
+      actionpack (= 4.0.2)
+      activerecord (= 4.0.2)
+      activesupport (= 4.0.2)
       bundler (>= 1.3.0, < 2.0)
-      railties (= 4.0.0)
+      railties (= 4.0.2)
       sprockets-rails (~> 2.0.0)
-    railties (4.0.0)
-      actionpack (= 4.0.0)
-      activesupport (= 4.0.0)
+    railties (4.0.2)
+      actionpack (= 4.0.2)
+      activesupport (= 4.0.2)
       rake (>= 0.8.7)
       thor (>= 0.18.1, < 2.0)
     rake (10.1.0)
     rest-client (1.6.7)
       mime-types (>= 1.16)
-    rspec-core (2.14.5)
-    rspec-expectations (2.14.2)
+    rspec-core (2.14.7)
+    rspec-expectations (2.14.4)
       diff-lcs (>= 1.1.3, < 2.0)
-    rspec-mocks (2.14.3)
+    rspec-mocks (2.14.4)
     rspec-rails (2.14.0)
       actionpack (>= 3.0)
       activesupport (>= 3.0)
@@ -82,28 +82,29 @@ GEM
       rspec-core (~> 2.14.0)
       rspec-expectations (~> 2.14.0)
       rspec-mocks (~> 2.14.0)
-    safe_yaml (0.9.5)
-    sprockets (2.10.0)
+    safe_yaml (0.9.7)
+    sprockets (2.10.1)
       hike (~> 1.2)
       multi_json (~> 1.0)
       rack (~> 1.0)
       tilt (~> 1.1, != 1.3.0)
-    sprockets-rails (2.0.0)
+    sprockets-rails (2.0.1)
       actionpack (>= 3.0)
       activesupport (>= 3.0)
       sprockets (~> 2.8)
-    stripe (1.8.5)
+    stripe (1.9.9)
+      mime-types (~> 1.25)
       multi_json (>= 1.0.4, < 2)
       rest-client (~> 1.4)
     thor (0.18.1)
-    thread_safe (0.1.2)
+    thread_safe (0.1.3)
       atomic
     tilt (1.4.1)
     treetop (1.4.15)
       polyglot
       polyglot (>= 0.3.1)
-    tzinfo (0.3.37)
-    webmock (1.13.0)
+    tzinfo (0.3.38)
+    webmock (1.16.0)
       addressable (>= 2.2.7)
       crack (>= 0.3.2)
 

data/lib/stripe_event.rb

@@ -1,77 +1,60 @@
-require "set"
+require "active_support/notifications"
 require "stripe"
-require "stripe_event/engine"
+require "stripe_event/engine" if defined?(Rails)
 
 module StripeEvent
   class << self
-    attr_accessor :backend, :event_retriever
+    attr_accessor :adapter, :backend, :event_retriever, :namespace
 
     def setup(&block)
       instance_eval(&block)
     end
 
     def instrument(params)
-      event = event_retriever.call(params)
-      publish(event)
+      begin
+        event = event_retriever.call(params)
+      rescue Stripe::StripeError => e
+        raise UnauthorizedError.new(e)
+      end
+
+      backend.instrument namespace.call(event[:type]), event
     end
 
-    def publish(event)
-      backend.publish(event[:type], event)
+    def subscribe(name, callable = Proc.new)
+      backend.subscribe namespace.to_regexp(name), adapter.call(callable)
     end
 
-    def subscribe(*names, &block)
-      pattern = Regexp.union(names.empty? ? TYPE_LIST.to_a : names)
+    def all(callable = Proc.new)
+      subscribe nil, callable
+    end
+  end
 
-      backend.subscribe(pattern) do |*args|
-        payload = args.last
-        block.call(payload)
-      end
+  class Namespace < Struct.new(:value, :delimiter)
+    def call(name = nil)
+      name ? "#{value}#{delimiter}#{name}" : value
+    end
+
+    def to_regexp(name = nil)
+      %r{^#{Regexp.escape call(name)}}
     end
   end
 
+  class NotificationAdapter < Struct.new(:subscriber)
+    def self.call(callable)
+      new(callable)
+    end
+
+    def call(*args)
+      payload = args.last
+      subscriber.call(payload)
+    end
+  end
+
+  class Error < StandardError; end
+  class UnauthorizedError < Error; end
+
+  self.adapter = NotificationAdapter
   self.backend = ActiveSupport::Notifications
   self.event_retriever = lambda { |params| Stripe::Event.retrieve(params[:id]) }
-
-  TYPE_LIST = Set[
-    'account.updated',
-    'account.application.deauthorized',
-    'balance.available',
-    'charge.succeeded',
-    'charge.failed',
-    'charge.refunded',
-    'charge.captured',
-    'charge.dispute.created',
-    'charge.dispute.updated',
-    'charge.dispute.closed',
-    'customer.created',
-    'customer.updated',
-    'customer.deleted',
-    'customer.card.created',
-    'customer.card.updated',
-    'customer.card.deleted',
-    'customer.subscription.created',
-    'customer.subscription.updated',
-    'customer.subscription.deleted',
-    'customer.subscription.trial_will_end',
-    'customer.discount.created',
-    'customer.discount.updated',
-    'customer.discount.deleted',
-    'invoice.created',
-    'invoice.updated',
-    'invoice.payment_succeeded',
-    'invoice.payment_failed',
-    'invoiceitem.created',
-    'invoiceitem.updated',
-    'invoiceitem.deleted',
-    'plan.created',
-    'plan.updated',
-    'plan.deleted',
-    'coupon.created',
-    'coupon.deleted',
-    'transfer.created',
-    'transfer.updated',
-    'transfer.paid',
-    'transfer.failed',
-    'ping'
-  ].freeze
+  self.namespace = Namespace.new("stripe_event", ".")
 end

data/lib/stripe_event/version.rb

@@ -1,3 +1,3 @@
 module StripeEvent
-  VERSION = "0.6.1"
+  VERSION = "1.0.0"
 end

data/spec/controllers/webhook_controller_spec.rb

@@ -1,28 +1,42 @@
+require 'rails_helper'
 require 'spec_helper'
 
 describe StripeEvent::WebhookController do
-  def event_post(params)
-    post :event, params.merge(:use_route => :stripe_event)
+  def stub_event(identifier, status = 200)
+    stub_request(:get, "https://api.stripe.com/v1/events/#{identifier}").
+      to_return(status: status, body: File.read("spec/support/fixtures/#{identifier}.json"))
+  end
+
+  def webhook(params)
+    post :event, params.merge(use_route: :stripe_event)
   end
 
   it "succeeds with valid event data" do
+    count = 0
+    StripeEvent.subscribe('charge.succeeded') { |evt| count += 1 }
     stub_event('evt_charge_succeeded')
 
-    event_post :id => 'evt_charge_succeeded'
-    expect(response).to be_success
+    webhook id: 'evt_charge_succeeded'
+
+    expect(response.code).to eq '200'
+    expect(count).to eq 1
   end
 
   it "denies access with invalid event data" do
+    count = 0
+    StripeEvent.subscribe('charge.succeeded') { |evt| count += 1 }
     stub_event('evt_invalid_id', 404)
 
-    event_post :id => 'evt_invalid_id'
+    webhook id: 'evt_invalid_id'
+
     expect(response.code).to eq '401'
+    expect(count).to eq 0
   end
 
-  it "succeeds with a custom event retriever" do
-    StripeEvent.event_retriever = Proc.new { |params| params }
+  it "ensures user-generated Stripe exceptions pass through" do
+    StripeEvent.subscribe('charge.succeeded') { |evt| raise Stripe::StripeError, "testing" }
+    stub_event('evt_charge_succeeded')
 
-    event_post :id => '1'
-    expect(response).to be_success
+    expect { webhook id: 'evt_charge_succeeded' }.to raise_error(Stripe::StripeError, /testing/)
   end
 end

data/spec/lib/stripe_event_spec.rb

@@ -1,45 +1,101 @@
 require 'spec_helper'
 
 describe StripeEvent do
-  let(:event_type) { StripeEvent::TYPE_LIST.sample }
+  let(:events) { [] }
+  let(:subscriber) { ->(evt){ events << evt } }
+  let(:charge_succeeded) { double('charge succeeded') }
+  let(:charge_failed) { double('charge failed') }
 
-  it "backend defaults to AS::Notifications" do
-    expect(described_class.backend).to eq ActiveSupport::Notifications
-  end
+  describe "subscribing to a specific event type" do
+    before do
+      expect(charge_succeeded).to receive(:[]).with(:type).and_return('charge.succeeded')
+      expect(Stripe::Event).to receive(:retrieve).with('evt_charge_succeeded').and_return(charge_succeeded)
+    end
 
-  it "registers a subscriber" do
-    subscriber = described_class.subscribe(event_type) { |e| }
-    subscribers = subscribers_for_type(event_type)
-    expect(subscribers).to eq [subscriber]
-  end
+    context "with a block subscriber" do
+      it "calls the subscriber with the retrieved event" do
+        StripeEvent.subscribe('charge.succeeded', &subscriber)
+
+        StripeEvent.instrument(id: 'evt_charge_succeeded', type: 'charge.succeeded')
 
-  it "registers subscribers within a parent block" do
-    described_class.setup do
-      subscribe('invoice.payment_succeeded') { |e| }
+        expect(events).to eq [charge_succeeded]
+      end
+    end
+
+    context "with a subscriber that responds to #call" do
+      it "calls the subscriber with the retrieved event" do
+        StripeEvent.subscribe('charge.succeeded', subscriber)
+
+        StripeEvent.instrument(id: 'evt_charge_succeeded', type: 'charge.succeeded')
+
+        expect(events).to eq [charge_succeeded]
+      end
     end
-    subscribers = subscribers_for_type('invoice.payment_succeeded')
-    expect(subscribers).to_not be_empty
   end
 
-  it "passes only the event object to the subscribed block" do
-    event = { :type => event_type }
+  describe "subscribing to all event types" do
+    before do
+      expect(charge_succeeded).to receive(:[]).with(:type).and_return('charge.succeeded')
+      expect(Stripe::Event).to receive(:retrieve).with('evt_charge_succeeded').and_return(charge_succeeded)
+
+      expect(charge_failed).to receive(:[]).with(:type).and_return('charge.failed')
+      expect(Stripe::Event).to receive(:retrieve).with('evt_charge_failed').and_return(charge_failed)
+    end
+
+    context "with a block subscriber" do
+      it "calls the subscriber with all retrieved events" do
+        StripeEvent.all(&subscriber)
+
+        StripeEvent.instrument(id: 'evt_charge_succeeded', type: 'charge.succeeded')
+        StripeEvent.instrument(id: 'evt_charge_failed', type: 'charge.failed')
 
-    expect { |block|
-      described_class.subscribe(event_type, &block)
-      described_class.publish(event)
-    }.to yield_with_args(event)
+        expect(events).to eq [charge_succeeded, charge_failed]
+      end
+    end
+
+    context "with a subscriber that responds to #call" do
+      it "calls the subscriber with all retrieved events" do
+        StripeEvent.all(subscriber)
+
+        StripeEvent.instrument(id: 'evt_charge_succeeded', type: 'charge.succeeded')
+        StripeEvent.instrument(id: 'evt_charge_failed', type: 'charge.failed')
+
+        expect(events).to eq [charge_succeeded, charge_failed]
+      end
+    end
   end
 
-  it "uses Stripe::Event as the default event retriever" do
-    Stripe::Event.should_receive(:retrieve).with('1')
-    described_class.event_retriever.call(:id => '1')
+  describe StripeEvent::NotificationAdapter do
+    let(:adapter) { StripeEvent.adapter }
+
+    it "calls the subscriber with the last argument" do
+      expect(subscriber).to receive(:call).with(:last)
+
+      adapter.call(subscriber).call(:first, :last)
+    end
   end
 
-  it "allows setting an event_retriever" do
-    params = { :id => '1' }
+  describe StripeEvent::Namespace do
+    let(:namespace) { StripeEvent.namespace }
+
+    describe "#call" do
+      it "prepends the namespace to a given string" do
+        expect(namespace.call('foo.bar')).to eq 'stripe_event.foo.bar'
+      end
+
+      it "returns the namespace given no arguments" do
+        expect(namespace.call).to eq 'stripe_event'
+      end
+    end
+
+    describe "#to_regexp" do
+      it "matches namespaced strings" do
+        expect(namespace.to_regexp('foo.bar')).to match namespace.call('foo.bar')
+      end
 
-    described_class.event_retriever = Proc.new { |arg| arg }
-    event = described_class.event_retriever.call(params)
-    expect(event).to eq params
+      it "matches all namespaced strings given no arguments" do
+        expect(namespace.to_regexp).to match namespace.call('foo.bar')
+      end
+    end
   end
 end

data/spec/rails_helper.rb

@@ -0,0 +1,3 @@
+ENV["RAILS_ENV"] = 'test'
+require File.expand_path("../dummy/config/environment", __FILE__)
+require 'rspec/rails'

data/spec/spec_helper.rb

@@ -1,15 +1,8 @@
-ENV["RAILS_ENV"] ||= 'test'
-require File.expand_path("../dummy/config/environment", __FILE__)
-require 'rspec/rails'
 require 'webmock/rspec'
-
-support_dir = File.join(File.dirname(__FILE__), '../spec/support/**/*.rb')
-Dir[support_dir].each { |f| require f }
+require File.expand_path('../../lib/stripe_event', __FILE__)
+Dir[File.expand_path('../spec/support/**/*.rb', __FILE__)].each { |f| require f }
 
 RSpec.configure do |config|
-  config.include FixtureHelper
-  config.include ActiveSupportHelper
-
   config.order = 'random'
 
   config.expect_with :rspec do |c|

data/stripe_event.gemspec

@@ -9,7 +9,7 @@ Gem::Specification.new do |s|
   s.version     = StripeEvent::VERSION
   s.license     = "MIT"
   s.authors     = ["Danny Whalen"]
-  s.email       = ["dwhalen@integrallis.com"]
+  s.email       = "daniel.r.whalen@gmail.com"
   s.homepage    = "https://github.com/integrallis/stripe_event"
   s.summary     = "Stripe webhook integration for Rails applications."
   s.description = "Stripe webhook integration for Rails applications."
@@ -17,9 +17,10 @@ Gem::Specification.new do |s|
   s.files       = `git ls-files`.split("\n")
   s.test_files  = `git ls-files -- Appraisals {spec,gemfiles}/*`.split("\n")
 
-  s.add_dependency "rails", ">= 3.1"
+  s.add_dependency "activesupport", ">= 3.1"
   s.add_dependency "stripe", "~> 1.6"
 
+  s.add_development_dependency "rails", ">= 3.1"
   s.add_development_dependency "rspec-rails", "~> 2.12"
   s.add_development_dependency "webmock", "~> 1.9"
   s.add_development_dependency "appraisal"

metadata

@@ -1,17 +1,17 @@
 --- !ruby/object:Gem::Specification
 name: stripe_event
 version: !ruby/object:Gem::Version
-  version: 0.6.1
+  version: 1.0.0
 platform: ruby
 authors:
 - Danny Whalen
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-08-19 00:00:00.000000000 Z
+date: 2013-12-19 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
-  name: rails
+  name: activesupport
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - '>='
@@ -38,6 +38,20 @@ dependencies:
     - - ~>
       - !ruby/object:Gem::Version
         version: '1.6'
+- !ruby/object:Gem::Dependency
+  name: rails
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '3.1'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '3.1'
 - !ruby/object:Gem::Dependency
   name: rspec-rails
   requirement: !ruby/object:Gem::Requirement
@@ -81,8 +95,7 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 description: Stripe webhook integration for Rails applications.
-email:
-- dwhalen@integrallis.com
+email: daniel.r.whalen@gmail.com
 executables: []
 extensions: []
 extra_rdoc_files: []
@@ -98,7 +111,6 @@ files:
 - Rakefile
 - app/controllers/stripe_event/webhook_controller.rb
 - config/routes.rb
-- dashboard-webhook.png
 - gemfiles/rails3.1.gemfile
 - gemfiles/rails3.1.gemfile.lock
 - gemfiles/rails3.2.gemfile
@@ -141,10 +153,8 @@ files:
 - spec/dummy/public/favicon.ico
 - spec/dummy/script/rails
 - spec/lib/stripe_event_spec.rb
+- spec/rails_helper.rb
 - spec/spec_helper.rb
-- spec/support/active_support_helper.rb
-- spec/support/core_ext.rb
-- spec/support/fixture_helper.rb
 - spec/support/fixtures/evt_charge_succeeded.json
 - spec/support/fixtures/evt_invalid_id.json
 - stripe_event.gemspec
@@ -168,7 +178,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.0.3
+rubygems_version: 2.0.14
 signing_key: 
 specification_version: 4
 summary: Stripe webhook integration for Rails applications.
@@ -213,9 +223,8 @@ test_files:
 - spec/dummy/public/favicon.ico
 - spec/dummy/script/rails
 - spec/lib/stripe_event_spec.rb
+- spec/rails_helper.rb
 - spec/spec_helper.rb
-- spec/support/active_support_helper.rb
-- spec/support/core_ext.rb
-- spec/support/fixture_helper.rb
 - spec/support/fixtures/evt_charge_succeeded.json
 - spec/support/fixtures/evt_invalid_id.json
+has_rdoc: 

data/spec/support/active_support_helper.rb

@@ -1,5 +0,0 @@
-module ActiveSupportHelper
-  def subscribers_for_type(name)
-    ActiveSupport::Notifications.notifier.listeners_for(name)
-  end
-end

data/spec/support/core_ext.rb

@@ -1,4 +0,0 @@
-class Set
-  # Just for tests
-  delegate :sample, :to => :to_a
-end

data/spec/support/fixture_helper.rb

@@ -1,10 +0,0 @@
-module FixtureHelper
-  def stub_event(identifier, status = 200)
-    stub_request(:get, "https://api.stripe.com/v1/events/#{identifier}").
-      to_return(:status => status, :body => get_fixture(identifier), :headers => {})
-  end
-
-  def get_fixture(name)
-    File.read("spec/support/fixtures/#{name}.json")
-  end
-end