stripe 4.9.0 → 4.9.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 26baa8832b98118a80e495a63c9ac784ebaaf6c05a6f45470e4d2bddfd81679f
-  data.tar.gz: 06ca6de0b1b8363ebf49df745722f095bb943105dbc22d51c688c39e9e06e4b9
+  metadata.gz: 05b0bfe8d9b4817553b20b94c660d08bdbcf0bec1b8c655636393e9288ac5ee2
+  data.tar.gz: 6a41f5b4709736df4e25c402d2171404b34ea8f6f92e7b1f4c22a8232bfe7b89
 SHA512:
-  metadata.gz: 9c19e6198d482addce7c6a9fd6e469a6c362139ada4926901c3e0d1704283de1b746c94c13ecee944741b8a7ad60f9acd0830bda020a3516b2a485f8e260c2ee
-  data.tar.gz: 545bd13709cb412e3c6505756eb566566d1658667c19572339811c6fd70d3425ecd0999a4d07fb1dd24bdebd5f4f4739bdf15e5a3286e058fbca1f06da884f7e
+  metadata.gz: 04a895d4d2f11ad5d9c74e3d99a2a7b9dddd46629e2df8413fd9370e5cfc8b11592232e0cb5982b01d9fca7ac6b5fb5cfc827646e725c8b9ce3e55a83bc0f9c6
+  data.tar.gz: cabfe746220087d68288f31636fa5eace4d00a36a5add7791fa7676751df4d81175d7a325818a9afe87a99849c7decfbd6e1d39829b967c482379ed2bde3b285

data/.travis.yml

@@ -17,7 +17,7 @@ sudo: false
 env:
   global:
     # If changing this number, please also change it in `test/test_helper.rb`.
-    - STRIPE_MOCK_VERSION=0.44.0
+    - STRIPE_MOCK_VERSION=0.47.0
 
 cache:
   directories:

data/CHANGELOG.md

@@ -1,5 +1,8 @@
 # Changelog
 
+## 4.9.1 - 2019-03-18
+* [#750](https://github.com/stripe/stripe-ruby/pull/750) Catch error and warn if unable to remove a method
+
 ## 4.9.0 - 2019-02-12
 * [#739](https://github.com/stripe/stripe-ruby/pull/739) Add support for `SubscriptionSchedule` and `SubscriptionScheduleRevision`
 
@@ -208,7 +211,8 @@
 * Handle `invalid_client` OAuth error code
 * Improve safety of error handling logic safer for unrecognized OAuth error codes
 
-## 3.0.2 - 2017-07-12 (yanked)
+## 3.0.2 - 2017-07-12
+**Important:** This version is non-functional and has been yanked in favor of 3.0.3.
 * Convert `nil` to empty string when serializing parameters (instead of opaquely dropping it) -- NOTE: this change has since been reverted
 
 ## 3.0.1 - 2017-07-11

data/VERSION

@@ -1 +1 @@
-4.9.0
+4.9.1

data/lib/stripe/stripe_object.rb

@@ -298,7 +298,25 @@ module Stripe
 
           # Remove methods for the accessor's reader and writer.
           [k, :"#{k}=", :"#{k}?"].each do |method_name|
-            remove_method(method_name) if method_defined?(method_name)
+            next unless method_defined?(method_name)
+
+            begin
+              remove_method(method_name)
+            rescue NameError
+              # In some cases there can be a method that's detected with
+              # `method_defined?`, but which cannot be removed with
+              # `remove_method`, even though it's on the same class. The only
+              # case so far that we've noticed this is when a class is
+              # reopened for monkey patching:
+              #
+              #     https://github.com/stripe/stripe-ruby/issues/749
+              #
+              # Here we swallow that error and issue a warning so at least
+              # the program doesn't crash.
+              $stderr.puts("WARNING: Unable to remove method `#{method_name}`; " \
+                "if custom, please consider renaming to a name that doesn't " \
+                "collide with an API property name.")
+            end
           end
         end
       end

data/lib/stripe/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Stripe
-  VERSION = "4.9.0".freeze
+  VERSION = "4.9.1".freeze
 end

data/test/stripe/account_test.rb

@@ -100,7 +100,12 @@ module Stripe
 
     context "#legal_entity=" do
       should "disallow direct overrides" do
-        account = Stripe::Account.retrieve("acct_123")
+        account = Stripe::Account.construct_from(
+          id: "acct_123",
+          legal_entity: {
+            first_name: "name",
+          }
+        )
 
         assert_raise NoMethodError do
           account.legal_entity = { first_name: "Blah" }
@@ -111,7 +116,7 @@ module Stripe
     end
 
     context "#serialize_params" do
-      should "serialize an a new additional_owners" do
+      should "serialize a new additional_owners" do
         obj = Stripe::Util.convert_to_stripe_object({
           object: "account",
           legal_entity: Stripe::StripeObject.construct_from({

data/test/stripe/api_resource_test.rb

@@ -375,20 +375,22 @@ module Stripe
       end
 
       should "correctly handle replaced nested objects" do
-        acct = Stripe::Account.construct_from(id: "myid",
-                                              legal_entity: {
-                                                last_name: "Smith",
-                                                address: {
-                                                  line1: "test",
-                                                  city: "San Francisco",
-                                                },
-                                              })
-
-        stub_request(:post, "#{Stripe.api_base}/v1/accounts/myid")
-          .with(body: { legal_entity: { address: { line1: "Test2", city: "" } } })
+        acct = Stripe::Account.construct_from(
+          id: "acct_123",
+          company: {
+            name: "company_name",
+            address: {
+              line1: "test",
+              city: "San Francisco",
+            },
+          }
+        )
+
+        stub_request(:post, "#{Stripe.api_base}/v1/accounts/acct_123")
+          .with(body: { company: { address: { line1: "Test2", city: "" } } })
           .to_return(body: JSON.generate("id" => "my_id"))
 
-        acct.legal_entity.address = { line1: "Test2" }
+        acct.company.address = { line1: "Test2" }
         acct.save
       end
 

data/test/test_helper.rb

@@ -17,7 +17,7 @@ require ::File.expand_path("../test_data", __FILE__)
 require ::File.expand_path("../stripe_mock", __FILE__)
 
 # If changing this number, please also change it in `.travis.yml`.
-MOCK_MINIMUM_VERSION = "0.44.0".freeze
+MOCK_MINIMUM_VERSION = "0.47.0".freeze
 MOCK_PORT = Stripe::StripeMock.start
 
 # Disable all real network connections except those that are outgoing to

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: stripe
 version: !ruby/object:Gem::Version
-  version: 4.9.0
+  version: 4.9.1
 platform: ruby
 authors:
 - Stripe
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-02-12 00:00:00.000000000 Z
+date: 2019-03-18 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: faraday
@@ -253,8 +253,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.7.7
+rubygems_version: 3.0.3
 signing_key: 
 specification_version: 4
 summary: Ruby bindings for the Stripe API