stripe 4.21.2 → 4.21.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 9565603560cfb5f63405f2ac5a1fbbab363d736c81bb7d06858a06530e9fb5b9
-  data.tar.gz: cc69afe87e63b28d38b1fcd5482cc947b24e0f13414e2c8abc4a2267b27ba373
+  metadata.gz: 9231fd56adca6e557e0e6956a115e7f969096402747e143ff7d433442146f0ac
+  data.tar.gz: 6f2a3c7a973e5f004518a83ccac1164f7eb354fe26816aa2f39bfa67b4b661e0
 SHA512:
-  metadata.gz: 6fdbf78bb9cce8463cedb3859755607b5c4b5e9eeea2125aee9079e3ea9ed00c623d8ce5dd249b4ee042c05552b80be8b7848a831c1a73d1e14cc72bcbd11e97
-  data.tar.gz: 539d01633f5ced964669bd7611aaeb64534b54a2125ea8e0480867e9d94a5af8d9563450e6ac9e2bdedf3e72d0f25fca77ca8c2d3c08a6049b804a72340bc237
+  metadata.gz: 66416730e242f3e1de13937d46143cfd3c2a2f97ac6cbdf908b9a01a1f12b158a3ee983e3f1d888bfccc734b518382889ef57dff9e215e448cd3572268883b99
+  data.tar.gz: c6ac92bcbe56e3d19cb642677f5cbcaf89afe45f5321e6016931b9fc8a86b5e203efc10f9de5db9b5df4ac443a3f539d8e4374e547f1e1f24f65d3730dbe9e91

data/CHANGELOG.md

@@ -1,5 +1,8 @@
 # Changelog
 
+## 4.21.3 - 2019-07-15
+* [#810](https://github.com/stripe/stripe-ruby/pull/810) Better error message when passing non-string to custom method
+
 ## 4.21.2 - 2019-07-05
 * [#806](https://github.com/stripe/stripe-ruby/pull/806) Revert back to `initialize_from` from `Util.convert_to_stripe_object`
 

data/VERSION

@@ -1 +1 @@
-4.21.2
+4.21.3

data/lib/stripe/api_resource.rb

@@ -70,6 +70,11 @@ module Stripe
       end
       http_path ||= name.to_s
       define_singleton_method(name) do |id, params = {}, opts = {}|
+        unless id.is_a?(String)
+          raise ArgumentError,
+                "id should be a string representing the ID of an API resource"
+        end
+
         url = "#{resource_url}/#{CGI.escape(id)}/#{CGI.escape(http_path)}"
         resp, opts = request(http_verb, url, params, opts)
         Util.convert_to_stripe_object(resp.data, opts)

data/lib/stripe/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Stripe
-  VERSION = "4.21.2".freeze
+  VERSION = "4.21.3".freeze
 end

data/test/stripe/api_resource_test.rb

@@ -4,10 +4,31 @@ require ::File.expand_path("../test_helper", __dir__)
 
 module Stripe
   class ApiResourceTest < Test::Unit::TestCase
+    class CustomMethodAPIResource < APIResource
+      OBJECT_NAME = "custom_method".freeze
+      custom_method :my_method, http_verb: :post
+    end
+
     class NestedTestAPIResource < APIResource
       save_nested_resource :external_account
     end
 
+    context ".custom_method" do
+      should "call to an RPC-style method" do
+        stub_request(:post, "#{Stripe.api_base}/v1/custom_methods/ch_123/my_method")
+          .to_return(body: JSON.generate({}))
+        CustomMethodAPIResource.my_method("ch_123")
+      end
+
+      should "raise an error if a non-ID is passed" do
+        e = assert_raises ArgumentError do
+          CustomMethodAPIResource.my_method(id: "ch_123")
+        end
+        assert_equal "id should be a string representing the ID of an API resource",
+                     e.message
+      end
+    end
+
     context ".save_nested_resource" do
       should "can have a scalar set" do
         r = NestedTestAPIResource.new("test_resource")

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: stripe
 version: !ruby/object:Gem::Version
-  version: 4.21.2
+  version: 4.21.3
 platform: ruby
 authors:
 - Stripe
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-07-05 00:00:00.000000000 Z
+date: 2019-07-16 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: faraday