stripe 3.9.1 → 3.9.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: 723bba8860a5b21cabb16483d47c3fc049db0c18
-  data.tar.gz: e586b7a2d24c7197a3b16e62766b6203cc9c38e4
+SHA256:
+  metadata.gz: f9f926c6f2c902aefeba870c1c7b3bdfac27b394a391096e17c0834d5016d3d1
+  data.tar.gz: 3e10d1311e66dcc34c67e3c75316cf6979725e6b05f362058a8138ae05d2fc70
 SHA512:
-  metadata.gz: e47a259ec4ed3e5ff6bea20e220617de06e6e1beacdd0682e78640d06ff7e13110a0d9f9d01474eec8192d821027fd24be8c307ddf87992a9705db845c6aaf46
-  data.tar.gz: 8683583d898179e103d59ba325806b1d4c806cf2863fdc22948a41dd159646427374466ad17a2d57c313f9cce43273a07e859de9c515bf68174b3033b4f8c94b
+  metadata.gz: 510a4b49893fc8ee4b7c056b4f4bcd64d17381beb83c1cb58618401353530533b7fec730be4af96d1d44f72e03b13dee69667132ea6b51acc8475066cc618a78
+  data.tar.gz: cd6192e48881e068b8e9fc70fd77a13decb94fcffd2016710b5d11b247515c33852e0fe2bd2afb41926419e8222611dd4f272678b8b5b0176312bb81e0a1cc32

data/CHANGELOG.md

@@ -1,5 +1,8 @@
 # Changelog
 
+## 3.9.2 - 2018-02-12
+* [#625](https://github.com/stripe/stripe-ruby/pull/625) Skip calling `to_hash` for `nil`
+
 ## 3.9.1 - 2017-12-15
 * [#616](https://github.com/stripe/stripe-ruby/pull/616) Support all file-like objects for uploads with duck typed checks on `path` and `read` (we previously whitelisted only certain classes)
 

data/VERSION

@@ -1 +1 @@
-3.9.1
+3.9.2

data/lib/stripe/stripe_object.rb

@@ -116,7 +116,7 @@ module Stripe
 
     def to_hash
       maybe_to_hash = lambda do |value|
-        value.respond_to?(:to_hash) ? value.to_hash : value
+        value && value.respond_to?(:to_hash) ? value.to_hash : value
       end
 
       @values.each_with_object({}) do |(key, value), acc|

data/lib/stripe/version.rb

@@ -1,3 +1,3 @@
 module Stripe
-  VERSION = "3.9.1".freeze
+  VERSION = "3.9.2".freeze
 end

data/test/stripe/stripe_object_test.rb

@@ -115,23 +115,40 @@ module Stripe
       end
     end
 
-    should "recursively call to_hash on its values" do
-      # deep nested hash (when contained in an array) or StripeObject
-      nested_hash = { id: 7, foo: "bar" }
-      nested = Stripe::StripeObject.construct_from(nested_hash)
-
-      obj = Stripe::StripeObject.construct_from(id: 1,
-                                                # simple hash that contains a StripeObject to help us test deep
-                                                # recursion
-                                                nested: { object: "list", data: [nested] },
-                                                list: [nested])
-
-      expected_hash = {
-        id: 1,
-        nested: { object: "list", data: [nested_hash] },
-        list: [nested_hash],
-      }
-      assert_equal expected_hash, obj.to_hash
+    context "#to_hash" do
+      should "skip calling to_hash on nil" do
+        module NilWithToHash
+          def to_hash
+            raise "Can't call to_hash on nil"
+          end
+        end
+        # include is private in Ruby 2.0
+        NilClass.send(:include, NilWithToHash)
+
+        hash_with_nil = { id: 3, foo: nil }
+        obj = StripeObject.construct_from(hash_with_nil)
+        expected_hash = { id: 3, foo: nil }
+        assert_equal expected_hash, obj.to_hash
+      end
+
+      should "recursively call to_hash on its values" do
+        # deep nested hash (when contained in an array) or StripeObject
+        nested_hash = { id: 7, foo: "bar" }
+        nested = Stripe::StripeObject.construct_from(nested_hash)
+
+        obj = Stripe::StripeObject.construct_from(id: 1,
+                                                  # simple hash that contains a StripeObject to help us test deep
+                                                  # recursion
+                                                  nested: { object: "list", data: [nested] },
+                                                  list: [nested])
+
+        expected_hash = {
+          id: 1,
+          nested: { object: "list", data: [nested_hash] },
+          list: [nested_hash],
+        }
+        assert_equal expected_hash, obj.to_hash
+      end
     end
 
     should "assign question mark accessors for booleans" do

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: stripe
 version: !ruby/object:Gem::Version
-  version: 3.9.1
+  version: 3.9.2
 platform: ruby
 authors:
 - Stripe
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-12-15 00:00:00.000000000 Z
+date: 2018-02-12 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: faraday
@@ -182,7 +182,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.6.14
+rubygems_version: 2.7.4
 signing_key: 
 specification_version: 4
 summary: Ruby bindings for the Stripe API