stripe 3.5.0 → 3.5.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 318be0fcbe32bab36c77a9390c936aba1735106a
-  data.tar.gz: b060b65d599adf9a51cb6c0d9f1ba81b3a6acc5c
+  metadata.gz: 6b7dbd882684aa750e2f41166db12d75e2cabae4
+  data.tar.gz: 6e83b5c99ad759bc9f0788fc95cd171e5a67b0b1
 SHA512:
-  metadata.gz: 83a649dc5dcdb5c62511afcad9367fb4368078950de40ad1e0472250eb4d1521034f27dd98740a759e4694937bf648aac692d2d6546687537e8bf9934fe0e17a
-  data.tar.gz: 8695ec3cf4e68d269c5e9826af93a50f2e61db554d4f2898035aacdf178240f7ed3ccd4f8fc4cd408a398f72d3ea428ed6bbd115d8e323357c41cb05d384b192
+  metadata.gz: 8a8e35eb52b5a40da94ca6a30b639b67bd029474d27728aa656de7c55ce52073a5ecaea2e0d0cd79e913bd4c58ecfef90bafef26b0d9a7a9e865894aec2245c9
+  data.tar.gz: 3d97567c3dfc0762ee9fae4a00f13faf689a8042630d87bb8e0e638b26b4b907dfdb4229fcfa70cc686da79ae7fa38ab51d7baaf2c86bc676998139d1524243c

data/.rubocop_todo.yml

@@ -1,6 +1,6 @@
 # This configuration was generated by
 # `rubocop --auto-gen-config`
-# on 2017-09-27 21:19:01 +0200 using RuboCop version 0.50.0.
+# on 2017-10-12 18:19:29 +0200 using RuboCop version 0.50.0.
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
@@ -10,46 +10,44 @@
 Metrics/AbcSize:
   Max: 49
 
-# Offense count: 22
+# Offense count: 24
 # Configuration parameters: CountComments, ExcludedMethods.
 Metrics/BlockLength:
-  Max: 461
+  Max: 455
 
 # Offense count: 8
 # Configuration parameters: CountComments.
 Metrics/ClassLength:
-  Max: 581
+  Max: 583
 
 # Offense count: 8
 Metrics/CyclomaticComplexity:
   Max: 13
 
-# Offense count: 216
+# Offense count: 215
 # Configuration parameters: AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, IgnoredPatterns.
 # URISchemes: http, https
 Metrics/LineLength:
-  Max: 312
+  Max: 310
 
-# Offense count: 29
+# Offense count: 31
 # Configuration parameters: CountComments.
 Metrics/MethodLength:
   Max: 47
 
-# Offense count: 2
+# Offense count: 1
 # Configuration parameters: CountComments.
 Metrics/ModuleLength:
-  Max: 423
+  Max: 298
 
-# Offense count: 6
+# Offense count: 5
 # Configuration parameters: CountKeywordArgs.
 Metrics/ParameterLists:
   Max: 7
 
-# Offense count: 5
+# Offense count: 4
 Metrics/PerceivedComplexity:
-  Max: 11
-  Exclude:
-    - 'lib/stripe/stripe_object.rb'
+  Max: 15
 
 # Offense count: 2
 Style/ClassVars:

data/History.txt

@@ -1,6 +1,10 @@
+=== 3.5.1 2017-10-12
+
+* [#591] Use thread-local `StripeClient` instances for thread safety
+
 === 3.5.0 2017-10-11
 
-* [#589] Add support for detaching sources fromm customers
+* [#589] Rename source `delete` to `detach` (and deprecate the former)
 
 === 3.4.1 2017-10-05
 

data/VERSION

@@ -1 +1 @@
-3.5.0
+3.5.1

data/lib/stripe/stripe_client.rb

@@ -17,7 +17,7 @@ module Stripe
     end
 
     def self.default_client
-      @default_client ||= StripeClient.new(default_conn)
+      Thread.current[:stripe_client_default_client] ||= StripeClient.new(default_conn)
     end
 
     # A default Faraday connection to be used when one isn't configured. This

data/lib/stripe/version.rb

@@ -1,3 +1,3 @@
 module Stripe
-  VERSION = "3.5.0".freeze
+  VERSION = "3.5.1".freeze
 end

data/test/stripe/stripe_client_test.rb

@@ -19,6 +19,15 @@ module Stripe
       should "be a StripeClient" do
         assert_kind_of StripeClient, StripeClient.default_client
       end
+
+      should "be a different client on each thread" do
+        other_thread_client = nil
+        thread = Thread.new do
+          other_thread_client = StripeClient.default_client
+        end
+        thread.join
+        refute_equal StripeClient.default_client, other_thread_client
+      end
     end
 
     context ".default_conn" do

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: stripe
 version: !ruby/object:Gem::Version
-  version: 3.5.0
+  version: 3.5.1
 platform: ruby
 authors:
 - Stripe
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-10-11 00:00:00.000000000 Z
+date: 2017-10-12 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: faraday