stripe 3.17.0 → 3.17.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: bac1f6ddcfa0fad7db03e5929bb02fa20a8d55a1
-  data.tar.gz: 7623d4070e7d9e4260d9213638fa7750e0fef6b3
+SHA256:
+  metadata.gz: acbfb1122ba314433628312929afc3560c5cf758d16665433d119b845e32001d
+  data.tar.gz: 14444a0da91da5fadbbd74ce3ec492ab03d5724de25c2a0d26f955fda6208fdb
 SHA512:
-  metadata.gz: 8d79721ac5dceccd1cd8769b1cdb104142750e0f3ddc9d965584e4731a2bd382a8cb5c17d2b3751da8699a0bc39a3fd00ba7589829d0cc4aec7aa8d481fd653e
-  data.tar.gz: 5df86bf3c52ee058ce0e00515264c166f14a935382fafdaab578d9545f9affcd63af20d3fa99f96534d6fc488d52aef76da06628db733b317565cdb00c2fe0bb
+  metadata.gz: 3413e4af564775f3fedab1418387361a68903b3f883b240395cf8deb70fed1c562e82f5c32e8dec94fb9b90053aafb798d6287c32083cf16a959dfdc097774eb
+  data.tar.gz: 5e6505abae65f4d3e014b71820efbe96509df473e5957f26b3be933cca89e5da06cf7884a05a961884a263863c68c88e52c5c83ca29f12e5d13dd6a0f55c8dcd

data/.rubocop_todo.yml

@@ -1,6 +1,6 @@
 # This configuration was generated by
 # `rubocop --auto-gen-config`
-# on 2018-06-28 10:59:56 -0400 using RuboCop version 0.50.0.
+# on 2018-07-19 14:22:24 +0200 using RuboCop version 0.50.0.
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
@@ -24,7 +24,7 @@ Metrics/ClassLength:
 Metrics/CyclomaticComplexity:
   Max: 15
 
-# Offense count: 269
+# Offense count: 278
 # Configuration parameters: AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, IgnoredPatterns.
 # URISchemes: http, https
 Metrics/LineLength:
@@ -38,7 +38,7 @@ Metrics/MethodLength:
 # Offense count: 1
 # Configuration parameters: CountComments.
 Metrics/ModuleLength:
-  Max: 350
+  Max: 308
 
 # Offense count: 6
 # Configuration parameters: CountKeywordArgs.
@@ -55,6 +55,6 @@ Style/ClassVars:
     - 'lib/stripe/stripe_object.rb'
     - 'test/stripe/api_resource_test.rb'
 
-# Offense count: 55
+# Offense count: 56
 Style/Documentation:
   Enabled: false

data/.travis.yml

@@ -1,11 +1,12 @@
 language: ruby
 
 rvm:
-  - 2.0.0
+  - 2.0
   - 2.1
   - 2.2
-  - 2.3.0
-  - 2.4.0
+  - 2.3
+  - 2.4
+  - 2.5
   - jruby-9.0.5.0
 
 notifications:
@@ -17,7 +18,7 @@ sudo: false
 env:
   global:
     # If changing this number, please also change it in `test/test_helper.rb`.
-    - STRIPE_MOCK_VERSION=0.16.0
+    - STRIPE_MOCK_VERSION=0.19.0
 
 cache:
   directories:

data/CHANGELOG.md

@@ -1,5 +1,8 @@
 # Changelog
 
+## 3.17.1 - 2018-07-19
+* [#663](https://github.com/stripe/stripe-ruby/pull/663) Internal improvements to `ApiResource.class_url`
+
 ## 3.17.0 - 2018-06-28
 * [#658](https://github.com/stripe/stripe-ruby/pull/658) Add support for `partner_id` from `Stripe.set_app_info`
 

data/VERSION

@@ -1 +1 @@
-3.17.0
+3.17.1

data/lib/stripe/api_resource.rb

@@ -19,7 +19,9 @@ module Stripe
       if self == APIResource
         raise NotImplementedError, "APIResource is an abstract class.  You should perform actions on its subclasses (Charge, Customer, etc.)"
       end
-      "/v1/#{CGI.escape(class_name.downcase)}s"
+      # Namespaces are separated in object names with periods (.) and in URLs
+      # with forward slashes (/), so replace the former with the latter.
+      "/v1/#{self::OBJECT_NAME.downcase.tr('.', '/')}s"
     end
 
     # A metaprogramming call that specifies that a field of a resource can be

data/lib/stripe/application_fee.rb

@@ -9,10 +9,6 @@ module Stripe
 
     nested_resource_class_methods :refund, operations: %i[create retrieve update list]
 
-    def self.resource_url
-      "/v1/application_fees"
-    end
-
     # If you don't need access to an updated fee object after the refund, it's
     # more performant to just call `fee.refunds.create` directly.
     def refund(params = {}, opts = {})

data/lib/stripe/country_spec.rb

@@ -5,9 +5,5 @@ module Stripe
     extend Stripe::APIOperations::List
 
     OBJECT_NAME = "country_spec".freeze
-
-    def self.resource_url
-      "/v1/country_specs"
-    end
   end
 end

data/lib/stripe/ephemeral_key.rb

@@ -7,10 +7,6 @@ module Stripe
 
     OBJECT_NAME = "ephemeral_key".freeze
 
-    def self.resource_url
-      "/v1/ephemeral_keys"
-    end
-
     def self.create(params = {}, opts = {})
       opts = Util.normalize_opts(opts)
       raise ArgumentError, "stripe_version must be specified to create an ephemeral key" unless opts[:stripe_version]

data/lib/stripe/exchange_rate.rb

@@ -5,9 +5,5 @@ module Stripe
     extend Stripe::APIOperations::List
 
     OBJECT_NAME = "exchange_rate".freeze
-
-    def self.resource_url
-      "/v1/exchange_rates"
-    end
   end
 end

data/lib/stripe/issuer_fraud_record.rb

@@ -5,9 +5,5 @@ module Stripe
     extend Stripe::APIOperations::List
 
     OBJECT_NAME = "issuer_fraud_record".freeze
-
-    def self.resource_url
-      "/v1/issuer_fraud_records"
-    end
   end
 end

data/lib/stripe/order_return.rb

@@ -5,9 +5,5 @@ module Stripe
     extend Stripe::APIOperations::List
 
     OBJECT_NAME = "order_return".freeze
-
-    def self.resource_url
-      "/v1/order_returns"
-    end
   end
 end

data/lib/stripe/payment_intent.rb

@@ -9,10 +9,6 @@ module Stripe
 
     OBJECT_NAME = "payment_intent".freeze
 
-    def self.resource_url
-      "/v1/payment_intents"
-    end
-
     def cancel
       resp, api_key = request(:post, resource_url + "/cancel")
       initialize_from(resp.data, api_key)

data/lib/stripe/singleton_api_resource.rb

@@ -6,7 +6,9 @@ module Stripe
       if self == SingletonAPIResource
         raise NotImplementedError, "SingletonAPIResource is an abstract class.  You should perform actions on its subclasses (Account, etc.)"
       end
-      "/v1/#{CGI.escape(class_name.downcase)}"
+      # Namespaces are separated in object names with periods (.) and in URLs
+      # with forward slashes (/), so replace the former with the latter.
+      "/v1/#{self::OBJECT_NAME.downcase.tr('.', '/')}"
     end
 
     def resource_url

data/lib/stripe/subscription_item.rb

@@ -8,9 +8,5 @@ module Stripe
     include Stripe::APIOperations::Save
 
     OBJECT_NAME = "subscription_item".freeze
-
-    def self.resource_url
-      "/v1/subscription_items"
-    end
   end
 end

data/lib/stripe/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Stripe
-  VERSION = "3.17.0".freeze
+  VERSION = "3.17.1".freeze
 end

data/test/stripe/api_operations_test.rb

@@ -8,6 +8,8 @@ module Stripe
     class UpdateableResource < APIResource
       include Stripe::APIOperations::Save
 
+      OBJECT_NAME = "updateableresource".freeze
+
       def self.protected_fields
         [:protected]
       end
@@ -33,6 +35,7 @@ module Stripe
     context ".nested_resource_class_methods" do
       class MainResource < APIResource
         extend Stripe::APIOperations::NestedResource
+        OBJECT_NAME = "mainresource".freeze
         nested_resource_class_methods :nested,
                                       operations: %i[create retrieve update delete list]
       end

data/test/stripe/payment_intent_test.rb

@@ -7,9 +7,6 @@ module Stripe
 
   class PaymentIntentTest < Test::Unit::TestCase
     should "be listable" do
-      stub_request(:get, "#{Stripe.api_base}/v1/payment_intents")
-        .to_return(body: JSON.generate(object: "list", data: [{ id: "pi_123", object: "payment_intent" }]))
-
       payment_intents = Stripe::PaymentIntent.list
       assert_requested :get, "#{Stripe.api_base}/v1/payment_intents"
       assert payment_intents.data.is_a?(Array)
@@ -17,27 +14,22 @@ module Stripe
     end
 
     should "be retrievable" do
-      stub_request(:get, "#{Stripe.api_base}/v1/payment_intents/pi_123")
-        .to_return(body: JSON.generate(id: "pi_123", object: "payment_intent"))
-
       payment_intent = Stripe::PaymentIntent.retrieve("pi_123")
       assert_requested :get, "#{Stripe.api_base}/v1/payment_intents/pi_123"
       assert payment_intent.is_a?(Stripe::PaymentIntent)
     end
 
     should "be creatable" do
-      stub_request(:post, "#{Stripe.api_base}/v1/payment_intents")
-        .to_return(body: JSON.generate(id: "pi_123", object: "payment_intent"))
-
-      payment_intent = Stripe::PaymentIntent.create
+      payment_intent = Stripe::PaymentIntent.create(
+        allowed_source_types: ["card"],
+        amount: 1234,
+        currency: "usd"
+      )
       assert_requested :post, "#{Stripe.api_base}/v1/payment_intents"
       assert payment_intent.is_a?(Stripe::PaymentIntent)
     end
 
     should "be saveable" do
-      stub_request(:post, "#{Stripe.api_base}/v1/payment_intents/pi_123")
-        .to_return(body: JSON.generate(id: "pi_123", object: "payment_intent"))
-
       payment_intent = Stripe::PaymentIntent.construct_from(id: "pi_123", object: "payment_intent", metadata: {})
       payment_intent.metadata["key"] = "value"
       payment_intent.save
@@ -45,9 +37,6 @@ module Stripe
     end
 
     should "be updateable" do
-      stub_request(:post, "#{Stripe.api_base}/v1/payment_intents/pi_123")
-        .to_return(body: JSON.generate(id: "pi_123", object: "payment_intent"))
-
       payment_intent = Stripe::PaymentIntent.update("pi_123", metadata: { foo: "bar" })
 
       assert_requested :post, "#{Stripe.api_base}/v1/payment_intents/pi_123"
@@ -56,9 +45,6 @@ module Stripe
 
     context "#cancel" do
       should "cancel a payment_intent" do
-        stub_request(:post, "#{Stripe.api_base}/v1/payment_intents/pi_123/cancel")
-          .to_return(body: JSON.generate(id: "pi_123", object: "payment_intent"))
-
         payment_intent = Stripe::PaymentIntent.construct_from(id: "pi_123", object: "payment_intent")
         payment_intent = payment_intent.cancel
 
@@ -69,9 +55,6 @@ module Stripe
 
     context "#capture" do
       should "capture a payment_intent" do
-        stub_request(:post, "#{Stripe.api_base}/v1/payment_intents/pi_123/capture")
-          .to_return(body: JSON.generate(id: "pi_123", object: "payment_intent"))
-
         payment_intent = Stripe::PaymentIntent.construct_from(id: "pi_123", object: "payment_intent")
         payment_intent = payment_intent.capture
 
@@ -82,9 +65,6 @@ module Stripe
 
     context "#confirm" do
       should "confirm a payment_intent" do
-        stub_request(:post, "#{Stripe.api_base}/v1/payment_intents/pi_123/confirm")
-          .to_return(body: JSON.generate(id: "pi_123", object: "payment_intent"))
-
         payment_intent = Stripe::PaymentIntent.construct_from(id: "pi_123", object: "payment_intent")
         payment_intent = payment_intent.confirm
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: stripe
 version: !ruby/object:Gem::Version
-  version: 3.17.0
+  version: 3.17.1
 platform: ruby
 authors:
 - Stripe
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-06-28 00:00:00.000000000 Z
+date: 2018-07-19 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: faraday
@@ -190,7 +190,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.6.14
+rubygems_version: 2.7.7
 signing_key: 
 specification_version: 4
 summary: Ruby bindings for the Stripe API