stripe 1.8.4 → 1.8.5

data/History.txt

@@ -1,4 +1,11 @@
-=== 1.8.3 2013-07-11
+=== 1.8.5 2013-08-12
+
+* Add support for unsetting attributes by setting to nil.
+  Permits unsetting email and description on customers and description on charges.
+  Setting properties to a blank string is now an error.
+* Attempting to set an object's id is now an error.
+
+=== 1.8.4 2013-07-11
 
 * Add support for new cards API (Stripe API version 2013-07-05)
 

data/VERSION

@@ -1 +1 @@
-1.8.4
+1.8.5

data/lib/stripe.rb

@@ -137,7 +137,7 @@ module Stripe
       @no_bundle = true
     end
 
-    !(@no_verify || @no_nobundle)
+    !(@no_verify || @no_bundle)
   end
 
   def self.user_agent

data/lib/stripe/api_operations/update.rb

@@ -3,8 +3,9 @@ module Stripe
     module Update
       def save
         if @unsaved_values.length > 0
-          values = {}
-          @unsaved_values.each { |k| values[k] = @values[k] }
+          values = @unsaved_values.reduce({}) do |h, k| 
+            h.update(k => @values[k].nil? ? '' : @values[k])
+          end
           values.delete(:id)
           response, api_key = Stripe.request(:post, url, @api_key, values)
           refresh_from(response, api_key)

data/lib/stripe/stripe_object.rb

@@ -26,7 +26,7 @@ module Stripe
       # to have a unified inspect method
       @unsaved_values = Set.new
       @transient_values = Set.new
-      self.id = id if id
+      @values[:id] = id if id
     end
 
     def self.construct_from(values, api_key=nil)
@@ -125,6 +125,12 @@ module Stripe
           k_eq = :"#{k}="
           define_method(k) { @values[k] }
           define_method(k_eq) do |v|
+            if v == ""
+              raise ArgumentError.new(
+                "You cannot set #{k} to an empty string." +
+                "We interpret empty strings as nil in requests." +
+                "You may set #{self}.#{k} = nil to delete the property.")
+            end
             @values[k] = v
             @unsaved_values.add(k)
           end
@@ -136,10 +142,13 @@ module Stripe
       # TODO: only allow setting in updateable classes.
       if name.to_s.end_with?('=')
         attr = name.to_s[0...-1].to_sym
-        @values[attr] = args[0]
-        @unsaved_values.add(attr)
         add_accessors([attr])
-        return
+        begin
+          mth = method(name)
+        rescue NameError
+          raise NoMethodError.new("Cannot set #{attr} on this object. HINT: you can't set: #{@@permanent_attributes.to_a.join(', ')}")
+        end
+        return mth.call(args[0])
       else
         return @values[name] if @values.has_key?(name)
       end

data/lib/stripe/version.rb

@@ -1,3 +1,3 @@
 module Stripe
-  VERSION = '1.8.4'
+  VERSION = '1.8.5'
 end

data/stripe.gemspec

@@ -10,8 +10,6 @@ spec = Gem::Specification.new do |s|
   s.authors = ['Ross Boucher', 'Greg Brockman']
   s.email = ['boucher@stripe.com', 'gdb@stripe.com']
   s.homepage = 'https://stripe.com/api'
-  s.executables = 'stripe-console'
-  s.require_paths = %w{lib}
 
   s.add_dependency('rest-client', '~> 1.4')
   s.add_dependency('multi_json', '>= 1.0.4', '< 2')

data/test/test_stripe.rb

@@ -240,7 +240,9 @@ class TestStripeRuby < Test::Unit::TestCase
         c = Stripe::Charge.all(:count => nil, :offset => 5, :sad => false)
 
         @mock.expects(:post).with do |url, api_key, params|
-          url == "#{Stripe.api_base}/v1/charges" && api_key.nil? && CGI.parse(params) == { 'amount' => ['50'], 'currency' => ['usd'] }
+          url == "#{Stripe.api_base}/v1/charges" && 
+            api_key.nil? && 
+            CGI.parse(params) == { 'amount' => ['50'], 'currency' => ['usd'] }
         end.returns(test_response({ :count => 1, :data => [test_charge] }))
         c = Stripe::Charge.create(:amount => 50, :currency => 'usd', :card => { :number => nil })
       end
@@ -295,17 +297,17 @@ class TestStripeRuby < Test::Unit::TestCase
 
       should "updating an object should issue a POST request with only the changed properties" do
         @mock.expects(:post).with do |url, api_key, params|
-          url == "#{Stripe.api_base}/v1/customers/c_test_customer" && api_key.nil? && CGI.parse(params) == {'mnemonic' => ['another_mn']}
+          url == "#{Stripe.api_base}/v1/customers/c_test_customer" && api_key.nil? && CGI.parse(params) == {'description' => ['another_mn']}
         end.once.returns(test_response(test_customer))
         c = Stripe::Customer.construct_from(test_customer)
-        c.mnemonic = "another_mn"
+        c.description = "another_mn"
         c.save
       end
 
       should "updating should merge in returned properties" do
         @mock.expects(:post).once.returns(test_response(test_customer))
         c = Stripe::Customer.new("c_test_customer")
-        c.mnemonic = "another_mn"
+        c.description = "another_mn"
         c.save
         assert_equal false, c.livemode
       end
@@ -394,7 +396,36 @@ class TestStripeRuby < Test::Unit::TestCase
           @mock.expects(:post).once.returns(test_response(test_charge))
           c = Stripe::Charge.new("test_charge")
           c.refresh
-          c.mnemonic = "New charge description"
+          c.description = "New charge description"
+          c.save
+        end
+
+        should "charge id should not be changeable" do
+          @mock.expects(:get).once.returns(test_response(test_charge))     
+          c = Stripe::Charge.new("test_charge")
+          c.refresh
+          assert_raises NoMethodError do
+            c.id = "my new id"
+          end
+        end
+
+        should "charge descriptions should not be settable to an empty string" do
+          @mock.expects(:get).once.returns(test_response(test_charge))     
+          c = Stripe::Charge.new("test_charge")
+          c.refresh
+          assert_raises ArgumentError do
+            c.description = ""
+          end
+        end
+
+        should "charges descriptions should pass nil as an empty string" do
+          @mock.expects(:get).once.returns(test_response(test_charge))
+          @mock.expects(:post).once.with do |url, api_key, params|
+            params == 'description='
+          end.returns(test_response(test_charge))
+          c = Stripe::Charge.new("test_charge")
+          c.refresh
+          c.description = nil
           c.save
         end
 
@@ -445,13 +476,13 @@ class TestStripeRuby < Test::Unit::TestCase
         end
 
         should "customers should be updateable" do
-          @mock.expects(:get).once.returns(test_response(test_customer({:mnemonic => "foo"})))
-          @mock.expects(:post).once.returns(test_response(test_customer({:mnemonic => "bar"})))
+          @mock.expects(:get).once.returns(test_response(test_customer({:description => "foo"})))
+          @mock.expects(:post).once.returns(test_response(test_customer({:description => "bar"})))
           c = Stripe::Customer.new("test_customer").refresh
-          assert_equal c.mnemonic, "foo"
-          c.mnemonic = "bar"
+          assert_equal c.description, "foo"
+          c.description = "bar"
           c.save
-          assert_equal c.mnemonic, "bar"
+          assert_equal c.description, "bar"
         end
 
         should "create should return a new customer" do
@@ -496,11 +527,11 @@ class TestStripeRuby < Test::Unit::TestCase
         end
 
         should "be able to update a customer without refreshing it first" do
-          @mock.expects(:post).once.with("#{Stripe.api_base}/v1/customers/test_customer", nil, 'mnemonic=bar').returns(test_response(test_customer({:mnemonic => "bar"})))
+          @mock.expects(:post).once.with("#{Stripe.api_base}/v1/customers/test_customer", nil, 'description=bar').returns(test_response(test_customer({:description => "bar"})))
           c = Stripe::Customer.new("test_customer")
-          c.mnemonic = "bar"
+          c.description = "bar"
           c.save
-          assert_equal c.mnemonic, "bar"
+          assert_equal c.description, "bar"
         end
 
       end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: stripe
 version: !ruby/object:Gem::Version
-  version: 1.8.4
+  version: 1.8.5
   prerelease: 
 platform: ruby
 authors:
@@ -10,7 +10,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-07-12 00:00:00.000000000 Z
+date: 2013-08-12 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rest-client