stripe 1.51.0 → 1.51.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 53821741b8b4c5d1ab26760b8dc79065a2b2ebf9
-  data.tar.gz: d61f8ae7d2501b2d4d3198fd31aebea2a07cf105
+  metadata.gz: 5d4b487a7f1742c56ebfafadb07b0a4ee7a352a4
+  data.tar.gz: ca0ab770ffc1e382f75b33c30a667d9fccd2af26
 SHA512:
-  metadata.gz: 6c4d5995dd5bbdd5ea063a79023a9467932470fb1299c69e73d1e9758600a4e890d66caa410680a7e2c13579a7b76bec62565d0cb665fbee5feb3c6124a049ce
-  data.tar.gz: 8db2e0a89f0327bb3b9c3fcbd61630dbab4d19d2b2150381ca551db9c4fda1b4778b8f972bf62f358db45173395e25969031466a9fb3352cc6de092d45cb9766
+  metadata.gz: 0fb66566f5cddad11f7fcdae7bd5ab6f50daf4366475da0da6bf8e2394063720b08c761bbc7f7afac446af907e2ecb5a8ea93b88d8e6aa9f5110c3afd44f00eb
+  data.tar.gz: 73c72693910b62975a67035cceca3ba5a3029c988eda0abeb268fd6d96dd2754bf93cb5198799c5f6903f06c2fe8dd031a85382047c24c6b90215fe1038707c6

data/History.txt

@@ -1,3 +1,7 @@
+=== 1.51.1 2016-08-30
+
+* Make sure `Account`'s `external_account` is saved with its parent
+
 === 1.51.0 2016-08-26
 
 * Error when an array of maps is detected that cannot be accurately encoded

data/VERSION

@@ -1 +1 @@
-1.51.0
+1.51.1

data/lib/stripe/account.rb

@@ -28,6 +28,23 @@ module Stripe
       super(id, opts)
     end
 
+    # Set or replace an account's external account.
+    def external_account=(value)
+      super
+
+      # The parent setter will perform certain useful operations like
+      # converting to an APIResource if appropriate.
+      value = self.external_account
+
+      # Note that external_account may be a card, but could also be a tokenized
+      # card's ID (which is a string), and so we check its type here.
+      if value.is_a?(APIResource)
+        value.save_with_parent = true
+      end
+
+      value
+    end
+
     def reject(params={}, opts={})
       opts = Util.normalize_opts(opts)
       response, opts = request(:post, resource_url + '/reject', params, opts)
@@ -93,6 +110,22 @@ module Stripe
 
     ARGUMENT_NOT_PROVIDED = Object.new
 
+    # Set or replace an account's bank account.
+    #
+    # This method is deprecated. Please use #external_account instead.
+    def bank_account=(value)
+      super
+      value = self.bank_account
+
+      if value.is_a?(APIResource)
+        value.save_with_parent = true
+      end
+
+      value
+    end
+    extend Gem::Deprecate
+    deprecate :bank_account=, "#external_account=", 2017, 8
+
     private
 
     def serialize_additional_owners(legal_entity, additional_owners)

data/lib/stripe/version.rb

@@ -1,3 +1,3 @@
 module Stripe
-  VERSION = '1.51.0'
+  VERSION = '1.51.1'
 end

data/test/stripe/account_test.rb

@@ -289,5 +289,63 @@ module Stripe
       }
       assert_equal(expected, obj.serialize_params)
     end
+
+    context "#external_account=" do
+      should "can have a token source set" do
+        a = Stripe::Account.new("test_account")
+        a.external_account = "tok_123"
+        assert_equal "tok_123", a.external_account
+      end
+
+      should "set a flag if given an object source" do
+        a = Stripe::Account.new("test_account")
+        a.external_account = {
+          :object => 'card'
+        }
+        assert_equal true, a.external_account.save_with_parent
+      end
+    end
+
+    context "#bank_account=" do
+      should "can have a token source set" do
+        old_stderr = $stderr
+        $stderr = StringIO.new
+        begin
+          a = Stripe::Account.new("test_account")
+          a.bank_account = "tok_123"
+          assert_equal "tok_123", a.bank_account
+        ensure
+          $stderr = old_stderr
+        end
+      end
+
+      should "set a flag if given an object source" do
+        old_stderr = $stderr
+        $stderr = StringIO.new
+        begin
+          a = Stripe::Account.new("test_account")
+          a.bank_account = {
+            :object => 'bank_account'
+          }
+          assert_equal true, a.bank_account.save_with_parent
+        ensure
+          $stderr = old_stderr
+        end
+      end
+
+      should "warn that #bank_account= is deprecated" do
+        old_stderr = $stderr
+        $stderr = StringIO.new
+        begin
+          a = Stripe::Account.new("test_account")
+          a.bank_account = "tok_123"
+          message = "NOTE: Stripe::Account#bank_account= is " +
+            "deprecated; use #external_account= instead"
+          assert_match Regexp.new(message), $stderr.string
+        ensure
+          $stderr = old_stderr
+        end
+      end
+    end
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: stripe
 version: !ruby/object:Gem::Version
-  version: 1.51.0
+  version: 1.51.1
 platform: ruby
 authors:
 - Stripe
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-08-26 00:00:00.000000000 Z
+date: 2016-08-30 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rest-client