stripe-ruby-mock 2.5.2 → 2.5.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 87b7b9bf58b67006fc280c125219f07faea77268
-  data.tar.gz: aa24705b3dcf69d0aacdac60f53e7e66a218939a
+  metadata.gz: 0e81f8b287a3ea9c2c80e4376f24a61e93dc7c0e
+  data.tar.gz: b8da1c4bfe60eacb520828cf2ea86341bff536ac
 SHA512:
-  metadata.gz: 84ed5f9ecccbff291acb4aa5b3ce65470867c2fbf876cf336001cac17893429f5ba97f4b7d2bf16c27d56036094f9a0cf60dabc8d048ea80f06be9bedf19a187
-  data.tar.gz: 26babda5f4790e6495339cab1ae83fb999b22073f6edb435baa4d4d7ae965db33744cc1f8946f33213ec4c085e8113d7f191ddae33906a9f5b41113fb2a977be
+  metadata.gz: 5a8fc8faa377c537d8c67893b1d71b65ed21e241827e4a391ca73fbc46333a66e6fb7bfb011e9f83a47d7019f6a75bdc738c04e42dc7e78a5b3ef7d1d46349e2
+  data.tar.gz: 028228088b4f8848c7fadae70fdcaf10a939975e08cad0b2efb45547f172ad0e79c7b79a7ff8d56687d41fba09311812c1240a9dffdebb6d0073e1a09872ff72

data/README.md

@@ -12,7 +12,7 @@ This gem has unexpectedly grown in popularity and I've gotten pretty busy, so I'
 
 In your gemfile:
 
-    gem 'stripe-ruby-mock', '~> 2.5.2', :require => 'stripe_mock'
+    gem 'stripe-ruby-mock', '~> 2.5.3', :require => 'stripe_mock'
 
 ## Features
 

data/lib/stripe_mock/api/client.rb

@@ -8,7 +8,7 @@ module StripeMock
     return false if @state == 'live'
     return @client unless @client.nil?
 
-    alias_stripe_method :execute_request, StripeMock.method(:redirect_to_mock_server)
+    Stripe::StripeClient.send(:define_method, :execute_request) { |*args| StripeMock.redirect_to_mock_server(*args) }
     @client = StripeMock::Client.new(port)
     @state = 'remote'
     @client
@@ -18,7 +18,7 @@ module StripeMock
     return false unless @state == 'remote'
     @state = 'ready'
 
-    alias_stripe_method :request, @original_request_method
+    restore_stripe_execute_request_method
     @client.clear_server_data if opts[:clear_server_data] == true
     @client.cleanup
     @client = nil

data/lib/stripe_mock/api/instance.rb

@@ -2,18 +2,18 @@ module StripeMock
 
   @state = 'ready'
   @instance = nil
-  @original_request_method = Stripe::StripeClient.active_client.method(:execute_request)
+  @original_execute_request_method = Stripe::StripeClient.instance_method(:execute_request)
 
   def self.start
     return false if @state == 'live'
-    @instance = Instance.new
-    alias_stripe_method :execute_request, @instance.method(:mock_request)
+    @instance = instance = Instance.new
+    Stripe::StripeClient.send(:define_method, :execute_request) { |*args| instance.mock_request(*args) }
     @state = 'local'
   end
 
   def self.stop
     return unless @state == 'local'
-    alias_stripe_method :execute_request, @original_request_method
+    restore_stripe_execute_request_method
     @instance = nil
     @state = 'ready'
   end
@@ -28,8 +28,8 @@ module StripeMock
     end
   end
 
-  def self.alias_stripe_method(new_name, method_object)
-    Stripe::StripeClient.active_client.define_singleton_method(new_name) {|*args| method_object.call(*args) }
+  def self.restore_stripe_execute_request_method
+    Stripe::StripeClient.send(:define_method, :execute_request, @original_execute_request_method)
   end
 
   def self.instance; @instance; end

data/lib/stripe_mock/request_handlers/charges.rb

@@ -160,7 +160,7 @@ module StripeMock
       end
 
       def allowed_params(params)
-        allowed = [:description, :metadata, :receipt_email, :fraud_details, :shipping]
+        allowed = [:description, :metadata, :receipt_email, :fraud_details, :shipping, :destination]
 
         # This is a workaround for the way the Stripe API sends params even when they aren't modified.
         # Stipe will include those params even when they aren't modified.

data/lib/stripe_mock/version.rb

@@ -1,4 +1,4 @@
 module StripeMock
   # stripe-ruby-mock version
-  VERSION = "2.5.2"
+  VERSION = "2.5.3"
 end

data/spec/shared_stripe_examples/charge_examples.rb

@@ -257,6 +257,23 @@ shared_examples 'Charge API' do
     expect(updated.fraud_details.to_hash).to eq(charge.fraud_details.to_hash)
   end
 
+  it "updates a stripe charge with no changes" do
+    original = Stripe::Charge.create({
+      amount: 777,
+      currency: 'USD',
+      source: stripe_helper.generate_card_token,
+      description: 'Original description',
+      destination: {
+        account: "acct_SOMEBOGUSID",
+        amount: 150
+      }
+    })
+
+    expect {
+      updated = original.save
+    }.not_to raise_error
+  end
+
   it "marks a charge as safe" do
     original = Stripe::Charge.create({
       amount: 777,

data/spec/stripe_mock_spec.rb

@@ -8,6 +8,12 @@ describe StripeMock do
     StripeMock.stop
   end
 
+  it "overrides stripe's execute_request method in other threads" do
+    StripeMock.start
+    Thread.new { Stripe::StripeClient.active_client.execute_request(:xtest, '/', api_key: 'abcde') }.join # no error
+    StripeMock.stop
+  end
+
   it "reverts overriding stripe's request method" do
     StripeMock.start
     Stripe::StripeClient.active_client.execute_request(:xtest, '/', api_key: 'abcde') # no error
@@ -15,6 +21,13 @@ describe StripeMock do
     expect { Stripe::StripeClient.active_client.execute_request(:x, '/', api_key: 'abcde') }.to raise_error ArgumentError
   end
 
+  it "reverts overriding stripe's execute_request method in other threads" do
+    StripeMock.start
+    Thread.new { Stripe::StripeClient.active_client.execute_request(:xtest, '/', api_key: 'abcde') }.join # no error
+    StripeMock.stop
+    expect { Thread.new { Stripe::StripeClient.active_client.execute_request(:x, '/', api_key: 'abcde') }.join }.to raise_error ArgumentError
+  end
+
   it "does not persist data between mock sessions" do
     StripeMock.start
     StripeMock.instance.customers[:x] = 9

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: stripe-ruby-mock
 version: !ruby/object:Gem::Version
-  version: 2.5.2
+  version: 2.5.3
 platform: ruby
 authors:
 - Gilbert
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-02-12 00:00:00.000000000 Z
+date: 2018-02-22 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: stripe