stripe-rails 1.1.0 → 1.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: ac50cc61a92527aeb62ea99d1c288dd9057e2796
-  data.tar.gz: a499347e24515c8d7ccddc7b961e62abf633e9a6
+  metadata.gz: 03a407b7ba74c65f266f9443496bc69251355f84
+  data.tar.gz: 5af8f232370df1d3547932002028600954e18666
 SHA512:
-  metadata.gz: 077e01fe7390da6d0c3facab63783dc89d71fe9d91ba14bddc7b6b765855379d832857d2b17630898d9d9cd5be618cac8ce676cddd99e29e5a1d761846118c62
-  data.tar.gz: 3a506cbec7767db9a96b5bf4b7c30b81dcc9f833d0904f049afee2b9aae64082e1da346a8902379e884869b473d18ca639506121cac1e10afbb4e0c3f79da50e
+  metadata.gz: 4600d4ae6231a38189c80504f86acbb08672aaf36ac29df556eefa4f1e255627b5d23109c05c974b7ea2ef7c89587e77a175599650ff472b8d44c1bb36075f94
+  data.tar.gz: ae40a99a4a73dfebba3a76292a734fcf6928ac11dd61d7607b35838fbb4314a0e11a3247f802708d69030fa74b168dd48fe7934d4ad2344ac17410c6349e8315

data/.travis.yml

@@ -1,32 +1,33 @@
 language: ruby
 rvm:
-  - 2.4.1
-  - 2.3.4
-  - 2.2.7
-  - 2.1.9
+- 2.4.1
+- 2.3.4
+- 2.2.7
+- 2.1.9
 env:
   global:
-    - GIT_COMMITTED_AT=$(if [ "$TRAVIS_PULL_REQUEST" == "false" ]; then git log -1 --pretty=format:%ct; else git log -1 --skip 1 --pretty=format:%ct; fi)
+  - GIT_COMMITTED_AT=$(if [ "$TRAVIS_PULL_REQUEST" == "false" ]; then git log -1 --pretty=format:%ct;
+    else git log -1 --skip 1 --pretty=format:%ct; fi)
 before_script:
-  - curl -L https://codeclimate.com/downloads/test-reporter/test-reporter-latest-linux-amd64 > ./cc-test-reporter
-  - chmod +x ./cc-test-reporter
-  - ./cc-test-reporter before-build
+- curl -L https://codeclimate.com/downloads/test-reporter/test-reporter-latest-linux-amd64
+  > ./cc-test-reporter
+- chmod +x ./cc-test-reporter
+- "./cc-test-reporter before-build"
 script:
-  - bundle exec rake
-  # Preferably you will run test-reporter on branch update events. But 
-  # if you setup travis to build PR updates only, you don't need to run 
-  # the line below
-  - if [ "$TRAVIS_PULL_REQUEST" == "false" ] && [ `basename $BUNDLE_GEMFILE` == "Gemfile" ]  && [ ${RUBY_VERSION:5:3} == "2.4" ] ; then echo "Sending Coverage..."; ./cc-test-reporter after-build --exit-code $TRAVIS_TEST_RESULT; fi
-  # In the case where travis is setup to build PR updates only, 
-  # uncomment the line below
-  # - ./cc-test-reporter after-build --exit-code $TRAVIS_TEST_RESULT
+- bundle exec rake
+- if [ "$TRAVIS_PULL_REQUEST" == "false" ] && [ `basename $BUNDLE_GEMFILE` == "Gemfile"
+  ]  && [ ${RUBY_VERSION:5:3} == "2.4" ] ; then echo "Sending Coverage..."; ./cc-test-reporter
+  after-build --exit-code $TRAVIS_TEST_RESULT; fi
 gemfile:
-  - Gemfile
-  - gemfiles/rails4.gemfile
-  - gemfiles/rails5.gemfile
+- Gemfile
+- gemfiles/rails4.gemfile
+- gemfiles/rails5.gemfile
 matrix:
   exclude:
-    - rvm: 2.1.9
-      gemfile: Gemfile
-    - rvm: 2.1.9
-      gemfile: gemfiles/rails5.gemfile
+  - rvm: 2.1.9
+    gemfile: Gemfile
+  - rvm: 2.1.9
+    gemfile: gemfiles/rails5.gemfile
+notifications:
+  slack:
+    secure: csciM073msTrOOdVYVXdAsrx2sR3Y1BKL0VvlSsYxBJawDa8BFNl6Fw8Uz1V2n4OfnkMvMCME4I3EXsCb4Kl5omnK+7ibeCzzzkCR5VwUs5/vLY7awUfCiihSCqg5ULAp2T1whQJUl5HY9Ot62sujIUX/FUhPzdbCqaKQ7cVkUo=

data/Changelog.md

@@ -1,3 +1,7 @@
+## 1.1.1 (2017-08-31)
+
+* Make stripe-ruby-mock an optional dependency (thanks @gaffneyc)
+
 ## 1.1.0 (2017-08-29)
 
 * Adds a testing module for testing callbacks (thanks @Pyo25)

data/Gemfile

@@ -8,10 +8,12 @@ gem "rake"
 gem 'tzinfo'
 gem 'mocha'
 gem 'pry'
-gem 'responders', '~> 2.0' # to support Rails 4.2
 
 group :test do
   gem 'simplecov', require: false
+  # NOTE: tracking master temporarily until they
+  # release https://github.com/rebelidealist/stripe-ruby-mock/pull/433
+  gem 'stripe-ruby-mock', github: 'rebelidealist/stripe-ruby-mock'
   gem 'poltergeist' # required for system tests
   gem 'phantomjs'   # ditto
   gem 'puma'        # ditto

data/README.md

@@ -360,11 +360,12 @@ See the [complete listing of all stripe events][5], and the [webhook tutorial][6
 
 ## Unit testing
 
-If you want to test your callbacks, you can use the `Stripe::Testing` module to send mocked Stripe events.
+If you want to test your callbacks, you can use the `Stripe::Rails::Testing` module to send mocked Stripe events.
 
 ```ruby
+require 'stripe/rails/testing'
 test "my callback handles new subscription" do
-  Stripe::Testing.send_event "customer.subscription.created"
+  Stripe::Rails::Testing.send_event "customer.subscription.created"
   # Assertions
 end
 ```
@@ -372,8 +373,9 @@ end
 You can also overwrite some event properties: ([More info](https://github.com/rebelidealist/stripe-ruby-mock#customizing-webhooks))
 
 ```ruby
+require 'stripe/rails/testing'
 test "my callback handles new subscription" do
-  Stripe::Testing.send_event "customer.subscription.created", {
+  Stripe::Rails::Testing.send_event "customer.subscription.created", {
     :email => "john@doe.com",
     :account_balance => 40
   }

data/lib/stripe/rails/testing.rb

@@ -0,0 +1,19 @@
+begin
+  require 'stripe_mock'
+rescue LoadError
+  warn %q{Please add "gem 'stripe-ruby-mock', group: 'test'"" to the Gemfile to use Stripe::Rails::Testing"}
+  exit
+end
+require 'stripe/callbacks'
+
+module Stripe
+  module Rails
+    module Testing
+      def self.send_event(event, properties = {})
+        evt = StripeMock.mock_webhook_event(event, properties)
+        target = evt.data.object
+        ::Stripe::Callbacks.run_callbacks(evt, target)
+      end
+    end
+  end
+end

data/lib/stripe/rails/version.rb

@@ -1,5 +1,5 @@
 module Stripe
   module Rails
-    VERSION = '1.1.0'
+    VERSION = '1.1.1'
   end
 end

data/lib/stripe/rails.rb

@@ -4,5 +4,4 @@ require 'stripe/engine'
 require 'stripe/configuration_builder'
 require 'stripe/plans'
 require 'stripe/coupons'
-require 'stripe/callbacks'
-require 'stripe/testing'
+require 'stripe/callbacks'

data/stripe-rails.gemspec

@@ -17,5 +17,4 @@ Gem::Specification.new do |gem|
   gem.add_dependency 'rails', '>= 3'
   gem.add_dependency 'stripe'
   gem.add_dependency 'responders'
-  gem.add_dependency 'stripe-ruby-mock', '~> 2.4'
 end

data/test/stripe_initializers_spec.rb

@@ -60,4 +60,13 @@ describe "Configuring the stripe engine" do
       Dummy.const_defined?(:ModuleWithCallbacks).must_equal true
     end
   end
+
+  describe 'setting stripe.api_key' do
+    subject { app.config.stripe.api_key = 'XYZ' }
+    let(:warning_msg) { "[DEPRECATION] to align with stripe nomenclature, stripe.api_key has been renamed to config.stripe.secret_key\n" }
+
+    it 'should output a warning' do
+      -> { subject }.must_output '', warning_msg
+    end
+  end
 end

data/test/testing_spec.rb

@@ -1,4 +1,5 @@
 require 'spec_helper'
+require 'stripe/rails/testing'
 
 describe "Testing" do
   let(:observer)  { Class.new }
@@ -20,7 +21,7 @@ describe "Testing" do
   end
 
   describe '.send_event' do
-    subject { Stripe::Testing.send_event event_name }
+    subject { Stripe::Rails::Testing.send_event event_name }
 
     describe 'when forwarding the event to the callback' do
       let(:event_name) { "invoice.payment_succeeded" }
@@ -42,7 +43,7 @@ describe "Testing" do
     end
 
     describe 'when overwriting event properties' do
-      subject { Stripe::Testing.send_event event_name, params }
+      subject { Stripe::Rails::Testing.send_event event_name, params }
       let(:event_name) { "invoice.payment_succeeded" }
       let(:params)     { { subtotal: 500, total: 1000, currency: "eur" } }
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: stripe-rails
 version: !ruby/object:Gem::Version
-  version: 1.1.0
+  version: 1.1.1
 platform: ruby
 authors:
 - Charles Lowell
@@ -10,7 +10,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-08-29 00:00:00.000000000 Z
+date: 2017-08-31 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
@@ -54,20 +54,6 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
-- !ruby/object:Gem::Dependency
-  name: stripe-ruby-mock
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '2.4'
-  type: :runtime
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '2.4'
 description: A gem to integrate stripe into your rails app
 email:
 - sengming@sanemen.com
@@ -107,8 +93,8 @@ files:
 - lib/stripe/plans.rb
 - lib/stripe/rails.rb
 - lib/stripe/rails/tasks.rake
+- lib/stripe/rails/testing.rb
 - lib/stripe/rails/version.rb
-- lib/stripe/testing.rb
 - stripe-rails.gemspec
 - test/all.rb
 - test/callbacks_spec.rb

data/lib/stripe/testing.rb

@@ -1,12 +0,0 @@
-require 'stripe_mock'
-require 'stripe/callbacks'
-
-module Stripe
-  module Testing
-    def self.send_event(event, properties = {})
-      evt = StripeMock.mock_webhook_event(event, properties)
-      target = evt.data.object
-      ::Stripe::Callbacks.run_callbacks(evt, target)
-    end
-  end
-end