string_bits 0.3.0 → 0.4.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: c21407d901f599aa0d33fe0bad85d39f4729da08c656cab3556fc087198394f2
-  data.tar.gz: e4c8912125bfd9f4a6fcfce0be0d78f528f0bb87369064cfc1c96b4d3f5b7ac9
+  metadata.gz: 94ef1efad2a1a13cfe6e2ece151103c4140e92fb1e320e21f5e174c2e1a2aabf
+  data.tar.gz: d787e35927e1a5dd4b1c056cfaf59f8cb4cb2df0e7d0f3018fe19f9a56d9a218
 SHA512:
-  metadata.gz: 8d73669323a7e9cee148d96775e8d9269b2c3c990906ad62e03d20466f93f3f2b7cafb911778fed607f7bdc561eaae57ac35770910de97f893addceb68e122bb
-  data.tar.gz: 359fd91c4eb04d4338850de1e38e2162c0d308a2697f86d2ef8ddbf200656384f62e81aa5eabac2c44c5afc79bde0383bc5b672a4a16ad50ab44fa0bcb195323
+  metadata.gz: f0d3bc9a11235cdc5b2c01bec186d265fc90c3f3c56eb0a0a97a56e72caf6fd2732be049bbd5bb834b8984c1e257e355c2f16edee046c7962f9a24bad0957013
+  data.tar.gz: 7fbb721347b9a32365de4b280e9ff6776a94314d64738694a470b818c8c327a22ee48d111db7b25c39ab720d32f50276f31afac5788122133b27498f34f6da14

data/README.md

@@ -6,7 +6,7 @@ The methods are designed for real workloads: Apache Arrow validity bitmaps, bitm
 
 Every method reads the receiver as a raw byte sequence, so the `String`s that `bit_slice` and the non-destructive `bitwise_*` methods return are always `Encoding::BINARY`. The destructive methods leave the receiver's encoding untouched, as `String#setbyte` does.
 
-A single keyword, `lsb_first:`, controls bit ordering across the API: it selects intra-byte numbering wherever positions are exchanged with the caller, and intra-byte scan direction wherever the API walks the sequence. Across-byte order is always `byte[0]` first, and result Strings from `bit_slice` are always packed LSB-first regardless, so `data.each_bit_offset(true, lsb_first: false).all? { |n| data.bit_set?(n, lsb_first: false) }` stays true.
+A single keyword, `lsb_first:`, controls bit ordering across the API: it selects intra-byte numbering wherever positions are exchanged with the caller, and intra-byte scan direction wherever the API walks the sequence. Across-byte order is always `byte[0]` first, and result Strings from `bit_slice` are always packed LSB-first regardless, so `data.each_bit_offset(1, lsb_first: false).all? { |n| data.bit_set?(n, lsb_first: false) }` stays true.
 
 ## Usage
 
@@ -22,5 +22,5 @@ puts "\xAA\xAA\xAA\xAA".bit_set?(10)
 #=> false
 
 puts "\xAA".each_bit(lsb_first: false).to_a.inspect
-#=> [true, false, true, false, true, false, true, false]
+#=> [1, 0, 1, 0, 1, 0, 1, 0]
 ```

data/ext/string_bits/string_bits.c

@@ -762,7 +762,7 @@ emit_bits(const unsigned char *str, ssize_t len, int lsb_first, ssize_t start_of
             unsigned char b = str[i];
             int j_start = (i == byte_start) ? bit_start : 0;
             for (int j = j_start; j < 8; j++) {
-                SB_EMIT((b >> j) & 1 ? Qtrue : Qfalse);
+                SB_EMIT(INT2FIX((b >> j) & 1));
             }
         }
     } else {
@@ -770,7 +770,7 @@ emit_bits(const unsigned char *str, ssize_t len, int lsb_first, ssize_t start_of
             unsigned char b = str[i];
             int j_end = (i == byte_start) ? (7 - bit_start) : 7;
             for (int j = j_end; j >= 0; j--) {
-                SB_EMIT((b >> j) & 1 ? Qtrue : Qfalse);
+                SB_EMIT(INT2FIX((b >> j) & 1));
             }
         }
     }
@@ -819,7 +819,7 @@ rb_str_bits(int argc, VALUE *argv, VALUE self)
 
 /* iterate bit positions matching `bit` ------------------------------------ */
 
-/* parse the required `bit` argument (true/false/1/0) to 0 or 1 */
+/* parse the required `bit` argument (0/1/true/false) to 0 or 1 */
 static int
 parse_bit_target(VALUE bit_val)
 {
@@ -1409,8 +1409,9 @@ SB_DEFINE_BINARY_METHODS(xor, kern_xor)
 /*
  * NOTE: each_bit_field and bit_fields are implemented here and fully tested,
  * but are NOT part of the current core proposal (see FUTURE_PROPOSAL_PLAN.md).
- * They are deferred because yielding Integer field values is a qualitatively
- * different contract from the rest of the API, and that difference is expected
+ * They are deferred because yielding multi-bit field values decoded from a
+ * packed layout is a qualitatively different contract from the single-bit
+ * 1/0 values the rest of the API exchanges, and that difference is expected
  * to extend core-ruby-dev discussion. The code is kept so the proposal can be
  * extended later without re-implementation.
  */
@@ -1713,7 +1714,7 @@ emit_bit_runs(VALUE self, int lsb_first, ssize_t start_offset, VALUE ary)
             const unsigned char *src = (const unsigned char *)RSTRING_PTR(self);
             int bit = (src[offset >> 3] >> (offset & 7)) & 1;
             ssize_t run = count_run_lsb(src, src_len, offset, bit);
-            SB_EMIT_TRIPLE(bit ? Qtrue : Qfalse, SSIZET2NUM(offset), SSIZET2NUM(run));
+            SB_EMIT_TRIPLE(INT2FIX(bit), SSIZET2NUM(offset), SSIZET2NUM(run));
             offset += run;
         }
     }
@@ -1725,7 +1726,7 @@ emit_bit_runs(VALUE self, int lsb_first, ssize_t start_offset, VALUE ary)
             while (offset + run < total_bits && logical_get_bit(src, offset + run, 0) == bit) {
                 run++;
             }
-            SB_EMIT_TRIPLE(bit ? Qtrue : Qfalse, SSIZET2NUM(offset), SSIZET2NUM(run));
+            SB_EMIT_TRIPLE(INT2FIX(bit), SSIZET2NUM(offset), SSIZET2NUM(run));
             offset += run;
         }
     }

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: string_bits
 version: !ruby/object:Gem::Version
-  version: 0.3.0
+  version: 0.4.0
 platform: ruby
 authors:
 - HASUMI Hitoshi