stricter-string-to-date 1.0.0

data/.gitignore

@@ -0,0 +1,17 @@
+*.gem
+*.rbc
+.bundle
+.config
+.yardoc
+Gemfile.lock
+InstalledFiles
+_yardoc
+coverage
+doc/
+lib/bundler/man
+pkg
+rdoc
+spec/reports
+test/tmp
+test/version_tmp
+tmp

data/Gemfile

@@ -0,0 +1,4 @@
+source 'https://rubygems.org'
+
+# Specify your gem's dependencies in stricter-string-to-date.gemspec
+gemspec

data/LICENSE.txt

@@ -0,0 +1,22 @@
+Copyright (c) 2013 Jeff Dean
+
+MIT License
+
+Permission is hereby granted, free of charge, to any person obtaining
+a copy of this software and associated documentation files (the
+"Software"), to deal in the Software without restriction, including
+without limitation the rights to use, copy, modify, merge, publish,
+distribute, sublicense, and/or sell copies of the Software, and to
+permit persons to whom the Software is furnished to do so, subject to
+the following conditions:
+
+The above copyright notice and this permission notice shall be
+included in all copies or substantial portions of the Software.
+
+THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
+EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
+MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
+NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE
+LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION
+OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION
+WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.

data/README.md

@@ -0,0 +1,34 @@
+# Stricter::String::To::Date
+
+ActiveSupport 4.0 changed `String#to_date` to raise a more descriptive error for invalid dates.
+
+It also makes date parsing more liberal than ActiveSupport 3.x.
+
+```ruby
+# ActiveSupport 3.x
+"asdf".to_date # => NoMethodError: undefined method `div' for nil:NilClass
+"333".to_date # => NoMethodError: undefined method `div' for nil:NilClass
+
+# ActiveSupport 4.x
+"asdf".to_date # => ArgumentError: invalid date
+"333".to_date # => Fri, 29 Nov 2013
+```
+
+You can install this gem if you:
+
+ * Rely on the old 3.x behavior and want to upgrade to ActiveSupport 4.x without dealing with it yet
+ * Are on 3.x and want to see deprecation warnings about the changes that will come in 4.x
+
+## Installation
+
+Add this line to your application's Gemfile:
+
+    gem 'stricter-string-to-date'
+
+And then execute:
+
+    $ bundle
+
+Or install it yourself as:
+
+    $ gem install stricter-string-to-date

data/Rakefile

@@ -0,0 +1 @@
+require "bundler/gem_tasks"

data/lib/stricter-string-to-date.rb

@@ -0,0 +1 @@
+require 'stricter_string_to_date'

data/lib/stricter_string_to_date.rb

@@ -0,0 +1,28 @@
+require 'active_support'
+require 'active_support/core_ext/date'
+require 'active_support/core_ext/string/conversions'
+require 'active_support/core_ext/object/blank'
+require 'active_support/deprecation'
+
+String.class_eval do
+  def to_date
+    unless blank?
+      begin
+        date_values = ::Date._parse(self, false).values_at(:year, :mon, :mday)
+        ::Date.new(*date_values)
+      rescue NoMethodError => e
+        if e.message == "undefined method `div' for nil:NilClass"
+          parsed_date = ::Date.parse(self, false) rescue nil
+          if parsed_date
+            message = %Q{"#{self}".to_date will become a valid date "#{parsed_date}"}
+            ActiveSupport::Deprecation.warn message
+          else
+            message = %Q{"NoMethodError: undefined method `div' for nil:NilClass" will raise "ArgumentError: Invalid Date" in "ActiveSupport: 4.0"}
+            ActiveSupport::Deprecation.warn message
+          end
+        end
+        raise e
+      end
+    end
+  end
+end

data/lib/stricter_string_to_date/version.rb

@@ -0,0 +1,3 @@
+module StricterStringToDate
+  VERSION = "1.0.0"
+end

data/spec/string_spec.rb

@@ -0,0 +1,32 @@
+require 'rspec'
+require_relative '../lib/stricter_string_to_date'
+
+describe String do
+
+  describe "#to_date" do
+
+    context "with a date that was invalid in ActiveSupport 3.2.13" do
+      it "should raise the same method that ActiveSupport 3.2.13" do
+        expect do
+          capture(:stderr) { "333".to_date }
+        end.to raise_error(NoMethodError, "undefined method `div' for nil:NilClass")
+      end
+    end
+
+    context "the date is valid in ActiveSupport 4.0" do
+      it "should render a deprecation warning about the date becoming valid" do
+        stderr_output = capture(:stderr) { expect { "333".to_date }.to raise_error }
+        stderr_output.should include(%Q{DEPRECATION WARNING: "333".to_date will become a valid date "#{Date.parse("333")}"})
+      end
+    end
+
+    context "the date is also invalid in ActiveSupport 4.0" do
+      it "should render a deprecation warning about the exception class change" do
+        stderr_output = capture(:stderr) { expect{ "asdf".to_date }.to raise_error }
+        stderr_output.should include(%Q{DEPRECATION WARNING: "NoMethodError: undefined method `div' for nil:NilClass" will raise "ArgumentError: Invalid Date" in "ActiveSupport: 4.0"})
+      end
+    end
+
+  end
+
+end

data/stricter-string-to-date.gemspec

@@ -0,0 +1,25 @@
+# coding: utf-8
+lib = File.expand_path('../lib', __FILE__)
+$LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
+require 'stricter_string_to_date/version'
+
+Gem::Specification.new do |spec|
+  spec.name          = "stricter-string-to-date"
+  spec.version       = StricterStringToDate::VERSION
+  spec.authors       = ["Jeff Dean"]
+  spec.email         = ["jeff@zilkey.com"]
+  spec.description   = %q{Restores ActiveSupport 3.x String#to_date functionality}
+  spec.summary       = %q{Restores ActiveSupport 3.x String#to_date functionality}
+  spec.homepage      = ""
+  spec.license       = "MIT"
+
+  spec.files         = `git ls-files`.split($/)
+  spec.executables   = spec.files.grep(%r{^bin/}) { |f| File.basename(f) }
+  spec.test_files    = spec.files.grep(%r{^(test|spec|features)/})
+  spec.require_paths = ["lib"]
+
+  spec.add_development_dependency "activesupport", "> 3.0"
+  spec.add_development_dependency "bundler", "~> 1.3"
+  spec.add_development_dependency "rake"
+  spec.add_development_dependency "rspec"
+end

metadata

@@ -0,0 +1,121 @@
+--- !ruby/object:Gem::Specification
+name: stricter-string-to-date
+version: !ruby/object:Gem::Version
+  version: 1.0.0
+  prerelease: 
+platform: ruby
+authors:
+- Jeff Dean
+autorequire: 
+bindir: bin
+cert_chain: []
+date: 2013-08-05 00:00:00.000000000 Z
+dependencies:
+- !ruby/object:Gem::Dependency
+  name: activesupport
+  requirement: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>'
+      - !ruby/object:Gem::Version
+        version: '3.0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>'
+      - !ruby/object:Gem::Version
+        version: '3.0'
+- !ruby/object:Gem::Dependency
+  name: bundler
+  requirement: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: '1.3'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: '1.3'
+- !ruby/object:Gem::Dependency
+  name: rake
+  requirement: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: rspec
+  requirement: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+description: Restores ActiveSupport 3.x String#to_date functionality
+email:
+- jeff@zilkey.com
+executables: []
+extensions: []
+extra_rdoc_files: []
+files:
+- .gitignore
+- Gemfile
+- LICENSE.txt
+- README.md
+- Rakefile
+- lib/stricter-string-to-date.rb
+- lib/stricter_string_to_date.rb
+- lib/stricter_string_to_date/version.rb
+- spec/string_spec.rb
+- stricter-string-to-date.gemspec
+homepage: ''
+licenses:
+- MIT
+post_install_message: 
+rdoc_options: []
+require_paths:
+- lib
+required_ruby_version: !ruby/object:Gem::Requirement
+  none: false
+  requirements:
+  - - ! '>='
+    - !ruby/object:Gem::Version
+      version: '0'
+required_rubygems_version: !ruby/object:Gem::Requirement
+  none: false
+  requirements:
+  - - ! '>='
+    - !ruby/object:Gem::Version
+      version: '0'
+requirements: []
+rubyforge_project: 
+rubygems_version: 1.8.24
+signing_key: 
+specification_version: 3
+summary: Restores ActiveSupport 3.x String#to_date functionality
+test_files:
+- spec/string_spec.rb