strict_ivars 1.0.0.rc3 → 1.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 937599360a03f578b3d440efc2d58eede817bc6ec71727f4ba74c1c0fb11dc0d
-  data.tar.gz: cb212c70dab8bcf3a9d163f80f864ddf81c8f0a0e3e2ae6781f2bcff37590b88
+  metadata.gz: dfeb3ee6871a0bbc8ba42d3b713697b66afc3158894189cc8f1aa52d78acdee2
+  data.tar.gz: db9a7c4610f9d2514d29ce3340326a9135b93a5106ad5389733e758c7adac828
 SHA512:
-  metadata.gz: 53fdba71a8e909d0afc5b797b1b4b7658a5ab956fab7946e1ead3e59be9298c5928a1b788c2be3781c46df3e2bb28505b5ca911357026aa0992c9f57a45e81e5
-  data.tar.gz: 86d26b307d4697843d10216e7c783a5db2207945ed3bb7a9e70959dd120e9652249dfef523b2803905728c1e4f4ed1de180a50c472f983068fbb38147367996a
+  metadata.gz: 731e53215db39bf6bcd9850eeb521fede63e2acad7b347f14702d921478a53adcc6635350ace7e646bd6f4dbd7416b0e38937dca70cea53624143150536924a3
+  data.tar.gz: b40c2da16f5179d9f15af2d39c3c506907dfc04116c66de6f1ffac9454f2fc8b52ec2a834c78fbd2a95ad1e8a36b8911e05e4b2a2270a4453bef0bcffa8b45b4

data/README.md

@@ -1,13 +1,19 @@
 # Strict Ivars
 
-Strict Ivars is a tiny pre-processor for Ruby that guards your instance variable reads, ensuring the instance variable is actually defined. This helps catch typos nice and early. It‘s especially good when used with [Literal](https://literal.fun) and [Phlex](https://www.phlex.fun), though it also works with ERB.
+If you reference an undefined method, constant or local varaible, Ruby will helpfully raise a `NameError`. But reference an undefined _instance_ variable and Ruby just returns `nil`. This can lead to all kinds of bugs — many of which can lay dormant for years before surprising you with an unexpected outage, data breach or data loss event.
+
+Strict Ivars solves this by making Ruby raise a `NameError` any time you read an undefined instance varaible. It’s enabled with two lines of code in your boot process, then it just works in the background and you’ll never have to think about it again. Strict Ivars has no known false-positives or false-negatives.
+
+It‘s especially good when used with [Literal](https://literal.fun) and [Phlex](https://www.phlex.fun), though it also works with regular Ruby objects and even ERB templates, which are actually pretty common spots for undefined instance variable reads to hide since that’s the main way of passing data to ERB.
+
+When combined with Literal, you can completely remove unexpected `nil`. Literal validates your inputs and Strict Ivars ensures you’re reading the right instance variables.
 
 > [!NOTE]  
 > JRuby and TruffleRuby are not currently supported.
 
 ## Setup
 
-Strict Ivars should be used in apps not libraries. Though you could use it in your library’s test suite.
+Strict Ivars should really be used in apps not libraries. Though you could definitely use it in your library’s test suite to help catch issues in the library code.
 
 Install the gem by adding it to your `Gemfile` and running `bundle install`. You’ll probably want to set it to `require: false` here because you should require it manually at precisely the right moment.
 

data/lib/strict_ivars/name_error.rb

@@ -0,0 +1,57 @@
+# frozen_string_literal: true
+
+class StrictIvars::NameError < ::NameError
+	INSTANCE_VARIABLE_METHOD = Kernel.instance_method(:instance_variables)
+
+	def initialize(object, name)
+		suggestion = INSTANCE_VARIABLE_METHOD.bind_call(object).max_by do |candidate|
+			n_common_trigrams(candidate, name) / Math.sqrt(candidate.length)
+		end
+
+		message = [
+			"Undefined instance variable `#{name}`.",
+			("Did you mean `#{suggestion}`?" if suggestion),
+		].join(" ")
+
+		super(message)
+	end
+
+	private def n_common_trigrams(left, right)
+		left = "\x03\x02#{left}"
+		right = "\x03\x02#{right}"
+
+		left_len = left.length
+		right_len = right.length
+
+		return 0 if left_len < 3 || right_len < 3
+
+		# Process shorter string first
+		if left_len > right_len
+			left, right = right, left
+			left_len, right_len = right_len, left_len
+		end
+
+		# Use a Set for lookup
+		trigrams = Set.new
+		count = 0
+
+		# Generate trigrams from shorter string
+		i = 0
+		left_max = left_len - 2
+		while i < left_max
+			trigram = left[i, 3]
+			trigrams.add(trigram)
+			i += 1
+		end
+
+		# Check trigrams from longer string
+		i = 0
+		right_max = right_len - 2
+		while i < right_max
+			count += 1 if trigrams.include?(right[i, 3])
+			i += 1
+		end
+
+		count
+	end
+end

data/lib/strict_ivars/processor.rb

@@ -65,7 +65,7 @@ class StrictIvars::Processor < StrictIvars::BaseProcessor
 
 			@annotations.push(
 				[location.start_character_offset, "(defined?(#{name}) ? "],
-				[location.end_character_offset, " : (::Kernel.raise(::StrictIvars::NameError.new('Undefined instance variable #{name}'))))"]
+				[location.end_character_offset, " : (::Kernel.raise(::StrictIvars::NameError.new(self, :#{name}))))"]
 			)
 		end
 

data/lib/strict_ivars/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module StrictIvars
-	VERSION = "1.0.0.rc3"
+	VERSION = "1.0.0"
 end

data/lib/strict_ivars.rb

@@ -4,16 +4,15 @@ require "set"
 require "prism"
 require "securerandom"
 
-require "require-hooks/setup"
-
 require "strict_ivars/version"
+require "strict_ivars/name_error"
 require "strict_ivars/base_processor"
 require "strict_ivars/processor"
 require "strict_ivars/configuration"
 
-module StrictIvars
-	NameError = Class.new(::NameError)
+require "require-hooks/setup"
 
+module StrictIvars
 	EMPTY_ARRAY = [].freeze
 	EVERYTHING = ["**/*"].freeze
 	METHOD_METHOD = Module.instance_method(:method)

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: strict_ivars
 version: !ruby/object:Gem::Version
-  version: 1.0.0.rc3
+  version: 1.0.0
 platform: ruby
 authors:
 - Joel Drapper
@@ -37,7 +37,8 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
-description: Raise an exception when using undefined instance variables.
+description: Strict Ivars is a tiny pre-processor that guards you against undefined
+  instance variable reads.
 email:
 - joel@drapper.me
 executables: []
@@ -49,14 +50,15 @@ files:
 - lib/strict_ivars.rb
 - lib/strict_ivars/base_processor.rb
 - lib/strict_ivars/configuration.rb
+- lib/strict_ivars/name_error.rb
 - lib/strict_ivars/processor.rb
 - lib/strict_ivars/version.rb
-homepage: https://github.com/joeldrapper/strict_ivars
+homepage: https://github.com/yippee-fun/strict_ivars
 licenses:
 - MIT
 metadata:
-  homepage_uri: https://github.com/joeldrapper/strict_ivars
-  source_code_uri: https://github.com/joeldrapper/strict_ivars
+  homepage_uri: https://github.com/yippee-fun/strict_ivars
+  source_code_uri: https://github.com/yippee-fun/strict_ivars
   funding_uri: https://github.com/sponsors/joeldrapper
   rubygems_mfa_required: 'true'
 rdoc_options: []
@@ -75,5 +77,5 @@ required_rubygems_version: !ruby/object:Gem::Requirement
 requirements: []
 rubygems_version: 3.6.7
 specification_version: 4
-summary: Raise an exception when using undefined instance variables.
+summary: Make Ruby raise a NameError if you read an undefined instance variable.
 test_files: []