strict_associations 0.1.7 → 0.1.8

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: fbe650347474030e15a049132a0e002e1a0dd421fd747d6b0a4c6cc2e8efce91
-  data.tar.gz: 31ba848896030b174536c90bca7f4970a24272958bb8f15b7d85c03897ad0da7
+  metadata.gz: c92d1223136a5265b920421b6905b4973aab91b4e6556d66e8a3d37fd07aba8b
+  data.tar.gz: d11fb79bd366064f7d3179bb20b2255da37a531db99e8fc0173e74b841a873d9
 SHA512:
-  metadata.gz: d290a381bce9063d13f5f6134145b4d05883681a28e3ac4b9fc44415846e7e0561ecdfdbe48572febfb8341f764c96ce1b68fe61ac2ee3715257c4d0e044ce21
-  data.tar.gz: 4d872852b7716e934d3271af605f6264714601d262f0c1bdc7841310e4a1251c0acaffc82f4fa4610e552a5348bc4c5f317b07cd8eb55149f8b90609049219b7
+  metadata.gz: 8ca2c4f5da3309031d53bee33e67d4f0bb42ddc7f676f7f307d1fa1075559bcb117ad5928478ff5b6488d7947a54c061687ca5a2f34cfc848befbe4236bd6d20
+  data.tar.gz: e21378c926f911085b51d4fb5e0ab3b08db8ba12dbd1d9e5d3e6fa8abc8eb4f56e0431026cd9f1e16f05dfdb357279b156a3c5eca3e3734f1f5e01ab52780ec3

data/CHANGELOG.md

@@ -2,6 +2,6 @@
 
 
 
-## [0.1.7] - Unreleased
+## [0.1.8] - Unreleased
 
-## [0.1.6] - Unreleased
+## [0.1.7] - Unreleased

data/lib/strict_associations/validator.rb

@@ -247,6 +247,13 @@ module StrictAssociations
       (fk_columns - defined_fk_columns).each do |column|
         assoc_name = column.delete_suffix("_id").to_sym
         next if model.strict_association_skipped?(assoc_name)
+        # For third-party models, skip if any model already has a
+        # has_many/has_one pointing to this table with this FK.
+        # The dev can't add belongs_to to third-party code, but
+        # they CAN define has_many on their own model.
+        if is_third_party
+          next if has_many_covers_fk?(model, column)
+        end
 
         msg = if is_third_party
           <<~MSG.squish
@@ -298,6 +305,27 @@ module StrictAssociations
         .map(&:column)
     end
 
+    # Checks if any loaded model has a has_many/has_one pointing
+    # to the given model's table with the given FK column.
+    def has_many_covers_fk?(model, fk_column)
+      table = model.table_name
+      all_models.any? do |other|
+        other.reflect_on_all_associations.any? do |ref|
+          next unless %i[has_many has_one].include?(ref.macro)
+          next if ref.is_a?(
+            ActiveRecord::Reflection::ThroughReflection
+          )
+
+          begin
+            ref.klass.table_name == table &&
+              ref.foreign_key.to_s == fk_column
+          rescue NameError
+            false
+          end
+        end
+      end
+    end
+
     def resolve_target(reflection)
       reflection.klass
     rescue NameError

data/lib/strict_associations/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module StrictAssociations
-  VERSION = "0.1.7"
+  VERSION = "0.1.8"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: strict_associations
 version: !ruby/object:Gem::Version
-  version: 0.1.7
+  version: 0.1.8
 platform: ruby
 authors:
 - Jeff Lange