strict_associations 0.1.5 → 0.1.6

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: d3f819414a8d4be6870c5852a87d82ea0aa73c7f0fed2f1495a04c82b2af73c4
-  data.tar.gz: a6033ed16295800065be0325cddae7ecfa5c6d231f4c04242e3c25eec45a7345
+  metadata.gz: d3840cb8da5c485000f4837ba8eb88d348ed314157e726746334a25ba902c9eb
+  data.tar.gz: abe99225f8efdeb73b5425d1e6ae161e7c441fd556d36e08849e6da8d2fa36d2
 SHA512:
-  metadata.gz: 16b986565c7ab65b619b9c2ee2ef764ebffa4462d054d1ff692bd10138791466f502c59386a168ef4a5d4647fcdd4a6a02f1619ce21927822303ed566e1b0939
-  data.tar.gz: b9a04a6e00b0b0c07d3cf1a5f62e855bbb7c04b820357e506c38ebf857ccfa242251556f63e39172501932b25446b028678947f8ff7b34d74ef1603c27fb4732
+  metadata.gz: d8773b7689493980c772e795e5d4c601abd268e715baa74db4b83c9e88fd80e4a3c9dbd603fc8b0573125d491a391a5fac3cef6a9cab01106656b1952ff2dd3b
+  data.tar.gz: 249247cb1a40bf234d2aeb77ba209e732390b6bbaf861543b986e01b192d8d9083a991f1ad0d100fee6038db638620447ec62f1c4e871967d1576c0cee66c912

data/CHANGELOG.md

@@ -2,6 +2,6 @@
 
 
 
-## [0.1.5] - Unreleased
+## [0.1.6] - Unreleased
 
-## [0.1.4] - Unreleased
+## [0.1.5] - Unreleased

data/lib/strict_associations/validator.rb

@@ -238,9 +238,9 @@ module StrictAssociations
     end
 
     def check_orphaned_foreign_keys(model, violations)
-      return if third_party?(model)
       return unless owns_table?(model)
 
+      is_third_party = third_party?(model)
       indexed_fk_columns = indexed_foreign_key_columns(model)
       defined_fk_columns = sti_family_foreign_keys(model)
 
@@ -248,17 +248,29 @@ module StrictAssociations
         assoc_name = column.delete_suffix("_id").to_sym
         next if model.strict_association_skipped?(assoc_name)
 
-        violations << Violation.new(
-          model:,
-          association_name: assoc_name,
-          rule: :orphaned_foreign_key,
-          message: <<~MSG.squish
-            #{model.table_name} has an indexed column #{column} but #{model} has no \
-            belongs_to association for it.
+        msg = if is_third_party
+          <<~MSG.squish
+            #{model} (third-party) has an indexed column #{column} \
+            with no corresponding belongs_to. If this FK references \
+            one of your models, define a has_many on your model \
+            pointing back. Or call skip_strict_association \
+            :#{assoc_name} on #{model}.
+          MSG
+        else
+          <<~MSG.squish
+            #{model.table_name} has an indexed column #{column} but \
+            #{model} has no belongs_to association for it.
             Define a belongs_to.
             Or remove the index.
             Or call skip_strict_association :#{assoc_name} on #{model}.
           MSG
+        end
+
+        violations << Violation.new(
+          model:,
+          association_name: assoc_name,
+          rule: :orphaned_foreign_key,
+          message: msg
         )
       end
     end

data/lib/strict_associations/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module StrictAssociations
-  VERSION = "0.1.5"
+  VERSION = "0.1.6"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: strict_associations
 version: !ruby/object:Gem::Version
-  version: 0.1.5
+  version: 0.1.6
 platform: ruby
 authors:
 - Jeff Lange