strict_associations 0.1.3 → 0.1.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: a41e36c429c6609f0bf28443610c799cb0d7ece5b2c72f31a3ba3f0dcabc1366
-  data.tar.gz: dbc1018a1d8c146aa8c4e2d49558b8731b90d77a56b6dbcf52a204161de6e3af
+  metadata.gz: d51dbc1b21c0c15b0df12958d5faae54b5ac9fd03b91b8bc81fab41d4b7440c9
+  data.tar.gz: 82affa137bf43762c2ca968ff22460d51697f3c70ddea71f4a5bdeba67a0c0ed
 SHA512:
-  metadata.gz: 5ce5abda2b0ed3dc7e7d397cc53d86f64706bb8b57ec953b51f9900a04262a86d169da1b70a4ee98d428d61a2160ea67f7f4ab4603dcfc2404fae601fb3a4d27
-  data.tar.gz: 32d7d39a71358d1ecee58bb6a9d737d94d8fd1c483daf1036981d1d58e742fc8501240a45ec19560eb56ed33fc94e1f847c72bfe83eecb845f5939463b0c34ce
+  metadata.gz: 54beee9276456e62f0b3dd35d2c1aa878897c26772e9bd64dab8119a9b42877e084762066723abc26750bdcea885480a2c23f00294dc57f6db46a30e8a13e2ae
+  data.tar.gz: a460cf7ba3bdee9581bcf62c5f776f483e47bcb5be23b5ebd9f1a4ae699e468c1b38433d1af1f25d57ef1682321c26837ab28ca3ef61339c1b4ba3402504880f

data/CHANGELOG.md

@@ -2,6 +2,6 @@
 
 
 
-## [0.1.3] - Unreleased
+## [0.1.4] - Unreleased
 
-## [0.1.2] - Unreleased
+## [0.1.3] - Unreleased

data/lib/strict_associations/validator.rb

@@ -29,10 +29,7 @@ module StrictAssociations
     def models_to_check
       candidates = explicit_models || all_models
       candidates.reject do |model|
-        model.abstract_class? ||
-          !safe_table_exists?(model) ||
-          view?(model) ||
-          third_party?(model)
+        model.abstract_class? || !safe_table_exists?(model) || view?(model)
       end
     end
 
@@ -47,11 +44,22 @@ module StrictAssociations
     end
 
     def view?(model)
-      model.connection.view_exists?(model.table_name)
+      conn = model.connection
+      table = model.table_name
+      conn.view_exists?(table) || materialized_view?(conn, table)
     rescue ActiveRecord::NoDatabaseError
       false
     end
 
+    def materialized_view?(conn, table_name)
+      return false unless conn.adapter_name == "PostgreSQL"
+
+      conn.select_value(
+        "SELECT 1 FROM pg_matviews WHERE matviewname = " \
+        "#{conn.quote(table_name)}"
+      ).present?
+    end
+
     def check_habtm(model, violations)
       return if config.habtm_allowed?
 
@@ -225,9 +233,7 @@ module StrictAssociations
       return unless owns_table?(model)
 
       indexed_fk_columns = indexed_foreign_key_columns(model)
-      defined_fk_columns = model
-        .reflect_on_all_associations(:belongs_to)
-        .map { |ref| ref.foreign_key.to_s }
+      defined_fk_columns = sti_family_foreign_keys(model)
 
       (indexed_fk_columns - defined_fk_columns).each do |column|
         assoc_name = column.delete_suffix("_id").to_sym
@@ -248,6 +254,22 @@ module StrictAssociations
       end
     end
 
+    # Collects belongs_to foreign keys from the model and all STI descendants sharing
+    # the same table. We check this because a belongs_to may be defined on one of the
+    # STI subclasses rather than the parent. In that case, a belongs_to IS defined,
+    # so we shouldn't raise a violation.
+    def sti_family_foreign_keys(model)
+      model_family = [model] + model.descendants.select do |descendant|
+        descendant.table_name == model.table_name
+      end
+
+      model_family.flat_map do |family_model|
+        family_model
+          .reflect_on_all_associations(:belongs_to)
+          .map { |ref| ref.foreign_key.to_s }
+      end.uniq
+    end
+
     def indexed_foreign_key_columns(model)
       model.connection.indexes(model.table_name).filter_map do |index|
         columns = index.columns
@@ -271,12 +293,9 @@ module StrictAssociations
         next if ref.options[:polymorphic]
 
         begin
-          # Use <= instead of == so STI children match a belongs_to pointing to their
-          # parent
           # The table_name guard ensures this only applies for true STI (shared
           # table), not unrelated inheritance with different tables.
-          source_model <= ref.klass &&
-            source_model.table_name == ref.klass.table_name &&
+          source_model.table_name == ref.klass.table_name &&
             ref.foreign_key.to_s == fk
         rescue NameError
           false

data/lib/strict_associations/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module StrictAssociations
-  VERSION = "0.1.3"
+  VERSION = "0.1.4"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: strict_associations
 version: !ruby/object:Gem::Version
-  version: 0.1.3
+  version: 0.1.4
 platform: ruby
 authors:
 - Jeff Lange