strict_associations 0.1.1 → 0.1.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 413a5326728f775abc9050baf64f35ab7f0f90d88ebb32627d360ade8156fb3e
-  data.tar.gz: e2eb32329274995e220142c30c9c7055d2f6a675849b3df7d7680cddd17f8537
+  metadata.gz: a9c960e3ba7830927d9cbbad3d3c67365722f2a0db54e92bb6654bc4acc2e31b
+  data.tar.gz: c13c5b0b7f4307a4cae04f8e014b33ad857f778c925c9f6a467c83686a555b68
 SHA512:
-  metadata.gz: e9aa8d31880309f3338f40dff593f768b6fee510e47a160e2a0a28f76c1cf949182f2e340cc8ef9a2ca40b70b812380e74386a5623e0489425406a0f0295b85e
-  data.tar.gz: b558d3374c0b552323b73c47b5b34c2e37a873e8f0999d6fbd0687982e481854718322774b94f8444fad58ba724de899c16a784209ff07a936c3cac0e8595d29
+  metadata.gz: '018818a16c859a0b86d07ff832fd632d18ad0ef968ce34628d6a259858a1e028a219579f4056ead948fd35259018d067116a73f486fc75c084c54d7f647884c7'
+  data.tar.gz: a13326ea6f298d111bdbd98fb0d1ab92ad0a5f535907f03da210b375b02bd2cbef5a70229742acba4938328b2862d812bb89687f0b1a58002a7cad23fe269f86

data/CHANGELOG.md

@@ -2,17 +2,6 @@
 
 
 
-## [0.1.1] - Unreleased
-
-## [0.1.0] - 2026-03-12
+## [0.1.2] - Unreleased
 
-### Added
-
-- Initial release
-- Validates `has_many` and `has_one` associations declare `:dependent`
-- Validates `belongs_to` associations have a matching inverse
-- Validates polymorphic `belongs_to` declares `valid_types:`
-- Detects `has_and_belongs_to_many` usage (configurable)
-- Per-association opt-out via `strict: false`
-- Per-model opt-out via `skip_strict_association`
-- Railtie for automatic setup in Rails applications
+## [0.1.1] - Unreleased

data/lib/strict_associations/validator.rb

@@ -29,7 +29,10 @@ module StrictAssociations
     def models_to_check
       candidates = explicit_models || all_models
       candidates.reject do |model|
-        model.abstract_class? || !safe_table_exists?(model) || view?(model)
+        model.abstract_class? ||
+          !safe_table_exists?(model) ||
+          view?(model) ||
+          third_party?(model)
       end
     end
 
@@ -219,6 +222,8 @@ module StrictAssociations
     end
 
     def check_orphaned_foreign_keys(model, violations)
+      return unless owns_table?(model)
+
       indexed_fk_columns = indexed_foreign_key_columns(model)
       defined_fk_columns = model
         .reflect_on_all_associations(:belongs_to)
@@ -245,10 +250,11 @@ module StrictAssociations
 
     def indexed_foreign_key_columns(model)
       model.connection.indexes(model.table_name).filter_map do |index|
-        column = index.columns.first
-        next unless index.columns.one? && column.end_with?("_id")
+        columns = index.columns
+        next unless columns.is_a?(Array) && columns.one?
+        next unless columns.first.end_with?("_id")
 
-        column
+        columns.first
       end
     end
 
@@ -307,7 +313,26 @@ module StrictAssociations
     end
 
     def skipped?(model, ref)
-      ref.options[:strict] == false || model.strict_association_skipped?(ref.name)
+      ref.options[:strict] == false ||
+        model.strict_association_skipped?(ref.name) || third_party?(ref.active_record)
+    end
+
+    def third_party?(model)
+      return false unless model.name
+
+      source = Object.const_source_location(model.name)&.first
+      return false unless source
+
+      !File.expand_path(source).start_with?(app_root)
+    end
+
+    def app_root
+      @app_root ||= File.expand_path(defined?(Rails) ? Rails.root.to_s : Dir.pwd)
+    end
+
+    def owns_table?(model)
+      model.superclass == ActiveRecord::Base ||
+        model.table_name != model.superclass.table_name
     end
   end
 end

data/lib/strict_associations/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module StrictAssociations
-  VERSION = "0.1.1"
+  VERSION = "0.1.2"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: strict_associations
 version: !ruby/object:Gem::Version
-  version: 0.1.1
+  version: 0.1.2
 platform: ruby
 authors:
 - Jeff Lange