streamsend 0.2.2 → 0.2.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 570a759259227d544ce683da82e01e9de3fcf02f
-  data.tar.gz: 3fab2452d29f3e1cb9246958482860a5610d9cf7
+  metadata.gz: 5e41691af38b21804f3ae360a1ba2dec326e7090
+  data.tar.gz: 2f7a0ac3bd573ac8b6ff95e36c746dcc01b23aef
 SHA512:
-  metadata.gz: 731dd7a05dc12b5cf17b923b3dba981703ff96838cf94abe44d7306270a89d5aa270e65e2ea2d5655f89f063c93951445e433e568494a8fc36555173cae46f2f
-  data.tar.gz: ff1ece90306b86ff2ebe904309f0782a4c0f0ea81fef98fbeb9bd8397a51eeaf3a84d0df40b76cc80c6cb495c918c7d26569d504a6d27a27659489cd3518770d
+  metadata.gz: 365a2fb216e108448b924e9c16578bcc266f0c4894132fd4deda97a82718fe996bf8e2e8338cd4b4c62bce3de31d578e1f0d5788220921722fb7fe6bb8405b49
+  data.tar.gz: d665fd2f40151ec996cacb85af23daaaba5689d98b7b615e02c80169c91df3ce380a01821d8809f3e2cb463e33f835f38c406f1f3680a9987fe5f6de3d299631

data/lib/streamsend/api/exception.rb

@@ -6,6 +6,20 @@ module StreamSend
     class ApiException < Exception
     end
 
+    class SemanticException < ApiException
+      def initialize(other_errors)
+       @errors = [other_errors].flatten
+      end
+
+      def errors
+        @errors
+      end
+
+      def to_s
+        "#{self.class.name}: #{errors.join(',')}"
+      end
+    end
+
     class LockedError <  ApiException
     end
 

data/lib/streamsend/api/subscriber.rb

@@ -53,6 +53,8 @@ module StreamSend
           unless subscriber_id.nil?
             subscriber_id.to_i
           end
+        when 422
+          raise StreamSend::Api::SemanticException.new(response["errors"]["error"])
         else
           raise StreamSend::Api::Exception.new("Could not create the subscriber. (#{response.code})")
         end

data/spec/lib/streamsend/api/subscriber_spec.rb

@@ -175,30 +175,64 @@ module StreamSend
             end
           end
 
-          describe "with an existing subscriber using the given email address" do
+          describe "when receiving a semantic error" do
+            describe "with a single error" do
+              let( :error1 ){ "Email address has already been taken" }
+
+              before(:each) do
+                response_body = <<-XML
+<errors>
+  <error>#{error1}</error>
+</errors>
+                XML
+                stub_http_request(:post, /audiences\/2\/people.xml/).with(:person => {"email_address" => "foo@bar.com", "first_name" => "JoeBob"}).to_return(:status => 422, :body => response_body )
+              end
+
+              it "should raise an exception" do
+                expect do
+                  subscriber_id = StreamSend::Api::Subscriber.create({"email_address" => "foo@bar.com", "first_name" => "JoeBob"})
+                end.to raise_error( StreamSend::Api::SemanticException )
+              end
+
+              it "should pass on the errors" do
+                captured_problem = nil
+                begin
+                  subscriber_id = StreamSend::Api::Subscriber.create({"email_address" => "foo@bar.com", "first_name" => "JoeBob"})
+                rescue StreamSend::Api::SemanticException => problem
+                  captured_problem = problem
+                end
+                expect(captured_problem.errors.count).to be(1)
+                expect(captured_problem.errors).to include(error1)
+              end
+            end
+          end
+
+          describe "with multiple errors" do
+            let( :error1 ){ "bonjour" }
+            let( :error2 ){ "some other string you are unlikely to copy and paste" }
+
             before(:each) do
-              stub_http_request(:post, /audiences\/2\/people.xml/).with(:person => {"email_address" => "foo@bar.com", "first_name" => "JoeBob"}).to_return(:body => "<error>Email address has already been taken<error>")
+              response_body = <<-XML
+<errors>
+  <error>#{error1}</error>
+  <error>#{error2}</error>
+</errors>
+XML
+              stub_http_request(:post, /audiences\/2\/people.xml/).with(:person => {"email_address" => "foo@bar.com", "first_name" => "JoeBob"}).to_return(:status => 422, :body => response_body )
             end
 
-            it "should raise an exception" do
-              lambda {
+            it "should pass on the errors" do
+              captured_problem = nil
+              begin
                 subscriber_id = StreamSend::Api::Subscriber.create({"email_address" => "foo@bar.com", "first_name" => "JoeBob"})
-              }.should raise_error
+              rescue StreamSend::Api::SemanticException => problem
+                captured_problem = problem
+              end
+              expect(captured_problem.errors.count).to eq( 2 )
+              expect(captured_problem.errors).to include(error1, error2)
             end
           end
         end
-
-        describe "with invalid subscriber parameters" do
-          before(:each) do
-            stub_http_request(:post, /audiences\/2\/people.xml/).with({"email_address" => "foo.com", "first_name" => "JoeBob"}).to_return(:body => "<error>Email address does not appear to be valid</error>")
-          end
-
-          it "should raise an exception" do
-            lambda {
-              subscriber_id = StreamSend::Api::Subscriber.create({"email_address" => "foo@bar.com", "first_name" => "JoeBob"})
-            }.should raise_error
-          end
-        end
       end
 
       describe "#show" do
@@ -281,7 +315,7 @@ module StreamSend
         end
       end
 
-      describe "#destory" do
+      describe "#destroy" do
         let( :subscriber ){
           StreamSend::Api::Subscriber.new({"id"=> 2, "audience_id" => 1})
         }

data/streamsend.gemspec

@@ -24,5 +24,5 @@ Gem::Specification.new do |gem|
   gem.test_files    = gem.files.grep(%r{^(test|spec|features)/})
   gem.name          = "streamsend"
   gem.require_paths = ["lib"]
-  gem.version       = "0.2.2"
+  gem.version       = "0.2.3"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: streamsend
 version: !ruby/object:Gem::Version
-  version: 0.2.2
+  version: 0.2.3
 platform: ruby
 authors:
 - Scott Albertson