streamsend 0.2.1 → 0.2.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 7e61be8f0dbd41447e476d4910db11a7f4d860fa
-  data.tar.gz: 5ca77625cf5941bb0b947e504e07d4a20f1df55a
+  metadata.gz: 570a759259227d544ce683da82e01e9de3fcf02f
+  data.tar.gz: 3fab2452d29f3e1cb9246958482860a5610d9cf7
 SHA512:
-  metadata.gz: a1dbb65d585166e0fed66484cecb556c44d559de6ff8e0effc80da9b4711d1207d85e18a5a2aa1d6b0eb86e3b8954453f2a7526bbfb7777a81e8299d2c8a4e8e
-  data.tar.gz: a546c213c265d6e810d3031405ea15e51209883229bd8d6ede350abedfcaaa368d2c27d08444bfcd7df91a95c99a22255f6d4d28c12804e85bbe3dede199e418
+  metadata.gz: 731dd7a05dc12b5cf17b923b3dba981703ff96838cf94abe44d7306270a89d5aa270e65e2ea2d5655f89f063c93951445e433e568494a8fc36555173cae46f2f
+  data.tar.gz: ff1ece90306b86ff2ebe904309f0782a4c0f0ea81fef98fbeb9bd8397a51eeaf3a84d0df40b76cc80c6cb495c918c7d26569d504a6d27a27659489cd3518770d

data/.gitignore

@@ -1,2 +1,5 @@
 .DS_Store
 tags
+spec/integration/integration.yml
+.git-commit-story.yml
+logfile.log

data/.pair

@@ -0,0 +1,10 @@
+email: engineers@streamsend.com
+authors:
+  - hn Huy Nguyen
+  - em Edward Monical-Vuylsteke
+  - eg Ed Gibbs
+  - tp Tom Parker
+  - sh Steve Holmes
+  - ar Andrei Ramanovich
+  - me Mark Eschbach
+  - by Bob Yeo

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    streamsend (0.2.0)
+    streamsend (0.2.2)
       activesupport (~> 3.2)
       builder
       httparty
@@ -9,20 +9,22 @@ PATH
 GEM
   remote: https://rubygems.org/
   specs:
-    activesupport (3.2.13)
-      i18n (= 0.6.1)
+    activesupport (3.2.14)
+      i18n (~> 0.6, >= 0.6.4)
       multi_json (~> 1.0)
     addressable (2.3.5)
     builder (3.2.2)
     crack (0.4.0)
       safe_yaml (~> 0.9.0)
     diff-lcs (1.2.4)
+    git-commit-story (0.1.5)
     httparty (0.11.0)
       multi_json (~> 1.0)
       multi_xml (>= 0.5.2)
-    i18n (0.6.1)
-    multi_json (1.7.7)
-    multi_xml (0.5.4)
+    i18n (0.6.5)
+    multi_json (1.8.0)
+    multi_xml (0.5.5)
+    pair-salad (0.1.1)
     rspec (2.13.0)
       rspec-core (~> 2.13.0)
       rspec-expectations (~> 2.13.0)
@@ -43,6 +45,8 @@ PLATFORMS
   ruby
 
 DEPENDENCIES
+  git-commit-story
+  pair-salad
   rspec
   ruby-fsevent
   streamsend!

data/lib/streamsend/api/exception.rb

@@ -1,2 +1,15 @@
-class StreamSend::Api::Exception < Exception
+module StreamSend
+  module Api
+    class Exception < StandardError
+    end
+
+    class ApiException < Exception
+    end
+
+    class LockedError <  ApiException
+    end
+
+    class UnexpectedResponse < ApiException
+    end
+  end
 end

data/lib/streamsend/api/subscriber.rb

@@ -4,13 +4,27 @@ module StreamSend
   module Api
     class Subscriber < Resource
       def self.all
-        response = StreamSend::Api.get("/audiences/#{audience_id}/people.xml")
+        options = { :per_page => 1_000, :page => 0 }
+        last_gathered_count = 1
+        sbuscribers = []
+
+        until last_gathered_count == 0
+          gathered = self.index( options )
+          subscribers.concat( gathered )
+          options[:page] = options[:page]+1
+          last_gathered_count = gatehred.count
+        end
+        subscribers
+      end
+
+      def self.index(options = {})
+        response = StreamSend::Api.get("/audiences/#{audience_id}/people.xml", :query => options)
 
         case response.code
         when 200
           response["people"].collect { |data| new(data) }
         else
-          raise StreamSend::Api::Exception.new("Could not find any subscribers. Make sure your audience ID is correct. (#{response.code})")
+          raise StreamSend::Api::ApiException.new("Error response (#{response.code}), Make sure your audience ID is correct. (audience_id => #{audience_id})")
         end
       end
 
@@ -80,6 +94,18 @@ module StreamSend
           raise StreamSend::Api::Exception("Could not subscribe the subscriber. (#{response.code})")
         end
       end
+
+      def destroy
+        response = StreamSend::Api.delete("/audiences/#{audience_id}/people/#{id}.xml")
+        case response.code
+        when 200
+          true
+        when 423
+          raise LockedError, "Can not delete"
+        else
+          raise UnexpectedResponse, response.code
+        end
+      end
     end
   end
 end

data/spec/lib/streamsend/api/subscriber_spec.rb

@@ -56,7 +56,7 @@ module StreamSend
         end
       end
 
-      describe ".all" do
+      describe ".index" do
         describe "with subscribers" do
           before(:each) do
             xml = <<-XML
@@ -70,11 +70,11 @@ module StreamSend
             </people>
             XML
 
-            stub_http_request(:get, "http://#{@username}:#{@password}@#{@host}/audiences/2/people.xml").to_return(:body => xml)
+            stub_http_request(:get, "http://#{@username}:#{@password}@#{@host}/audiences/2/people.xml?").to_return(:body => xml)
           end
 
           it "should return array of one subscriber object" do
-            subscribers = StreamSend::Api::Subscriber.all
+            subscribers = StreamSend::Api::Subscriber.index
             subscribers.size.should == 1
 
             subscribers.first.should be_instance_of(StreamSend::Api::Subscriber)
@@ -91,11 +91,11 @@ module StreamSend
             <people type="array"/>
             XML
 
-            stub_http_request(:get, "http://#{@username}:#{@password}@#{@host}/audiences/2/people.xml").to_return(:body => xml)
+            stub_http_request(:get, "http://#{@username}:#{@password}@#{@host}/audiences/2/people.xml?").to_return(:body => xml)
           end
 
           it "should return an empty array" do
-            StreamSend::Api::Subscriber.all.should == []
+            StreamSend::Api::Subscriber.index.should == []
           end
         end
 
@@ -110,7 +110,9 @@ module StreamSend
           end
 
           it "should raise an exception" do
-            lambda { StreamSend::Api::Subscriber.all }.should raise_error
+            expect do
+              StreamSend::Api::Subscriber.index
+            end.to raise_error(ApiException)
           end
         end
       end
@@ -278,6 +280,32 @@ module StreamSend
           end
         end
       end
+
+      describe "#destory" do
+        let( :subscriber ){
+          StreamSend::Api::Subscriber.new({"id"=> 2, "audience_id" => 1})
+        }
+        let( :uri ){ "http://#{@username}:#{@password}@#{@host}/audiences/1/people/2.xml" }
+
+        it "returns true when destroyed" do
+          stub_http_request(:delete, uri ).to_return(:body => nil)
+          expect(subscriber.destroy).to be_true
+        end
+
+        it "throws a LockedError when locked" do
+          stub_http_request(:delete, uri ).to_return(:status => 423, :body => nil)
+          expect do
+            subscriber.destroy
+          end.to raise_error( LockedError )
+        end
+
+        it "throws unexpected response with any other exception" do
+          stub_http_request(:delete, uri ).to_return(:status => 500, :body => "Error text meant for HCI")
+          expect do
+            subscriber.destroy
+          end.to raise_error( UnexpectedResponse )
+        end
+      end
     end
   end
 end

data/streamsend.gemspec

@@ -1,7 +1,7 @@
 # -*- encoding: utf-8 -*-
 
 Gem::Specification.new do |gem|
-  gem.authors       = ["Scott Albertson", "Jeff Roush"]
+  gem.authors       = ["Scott Albertson", "Jeff Roush", "Mark Eschbach", "Bob Yeo"]
   gem.email         = %q{jroush@ezpublishing.com}
   gem.summary       = %q{Ruby wrapper for the StreamSend API.}
   gem.description   = %q{Ruby wrapper for the StreamSend API.}
@@ -12,15 +12,17 @@ Gem::Specification.new do |gem|
   gem.add_dependency "activesupport", "~>3.2"
   gem.add_dependency "builder"
   gem.add_development_dependency "rspec"
+  gem.add_development_dependency "git-commit-story"
   gem.add_development_dependency "webmock", "~> 1.6"
   gem.add_development_dependency "vcr"
   gem.add_development_dependency "watchr"
   gem.add_development_dependency "ruby-fsevent"
+  gem.add_development_dependency "pair-salad"
 
   gem.files         = `git ls-files`.split($\)
   gem.executables   = gem.files.grep(%r{^bin/}).map{ |f| File.basename(f) }
   gem.test_files    = gem.files.grep(%r{^(test|spec|features)/})
   gem.name          = "streamsend"
   gem.require_paths = ["lib"]
-  gem.version       = "0.2.1"
+  gem.version       = "0.2.2"
 end

metadata

@@ -1,11 +1,13 @@
 --- !ruby/object:Gem::Specification
 name: streamsend
 version: !ruby/object:Gem::Version
-  version: 0.2.1
+  version: 0.2.2
 platform: ruby
 authors:
 - Scott Albertson
 - Jeff Roush
+- Mark Eschbach
+- Bob Yeo
 autorequire: 
 bindir: bin
 cert_chain: []
@@ -67,6 +69,20 @@ dependencies:
     - - '>='
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: git-commit-story
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: webmock
   requirement: !ruby/object:Gem::Requirement
@@ -123,6 +139,20 @@ dependencies:
     - - '>='
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: pair-salad
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '0'
 description: Ruby wrapper for the StreamSend API.
 email: jroush@ezpublishing.com
 executables: []
@@ -130,6 +160,7 @@ extensions: []
 extra_rdoc_files: []
 files:
 - .gitignore
+- .pair
 - .rspec
 - Gemfile
 - Gemfile.lock