strava-ruby-client 2.1.0 → 2.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 7b7cecf53fa55d912d8f4a4e2c8d62621f3f4aa386315745de5792bfe45328ae
-  data.tar.gz: f9ee4eaea70ead74645748d557e9f316346aca2fc49ec0e5c37b55e5ba4ae0ee
+  metadata.gz: eae71d27881be5526b289574a16cbb6897d987008f4941d8b32172f7e40971d2
+  data.tar.gz: 8643756679123f7f0ddcd29f4755358eb27534ce48bdb0be085c080ba76c8d13
 SHA512:
-  metadata.gz: c9bb8c36fa560060cd2ee5ea7f4cda88bb4d2a9b4f5b2a278dc39a99260c56727ce90cb1c09b17ccb9dfad624829934ae10049ff05d58a06009559e7b2ed6161
-  data.tar.gz: 05f4a34f12d7e9691c0f7446e0381bf52bbda3f55fdaad57c018eb128e30f8938784f1a5b327de2dcb8fd3b32841946b495883a8b1a27fbfdba84e958d0f71ce
+  metadata.gz: 92743308394842b6b9a8d6c975141537c14dd3dc857ba5085a050dc0622855e9454b8bee9a4a3ba5e4747daf206d715e16dd75b67112a152b72a011564c99453
+  data.tar.gz: 493fc2d1558ad057c1ed78ef77df83f175d47dd23e97cfd9502c4b11249f84e8651c8a9319552a7c16ec5ba8369ee70d7d6ed567eddd94cb1e4ea6e9fecc4979

data/CHANGELOG.md

@@ -1,3 +1,9 @@
+### 2.2.0 (2024/9/17)
+
+* [#83](https://github.com/dblock/strava-ruby-client/pull/83): Adds back activity photos - [@dillon-co](https://github.com/dillon-co).
+* [#84](https://github.com/dblock/strava-ruby-client/pull/84): Adds back activity photos (finished PR #83) - [@simonneutert](https://github.com/simonneutert).
+* [#85](https://github.com/dblock/strava-ruby-client/pull/85): Lays groundwork to v3.0.0 of the gem (ruby3, newest rubocop, rubocop-rake and rubocop-rspec) - [@simonneutert](https://github.com/simonneutert).
+
 ### 2.1.0 (2024/3/20)
 
 * [#80](https://github.com/dblock/strava-ruby-client/pull/80): Removes default values for Faraday's SSL settings `ca_file` and `ca_path` - [@dblock](https://github.com/dblock).

data/README.md

@@ -14,6 +14,7 @@ Unlike other clients, including [strava-api-v3](https://github.com/jaredholdcrof
   - [Activities](#activities)
     - [Create an Activity](#create-an-activity)
     - [Get Activity](#get-activity)
+    - [List Activity Photos](#list-activity-photos)
     - [List Activity Comments](#list-activity-comments)
     - [List Activity Kudoers](#list-activity-kudoers)
     - [List Activity Laps](#list-activity-laps)
@@ -149,6 +150,31 @@ google_image_url = "https://maps.googleapis.com/maps/api/staticmap?maptype=roadm
 
 See [Strava::Models::Map](lib/strava/models/map.rb) for all available properties.
 
+#### List Activity Photos
+
+Returns the photos on the given activity. This API is undocumented in Strava's docs. But there is a discussion in the [strava community hub](https://communityhub.strava.com/t5/developer-discussions/download-all-photos-of-my-own-activities/m-p/11262).
+
+```ruby
+photos = client.activity_photos(1982980795) # => Array[Strava::Models::Photo]
+# in order to request a certain size (by default it will return the biggest size possible):
+# photos = client.activity_photos(1982980795, {size: 1920}) # => Array[Strava::Models::Photo]
+
+photo = photos.first # => Strava::Models::Photo
+
+photo.id # => nil
+photo.unique_id # => '65889142-538D-4EE5-96F5-3DC3B773B1E3'
+photo.urls # => { '0' => 'https://dgtzuqphqg23d.cloudfront.net/eb4DMJ2hJW3k_g9URZEMfaJ8rZfHagrNlZRuEZz0osU-29x64.jpg' }
+photo.athlete_id # => 26_462_176
+photo.activity_id # => 1_946_417_534
+photo.activity_name # => 'TCS NYC Marathon 2018'
+photo.created_at # => Time
+photo.uploaded_at # => Time
+photo.sizes # => { '0' => [29, 64] }
+photo.default_photo # => false
+```
+
+See [Strava::Models::Photo](lib/strava/models/photo.rb) for all available properties.
+
 #### List Activity Comments
 
 Returns the comments on the given activity.

data/bin/strava-webhooks

@@ -5,7 +5,7 @@ require 'dotenv/load'
 require 'webrick'
 require 'strava-ruby-client'
 
-logger = ::Logger.new($stdout)
+logger = Logger.new($stdout)
 logger.level = Logger::INFO
 
 client = Strava::Webhooks::Client.new(

data/lib/strava/api/endpoints/activities.rb

@@ -37,6 +37,22 @@ module Strava
           paginate "activities/#{id}/comments", options, Strava::Models::Comment, &block
         end
 
+        #
+        # List activity photos.
+        #
+        # @option options [String] :id
+        #   Activity id.
+        # @option options [Integer] :page
+        #   Page number.
+        # @option options [Integer] :per_page
+        #   Number of items per page. Defaults to 30.
+        #
+        def activity_photos(id_or_options, options = {}, &block)
+          id, options = parse_args(id_or_options, options)
+          options[:size] = 5000 unless options[:size] # to retrieve full size photos
+          paginate "activities/#{id}/photos", options, Strava::Models::Photo, &block
+        end
+
         #
         # List activity kudoers.
         #

data/lib/strava/api/pagination.rb

@@ -48,8 +48,8 @@ module Strava
 
       private
 
-      def method_missing(method_symbol, *args, &block)
-        @collection.send(method_symbol, *args, &block)
+      def method_missing(method_symbol, ...)
+        @collection.send(method_symbol, ...)
       end
 
       def respond_to_missing?(method_name, include_private = false)

data/lib/strava/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Strava
-  VERSION = '2.1.0'
+  VERSION = '2.2.0'
 end

data/lib/strava/web/raise_response_error.rb

@@ -3,7 +3,7 @@
 module Strava
   module Web
     class RaiseResponseError < ::Faraday::Middleware
-      CLIENT_ERROR_STATUSES = (400...600).freeze
+      CLIENT_ERROR_STATUSES = (400...600)
 
       def on_complete(env)
         case env[:status]

data/lib/strava/web/response.rb

@@ -51,10 +51,10 @@ module Strava
       # @raise [NoMethodError]
       # @return [any]
       #
-      def operate_on_response_body!(method_symbol, *args, &block)
+      def operate_on_response_body!(method_symbol, ...)
         case @response.body
         when Hash
-          @response.body.send(method_symbol, *args, &block)
+          @response.body.send(method_symbol, ...)
         else
           raise NoMethodError
         end
@@ -75,12 +75,12 @@ module Strava
         end
       end
 
-      def method_missing(method_symbol, *args, &block)
+      def method_missing(method_symbol, ...)
         case @response
         when Array
-          @response.send(method_symbol, *args, &block)
+          @response.send(method_symbol, ...)
         else
-          operate_on_response_body!(method_symbol, *args, &block)
+          operate_on_response_body!(method_symbol, ...)
         end
       end
 

data/lib/strava/webhooks/client.rb

@@ -13,7 +13,7 @@ module Strava
       end
 
       def request(method, path, options)
-        super method, path, { client_id: client_id, client_secret: client_secret }.merge(options)
+        super(method, path, { client_id: client_id, client_secret: client_secret }.merge(options))
       end
 
       #

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: strava-ruby-client
 version: !ruby/object:Gem::Version
-  version: 2.1.0
+  version: 2.2.0
 platform: ruby
 authors:
 - Daniel Doubrovkine
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2024-03-20 00:00:00.000000000 Z
+date: 2024-09-17 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -172,14 +172,14 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: '2.7'
+      version: '3.0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: 1.3.6
+      version: '2.5'
 requirements: []
-rubygems_version: 3.3.7
+rubygems_version: 3.5.11
 signing_key:
 specification_version: 4
 summary: Strava API Ruby client.