strategic 1.0.0 → 1.0.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: f8ddc7e63dc608ac0a7e97ebb9110431c9a490e7ec07abed6936bb347b6105e8
-  data.tar.gz: 4ca98f38d3933fc5f33ac460dc2767a2769cfbe0a870c9f48bfb427ca2a4c1c4
+  metadata.gz: 5d1b5e48f559fa9befbe74660a5894d73aa99e9acb9ab31daf6d592e50d5200e
+  data.tar.gz: b0064808d6119cd5e860762c82483d457c30c4a5d22b703060fbef323a781086
 SHA512:
-  metadata.gz: '067224647109cf8198006ddce287755a1ec9997ff67fc8a3099d4f172ba6549a8e9ef4f8bf285d44996aa3a5d6ef4949892dffab5a1d26918d17cdc27cbd6e0b'
-  data.tar.gz: 1046857c6fd46e0615ab559bbb4e84bc8ba70f7d7995bd621e7d182316d603d22e4d99e2fefc1adce3d2682769519e0cc9189bef7ce614d0aca8354271994e05
+  metadata.gz: 351e5f342baf23c732723b97e0040f85d65378bf4e5fdfcde2385a9b16870a303f638da34765569d0392180295997088e1f7730b3a970210ebdd22bb388b712a
+  data.tar.gz: b5b269f698ae134d412dc9d8ff5e16d397da76480c88f9b92e984079f5edbaed3002f409e71ac4686e010fbd0a0bdcc460b70a42a7c503ea95e2001b665dd7a5

data/CHANGELOG.md

@@ -1,5 +1,10 @@
 # Change Log
 
+## 1.0.1
+
+- Fix error "undefined method `new' for Strategic::Strategy:Module" that occurs when setting an empty string strategy (must return nil or default strategy)
+- Fix issue with `ancestors` method not available on all constants (only ones that are classes/modules)
+
 ## 1.0.0
 
 - Improve design to better match the authentic Gang of Four Strategy Pattern with `Strategic::Strategy` module, removing the need for inheritance.

data/README.md

@@ -1,4 +1,4 @@
-# Strategic 1.0.0
+# Strategic 1.0.1
 ## Painless Strategy Pattern in Ruby and Rails
 [![Gem Version](https://badge.fury.io/rb/strategic.svg)](http://badge.fury.io/rb/strategic)
 [![rspec](https://github.com/AndyObtiva/strategic/actions/workflows/ruby.yml/badge.svg)](https://github.com/AndyObtiva/strategic/actions/workflows/ruby.yml)
@@ -92,7 +92,7 @@ tax_calculator = TaxCalculator.new_with_strategy('us', args)
 tax = tax_calculator.tax_for(39.78)
 ```
 
-**Default strategy for a strategy name that has no strategy class is the superclass: `TaxCalculator`**
+Default strategy for a strategy name that has no strategy class is `nil`
 
 You may set a default strategy on a strategic model via class method `default_strategy`
 
@@ -116,7 +116,7 @@ If no strategy is selected and you try to invoke a method that belongs to strate
 Add the following to bundler's `Gemfile`.
 
 ```ruby
-gem 'strategic', '~> 1.0.0'
+gem 'strategic', '~> 1.0.1'
 ```
 
 ### Option 2: Manual
@@ -124,7 +124,7 @@ gem 'strategic', '~> 1.0.0'
 Or manually install and require library.
 
 ```bash
-gem install strategic -v1.0.0
+gem install strategic -v1.0.1
 ```
 
 ```ruby
@@ -145,21 +145,44 @@ Steps:
 
 ## API
 
-- `StrategicClass::strategy_names`: returns list of strategy names (strings) discovered by convention (nested under a namespace matching the superclass name)
-- `StrategicClass::strategies`: returns list of strategies discovered by convention (nested under a namespace matching the superclass name)
-- `StrategicClass::new_with_strategy(string_or_class_or_object, *args, &block)`: instantiates a strategy based on a string/class/object and strategy constructor args
-- `StrategicClass::strategy_class_for(string_or_class_or_object)`: selects a strategy class based on a string (e.g. 'us' selects UsStrategy) or alternatively a class/object if you have a mirror hierarchy for the strategy hierarchy
-- `StrategicClass::default_strategy`: (used in model class body) sets default strategy as a strategy name string (e.g. 'us' selects UsStrategy) or alternatively a class/object if you have a mirror hierarchy for the strategy hierarchy
-- `StrategicClass::strategy_matcher`: (used in model class body) custom matcher for all strategies (e.g. `strategy_matcher {|string| string.start_with?('C') && string.end_with?('o')}`)
-- `StrategicClass#strategy=`: sets strategy
-- `StrategicClass#strategy`: returns current strategy
-- `StrategyClass::strategy_name`: returns parsed strategy name of current strategy class
-- `StrategyClass::strategy_matcher`: (used in model class body) custom matcher for a specific strategy (e.g. `strategy_matcher {|string| string.start_with?('C') && string.end_with?('o')}`)
-- `StrategyClass::strategy_exclusion`: (used in model class body) exclusion from custom matcher (e.g. `strategy_exclusion 'Cio'`)
-- `StrategyClass::strategy_alias`: (used in model class body) alias for strategy in addition to strategy's name derived from class name by convention (e.g. `strategy_alias 'USA'` for `UsStrategy`)
-- `StrategyClass#context`: returns strategy context (the strategic model instance)
-
-Example with customizations via class body methods:
+### Strategic model
+
+#### Class Body Methods
+
+These methods can be delcared in a strategic model class body.
+
+- `::default_strategy`: sets default strategy as a strategy name string (e.g. 'us' selects UsStrategy) or alternatively a class/object if you have a mirror hierarchy for the strategy hierarchy
+- `::strategy_matcher`: custom matcher for all strategies (e.g. `strategy_matcher {|string| string.start_with?('C') && string.end_with?('o')}`)
+
+#### Class Methods
+
+- `::strategy_names`: returns list of strategy names (strings) discovered by convention (nested under a namespace matching the superclass name)
+- `::strategies`: returns list of strategies discovered by convention (nested under a namespace matching the superclass name)
+- `::new_with_strategy(string_or_class_or_object, *args, &block)`: instantiates a strategy based on a string/class/object and strategy constructor args
+- `::strategy_class_for(string_or_class_or_object)`: selects a strategy class based on a string (e.g. 'us' selects UsStrategy) or alternatively a class/object if you have a mirror hierarchy for the strategy hierarchy
+
+#### Instance Methods
+
+- `#strategy=`: sets strategy
+- `#strategy`: returns current strategy
+
+### Strategy
+
+#### Class Body Methods
+
+- `::strategy_matcher`: custom matcher for a specific strategy (e.g. `strategy_matcher {|string| string.start_with?('C') && string.end_with?('o')}`)
+- `::strategy_exclusion`: exclusion from custom matcher (e.g. `strategy_exclusion 'Cio'`)
+- `::strategy_alias`: alias for strategy in addition to strategy's name derived from class name by convention (e.g. `strategy_alias 'USA'` for `UsStrategy`)
+
+#### Class Methods
+
+- `::strategy_name`: returns parsed strategy name of current strategy class
+
+#### Instance Methods
+
+- `#context`: returns strategy context (the strategic model instance)
+
+### Example with Customizations via Class Body Methods
 
 ```ruby
 class TaxCalculator

data/lib/strategic.rb

@@ -77,6 +77,7 @@ module Strategic
       else
         strategy_class_name = string_or_class_or_object.class.name
       end
+      return nil if strategy_class_name.to_s.strip.empty?
       begin
         class_name = "::#{self.name}::#{Strategic.classify(strategy_class_name)}Strategy"
         class_eval(class_name)
@@ -94,6 +95,8 @@ module Strategic
     def strategies
       constants.map do |constant_symbol|
         const_get(constant_symbol)
+      end.select do |constant|
+        constant.respond_to?(:ancestors)
       end.select do |constant|
         constant.ancestors.include?(Strategic::Strategy) && constant.name.split('::').last.end_with?('Strategy') && constant.name.split('::').last != 'Strategy' # has to be something like PrefixStrategy
       end.sort_by(&:strategy_name)

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: strategic
 version: !ruby/object:Gem::Version
-  version: 1.0.0
+  version: 1.0.1
 platform: ruby
 authors:
 - Andy Maleh
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2021-03-29 00:00:00.000000000 Z
+date: 2021-09-14 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rspec
@@ -167,7 +167,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.2.3
+rubygems_version: 3.2.22
 signing_key:
 specification_version: 4
 summary: Painless Strategy Pattern for Ruby and Rails