straight_to_video 0.0.6 → 0.0.7

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 57371915cd38c1ecac814d16a43244275216661f31b639a80022685672984e22
-  data.tar.gz: bb04ab7274edbb61031a270c8f650872b0b2338a7a1fc93a54948c8f3a3fcd04
+  metadata.gz: 7412c0ad6de37671f90aad3c474a2dfc2f846e656de524248791ec318ad598b7
+  data.tar.gz: 4032432057ff6b71831f3e509e4300f34a8f662c70b977923ec60edfce2d15ae
 SHA512:
-  metadata.gz: 92b3e2d474ba435ac6679c26755a9d62bb5388cd3fbb984fc6b31506287b4ced1be3a7c3621efdaf1812a9feae7f60287caa9e91e3601731c60c0a450e4d8824
-  data.tar.gz: 550b54b8fb004e7b6fea54282f00053fe47fd4bdefd20a5e87817c91495756adfe38c40d72888de883b0fbc049ad9615eb3f4f1783b05d01d92fc418356645cb
+  metadata.gz: 6c1d31ff446323e0304df7abfa4d02d7a52b883149a97f810753b55944447e5001a9ec810fa37525a8a0e5be7662c552df5c70d740d82b8ba367389c2d86d1ac
+  data.tar.gz: d8244161a7cd07734f24f7bf24037131db2c7ccaceb54e89330474edc575d00c32d82b24317ae24561e9bd42f1191b06d986c19ae770e829f81ef973598cc330

data/CHANGELOG.md

@@ -1,5 +1,9 @@
 # Changelog
 
+## 0.0.7
+
+- guard against a race condition for forms that subscribe to change events but don't disable submission while optimize is already underway
+
 ## 0.0.6
 
 - fix iOS Safari Stimulus controller hang by making `seeked` waits robust

data/app/assets/javascripts/straight-to-video.js

@@ -1,4 +1,4 @@
-// straight-to-video@0.0.6 vendored by the straight_to_video gem
+// straight-to-video@0.0.7 vendored by the straight_to_video gem
 // straight-to-video - https://github.com/searlsco/straight-to-video
 
 // ----- External imports -----
@@ -233,7 +233,11 @@ async function encodeVideo ({ file, srcMeta, onProgress }) {
     v.addEventListener('loadedmetadata', onLoaded)
     v.addEventListener('error', onError)
     v.src = url
-    try { v.load() } catch (_) {}
+    try {
+      v.load()
+    } catch (err) {
+      console.warn('straight-to-video: video.load() threw; continuing without explicit load()', err)
+    }
   })
   const canvas = document.createElement('canvas'); canvas.width = targetWidth; canvas.height = targetHeight
   const ctx = canvas.getContext('2d', { alpha: false })
@@ -244,9 +248,7 @@ async function encodeVideo ({ file, srcMeta, onProgress }) {
     const drawTime = i === 0
       ? Math.min(Math.max(0, t + (step * 0.5)), Math.max(0.000001, durationCfr - 0.000001))
       : targetTime
-    if (i === 0) {}
     await seekOnce(v, drawTime)
-    if (i === 0) {}
     const budgetMs = Math.min(34, Math.max(17, Math.round(step * 1000)))
     const presented = await waitForFrameReady(v, budgetMs)
     if (!presented && i === 0) {
@@ -261,7 +263,11 @@ async function encodeVideo ({ file, srcMeta, onProgress }) {
     vf.close()
 
     if (typeof onProgress === 'function') {
-      try { onProgress(Math.min(1, (i + 1) / frames)) } catch (_) {}
+      try {
+        onProgress(Math.min(1, (i + 1) / frames))
+      } catch (err) {
+        console.warn('straight-to-video: onProgress callback threw; ignoring error', err)
+      }
     }
   }
   await ve.flush()
@@ -352,8 +358,11 @@ function registerStraightToVideoController (app, opts = {}) {
     }
 
     async _processFileInput (fileInput) {
-      const ua = typeof navigator !== 'undefined' && navigator.userAgent ? navigator.userAgent : ''
-      const isIos = /iP(hone|ad|od)/.test(ua)
+      if (!this._pendingProcesses) this._pendingProcesses = new WeakMap()
+      const existing = this._pendingProcesses.get(fileInput)
+      if (existing) return existing
+
+      const job = (async () => {
       this._markFlag(fileInput, 'processing')
       fileInput.disabled = true
       try {
@@ -372,6 +381,13 @@ function registerStraightToVideoController (app, opts = {}) {
         fileInput.disabled = false
         this._unmarkFlag(fileInput, 'processing')
       }
+      })()
+
+      this._pendingProcesses.set(fileInput, job)
+      job.finally(() => {
+        if (this._pendingProcesses?.get(fileInput) === job) this._pendingProcesses.delete(fileInput)
+      })
+      return job
     }
 
     _fire (el, name, detail = {}) {

data/index.html

@@ -200,7 +200,14 @@
 
       // Single‑button flow: open picker then auto‑submit
       tryBtn.addEventListener('click', () => {
-        if (fileEl.showPicker) { try { fileEl.showPicker(); return } catch (_) {} }
+        if (fileEl.showPicker) {
+          try {
+            fileEl.showPicker()
+            return
+          } catch (err) {
+            console.warn('straight-to-video demo: file input showPicker() failed; falling back to click()', err)
+          }
+        }
         fileEl.click()
       })
 
@@ -211,7 +218,11 @@
         sizes.classList.remove('hidden')
         p.classList.remove('hidden')
         pct && (pct.textContent = '0%')
-        try { form.requestSubmit() } catch (_) {}
+        try {
+          form.requestSubmit()
+        } catch (err) {
+          console.warn('straight-to-video demo: form.requestSubmit() failed; user may need to submit manually', err)
+        }
       })
 
       // Mirror controller events into the UI

data/index.js

@@ -232,7 +232,11 @@ async function encodeVideo ({ file, srcMeta, onProgress }) {
     v.addEventListener('loadedmetadata', onLoaded)
     v.addEventListener('error', onError)
     v.src = url
-    try { v.load() } catch (_) {}
+    try {
+      v.load()
+    } catch (err) {
+      console.warn('straight-to-video: video.load() threw; continuing without explicit load()', err)
+    }
   })
   const canvas = document.createElement('canvas'); canvas.width = targetWidth; canvas.height = targetHeight
   const ctx = canvas.getContext('2d', { alpha: false })
@@ -243,9 +247,7 @@ async function encodeVideo ({ file, srcMeta, onProgress }) {
     const drawTime = i === 0
       ? Math.min(Math.max(0, t + (step * 0.5)), Math.max(0.000001, durationCfr - 0.000001))
       : targetTime
-    if (i === 0) {}
     await seekOnce(v, drawTime)
-    if (i === 0) {}
     const budgetMs = Math.min(34, Math.max(17, Math.round(step * 1000)))
     const presented = await waitForFrameReady(v, budgetMs)
     if (!presented && i === 0) {
@@ -260,7 +262,11 @@ async function encodeVideo ({ file, srcMeta, onProgress }) {
     vf.close()
 
     if (typeof onProgress === 'function') {
-      try { onProgress(Math.min(1, (i + 1) / frames)) } catch (_) {}
+      try {
+        onProgress(Math.min(1, (i + 1) / frames))
+      } catch (err) {
+        console.warn('straight-to-video: onProgress callback threw; ignoring error', err)
+      }
     }
   }
   await ve.flush()
@@ -351,8 +357,11 @@ function registerStraightToVideoController (app, opts = {}) {
     }
 
     async _processFileInput (fileInput) {
-      const ua = typeof navigator !== 'undefined' && navigator.userAgent ? navigator.userAgent : ''
-      const isIos = /iP(hone|ad|od)/.test(ua)
+      if (!this._pendingProcesses) this._pendingProcesses = new WeakMap()
+      const existing = this._pendingProcesses.get(fileInput)
+      if (existing) return existing
+
+      const job = (async () => {
       this._markFlag(fileInput, 'processing')
       fileInput.disabled = true
       try {
@@ -371,6 +380,13 @@ function registerStraightToVideoController (app, opts = {}) {
         fileInput.disabled = false
         this._unmarkFlag(fileInput, 'processing')
       }
+      })()
+
+      this._pendingProcesses.set(fileInput, job)
+      job.finally(() => {
+        if (this._pendingProcesses?.get(fileInput) === job) this._pendingProcesses.delete(fileInput)
+      })
+      return job
     }
 
     _fire (el, name, detail = {}) {

data/lib/straight_to_video/version.rb

@@ -1,3 +1,3 @@
 module StraightToVideo
-  VERSION = "0.0.6"
+  VERSION = "0.0.7"
 end

data/package-lock.json

@@ -1,12 +1,12 @@
 {
   "name": "straight-to-video",
-  "version": "0.0.6",
+  "version": "0.0.7",
   "lockfileVersion": 3,
   "requires": true,
   "packages": {
     "": {
       "name": "straight-to-video",
-      "version": "0.0.6",
+      "version": "0.0.7",
       "license": "MIT",
       "dependencies": {
         "mediabunny": "^1.24.4"

data/package.json

@@ -1,6 +1,6 @@
 {
   "name": "straight-to-video",
-  "version": "0.0.6",
+  "version": "0.0.7",
   "description": "Browser-based, hardware-accelerated video upload optimization",
   "type": "module",
   "exports": {

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: straight_to_video
 version: !ruby/object:Gem::Version
-  version: 0.0.6
+  version: 0.0.7
 platform: ruby
 authors:
 - Justin Searls