storey 2.0.1 → 2.0.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 9bb3f2b4defb8e7efc5b8fc40436f55af4f108e84a036acd96a88719b0ce609b
-  data.tar.gz: b7c0a0382f6b0569f310e89da8408623a334260773bfbb21ae22bae2c98cfc88
+  metadata.gz: 89dc451e50d3e25bfa3e2f4028f1718059cd28f8aafab7aaf87a1815837f9121
+  data.tar.gz: 3f32de0842a1c7d05b91fc7b715fbb1710d8452e0fe7db00eb740994d35cb80e
 SHA512:
-  metadata.gz: 8f5cd71b0a6b1792e58dd0b2e47af04eb679b1cba49336f7e1a7f8c961568cc18d8fa810e553da368466e9786e1e6ec2d45af66f7613e08558a2427e463f45aa
-  data.tar.gz: 85c6de9f6818ec7fa46d6326a91c9c105a82e04e40e0ede0ba6744a78b60b61ced509ce041ec2f068d10c88df385f8b84553e1e6234397297ccce3b78d4592b1
+  metadata.gz: 73992092bc15f428a45bea3b4a9de2794f9eeb72f0aaec6d3eee7b36b2cf6c4030ae10d6b9f869702589acc724b3c92dabb4597373541926be2e01fe05b5ba7c
+  data.tar.gz: 0617b1dd0a58fe4bf1d8dacfcd8a1cddd8efcf8ef5ff7f384edbbffd950a905525529f3de1e005a133d647a2806d365be3b5a12c07855f9f81a1c9c234f3e9d3

data/CHANGELOG.md

@@ -2,6 +2,11 @@
 All notable changes to this project will be documented in this file.
 This project adheres to [Semantic Versioning](http://semver.org/).
 
+## [2.0.2] - 2018-06-29
+### Fixed
+- Fix instances when the default schema is the wrong schema
+- Silence output when creating schemas
+
 ## [2.0.1] - 2018-06-27
 ### Fixed
 - Do not blow up `rake db:create` in Rails 5.2

data/README.md

@@ -39,16 +39,16 @@ Usage:
 
 ## schemas
 
-Returns all schemas except postgres' schemas.
+Returns all postgres' schemas.
 
 Accepts options:
 
-    :exclude_public => true
+    :public => true
 
 Usage:
 
-    Storey.schemas
-    Storey.schemas(:exclude_public => true)
+    Storey.schemas # defaults to :public => true
+    Storey.schemas(:public => true)
 
 ## default_schema?
 

data/gemfiles/rails_5.0.gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: ..
   specs:
-    storey (2.0.0)
+    storey (2.0.1)
       easy_class_to_instance_method (~> 0.0.2)
       pg
       rails (>= 4.0.0)

data/gemfiles/rails_5.1.gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: ..
   specs:
-    storey (2.0.0)
+    storey (2.0.1)
       easy_class_to_instance_method (~> 0.0.2)
       pg
       rails (>= 4.0.0)

data/gemfiles/rails_5.2.gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: ..
   specs:
-    storey (2.0.0)
+    storey (2.0.1)
       easy_class_to_instance_method (~> 0.0.2)
       pg
       rails (>= 4.0.0)

data/lib/storey.rb

@@ -37,7 +37,7 @@ module Storey
   end
 
   def default_search_path
-    @@default_search_path ||= self.schema
+    set_default_search_path
     default_search_paths = @@default_search_path.split(',')
     paths = default_search_paths + self.persistent_schemas
     paths.uniq!
@@ -93,7 +93,7 @@ module Storey
   def create_plain_schema(schema_name)
     name = suffixify schema_name
     command = "CREATE SCHEMA #{name}"
-    system psql_load_command(command: command)
+    Open3.capture3 psql_load_command(command: command)
   end
 
   def schemas(options={})
@@ -124,6 +124,8 @@ module Storey
   end
 
   def switch(name=nil, &block)
+    set_default_search_path
+
     if block_given?
       original_schema = schema
       switch name
@@ -243,4 +245,8 @@ module Storey
     BuildsLoadCommand.execute(self.database_config.merge(options))
   end
 
+  def set_default_search_path
+    @@default_search_path ||= self.schema
+  end
+
 end

data/lib/storey/duplicator.rb

@@ -53,9 +53,14 @@ module Storey
       arg_options['schema-only'] = nil if @structure_only
 
       switches = Utils.command_line_switches_from(arg_options)
-
-      success = system("pg_dump #{switches} #{Storey.database_config[:database]}")
-      unless success
+      pg_dump_command = [
+        "pg_dump",
+        switches,
+        Storey.database_config[:database],
+      ].join(" ")
+
+      stdout_str, stderr_str, status = Open3.capture3(pg_dump_command)
+      unless status.exitstatus.zero?
         raise StoreyError, "There seems to have been a problem dumping `#{@source_schema}` to make a copy of it into `#{@target_schema}`"
       end
     end
@@ -78,7 +83,7 @@ module Storey
       end
 
       psql_load_command = BuildsLoadCommand.execute(psql_options)
-      system psql_load_command
+      Open3.capture3(psql_load_command)
 
       copy_source_schema_migrations
 

data/lib/storey/version.rb

@@ -1,3 +1,3 @@
 module Storey
-  VERSION = "2.0.1"
+  VERSION = "2.0.2"
 end

data/spec/storey/default_search_path_spec.rb

@@ -4,6 +4,14 @@ describe 'Storey', '#default_search_path' do
 
   context "when #default_search_path has not been set before" do
     it "defaults to the current schema" do
+      Storey.create "anotherschema"
+
+      # A bit of a hack, but set the @@default_search_path so we can test
+      # the scenario when no path has been set
+      Storey.class_variable_set("@@default_search_path", nil)
+
+      Storey.switch "anotherschema"
+
       expect(Storey.default_search_path).to eq '"$user",public'
     end
   end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: storey
 version: !ruby/object:Gem::Version
-  version: 2.0.1
+  version: 2.0.2
 platform: ruby
 authors:
 - Ramon Tayag
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-06-27 00:00:00.000000000 Z
+date: 2018-06-29 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rspec-rails