store_base_sti_class 0.1.0 → 0.2.0

checksums.yaml

@@ -0,0 +1,7 @@
+---
+SHA1:
+  metadata.gz: 8223d210369cfbaa74f8f4f75bc792e6a17d3833
+  data.tar.gz: 4868fd15abcdcbd37a82fcbbeb5b0bccd6e6fced
+SHA512:
+  metadata.gz: f7f95896a2a50d03aed6270c86556366135832645afa62401ec4d03d96597d6e1314e9cded000138c0739af1f42e5a40782f8d036d9f5bd70840d10da1423f8f
+  data.tar.gz: 9b7009d9864e1317276322be0c1f01155d9239bf5b764bb6e11e92a707e674745636c7b5d8e85c7251602b5e7436aebcecbcb685e8e0f7fff72af45168a1b858

data/Gemfile

@@ -7,3 +7,5 @@ gem 'appraisal', :group => :development
 
 gem "jeweler", :group => :development
 gem "bundler", :group => :development
+
+gem "minitest", "~> 4.0"

data/Gemfile.lock

@@ -78,4 +78,5 @@ DEPENDENCIES
   appraisal
   bundler
   jeweler
+  minitest (~> 4.0)
   sqlite3

data/VERSION

@@ -1 +1 @@
-0.1.0
+0.2.0

data/gemfiles/rails_4.1.0.gemfile

@@ -0,0 +1,10 @@
+# This file was generated by Appraisal
+
+source "https://rubygems.org"
+
+gem "sqlite3", :group=>:development
+gem "appraisal", :group=>:development
+gem "jeweler", :group=>:development
+gem "bundler", :group=>:development
+gem "activerecord", "4.1.0"
+

data/gemfiles/rails_4.1.0.gemfile.lock

@@ -0,0 +1,81 @@
+GEM
+  remote: https://rubygems.org/
+  specs:
+    activemodel (4.0.1)
+      activesupport (= 4.0.1)
+      builder (~> 3.1.0)
+    activerecord (4.0.1)
+      activemodel (= 4.0.1)
+      activerecord-deprecated_finders (~> 1.0.2)
+      activesupport (= 4.0.1)
+      arel (~> 4.0.0)
+    activerecord-deprecated_finders (1.0.3)
+    activesupport (4.0.1)
+      i18n (~> 0.6, >= 0.6.4)
+      minitest (~> 4.2)
+      multi_json (~> 1.3)
+      thread_safe (~> 0.1)
+      tzinfo (~> 0.3.37)
+    addressable (2.3.5)
+    appraisal (0.5.2)
+      bundler
+      rake
+    arel (4.0.1)
+    atomic (1.1.14)
+    builder (3.1.4)
+    faraday (0.8.8)
+      multipart-post (~> 1.2.0)
+    git (1.2.6)
+    github_api (0.10.1)
+      addressable
+      faraday (~> 0.8.1)
+      hashie (>= 1.2)
+      multi_json (~> 1.4)
+      nokogiri (~> 1.5.2)
+      oauth2
+    hashie (2.0.5)
+    highline (1.6.20)
+    httpauth (0.2.0)
+    i18n (0.6.5)
+    jeweler (1.8.8)
+      builder
+      bundler (~> 1.0)
+      git (>= 1.2.5)
+      github_api (= 0.10.1)
+      highline (>= 1.6.15)
+      nokogiri (= 1.5.10)
+      rake
+      rdoc
+    json (1.8.1)
+    jwt (0.1.8)
+      multi_json (>= 1.5)
+    minitest (4.7.5)
+    multi_json (1.8.2)
+    multi_xml (0.5.5)
+    multipart-post (1.2.0)
+    nokogiri (1.5.10)
+    oauth2 (0.9.2)
+      faraday (~> 0.8)
+      httpauth (~> 0.2)
+      jwt (~> 0.1.4)
+      multi_json (~> 1.0)
+      multi_xml (~> 0.5)
+      rack (~> 1.2)
+    rack (1.5.2)
+    rake (10.1.0)
+    rdoc (4.0.1)
+      json (~> 1.4)
+    sqlite3 (1.3.8)
+    thread_safe (0.1.3)
+      atomic
+    tzinfo (0.3.38)
+
+PLATFORMS
+  ruby
+
+DEPENDENCIES
+  activerecord (= 4.0.1)
+  appraisal
+  bundler
+  jeweler
+  sqlite3

data/lib/store_base_sti_class.rb

@@ -4,6 +4,8 @@ if ActiveRecord::VERSION::STRING =~ /^3\.0/
   require 'store_base_sti_class_for_3_0'
 elsif ActiveRecord::VERSION::STRING =~ /^3\.(1|2)/
   require 'store_base_sti_class_for_3_1_and_above'
-elsif ActiveRecord::VERSION::STRING =~ /^4/
+elsif ActiveRecord::VERSION::STRING =~ /^4\.0/
   require 'store_base_sti_class_for_4_0'
+elsif ActiveRecord::VERSION::STRING =~ /^4\.1/
+  require 'store_base_sti_class_for_4_1'
 end

data/lib/store_base_sti_class_for_4_0.rb

@@ -1,6 +1,6 @@
 require 'active_record'
 
-if ActiveRecord::VERSION::STRING =~ /^4/
+if ActiveRecord::VERSION::STRING =~ /^4\.0/
   module ActiveRecord
 
     class Base

data/lib/store_base_sti_class_for_4_1.rb

@@ -0,0 +1,351 @@
+require 'active_record/associations/join_dependency/join_part'
+
+if ActiveRecord::VERSION::STRING =~ /^4\.1/
+  module ActiveRecord
+
+    class Base
+      class_attribute :store_base_sti_class
+      self.store_base_sti_class = true
+    end
+
+    module Associations
+      class Association
+
+        def creation_attributes
+          attributes = {}
+
+          if (reflection.macro == :has_one || reflection.macro == :has_many) && !options[:through]
+            attributes[reflection.foreign_key] = owner[reflection.active_record_primary_key]
+
+            if reflection.options[:as]
+              # START PATCH
+              # original:
+              # attributes[reflection.type] = owner.class.base_class.name
+
+              attributes[reflection.type] = ActiveRecord::Base.store_base_sti_class ? owner.class.base_class.name : owner.class.name
+
+              # END PATCH
+            end
+          end
+
+          attributes
+        end
+
+      end
+
+      class JoinDependency # :nodoc:
+        class JoinAssociation < JoinPart # :nodoc:
+
+          def add_constraints(scope, owner, assoc_klass, refl, tracker)
+            chain = refl.chain
+            scope_chain = refl.scope_chain
+
+            tables = construct_tables(chain, assoc_klass, refl, tracker)
+
+            chain.each_with_index do |reflection, i|
+              table, foreign_table = tables.shift, tables.first
+
+              if reflection.source_macro == :belongs_to
+                if reflection.options[:polymorphic]
+                  key = reflection.association_primary_key(assoc_klass)
+                else
+                  key = reflection.association_primary_key
+                end
+
+                foreign_key = reflection.foreign_key
+              else
+                key         = reflection.foreign_key
+                foreign_key = reflection.active_record_primary_key
+              end
+
+              if reflection == chain.last
+                bind_val = bind scope, table.table_name, key.to_s, owner[foreign_key], tracker
+                scope    = scope.where(table[key].eq(bind_val))
+
+                if reflection.type
+                  # START PATCH
+                  # original: value = owner.class.base_class.name
+
+                  unless ActiveRecord::Base.store_base_sti_class
+                    value = owner.class.name
+                  else
+                    value = owner.class.base_class.name
+                  end
+
+                  # END PATCH
+
+                  bind_val = bind scope, table.table_name, reflection.type.to_s, value, tracker
+                  scope    = scope.where(table[reflection.type].eq(bind_val))
+                end
+              else
+                constraint = table[key].eq(foreign_table[foreign_key])
+
+                if reflection.type
+                  # START PATCH
+                  # original: type = chain[i + 1].klass.base_class.name
+                  #           constraint = constraint.and(table[reflection.type].eq(type))
+
+                  if ActiveRecord::Base.store_base_sti_class
+                    type = chain[i + 1].klass.base_class.name
+                    constraint = constraint.and(table[reflection.type].eq(type))
+                  else
+                    klass = chain[i + 1].klass
+                    constraint = constraint.and(table[reflection.type].in(([klass] + klass.descendants).map(&:name)))
+                  end
+
+                  # END PATCH
+                end
+
+                scope = scope.joins(join(foreign_table, constraint))
+              end
+
+              is_first_chain = i == 0
+              klass = is_first_chain ? assoc_klass : reflection.klass
+
+              # Exclude the scope of the association itself, because that
+              # was already merged in the #scope method.
+              scope_chain[i].each do |scope_chain_item|
+                item  = eval_scope(klass, scope_chain_item, owner)
+
+                if scope_chain_item == refl.scope
+                  scope.merge! item.except(:where, :includes, :bind)
+                end
+
+                if is_first_chain
+                  scope.includes! item.includes_values
+                end
+
+                scope.where_values += item.where_values
+                scope.order_values |= item.order_values
+              end
+            end
+
+            scope
+          end
+        end
+      end
+
+
+      class BelongsToPolymorphicAssociation < BelongsToAssociation #:nodoc:
+
+        private
+
+        def replace_keys(record)
+          super
+
+          # START PATCH
+          # original: owner[reflection.foreign_type] = record && record.class.base_class.name
+
+          unless ActiveRecord::Base.store_base_sti_class
+            owner[reflection.foreign_type] = record && record.class.sti_name
+          else
+            owner[reflection.foreign_type] = record && record.class.base_class.name
+          end
+
+          #END PATCH
+        end
+      end
+    end
+
+    module Associations
+      class Preloader
+        class Association
+          private
+
+          def build_scope
+            scope = klass.unscoped
+
+            values         = reflection_scope.values
+            preload_values = preload_scope.values
+
+            scope.where_values      = Array(values[:where])      + Array(preload_values[:where])
+            scope.references_values = Array(values[:references]) + Array(preload_values[:references])
+
+            scope.select!   preload_values[:select] || values[:select] || table[Arel.star]
+            scope.includes! preload_values[:includes] || values[:includes]
+
+            if options[:as]
+              scope.where!(klass.table_name => {
+
+                  #START PATCH
+                  #original: reflection.type => model.base_class.sti_name
+
+                  reflection.type => ActiveRecord::Base.store_base_sti_class ? model.base_class.sti_name : model.sti_name
+
+                  #END PATCH
+              })
+            end
+
+            scope
+          end
+        end
+
+        module ThroughAssociation
+          def through_scope
+            through_scope = through_reflection.klass.unscoped
+
+            if options[:source_type]
+              #START PATCH
+              #original: through_scope.where! reflection.foreign_type => options[:source_type]
+
+              through_scope.where! reflection.foreign_type => ([options[:source_type].constantize] + options[:source_type].constantize.descendants).map(&:to_s)
+
+              #END PATCH
+            else
+              unless reflection_scope.where_values.empty?
+                through_scope.includes_values = Array(reflection_scope.values[:includes] || options[:source])
+                through_scope.where_values    = reflection_scope.values[:where]
+              end
+
+              through_scope.references! reflection_scope.values[:references]
+              through_scope.order! reflection_scope.values[:order] if through_scope.eager_loading?
+            end
+
+            through_scope
+          end
+        end
+      end
+
+      class AssociationScope
+        def add_constraints(scope, owner, assoc_klass, refl, tracker)
+          chain = refl.chain
+          scope_chain = refl.scope_chain
+
+          tables = construct_tables(chain, assoc_klass, refl, tracker)
+
+          chain.each_with_index do |reflection, i|
+            table, foreign_table = tables.shift, tables.first
+
+            if reflection.source_macro == :has_and_belongs_to_many
+              join_table = tables.shift
+
+              scope = scope.joins(join(
+                                      join_table,
+                                      table[reflection.association_primary_key].
+                                          eq(join_table[reflection.association_foreign_key])
+                                  ))
+
+              table, foreign_table = join_table, tables.first
+            end
+
+            if reflection.source_macro == :belongs_to
+              if reflection.options[:polymorphic]
+                key = reflection.association_primary_key(assoc_klass)
+              else
+                key = reflection.association_primary_key
+              end
+
+              foreign_key = reflection.foreign_key
+            else
+              key         = reflection.foreign_key
+              foreign_key = reflection.active_record_primary_key
+            end
+
+            if reflection == chain.last
+              bind_val = bind scope, table.table_name, key.to_s, owner[foreign_key], tracker
+              scope    = scope.where(table[key].eq(bind_val))
+
+              if reflection.type
+                # # START PATCH
+                # # original: value = owner.class.base_class.name
+
+                unless ActiveRecord::Base.store_base_sti_class
+                  value = owner.class.name
+                else
+                  value = owner.class.base_class.name
+                end
+
+                # END PATCH
+                bind_val = bind scope, table.table_name, reflection.type.to_s, value, tracker
+                scope    = scope.where(table[reflection.type].eq(bind_val))
+              end
+            else
+              constraint = table[key].eq(foreign_table[foreign_key])
+
+              if reflection.type
+                # START PATCH
+                # original: type = chain[i + 1].klass.base_class.name
+                #           constraint = constraint.and(table[reflection.type].eq(type))
+
+                if ActiveRecord::Base.store_base_sti_class
+                  type = chain[i + 1].klass.base_class.name
+                  constraint = constraint.and(table[reflection.type].eq(type))
+                else
+                  klass = chain[i + 1].klass
+                  constraint = constraint.and(table[reflection.type].in(([klass] + klass.descendants).map(&:name)))
+                end
+
+                bind_val = bind scope, table.table_name, reflection.type.to_s, value, tracker
+                scope    = scope.where(table[reflection.type].eq(bind_val))
+                # END PATCH
+              end
+
+              scope = scope.joins(join(foreign_table, constraint))
+            end
+
+            is_first_chain = i == 0
+            klass = is_first_chain ? assoc_klass : reflection.klass
+
+            # Exclude the scope of the association itself, because that
+            # was already merged in the #scope method.
+            scope_chain[i].each do |scope_chain_item|
+              item  = eval_scope(klass, scope_chain_item, owner)
+
+              if scope_chain_item == refl.scope
+                scope.merge! item.except(:where, :includes, :bind)
+              end
+
+              if is_first_chain
+                scope.includes! item.includes_values
+              end
+
+              scope.where_values += item.where_values
+              scope.order_values |= item.order_values
+            end
+          end
+
+          scope
+        end
+
+      end
+    end
+
+    module Reflection
+      class ThroughReflection < AssociationReflection
+
+        def scope_chain
+          @scope_chain ||= begin
+            scope_chain = source_reflection.scope_chain.map(&:dup)
+
+            # Add to it the scope from this reflection (if any)
+            scope_chain.first << scope if scope
+
+            through_scope_chain = through_reflection.scope_chain.map(&:dup)
+
+            if options[:source_type]
+              # START PATCH
+              # original:
+              # through_scope_chain.first <<
+              #   through_reflection.klass.where(foreign_type => options[:source_type])
+
+              unless ActiveRecord::Base.store_base_sti_class
+                through_scope_chain.first <<
+                    through_reflection.klass.where(foreign_type => ([options[:source_type].constantize] + options[:source_type].constantize.descendants).map(&:to_s))
+              else
+                through_scope_chain.first <<
+                    through_reflection.klass.where(foreign_type => options[:source_type])
+              end
+
+              # END PATCH
+            end
+
+            # Recursively fill out the rest of the array from the through reflection
+            scope_chain + through_scope_chain
+          end
+        end
+      end
+    end
+
+  end
+
+end

data/store_base_sti_class.gemspec

@@ -2,14 +2,16 @@
 # DO NOT EDIT THIS FILE DIRECTLY
 # Instead, edit Jeweler::Tasks in Rakefile, and run 'rake gemspec'
 # -*- encoding: utf-8 -*-
+# stub: store_base_sti_class 0.2.0 ruby lib
 
 Gem::Specification.new do |s|
   s.name = "store_base_sti_class"
-  s.version = "0.1.0"
+  s.version = "0.2.0"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
+  s.require_paths = ["lib"]
   s.authors = ["Andrew Mutz"]
-  s.date = "2013-11-28"
+  s.date = "2014-08-03"
   s.description = "\n    ActiveRecord has always stored the base class in polymorphic _type columns when using STI. This can have non-trivial\n    performance implications in certain cases. This gem adds 'store_base_sti_class' configuration options which controls\n    whether ActiveRecord will store the base class or the actual class. Default to true for backwards compatibility.\n  "
   s.email = "andrew.mutz@appfolio.com"
   s.extra_rdoc_files = [
@@ -110,10 +112,13 @@ Gem::Specification.new do |s|
     "gemfiles/rails_4.0.0.gemfile.lock",
     "gemfiles/rails_4.0.1.gemfile",
     "gemfiles/rails_4.0.1.gemfile.lock",
+    "gemfiles/rails_4.1.0.gemfile",
+    "gemfiles/rails_4.1.0.gemfile.lock",
     "lib/store_base_sti_class.rb",
     "lib/store_base_sti_class_for_3_0.rb",
     "lib/store_base_sti_class_for_3_1_and_above.rb",
     "lib/store_base_sti_class_for_4_0.rb",
+    "lib/store_base_sti_class_for_4_1.rb",
     "store_base_sti_class.gemspec",
     "test/connection.rb",
     "test/helper.rb",
@@ -123,21 +128,22 @@ Gem::Specification.new do |s|
   ]
   s.homepage = "http://github.com/appfolio/store_base_sti_class"
   s.licenses = ["MIT"]
-  s.require_paths = ["lib"]
-  s.rubygems_version = "1.8.23"
+  s.rubygems_version = "2.2.0"
   s.summary = "Modifies ActiveRecord 3.0.5 - 4.0.1 with the ability to store the actual class (instead of the base class) in polymorhic _type columns when using STI"
 
   if s.respond_to? :specification_version then
-    s.specification_version = 3
+    s.specification_version = 4
 
     if Gem::Version.new(Gem::VERSION) >= Gem::Version.new('1.2.0') then
       s.add_runtime_dependency(%q<activerecord>, [">= 0"])
+      s.add_runtime_dependency(%q<minitest>, ["~> 4.0"])
       s.add_development_dependency(%q<sqlite3>, [">= 0"])
       s.add_development_dependency(%q<appraisal>, [">= 0"])
       s.add_development_dependency(%q<jeweler>, [">= 0"])
       s.add_development_dependency(%q<bundler>, [">= 0"])
     else
       s.add_dependency(%q<activerecord>, [">= 0"])
+      s.add_dependency(%q<minitest>, ["~> 4.0"])
       s.add_dependency(%q<sqlite3>, [">= 0"])
       s.add_dependency(%q<appraisal>, [">= 0"])
       s.add_dependency(%q<jeweler>, [">= 0"])
@@ -145,6 +151,7 @@ Gem::Specification.new do |s|
     end
   else
     s.add_dependency(%q<activerecord>, [">= 0"])
+    s.add_dependency(%q<minitest>, ["~> 4.0"])
     s.add_dependency(%q<sqlite3>, [">= 0"])
     s.add_dependency(%q<appraisal>, [">= 0"])
     s.add_dependency(%q<jeweler>, [">= 0"])

metadata

@@ -1,98 +1,101 @@
 --- !ruby/object:Gem::Specification
 name: store_base_sti_class
 version: !ruby/object:Gem::Version
-  version: 0.1.0
-  prerelease: 
+  version: 0.2.0
 platform: ruby
 authors:
 - Andrew Mutz
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-11-28 00:00:00.000000000 Z
+date: 2014-08-03 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: minitest
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '4.0'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '4.0'
 - !ruby/object:Gem::Dependency
   name: sqlite3
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: appraisal
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: jeweler
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
-description: ! "\n    ActiveRecord has always stored the base class in polymorphic
-  _type columns when using STI. This can have non-trivial\n    performance implications
+description: "\n    ActiveRecord has always stored the base class in polymorphic _type
+  columns when using STI. This can have non-trivial\n    performance implications
   in certain cases. This gem adds 'store_base_sti_class' configuration options which
   controls\n    whether ActiveRecord will store the base class or the actual class.
   Default to true for backwards compatibility.\n  "
@@ -196,10 +199,13 @@ files:
 - gemfiles/rails_4.0.0.gemfile.lock
 - gemfiles/rails_4.0.1.gemfile
 - gemfiles/rails_4.0.1.gemfile.lock
+- gemfiles/rails_4.1.0.gemfile
+- gemfiles/rails_4.1.0.gemfile.lock
 - lib/store_base_sti_class.rb
 - lib/store_base_sti_class_for_3_0.rb
 - lib/store_base_sti_class_for_3_1_and_above.rb
 - lib/store_base_sti_class_for_4_0.rb
+- lib/store_base_sti_class_for_4_1.rb
 - store_base_sti_class.gemspec
 - test/connection.rb
 - test/helper.rb
@@ -209,30 +215,26 @@ files:
 homepage: http://github.com/appfolio/store_base_sti_class
 licenses:
 - MIT
+metadata: {}
 post_install_message: 
 rdoc_options: []
 require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
-  none: false
   requirements:
-  - - ! '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
-      segments:
-      - 0
-      hash: 183579664896740947
 required_rubygems_version: !ruby/object:Gem::Requirement
-  none: false
   requirements:
-  - - ! '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 1.8.23
+rubygems_version: 2.2.0
 signing_key: 
-specification_version: 3
+specification_version: 4
 summary: Modifies ActiveRecord 3.0.5 - 4.0.1 with the ability to store the actual
   class (instead of the base class) in polymorhic _type columns when using STI
 test_files: []