storage 0.3.2 → 0.3.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: debdbb389e3c318ff68a502dc87ac52fbd047894
-  data.tar.gz: 1857d2fa6a260d0862400d519d2ac0c34c4f1a51
+  metadata.gz: d0d83caa2e0340dd5a4c32e7c0959c915878cb92
+  data.tar.gz: 5ca85b4b43b9ea5f62dfd3f0fef6416ca6a81fe9
 SHA512:
-  metadata.gz: 8a1e73f719687b06f538a307b7caaa06ee3f598d44f0b2baa2e6f4c4233281e91235d6d426f2e90bf45479af58ee047f815e5eba82e30e7b5c314e904c240cce
-  data.tar.gz: 8338bc57f95931f7e6db01c5ae8ba0c8ee9d7339b38e0bb57fde7051afb2a4f68e8cc5554228d2b4b72f800fde66f0025e20cfc4b36846cfe3e9f74cf084267e
+  metadata.gz: 4d1a51dcaa5d1b0255112d1016c933f1bfb4a0eba94544edf9c00bbee0d3d9602077f316a19b3f5ad0bf1ea718e1c2543e8de11ca116d3c321176184ab88c1eb
+  data.tar.gz: e5ae7cc620bf92784a4c375d1ea2fdbc1d9678af32907ccf10bcfdb6b08ac01d4a58ff8b0e9e9201e08c8a32b052f369a97d0ffd5cd095125d52cbb475eb5dd3

data/.gitignore

@@ -2,4 +2,5 @@ tmp
 pkg
 *.gem
 *.log
-coverage
+coverage
+*.lock

data/Rakefile

@@ -1,5 +1,10 @@
-require "bundler"
-Bundler::GemHelper.install_tasks
+require "bundler/gem_tasks"
+require "rake/testtask"
 
-require "rspec/core/rake_task"
-RSpec::Core::RakeTask.new
+Rake::TestTask.new(:test) do |t|
+  t.libs << "test"
+  t.test_files = FileList["test/**/*_test.rb"]
+  t.warning = false
+end
+
+task :default => :test

data/lib/storage/config.rb

@@ -5,7 +5,7 @@ module Storage
       #
       #   Storage::Config.strategy = :s3
       #
-      attr_accessor :strategy
+      attr_reader :strategy
 
       # Set a storage class.
       #

data/lib/storage/strategies/file_system.rb

@@ -35,8 +35,6 @@ module Storage
         file = File.open(file, "rb") unless file.respond_to?(:read) && !file.kind_of?(Pathname)
         path = fullpath(options[:name])
 
-        raise Storage::FileAlreadyExistsError if File.file?(path)
-
         File.open(path, "wb") do |handler|
           while line = file.gets
             handler.write line

data/lib/storage/version.rb

@@ -2,7 +2,7 @@ module Storage
   module Version
     MAJOR = 0
     MINOR = 3
-    PATCH = 2
+    PATCH = 3
     STRING = "#{MAJOR}.#{MINOR}.#{PATCH}"
   end
 end

data/storage.gemspec

@@ -20,4 +20,7 @@ Gem::Specification.new do |s|
 
   s.add_development_dependency "rspec"
   s.add_development_dependency "pry-meta"
+  s.add_development_dependency "minitest-utils"
+  s.add_development_dependency "rake"
+  s.add_development_dependency "mocha"
 end

data/{spec/spec_helper.rb → test/test_helper.rb}

@@ -1,17 +1,28 @@
 require "bundler/setup"
-Bundler.require(:default, :development)
 
 require "storage"
 require "pathname"
 
+require "minitest/utils"
+require "minitest/autorun"
+require "mocha"
+require "mocha/mini_test"
+
 TMP = Pathname.new(File.expand_path(File.dirname(__FILE__) + "/tmp"))
 RESOURCES = Pathname.new(File.expand_path(File.dirname(__FILE__) + "/resources"))
 
-RSpec.configure do |config|
-  cleaner = proc do
+class Minitest::Test
+  setup do
     FileUtils.rm_rf(TMP) rescue nil
     FileUtils.mkdir_p(TMP) rescue nil
   end
+end
 
-  config.before(:each, &cleaner)
+class NullObject
+  def initialize(*)
+  end
+
+  def method_missing(*)
+    self
+  end
 end

data/test/unit/delegation_test.rb

@@ -0,0 +1,23 @@
+require "test_helper"
+
+class DelegationTest < Minitest::Test
+  setup do
+    @strategy = mock("strategy")
+    Storage.expects(:strategy).returns(@strategy)
+  end
+
+  test "delegate save method" do
+    @strategy.expects(:store).with("some/file")
+    Storage.store "some/file"
+  end
+
+  test "delegate destroy method" do
+    @strategy.expects(:remove).with("some/file")
+    Storage.remove "some/file"
+  end
+
+  test "delegate get method" do
+    @strategy.expects(:get).with("some/file")
+    Storage.get "some/file"
+  end
+end

data/test/unit/file_system_strategy_test.rb

@@ -0,0 +1,52 @@
+require "test_helper"
+
+class FileSystemStrategyTest < Minitest::Test
+  let(:source) { RESOURCES.join("file.txt") }
+  let(:destiny) { TMP.join("lorem.txt") }
+
+  setup do
+    Storage.setup do |c|
+      c.strategy = :file
+      c.path = TMP
+    end
+  end
+
+  test "saves a file using file handler" do
+    handler = File.open(source)
+    Storage.store(handler, name: "lorem.txt")
+
+    assert File.file?(destiny)
+    assert_equal File.read(source), File.read(destiny)
+  end
+
+  test "save a file using a path" do
+    Storage.store(source, name: "lorem.txt")
+
+    assert File.file?(destiny)
+    assert_equal File.read(source), File.read(destiny)
+  end
+
+  test "remove an existing file" do
+    Storage.store(source, name: "lorem.txt")
+
+    assert Storage.remove("lorem.txt")
+    refute File.file?(destiny)
+  end
+
+  test "raise when trying to removing an unexesting file" do
+    assert_raises(Storage::MissingFileError) {
+      Storage.remove("invalid")
+    }
+  end
+
+  test "retrieve an existing file" do
+    Storage.store(source, name: "lorem.txt")
+    assert_equal File.expand_path(TMP.join("lorem.txt")), Storage.get("lorem.txt")
+  end
+
+  test "raise when trying to retrieve an unexesting file" do
+    assert_raises(Storage::MissingFileError) {
+      Storage.get("invalid")
+    }
+  end
+end

data/test/unit/s3_strategy_test.rb

@@ -0,0 +1,192 @@
+require "test_helper"
+
+module S3StrategyTest
+  class RegionTest < Minitest::Test
+    setup do
+      Storage.setup do |c|
+        c.strategy = :s3
+        c.access_key = "AKIAIOSFODNN7EXAMPLE"
+        c.secret_key = "wJalrXUtnFEMI/K7MDENG/bPxRfiCYEXAMPLEKEY"
+      end
+    end
+
+    test "sets default region" do
+      Storage::Config.region = nil
+      assert_equal "us-east-1", Storage::Strategies::S3.connection.region
+    end
+
+    test "sets custom region" do
+      Storage::Config.region = "eu-west-1"
+      assert_equal "eu-west-1", Storage::Strategies::S3.connection.region
+    end
+  end
+
+  class GeneralTest < Minitest::Test
+    let(:adapter) { Storage::Strategies::S3 }
+    let(:source) { RESOURCES.join("file.txt") }
+    let(:destiny) { TMP.join("lorem.txt") }
+    let(:connection) { mock("connection") }
+    let(:bucket) { mock("bucket") }
+
+    setup do
+      adapter.stubs(:connection).returns(connection)
+
+      Storage.setup do |c|
+        c.strategy = :s3
+        c.access_key = "abc"
+        c.secret_key = "123"
+        c.region = "us-east-1"
+      end
+    end
+
+    test "saves a file using file handler" do
+      handler = File.open(source)
+      setup_create_object
+
+      Storage.store(handler, name: "lorem.txt", bucket: "files")
+    end
+
+    test "saves a file using a path" do
+      setup_create_object
+      Storage.store(source, name: "lorem.txt", bucket: "files")
+    end
+
+    test "removes an existing file" do
+      object = mock("object")
+
+      setup_get_object object: object
+      object.expects(:destroy).returns(true)
+
+      assert Storage.remove("lorem.txt", bucket: "files")
+    end
+
+    test "raises when trying to removing an nonexisting file" do
+      setup_get_object object: nil
+
+      assert_raises(Storage::MissingFileError) {
+        Storage.remove("lorem.txt", bucket: "files")
+      }
+    end
+
+    test "retrieves an existing file (public url)" do
+      object = mock("object", public_url: "PUBLIC_URL")
+
+      setup_get_object object: object
+
+      assert_equal "PUBLIC_URL", Storage.get("lorem.txt", bucket: "files")
+    end
+
+    test "retrieves an existing file with default expiration [private url]" do
+      Time.stubs(:now).returns(Time.now)
+
+      object = mock("object", public_url: nil)
+      object.expects(:url).with(Time.now.to_i + 3600).returns("PRIVATE_URL")
+
+      Storage::Strategies::S3.stubs(:find_object).returns(object)
+
+      assert_equal "PRIVATE_URL", Storage.get("lorem.txt", bucket: "files")
+    end
+
+    test "retrieves an existing file with custom expiration [private url]" do
+      Time.stubs(:now).returns(Time.now)
+
+      object = mock("object", public_url: nil)
+      object.expects(:url).with(Time.now.to_i + 60).returns("PRIVATE_URL")
+
+      Storage::Strategies::S3.stubs(:find_object).returns(object)
+
+      private_url = Storage.get("lorem.txt",
+                                bucket: "files",
+                                expires: Time.now.to_i + 60)
+
+      assert_equal "PRIVATE_URL", private_url
+    end
+
+    test "raises when trying to retrieve an missing file" do
+      setup_get_object object: nil
+
+      assert_raises(Storage::MissingFileError) {
+        Storage.get("lorem.txt", bucket: "files")
+      }
+    end
+
+    test "raises when trying to retrieve an missing bucket" do
+      setup_get_bucket bucket: nil
+
+      assert_raises(Storage::MissingFileError) {
+        Storage.get("lorem.txt", bucket: "files")
+      }
+    end
+
+    test "creates a bucket when trying to store a file on a missing bucket" do
+      null_object = NullObject.new
+      bucket.stubs(:files).returns(null_object)
+      setup_create_bucket
+
+      Storage.store(source, name: "lorem.txt", bucket: "files")
+    end
+
+    test "sets file permission to public" do
+      setup_create_object public: true
+      Storage.store(source, name: "lorem.txt", bucket: "files", public: true)
+    end
+
+    test "sets file permission to private (default)" do
+      setup_create_object public: false
+      Storage.store(source, name: "lorem.txt", bucket: "files")
+    end
+
+    test "sets file permission to private" do
+      setup_create_object public: false
+      Storage.store(source, name: "lorem.txt", bucket: "files", public: false)
+    end
+
+    test "sets file permission to private (access option)" do
+      setup_create_object public: false
+      Storage.store(source, name: "lorem.txt", bucket: "files", access: :private)
+    end
+
+    test "sets file permission to public (access option)" do
+      setup_create_object public: true
+      Storage.store(source, name: "lorem.txt", bucket: "files", access: :public_read)
+    end
+
+    def setup_create_object(bucket: self.bucket, object: nil, public: false, file_name: "lorem.txt")
+      # 1. first find bucket.
+      setup_get_bucket(bucket: bucket)
+
+      # 2. create file
+      params = {key: file_name, body: instance_of(File), public: public}
+
+      files = stub("files")
+      files.expects(:create).with(has_entries(params)).returns(object)
+      bucket.stubs(:files).returns(files)
+    end
+
+    def setup_get_object(bucket: self.bucket, file_name: "lorem.txt", object: nil)
+      # 1. Set up connection.directories.get
+      setup_get_bucket(bucket: bucket)
+
+      # 2. Set up bucket.files.get
+      files = stub("files")
+      files.expects(:get).with(file_name).returns(object)
+      bucket.expects(:files).returns(files)
+    end
+
+    def setup_create_bucket(bucket: nil)
+      get = stub("get")
+      get.expects(:get).with("files").returns(bucket)
+
+      create = stub("create")
+      create.expects(:create).with(key: "files", public: false).returns(self.bucket)
+
+      connection.stubs(:directories).returns(get, create)
+    end
+
+    def setup_get_bucket(bucket: self.bucket)
+      dir = stub("directories")
+      dir.expects(:get).with("files").returns(bucket)
+      connection.expects(:directories).at_least_once.returns(dir)
+    end
+  end
+end

data/test/unit/storage_test.rb

@@ -0,0 +1,34 @@
+require "test_helper"
+
+class StorageTest < Minitest::Test
+  test "returns the strategy" do
+    strategy = mock("strategy")
+    Storage::Config.strategy_class = strategy
+
+    assert_equal strategy, Storage.strategy
+  end
+
+  test "returns the config" do
+    Storage::Strategies::S3.stubs(:prepare!)
+    config = nil
+
+    Storage.setup do |actual_config|
+      actual_config.strategy = :s3
+      config = actual_config
+    end
+
+    assert_equal Storage::Config, config
+  end
+
+  test "sets strategy class based on its name" do
+    Storage::Config.strategy_class = nil
+    Storage::Config.strategy = :s3
+
+    assert_equal Storage::Strategies::S3, Storage::Config.strategy_class
+  end
+
+  test "prepares strategy after setting its configuration" do
+    Storage::Strategies::S3.expects(:prepare!).once
+    Storage.setup {|config| config.strategy = :s3 }
+  end
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: storage
 version: !ruby/object:Gem::Version
-  version: 0.3.2
+  version: 0.3.3
 platform: ruby
 authors:
 - Nando Vieira
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-03-03 00:00:00.000000000 Z
+date: 2016-03-11 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: fog
@@ -66,6 +66,48 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: minitest-utils
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: rake
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: mocha
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 description: 'This gem provides a simple API for multiple storage backends. Supported
   storages: Amazon S3 and FileSystem.'
 email:
@@ -77,7 +119,6 @@ files:
 - ".gitignore"
 - ".rspec"
 - Gemfile
-- Gemfile.lock
 - README.md
 - Rakefile
 - lib/storage.rb
@@ -87,12 +128,13 @@ files:
 - lib/storage/strategies/file_system.rb
 - lib/storage/strategies/s3.rb
 - lib/storage/version.rb
-- spec/resources/file.txt
-- spec/spec_helper.rb
-- spec/storage/strategies/file_system_spec.rb
-- spec/storage/strategies/s3_spec.rb
-- spec/storage_spec.rb
 - storage.gemspec
+- test/resources/file.txt
+- test/test_helper.rb
+- test/unit/delegation_test.rb
+- test/unit/file_system_strategy_test.rb
+- test/unit/s3_strategy_test.rb
+- test/unit/storage_test.rb
 homepage: http://github.com/fnando/storage
 licenses: []
 metadata: {}
@@ -118,8 +160,9 @@ specification_version: 4
 summary: 'This gem provides a simple API for multiple storage backends. Supported
   storages: Amazon S3 and FileSystem.'
 test_files:
-- spec/resources/file.txt
-- spec/spec_helper.rb
-- spec/storage/strategies/file_system_spec.rb
-- spec/storage/strategies/s3_spec.rb
-- spec/storage_spec.rb
+- test/resources/file.txt
+- test/test_helper.rb
+- test/unit/delegation_test.rb
+- test/unit/file_system_strategy_test.rb
+- test/unit/s3_strategy_test.rb
+- test/unit/storage_test.rb

data/Gemfile.lock

@@ -1,185 +0,0 @@
-PATH
-  remote: .
-  specs:
-    storage (0.3.2)
-      fog
-      mime-types
-
-GEM
-  remote: https://rubygems.org/
-  specs:
-    CFPropertyList (2.3.2)
-    awesome_print (1.6.1)
-    builder (3.2.2)
-    byebug (8.2.2)
-    coderay (1.1.1)
-    diff-lcs (1.2.5)
-    excon (0.47.0)
-    fission (0.5.0)
-      CFPropertyList (~> 2.2)
-    fog (1.37.0)
-      fog-aliyun (>= 0.1.0)
-      fog-atmos
-      fog-aws (>= 0.6.0)
-      fog-brightbox (~> 0.4)
-      fog-core (~> 1.32)
-      fog-dynect (~> 0.0.2)
-      fog-ecloud (~> 0.1)
-      fog-google (<= 0.1.0)
-      fog-json
-      fog-local
-      fog-powerdns (>= 0.1.1)
-      fog-profitbricks
-      fog-radosgw (>= 0.0.2)
-      fog-riakcs
-      fog-sakuracloud (>= 0.0.4)
-      fog-serverlove
-      fog-softlayer
-      fog-storm_on_demand
-      fog-terremark
-      fog-vmfusion
-      fog-voxel
-      fog-vsphere (>= 0.4.0)
-      fog-xenserver
-      fog-xml (~> 0.1.1)
-      ipaddress (~> 0.5)
-    fog-aliyun (0.1.0)
-      fog-core (~> 1.27)
-      fog-json (~> 1.0)
-      ipaddress (~> 0.8)
-      xml-simple (~> 1.1)
-    fog-atmos (0.1.0)
-      fog-core
-      fog-xml
-    fog-aws (0.8.1)
-      fog-core (~> 1.27)
-      fog-json (~> 1.0)
-      fog-xml (~> 0.1)
-      ipaddress (~> 0.8)
-    fog-brightbox (0.10.1)
-      fog-core (~> 1.22)
-      fog-json
-      inflecto (~> 0.0.2)
-    fog-core (1.36.0)
-      builder
-      excon (~> 0.45)
-      formatador (~> 0.2)
-    fog-dynect (0.0.2)
-      fog-core
-      fog-json
-      fog-xml
-    fog-ecloud (0.3.0)
-      fog-core
-      fog-xml
-    fog-google (0.1.0)
-      fog-core
-      fog-json
-      fog-xml
-    fog-json (1.0.2)
-      fog-core (~> 1.0)
-      multi_json (~> 1.10)
-    fog-local (0.2.1)
-      fog-core (~> 1.27)
-    fog-powerdns (0.1.1)
-      fog-core (~> 1.27)
-      fog-json (~> 1.0)
-      fog-xml (~> 0.1)
-    fog-profitbricks (0.0.5)
-      fog-core
-      fog-xml
-      nokogiri
-    fog-radosgw (0.0.5)
-      fog-core (>= 1.21.0)
-      fog-json
-      fog-xml (>= 0.0.1)
-    fog-riakcs (0.1.0)
-      fog-core
-      fog-json
-      fog-xml
-    fog-sakuracloud (1.7.5)
-      fog-core
-      fog-json
-    fog-serverlove (0.1.2)
-      fog-core
-      fog-json
-    fog-softlayer (1.1.0)
-      fog-core
-      fog-json
-    fog-storm_on_demand (0.1.1)
-      fog-core
-      fog-json
-    fog-terremark (0.1.0)
-      fog-core
-      fog-xml
-    fog-vmfusion (0.1.0)
-      fission
-      fog-core
-    fog-voxel (0.1.0)
-      fog-core
-      fog-xml
-    fog-vsphere (0.6.0)
-      fog-core
-      rbvmomi (~> 1.8)
-    fog-xenserver (0.2.3)
-      fog-core
-      fog-xml
-    fog-xml (0.1.2)
-      fog-core
-      nokogiri (~> 1.5, >= 1.5.11)
-    formatador (0.2.5)
-    inflecto (0.0.2)
-    ipaddress (0.8.3)
-    method_source (0.8.2)
-    mime-types (3.0)
-      mime-types-data (~> 3.2015)
-    mime-types-data (3.2016.0221)
-    mini_portile2 (2.0.0)
-    multi_json (1.11.2)
-    nokogiri (1.6.7.2)
-      mini_portile2 (~> 2.0.0.rc2)
-    pry (0.10.3)
-      coderay (~> 1.1.0)
-      method_source (~> 0.8.1)
-      slop (~> 3.4)
-    pry-byebug (3.3.0)
-      byebug (~> 8.0)
-      pry (~> 0.10)
-    pry-meta (0.0.10)
-      awesome_print
-      pry
-      pry-byebug
-      pry-remote
-    pry-remote (0.1.8)
-      pry (~> 0.9)
-      slop (~> 3.0)
-    rbvmomi (1.8.2)
-      builder
-      nokogiri (>= 1.4.1)
-      trollop
-    rspec (3.4.0)
-      rspec-core (~> 3.4.0)
-      rspec-expectations (~> 3.4.0)
-      rspec-mocks (~> 3.4.0)
-    rspec-core (3.4.3)
-      rspec-support (~> 3.4.0)
-    rspec-expectations (3.4.0)
-      diff-lcs (>= 1.2.0, < 2.0)
-      rspec-support (~> 3.4.0)
-    rspec-mocks (3.4.1)
-      diff-lcs (>= 1.2.0, < 2.0)
-      rspec-support (~> 3.4.0)
-    rspec-support (3.4.1)
-    slop (3.6.0)
-    trollop (2.1.2)
-    xml-simple (1.1.5)
-
-PLATFORMS
-  ruby
-
-DEPENDENCIES
-  pry-meta
-  rspec
-  storage!
-
-BUNDLED WITH
-   1.11.2

data/spec/storage/strategies/file_system_spec.rb

@@ -1,59 +0,0 @@
-require "spec_helper"
-
-describe Storage::Strategies::FileSystem do
-  before do
-    @source = RESOURCES.join("file.txt")
-    @destiny = TMP.join("lorem.txt")
-
-    Storage.setup do |c|
-      c.strategy = :file
-      c.path = TMP
-    end
-  end
-
-  it "should save a file using file handler" do
-    handler = File.open(@source)
-    Storage.store(handler, :name => "lorem.txt")
-
-    expect(File).to be_file(@destiny)
-    expect(File.read(@destiny)).to eq(File.read(@source))
-  end
-
-  it "should save a file using a path" do
-    Storage.store(@source, :name => "lorem.txt")
-
-    expect(File).to be_file(@destiny)
-    expect(File.read(@destiny)).to eq(File.read(@source))
-  end
-
-  it "should remove an existing file" do
-    Storage.store(@source, :name => "lorem.txt")
-    expect(Storage.remove("lorem.txt")).to be_truthy
-    expect(File).not_to be_file(@destiny)
-  end
-
-  it "should raise when trying to removing an unexesting file" do
-    expect {
-      Storage.remove("invalid")
-    }.to raise_error(Storage::MissingFileError)
-  end
-
-  it "should retrieve an existing file" do
-    Storage.store(@source, :name => "lorem.txt")
-    expect(Storage.get("lorem.txt")).to eq(File.expand_path(TMP.join("lorem.txt")))
-  end
-
-  it "should raise when trying to retrieve an unexesting file" do
-    expect {
-      Storage.get("invalid")
-    }.to raise_error(Storage::MissingFileError)
-  end
-
-  it "should raise when saving a file that already exists" do
-    Storage.store(@source, :name => "lorem.txt")
-
-    expect {
-      Storage.store(@source, :name => "lorem.txt")
-    }.to raise_error(Storage::FileAlreadyExistsError)
-  end
-end

data/spec/storage/strategies/s3_spec.rb

@@ -1,155 +0,0 @@
-require "spec_helper"
-
-describe Storage::Strategies::S3 do
-  context "region" do
-    before do
-      Storage.setup do |c|
-        c.strategy = :s3
-        c.access_key = "AKIAIOSFODNN7EXAMPLE"
-        c.secret_key = "wJalrXUtnFEMI/K7MDENG/bPxRfiCYEXAMPLEKEY"
-      end
-    end
-
-    it "sets default region" do
-      Storage::Config.region = nil
-      expect(Storage::Strategies::S3.connection.region).to eq("us-east-1")
-    end
-
-    it "sets custom region" do
-      Storage::Config.region = "eu-west-1"
-      expect(Storage::Strategies::S3.connection.region).to eq("eu-west-1")
-    end
-  end
-
-  context "general" do
-    let(:adapter) { Storage::Strategies::S3 }
-    let(:source) { RESOURCES.join("file.txt") }
-    let(:destiny) { TMP.join("lorem.txt") }
-    let(:connection) { double("connection") }
-    let(:bucket) { double("bucket") }
-
-    before do
-      allow(adapter).to receive(:connection).and_return(connection)
-
-      Storage.setup do |c|
-        c.strategy = :s3
-        c.access_key = "abc"
-        c.secret_key = "123"
-        c.region = "us-east-1"
-      end
-    end
-
-    it "should save a file using file handler" do
-      handler = File.open(source)
-      setup_create_object
-
-      Storage.store(handler, name: "lorem.txt", bucket: "files")
-    end
-
-    it "should save a file using a path" do
-      setup_create_object
-      Storage.store(source, name: "lorem.txt", bucket: "files")
-    end
-
-    it "should remove an existing file" do
-      object = double("object")
-
-      setup_get_object object: object
-      expect(object).to receive(:destroy).and_return(true)
-
-      expect(Storage.remove("lorem.txt", bucket: "files")).to be_truthy
-    end
-
-    it "should raise when trying to removing an nonexisting file" do
-      setup_get_object object: nil
-
-      expect {
-        Storage.remove("lorem.txt", bucket: "files")
-      }.to raise_error(Storage::MissingFileError)
-    end
-
-    it "should retrieve an existing file (public url)" do
-      object = double("object", public_url: "PUBLIC_URL")
-
-      setup_get_object object: object
-
-      expect(Storage.get("lorem.txt", bucket: "files")).to eq("PUBLIC_URL")
-    end
-
-    it "should retrieve an existing file (private url)" do
-      object = double("object", public_url: nil)
-
-      expect(object).to receive_message_chain("url").with(Time.now.to_i + 3600).and_return("PRIVATE_URL")
-      setup_get_object object: object
-
-      expect(Storage.get("lorem.txt", bucket: "files")).to eq("PRIVATE_URL")
-    end
-
-    it "should raise when trying to retrieve an missing file" do
-      setup_get_object object: nil
-
-      expect {
-        Storage.get("lorem.txt", bucket: "files")
-      }.to raise_error(Storage::MissingFileError)
-    end
-
-    it "should raise when trying to retrieve an missing bucket" do
-      setup_get_bucket bucket: nil
-
-      expect {
-        Storage.get("lorem.txt", bucket: "files")
-      }.to raise_error(Storage::MissingFileError)
-    end
-
-    it "should create a bucket when trying to store a file on a missing bucket" do
-      bucket.as_null_object
-      setup_create_bucket
-
-      Storage.store(source, name: "lorem.txt", bucket: "files")
-    end
-
-    it "should set file permission to public" do
-      setup_create_object public: true
-      Storage.store(source, name: "lorem.txt", bucket: "files", public: true)
-    end
-
-    it "should set file permission to private (default)" do
-      setup_create_object public: false
-      Storage.store(source, name: "lorem.txt", bucket: "files")
-    end
-
-    it "should set file permission to private" do
-      setup_create_object public: false
-      Storage.store(source, name: "lorem.txt", bucket: "files", public: false)
-    end
-
-    it "should set file permission to private (access option)" do
-      setup_create_object public: false
-      Storage.store(source, name: "lorem.txt", bucket: "files", access: :private)
-    end
-
-    it "should set file permission to public (access option)" do
-      setup_create_object public: true
-      Storage.store(source, name: "lorem.txt", bucket: "files", access: :public_read)
-    end
-
-    def setup_create_object(bucket: self.bucket, object: nil, public: false, file_name: "lorem.txt")
-      allow(connection).to receive_message_chain("directories.get").with("files").and_return(bucket)
-      expect(bucket).to receive_message_chain("files.create").with(key: file_name, body: kind_of(File), public: public)
-    end
-
-    def setup_get_object(bucket: self.bucket, file_name: "lorem.txt", object: nil)
-      expect(connection).to receive_message_chain("directories.get").with("files").and_return(bucket)
-      expect(bucket).to receive_message_chain("files.get").with(file_name).and_return(object)
-    end
-
-    def setup_create_bucket(bucket: nil)
-      allow(connection).to receive_message_chain("directories.get").with("files").and_return(bucket)
-      expect(connection).to receive_message_chain("directories.create").with(key: "files", public: false).and_return(self.bucket)
-    end
-
-    def setup_get_bucket(bucket: self.bucket)
-      allow(connection).to receive_message_chain("directories.get").with("files").and_return(bucket)
-    end
-  end
-end

data/spec/storage_spec.rb

@@ -1,53 +0,0 @@
-require "spec_helper"
-
-describe Storage do
-  it "should return the strategy" do
-    @strategy = double("strategy")
-    Storage::Config.strategy_class = @strategy
-
-    expect(Storage.strategy).to be(@strategy)
-  end
-
-  it "should return the config" do
-    allow(Storage::Strategies::S3).to receive :prepare!
-
-    Storage.setup do |config|
-      config.strategy = :s3
-      expect(config).to be(Storage::Config)
-    end
-  end
-
-  it "should set strategy class based on its name" do
-    Storage::Config.strategy_class = nil
-    Storage::Config.strategy = :s3
-
-    expect(Storage::Config.strategy_class).to eq(Storage::Strategies::S3)
-  end
-
-  it "prepare strategy after setting its configuration" do
-    expect(Storage::Strategies::S3).to receive(:prepare!).once
-    Storage.setup {|config| config.strategy = :s3}
-  end
-
-  context "delegation" do
-    before do
-      @strategy = double("strategy")
-      expect(Storage).to receive(:strategy).and_return(@strategy)
-    end
-
-    it "should delegate save method" do
-      expect(@strategy).to receive(:store).with("some/file")
-      Storage.store "some/file"
-    end
-
-    it "should delegate destroy method" do
-      expect(@strategy).to receive(:remove).with("some/file")
-      Storage.remove "some/file"
-    end
-
-    it "should delegate get method" do
-      expect(@strategy).to receive(:get).with("some/file")
-      Storage.get "some/file"
-    end
-  end
-end