stoplight 1.3.0 → 1.4.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 1129070df15d367423a8be3a21f9bd73bffc2c74
-  data.tar.gz: c98bfeffa3eddfac90367b7d6d15c308151eccd5
+  metadata.gz: e8f2a2c82dbcebacbd22a8e7c945ded26322e528
+  data.tar.gz: 499150fa4ddaa7280f609e9171ab3d01a5486c6e
 SHA512:
-  metadata.gz: 52f6543a523f1598c604198831b854e4efa112868417385ec45ba6b628138ea5abc05be0b0a95ee8601e7f01680f8f31a47d66aeb2ead79f588e30b1868ae459
-  data.tar.gz: 9df784bc02e745c8dd770c3126a34c37c9b283d5c9712b71f4260e8ed49888a28c9c7b8aa19c5a2001d039d2a2fea51c66dc467e6c7212e4fc9d3d286a0ef65e
+  metadata.gz: fb0064324bbfdf24238b17eb0d7f486981a1c327799441d0571549df292be4b5e0abf61a8d4697bceae3c7bca2c12f66cf6a6fc090349cb5592fb141c171dab1
+  data.tar.gz: 7cf937362b94a968b2ce0cd425e3cb7bf289f6c6708f5daa9386b4e06fedf493d736f9662fd878493894c9f5e1a39d35f0067bfeb06b134f962b6303c6d0e436

data/README.md

@@ -352,7 +352,7 @@ Stoplight::Light.default_notifiers += [notifier]
 
 #### Honeybadger
 
-Make sure you have [the Honeybadger gem][] (`~> 2.1`) installed before
+Make sure you have [the Honeybadger gem][] (`~> 2.5`) installed before
 configuring Stoplight.
 
 ``` rb

data/lib/stoplight.rb

@@ -1,6 +1,6 @@
 # coding: utf-8
 
-module Stoplight
+module Stoplight # rubocop:disable Style/Documentation
 end
 
 require 'stoplight/version'

data/lib/stoplight/data_store.rb

@@ -1,6 +1,6 @@
 # coding: utf-8
 
 module Stoplight
-  module DataStore
+  module DataStore # rubocop:disable Style/Documentation
   end
 end

data/lib/stoplight/data_store/base.rb

@@ -6,51 +6,51 @@ module Stoplight
     class Base
       # @return [Array<String>]
       def names
-        fail NotImplementedError
+        raise NotImplementedError
       end
 
       # @param _light [Light]
       # @return [Array(Array<Failure>, String)]
       def get_all(_light)
-        fail NotImplementedError
+        raise NotImplementedError
       end
 
       # @param _light [Light]
       # @return [Array<Failure>]
       def get_failures(_light)
-        fail NotImplementedError
+        raise NotImplementedError
       end
 
       # @param _light [Light]
       # @param _failure [Failure]
       # @return [Fixnum]
       def record_failure(_light, _failure)
-        fail NotImplementedError
+        raise NotImplementedError
       end
 
       # @param _light [Light]
       # @return [Array<Failure>]
       def clear_failures(_light)
-        fail NotImplementedError
+        raise NotImplementedError
       end
 
       # @param _light [Light]
       # @return [String]
       def get_state(_light)
-        fail NotImplementedError
+        raise NotImplementedError
       end
 
       # @param _light [Light]
       # @param _state [String]
       # @return [String]
       def set_state(_light, _state)
-        fail NotImplementedError
+        raise NotImplementedError
       end
 
       # @param _light [Light]
       # @return [String]
       def clear_state(_light)
-        fail NotImplementedError
+        raise NotImplementedError
       end
     end
   end

data/lib/stoplight/data_store/memory.rb

@@ -1,11 +1,15 @@
 # coding: utf-8
 
+require 'concurrent'
+
 module Stoplight
   module DataStore
     # @see Base
     class Memory < Base
       def initialize
-        @data = {}
+        @failures = Concurrent::Map.new { [] }
+        @states = Concurrent::Map.new { State::UNLOCKED }
+        @lock = Monitor.new
       end
 
       def names
@@ -17,23 +21,24 @@ module Stoplight
       end
 
       def get_failures(light)
-        all_failures[light.name] || []
+        all_failures[light.name]
       end
 
       def record_failure(light, failure)
-        failures = get_failures(light).unshift(failure).first(light.threshold)
-        all_failures[light.name] = failures
-        failures.size
+        @lock.synchronize do
+          n = light.threshold - 1
+          failures = get_failures(light).first(n).unshift(failure)
+          all_failures[light.name] = failures
+          failures.size
+        end
       end
 
       def clear_failures(light)
-        failures = get_failures(light)
         all_failures.delete(light.name)
-        failures
       end
 
       def get_state(light)
-        all_states[light.name] || State::UNLOCKED
+        all_states[light.name]
       end
 
       def set_state(light, state)
@@ -41,19 +46,17 @@ module Stoplight
       end
 
       def clear_state(light)
-        state = get_state(light)
         all_states.delete(light.name)
-        state
       end
 
       private
 
       def all_failures
-        @data['failures'] ||= {}
+        @failures
       end
 
       def all_states
-        @data['states'] ||= {}
+        @states
       end
     end
   end

data/lib/stoplight/failure.rb

@@ -4,7 +4,7 @@ require 'json'
 require 'time'
 
 module Stoplight
-  class Failure
+  class Failure # rubocop:disable Style/Documentation
     # @return [String]
     attr_reader :error_class
     # @return [String]

data/lib/stoplight/light.rb

@@ -1,7 +1,7 @@
 # coding: utf-8
 
 module Stoplight
-  class Light
+  class Light # rubocop:disable Style/Documentation
     include Runnable
 
     # @return [Array<Exception>]

data/lib/stoplight/light/runnable.rb

@@ -2,7 +2,7 @@
 
 module Stoplight
   class Light
-    module Runnable
+    module Runnable # rubocop:disable Style/Documentation
       # @return [String]
       def color
         failures, state = failures_and_state
@@ -43,7 +43,7 @@ module Stoplight
       end
 
       def run_red
-        fail Error::RedLight, name unless fallback
+        raise Error::RedLight, name unless fallback
         fallback.call(nil)
       end
 
@@ -57,16 +57,16 @@ module Stoplight
       end
 
       def not_blacklisted_error?(error)
-        blacklisted_errors.length > 0 &&
+        !blacklisted_errors.empty? &&
           blacklisted_errors.none? { |klass| error.is_a?(klass) }
       end
 
       def handle_error(error, on_failure)
-        fail error if whitelisted_errors.any? { |klass| error.is_a?(klass) }
-        fail error if not_blacklisted_error?(error)
+        raise error if whitelisted_errors.any? { |klass| error.is_a?(klass) }
+        raise error if not_blacklisted_error?(error)
         size = record_failure(error)
         on_failure.call(size, error) if on_failure
-        fail error unless fallback
+        raise error unless fallback
         fallback.call(error)
       end
 

data/lib/stoplight/notifier.rb

@@ -1,6 +1,6 @@
 # coding: utf-8
 
 module Stoplight
-  module Notifier
+  module Notifier # rubocop:disable Style/Documentation
   end
 end

data/lib/stoplight/notifier/base.rb

@@ -10,7 +10,7 @@ module Stoplight
       # @param _error [Exception, nil]
       # @return [String]
       def notify(_light, _from_color, _to_color, _error)
-        fail NotImplementedError
+        raise NotImplementedError
       end
     end
   end

data/lib/stoplight/notifier/generic.rb

@@ -2,7 +2,7 @@
 
 module Stoplight
   module Notifier
-    module Generic
+    module Generic # rubocop:disable Style/Documentation
       # @return [Proc]
       attr_reader :formatter
 
@@ -23,7 +23,7 @@ module Stoplight
       private
 
       def put(_message)
-        fail NotImplementedError
+        raise NotImplementedError
       end
     end
   end

data/lib/stoplight/version.rb

@@ -1,5 +1,5 @@
 # coding: utf-8
 
 module Stoplight
-  VERSION = Gem::Version.new('1.3.0')
+  VERSION = Gem::Version.new('1.4.0')
 end

data/spec/stoplight/light/runnable_spec.rb

@@ -91,7 +91,7 @@ RSpec.describe Stoplight::Light::Runnable do
       end
 
       context 'when the code is failing' do
-        let(:code_result) { fail error }
+        let(:code_result) { raise error }
 
         it 're-raises the error' do
           expect { subject.run }.to raise_error(error.class)

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: stoplight
 version: !ruby/object:Gem::Version
-  version: 1.3.0
+  version: 1.4.0
 platform: ruby
 authors:
 - Cameron Desautels
@@ -10,8 +10,22 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-01-28 00:00:00.000000000 Z
+date: 2016-03-01 00:00:00.000000000 Z
 dependencies:
+- !ruby/object:Gem::Dependency
+  name: concurrent-ruby
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.0'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.0'
 - !ruby/object:Gem::Dependency
   name: benchmark-ips
   requirement: !ruby/object:Gem::Requirement
@@ -130,14 +144,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '2.1'
+        version: '2.5'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '2.1'
+        version: '2.5'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
@@ -186,14 +200,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.36.0
+        version: 0.37.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.36.0
+        version: 0.37.0
 - !ruby/object:Gem::Dependency
   name: slack-notifier
   requirement: !ruby/object:Gem::Requirement
@@ -222,20 +236,6 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '0.8'
-- !ruby/object:Gem::Dependency
-  name: yard
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '0.8'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '0.8'
 description: An implementation of the circuit breaker pattern.
 email:
 - camdez@gmail.com
@@ -313,7 +313,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.5
+rubygems_version: 2.6.0
 signing_key: 
 specification_version: 4
 summary: Traffic control for code.
@@ -341,4 +341,3 @@ test_files:
 - spec/stoplight/state_spec.rb
 - spec/stoplight/version_spec.rb
 - spec/stoplight_spec.rb
-has_rdoc: