stockery 0.4.0 → 0.4.1

data/README.md

@@ -16,6 +16,7 @@ CLI Usage
       -q, --quotes 'comma separated'   Required, no default
       
       -h, --help 
+      -v, --version
 
 Example
 -------

data/Rakefile

@@ -4,8 +4,8 @@ require 'rubygems'
 require 'bundler'
 require 'rake'
 require 'jeweler'
-require 'rdoc/task'
-require 'rcov/rcovtask'
+# require 'rdoc/task'
+# require 'rcov/rcovtask'
 require 'rake/testtask'
 
 begin
@@ -34,20 +34,20 @@ Rake::TestTask.new(:test) do |test|
   test.verbose = true
 end
 
-Rcov::RcovTask.new do |test|
-  test.libs << 'test'
-  test.pattern = 'test/**/test_*.rb'
-  test.verbose = true
-  test.rcov_opts << '--exclude "gems/*"'
-end
+# Rcov::RcovTask.new do |test|
+#   test.libs << 'test'
+#   test.pattern = 'test/**/test_*.rb'
+#   test.verbose = true
+#   test.rcov_opts << '--exclude "gems/*"'
+# end
+
+# Rake::RDocTask.new do |rdoc|
+#   version = File.exist?('VERSION') ? File.read('VERSION') : ""
+# 
+#   rdoc.rdoc_dir = 'rdoc'
+#   rdoc.title = "Stockery #{version}"
+#   rdoc.rdoc_files.include('README*')
+#   rdoc.rdoc_files.include('lib/**/*.rb')
+# end
 
 task :default => :test
-
-Rake::RDocTask.new do |rdoc|
-  version = File.exist?('VERSION') ? File.read('VERSION') : ""
-
-  rdoc.rdoc_dir = 'rdoc'
-  rdoc.title = "Stockery #{version}"
-  rdoc.rdoc_files.include('README*')
-  rdoc.rdoc_files.include('lib/**/*.rb')
-end

data/VERSION

@@ -1 +1 @@
-0.4.0
+0.4.1

data/lib/stockery/quote.rb

@@ -24,7 +24,7 @@ module Stockery
     def print(stockery_data)
       printed = ""
 
-      unless stockery_data.empty?
+      unless stockery_data.nil? || stockery_data.empty?
         printed += "#{stockery_data[:name]} on #{stockery_data[:market]} @ #{stockery_data[:timestamp]}\n"
         # printed += " *** MARKET CLOSED ***\n" if Time.now.strftime("%H:%M") > "16:00"
         

data/lib/stockery/runner.rb

@@ -2,6 +2,8 @@ require 'optparse'
 
 module Stockery
   class Runner
+    attr_accessor :options
+
     def initialize(argv)
       @argv = argv
       
@@ -40,7 +42,7 @@ module Stockery
           puts "\n"
         end
       when 'json'
-        p JSON.generate(quotes_res)
+        puts JSON.generate(quotes_res)
       end
     end 
 

data/stockery.gemspec

@@ -5,11 +5,11 @@
 
 Gem::Specification.new do |s|
   s.name = "stockery"
-  s.version = "0.4.0"
+  s.version = "0.4.1"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.authors = ["Pieter Michels"]
-  s.date = "2011-09-23"
+  s.date = "2011-09-25"
   s.description = "Fetch stock quotes. Build as a gem and command line tool."
   s.email = "pieter@noort.be"
   s.executables = ["stockery"]
@@ -18,6 +18,7 @@ Gem::Specification.new do |s|
     "README.md"
   ]
   s.files = [
+    ".gemtest",
     "Gemfile",
     "LICENSE.txt",
     "README.md",
@@ -29,7 +30,8 @@ Gem::Specification.new do |s|
     "lib/stockery/runner.rb",
     "stockery.gemspec",
     "test/helper.rb",
-    "test/test_stockery.rb"
+    "test/test_quote.rb",
+    "test/test_runner.rb"
   ]
   s.homepage = "http://wellconsidered.be/post/10526511041/stockery-stock-quotes-rubygem"
   s.licenses = ["MIT"]

data/test/helper.rb

@@ -16,3 +16,13 @@ require 'stockery'
 
 class Test::Unit::TestCase
 end
+
+def silence_stream(stream)                                                                                                                                   
+  old_stream = stream.dup
+  stream.reopen(RUBY_PLATFORM =~ /mswin/ ? 'NUL:' : '/dev/null')
+  stream.sync = true                                                                                                                                         
+
+  yield                                                                                                                                                    
+ensure                                                                                                                                                       
+  stream.reopen(old_stream)                                                                                                                                  
+end

data/test/test_quote.rb

@@ -0,0 +1,40 @@
+require 'helper'
+
+class TestStockeryQuote < Test::Unit::TestCase
+  context "A Stockery::Quote instance" do
+    setup do
+      @stock = Stockery::Quote.new
+    end
+
+    should "have GOOGLE as default source" do
+       assert_equal @stock.source, "GOOGLE"
+    end
+
+    should "be able to switch sources" do
+      @stock.source = Stockery::YAHOO
+      assert_equal @stock.source, Stockery::YAHOO
+    end
+
+    should "return not nil when requesting a valid symbol" do
+      result = @stock.get_status("AAPL")
+      assert_not_nil result 
+    end
+
+    should "print out an 'error message' when sending an invalid stock data object" do
+      message = @stock.print(nil)
+      assert_equal message, "Stock data invalid or empty"
+    end
+
+    should "print out a quote message when sending stock data object" do
+      result = @stock.get_status("AAPL")
+      message = @stock.print(result)
+      assert message.length > 0
+    end
+
+    should "not print out an 'error message' when sending an valid stock data object" do
+      result = @stock.get_status("AAPL")
+      message = @stock.print(result)
+      assert_not_equal message, "Stock data invalid or empty"
+    end
+  end
+end

data/test/test_runner.rb

@@ -0,0 +1,47 @@
+require 'helper'
+require 'json'
+
+class TestStockeryRunner < Test::Unit::TestCase
+  context "A Stockery::Runner instance" do
+    setup do
+
+    end
+
+    should "parse its options" do
+      runner = Stockery::Runner.new(%w(-q AAPL -s YAHOO -o print))
+
+      assert_equal runner.options[:source], "YAHOO"
+      assert_equal runner.options[:quotes], "AAPL"
+      assert_equal runner.options[:output], "print"
+    end
+
+    # should "print the result as a json string by default" do
+    #   out = silence_stream(STDOUT) do
+    #     runner = Stockery::Runner.new(%w(-q AAPL))
+    #     runner.run!
+    #   end
+
+    #   puts out.to_s
+    #   json = JSON.parse(out.to_s)
+    #   # assert_match out.to_s, "/Quotes at/"
+    # end
+
+    # should "print the result when passing print output argument" do
+    #   out = silence_stream(STDOUT) do
+    #     runner = Stockery::Runner.new(%w(-q AAPL -o print))
+    #     runner.run!
+    #   end
+
+    #   assert_match out.to_s, "/Quotes at/"
+    # end
+
+    # should "print its version" do
+    #   out = silence_stream(STDOUT) do
+    #     runner = Stockery::Runner.new(%w(-v))
+    #     runner.run!
+    #   end
+
+    #   assert_equal out.to_s, Stockery::VERSION
+    # end
+  end
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: stockery
 version: !ruby/object:Gem::Version
-  version: 0.4.0
+  version: 0.4.1
   prerelease: 
 platform: ruby
 authors:
@@ -9,11 +9,11 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2011-09-23 00:00:00.000000000Z
+date: 2011-09-25 00:00:00.000000000Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: json
-  requirement: &2166331580 !ruby/object:Gem::Requirement
+  requirement: &2162930560 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -21,10 +21,10 @@ dependencies:
         version: '0'
   type: :runtime
   prerelease: false
-  version_requirements: *2166331580
+  version_requirements: *2162930560
 - !ruby/object:Gem::Dependency
   name: shoulda
-  requirement: &2166330980 !ruby/object:Gem::Requirement
+  requirement: &2162929560 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -32,10 +32,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *2166330980
+  version_requirements: *2162929560
 - !ruby/object:Gem::Dependency
   name: bundler
-  requirement: &2166330240 !ruby/object:Gem::Requirement
+  requirement: &2162928800 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -43,10 +43,10 @@ dependencies:
         version: 1.0.0
   type: :development
   prerelease: false
-  version_requirements: *2166330240
+  version_requirements: *2162928800
 - !ruby/object:Gem::Dependency
   name: jeweler
-  requirement: &2166329520 !ruby/object:Gem::Requirement
+  requirement: &2162927900 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -54,10 +54,10 @@ dependencies:
         version: 1.6.4
   type: :development
   prerelease: false
-  version_requirements: *2166329520
+  version_requirements: *2162927900
 - !ruby/object:Gem::Dependency
   name: rcov
-  requirement: &2166328920 !ruby/object:Gem::Requirement
+  requirement: &2162926940 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -65,10 +65,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *2166328920
+  version_requirements: *2162926940
 - !ruby/object:Gem::Dependency
   name: thoughtbot-shoulda
-  requirement: &2166328440 !ruby/object:Gem::Requirement
+  requirement: &2162925960 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -76,7 +76,7 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *2166328440
+  version_requirements: *2162925960
 description: Fetch stock quotes. Build as a gem and command line tool.
 email: pieter@noort.be
 executables:
@@ -86,6 +86,7 @@ extra_rdoc_files:
 - LICENSE.txt
 - README.md
 files:
+- .gemtest
 - Gemfile
 - LICENSE.txt
 - README.md
@@ -97,7 +98,8 @@ files:
 - lib/stockery/runner.rb
 - stockery.gemspec
 - test/helper.rb
-- test/test_stockery.rb
+- test/test_quote.rb
+- test/test_runner.rb
 homepage: http://wellconsidered.be/post/10526511041/stockery-stock-quotes-rubygem
 licenses:
 - MIT
@@ -113,7 +115,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: -3896205245751848673
+      hash: 3780466078473534277
 required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
   requirements:

data/test/test_stockery.rb

@@ -1,7 +0,0 @@
-require 'helper'
-
-class TestStocky < Test::Unit::TestCase
-  should "probably rename this file and start testing for real" do
-    flunk "hey buddy, you should probably rename this file and start testing for real"
-  end
-end