stockcruncher 1.1.1 → 1.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 1beb20ef59441b6227bd56d52cb1db85970c50be5cb909d3f631a97539897602
-  data.tar.gz: 96722ce534f031f40435958d4068a6212b0d4dd583840077423132d7b7349654
+  metadata.gz: 7bd12e5a6e5db6f83f239c1b6da9aca85931048dd427778ffb96f043e7334596
+  data.tar.gz: 48fe8efa593f30fe39c294725d7090c89a4a14413eaa59a1d6741c817fc02d64
 SHA512:
-  metadata.gz: 45ff2b03c7d1233717dd60a4030d376a56ac5eb59d01c89dd6600b77b886cabc79a250686c013ed74463bd4c357a056b75684395bf3bb66b89d2b3c49aeb04f7
-  data.tar.gz: c7945f2f156aae5f7140165bbeda8794ea9b8f72b56bd810e110ce93ebe0ce21f80cab80b516bcd9c73c4dcbeca6d6bd023581b57a01deff682b922c56a4aa55
+  metadata.gz: ad4ed352a8ed30d41edbe9c4bac03ba721c9af42837f9e94f9c14df2175013d4ae7a09e29c7076e034cf375abaf222ce04c251a4b8fde31ce10ae29936c18894
+  data.tar.gz: 06206e1a91e23706c6a83c02357b31064124a21e522f3144d4ec93d4d4e7863e82e38cf4b561eedb662e59ea801120ee05f8cd3fff1b414da5ea5a069dd337ff

data/CHANGELOG

@@ -11,3 +11,14 @@ Changelog
 
 - Add InfluxDB as database.
 - WIP for daily time serie.
+
+1.1.1
+-----
+
+- Rescue error on no data
+
+1.2.0
+-----
+
+- daily subcommand now recalculates missing data
+- daily subcommand also writes data to database

data/lib/stockcruncher/cli.rb

@@ -49,7 +49,7 @@ module StockCruncher
       config = YAML.load_file(opts['config'])
       cruncher = StockCruncher::AlphaVantage.new(config, opts['insecure'])
       raw_data = cruncher.crunch_daily(symbol, opts['full'])
-      # TODO: export to DB here
+      StockCruncher::InfluxDB.new(config).export_history(symbol, raw_data)
       puts raw_data unless opts['quiet']
     end
 

data/lib/stockcruncher/influxdb.rb

@@ -13,6 +13,38 @@ module StockCruncher
       @insecure = insecure
     end
 
+    # Method to calculate missing data (previousClose, change, changePercent)
+    def calculate_missing_data(hash)
+      keys = hash.keys
+      hash.each_with_index do |(date, v), index|
+        prevday = keys[index + 1]
+        next if prevday.nil?
+
+        prevclose = hash[prevday]['close']
+        hash[date] = v.merge(generate_missing_data(v['close'], prevclose))
+      end
+      hash
+    end
+
+    # Method to generate missing data
+    def generate_missing_data(current, previous)
+      {
+        'previousClose' => previous,
+        'change' => change(current.to_f, previous.to_f),
+        'changePercent' => change_percent(current.to_f, previous.to_f)
+      }
+    end
+
+    # Method to calculate change difference
+    def change(value, base)
+      (value - base).round(4).to_s
+    end
+
+    # Method to calculate percentage of change
+    def change_percent(value, base)
+      ((value / base - 1) * 100).round(4).to_s
+    end
+
     # Method to create a new hash from two arrays of keys and values
     def create_hash(descriptions, values)
       descriptions.split(',').zip(values.split(',')).to_h
@@ -31,8 +63,15 @@ module StockCruncher
     end
 
     # Method to export historical data to database
-    def export_history(raw)
-      # TODO: export whole history and calculated missing values
+    def export_history(symbol, raw)
+      raise StandardError, 'No data to export' if raw.match?(/Error Message/)
+
+      tags = { 'symbol' => symbol }
+      timeseries = prepare_daily_timeserie(raw)
+      timeseries = calculate_missing_data(timeseries)
+      timeseries.each_pair do |date, values|
+        write('daily', tags, values, date)
+      end
     end
 
     # Method to format and array of values into comma separated string
@@ -45,6 +84,19 @@ module StockCruncher
       string
     end
 
+    # Method to transform raw data to constructed hash
+    def prepare_daily_timeserie(data)
+      lines = data.split("\r\n")
+      desc = lines.shift.split(',').drop(1)
+      hash = {}
+      lines.each do |line|
+        values = line.split(',')
+        date = values.shift
+        hash[date] = desc.zip(values).to_h
+      end
+      hash
+    end
+
     # Method to send http post request
     def request(url, body)
       uri = URI.parse(url)

data/lib/stockcruncher/version.rb

@@ -2,5 +2,5 @@
 # frozen_string_literal: true
 
 module StockCruncher
-  VERSION = '1.1.1'
+  VERSION = '1.2.0'
 end

data/spec/stockcruncher/cli_spec.rb

@@ -5,6 +5,11 @@ require 'spec_helper'
 quote = 'symbol,open,high,low,price,volume,latestDay,previousClose,change,ch' \
         "angePercent\r\nSYM,100.0000,100.1000,99.9000,100.0000,4,2020-07-30," \
         "100.0000,0.0000,0.0000%\r\n"
+daily = "timestamp,open,high,low,close,volume\r\n2020-08-03,23.8500,24.6500," \
+        "23.7400,24.5500,3112972\r\n2020-07-31,24.0100,24.5100,23.5900,23.81" \
+        "00,5482485\r\n2020-07-30,24.4700,24.6600,23.5200,23.6600,6466738\r" \
+        "\n2020-07-29,24.7500,25.0300,24.0400,24.5600,4605804\r\n2020-07-28," \
+        "25.9900,26.0700,24.5100,24.7500,6904261\r\n"
 
 describe StockCruncher::CLI do # rubocop:disable Metrics/BlockLength
   context 'version' do
@@ -14,9 +19,15 @@ describe StockCruncher::CLI do # rubocop:disable Metrics/BlockLength
     end
   end
 
+  context 'daily NODATA -c spec/files/stockcruncher.yml' do
+    it 'Should not get any data and should fail.' do
+      expect { start(self) }.to raise_error(SystemExit)
+    end
+  end
+
   context 'daily SYM -c spec/files/stockcruncher.yml' do
     it 'Get the daily time serie for SYM.' do
-      expect { start(self) }.to output("{}\n").to_stdout
+      expect { start(self) }.to output(daily).to_stdout
     end
   end
 

data/spec/stockcruncher/stubs/servers_stubs.rb

@@ -5,20 +5,31 @@ require 'spec_helper'
 quote = 'symbol,open,high,low,price,volume,latestDay,previousClose,change,ch' \
         "angePercent\r\nSYM,100.0000,100.1000,99.9000,100.0000,4,2020-07-30," \
         "100.0000,0.0000,0.0000%\r\n"
+q_err = '{}'
+daily = "timestamp,open,high,low,close,volume\r\n2020-08-03,23.8500,24.6500," \
+        "23.7400,24.5500,3112972\r\n2020-07-31,24.0100,24.5100,23.5900,23.81" \
+        "00,5482485\r\n2020-07-30,24.4700,24.6600,23.5200,23.6600,6466738\r" \
+        "\n2020-07-29,24.7500,25.0300,24.0400,24.5600,4605804\r\n2020-07-28," \
+        "25.9900,26.0700,24.5100,24.7500,6904261\r\n"
+d_err = "{\n    \"Error Message\": \"Invalid API call.\"\n}"
 
 RSpec.configure do |config|
   config.before(:each) do
     # requests an API without extra arguments
     stub_request(:get, 'https://www.alphavantage.co/query?' \
       'function=GLOBAL_QUOTE&symbol=NODATA&apikey=demo&datatype=csv')
-      .to_return('status' => 200, 'body' => '{}', 'headers' => {})
+      .to_return('status' => 200, 'body' => q_err, 'headers' => {})
     stub_request(:get, 'https://www.alphavantage.co/query?' \
       'function=GLOBAL_QUOTE&symbol=SYM&apikey=demo&datatype=csv')
       .to_return('status' => 200, 'body' => quote, 'headers' => {})
+    stub_request(:get, 'https://www.alphavantage.co/query?' \
+      'function=TIME_SERIES_DAILY&symbol=NODATA&apikey=demo' \
+      '&datatype=csv&outputsize=compact')
+      .to_return('status' => 200, 'body' => d_err, 'headers' => {})
     stub_request(:get, 'https://www.alphavantage.co/query?' \
       'function=TIME_SERIES_DAILY&symbol=SYM&apikey=demo' \
       '&datatype=csv&outputsize=compact')
-      .to_return('status' => 200, 'body' => '{}', 'headers' => {})
+      .to_return('status' => 200, 'body' => daily, 'headers' => {})
     stub_request(:post, 'http://localhost:8086/write?db=test')
       .to_return('status' => 204, 'body' => '', 'headers' => {})
   end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: stockcruncher
 version: !ruby/object:Gem::Version
-  version: 1.1.1
+  version: 1.2.0
 platform: ruby
 authors:
 - Richard Delaplace
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-08-03 00:00:00.000000000 Z
+date: 2020-08-04 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler