stitches 5.1.0 → 5.1.1.RC1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 64bcd93b7810fda03ae7e4ca953c89c99668b010c17f27d0f9e7feadb7ab2c34
-  data.tar.gz: 78918e3342128184cddbe7ecaa5f71a72f906abdc9d5e0902be6f791ff84f6b9
+  metadata.gz: 8e0746344411dfb94b2390bb0a89ab7ec4027958b8d4a59f5ff279120610bf7a
+  data.tar.gz: 5641776831bf1c8fc82f43393d4dfaf6de61e5e35d76d1f56dbd3fa77d1affe7
 SHA512:
-  metadata.gz: 3143f65cf899576de9c7ce91df6ae17efb0f0d496804e99f45e4ef00223398d1aae0278c726cc7baecfc8cd8693dd6e614db1ab9a123e3790d670c37e96e4f5d
-  data.tar.gz: ca43fa742f06811c7c3b2bab50a539b8f022aa04fb46592baaa77a44e128ffb36db7deee302997c90e564d28ccd8c094a0fff26fbd3c4b94ede68f9f4b866f13
+  metadata.gz: e4654064ef560a5fab1e5fa0ff98740103e3aa0e707e86930958b1c487609ae3fd3e56649abd38ab2c38b6ca68ef8c8fc000d64f6c8a6f70a4b469aed13a98b6
+  data.tar.gz: 0dd65a08561bbd953c5811c64966dcf602743d4c949bf02e1d664b6a5fbbaee9ef52a07e0e8bca108020aaa645a48b72dc459428f805fe75cdb5c2c3d8cef888

data/lib/stitches/calling_service_middleware.rb

@@ -17,9 +17,8 @@ module Stitches
         header_name = Stitches.configuration.calling_service_header
         rack_key = "HTTP_#{header_name.upcase.tr('-', '_')}"
 
-        if (name = env[rack_key]).present?
-          env[client_key] = CallingServiceClient.new(name)
-        end
+        name = env[rack_key].presence || ""
+        env[client_key] = CallingServiceClient.new(name)
       end
 
       @app.call(env)

data/lib/stitches/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Stitches
-  VERSION = '5.1.0'
+  VERSION = '5.1.1.RC1'
 end

data/spec/api_key_middleware_spec.rb

@@ -45,7 +45,7 @@ RSpec.describe "/api/hellos", type: :request do
     it "does not look up information from the database" do
       execute_call
 
-      expect(response.body).to include "NameNotFound"
+      expect(response.body).to include "Hello ,"
       expect(response.body).to include "IdNotFound"
     end
 
@@ -315,7 +315,7 @@ RSpec.describe "/api/hellos", type: :request do
           it "does not save the api_client information used" do
             execute_call
 
-            expect(response.body).to include "NameNotFound"
+            expect(response.body).to include "Hello ,"
             expect(response.body).to include "IdNotFound"
           end
         end

data/spec/calling_service_middleware_spec.rb

@@ -37,18 +37,24 @@ describe Stitches::CallingServiceMiddleware do
     end
 
     context "when the header is absent and env var is not set" do
-      it "leaves the env var nil" do
+      it "sets a fallback CallingServiceClient with empty name" do
         _status, result_env, _body = middleware.call(env)
-        expect(result_env[client_key]).to be_nil
+        client = result_env[client_key]
+
+        expect(client).to be_a(Stitches::CallingServiceClient)
+        expect(client.name).to eq("")
       end
     end
 
     context "when the header is blank" do
       before { env["HTTP_X_STITCHFIX_CALLING_SERVICE"] = "" }
 
-      it "leaves the env var nil" do
+      it "sets a fallback CallingServiceClient with empty name" do
         _status, result_env, _body = middleware.call(env)
-        expect(result_env[client_key]).to be_nil
+        client = result_env[client_key]
+
+        expect(client).to be_a(Stitches::CallingServiceClient)
+        expect(client.name).to eq("")
       end
     end
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: stitches
 version: !ruby/object:Gem::Version
-  version: 5.1.0
+  version: 5.1.1.RC1
 platform: ruby
 authors:
 - Stitch Fix Engineering