stitches 4.2.0 → 4.2.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: b96871187fb98a847464ed9e035f2bbce340fb8acd0e15372cd2de84e14393fd
-  data.tar.gz: e60814802decfe7bb0e7cc8a51c8a2a99db7fc3db4183904f12570febb6611ae
+  metadata.gz: 076cbbf3b2dfdd8b9b01d5c9f80cc091c223f14008fd7d45ceb2fff58bf454a0
+  data.tar.gz: a0d73979c10617fd6567aa7089236da49c7d2f1e1f58648931af5f5a0d7562b4
 SHA512:
-  metadata.gz: 3fc14b2226a3f1fdc6a7d4fcf2a905166765603e3c5b03039c3c76beb506d62a7415d0738062e046d85b70a3496f73eaa06d7fd9c55cf2fcc5e62f73ee01fb46
-  data.tar.gz: f25373d0f6cdb1641172d9a0e574dcaf2e3660558975dd085bdc45c202d113337420af5ac3a55cd4311017cb66d93c7e2c24ca78452913d38564982e0df9f5fc
+  metadata.gz: 46e0364ba7c84f2fe1ca66cac2b74236b173bd023b4573b41f0ed718c66828c1131075802e7cc388f427f7de81af6e9bc13c763429f68382ce6a8729d548e988
+  data.tar.gz: af3e5c6b23f9134ee842b300a65afcf13455d3842516696e3774e35a324d590271058f581db1451ecccbbf23c3c70f63ec2d12476c0306a1dfdf50825c7e5d55

data/lib/stitches/api_client_access_wrapper.rb

@@ -33,7 +33,7 @@ module Stitches::ApiClientAccessWrapper
 
     disabled_at = api_client.respond_to?(:disabled_at) ? api_client.disabled_at : nil
     if disabled_at && disabled_at > configuration.disabled_key_leniency_in_seconds.seconds.ago
-      message = "Allowing disabled ApiClient: #{api_client.name} with key #{api_client.key} disabled at #{disabled_at}"
+      message = "Allowing disabled ApiClient: #{api_client.name} with key #{redact_key(api_client)} disabled at #{disabled_at}"
       if disabled_at > configuration.disabled_key_leniency_error_log_threshold_in_seconds.seconds.ago
         logger.warn(message)
       else
@@ -41,11 +41,15 @@ module Stitches::ApiClientAccessWrapper
       end
       return api_client
     else
-      logger.error("Rejecting disabled ApiClient: #{api_client.name} with key #{api_client.key}")
+      logger.error("Rejecting disabled ApiClient: #{api_client.name} with key #{redact_key(api_client)}")
     end
     nil
   end
 
+  def self.redact_key(api_client)
+    "*****#{api_client.key.to_s[-8..-1]}"
+  end
+
   def self.logger
     if defined?(StitchFix::Logger::LogWriter)
       StitchFix::Logger::LogWriter

data/lib/stitches/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Stitches
-  VERSION = '4.2.0'
+  VERSION = '4.2.1'
 end

data/spec/api_key_middleware_spec.rb

@@ -102,10 +102,11 @@ RSpec.describe "/api/hellos", type: :request do
         context "when disabled_at is set to a time older than three days ago" do
           let(:disabled_at) { 4.day.ago }
 
-          it "allows the call" do
+          it "does not allow the call" do
             execute_call
 
             expect_unauthorized
+
           end
         end
 
@@ -162,7 +163,9 @@ RSpec.describe "/api/hellos", type: :request do
 
           it "logs error about the disabled key to the Rails.logger" do
             allow(Rails.logger).to receive(:warn)
-            allow(Rails.logger).to receive(:error)
+            allow(Rails.logger).to receive(:error) do |message1|
+              expect(message1).not_to include uuid
+            end
 
             execute_call
 
@@ -210,7 +213,10 @@ RSpec.describe "/api/hellos", type: :request do
             let(:disabled_at) { 101.seconds.ago }
 
             it "forbids the call" do
-              allow(Rails.logger).to receive(:error)
+              allow(Rails.logger).to receive(:error) do |message1|
+                expect(message1).not_to include uuid
+              end
+
               execute_call
 
               expect_unauthorized
@@ -235,7 +241,9 @@ RSpec.describe "/api/hellos", type: :request do
             let(:disabled_at) { 25.seconds.ago }
 
             it "allows the call" do
-              allow(Rails.logger).to receive(:warn)
+              allow(Rails.logger).to receive(:warn) do |message1|
+                expect(message1).not_to include uuid
+              end
 
               execute_call
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: stitches
 version: !ruby/object:Gem::Version
-  version: 4.2.0
+  version: 4.2.1
 platform: ruby
 authors:
 - Stitch Fix Engineering
@@ -11,7 +11,7 @@ authors:
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2021-08-12 00:00:00.000000000 Z
+date: 2021-09-20 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails