stitches 3.2.2 → 3.2.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 88481c42da4d9e07d58401429c123d0042e0f196
-  data.tar.gz: d042b0b4103d22217b62123be762dbf1af9dd610
+  metadata.gz: a861f11796bfcc697ded1857fe96d0b0dfbc73ab
+  data.tar.gz: 831d978bdf931a550a6af1fe1779e8216f6f56b0
 SHA512:
-  metadata.gz: c91377aef8b39bad255cf2c0bce0d5b36a83baa15f84b475332b9662c5a1c75adf3cee15574145792e3496fcd8a5d289416c074e974d28ccf3b0f9a17088530e
-  data.tar.gz: 016a482c093d53c5a46812ed632e5a1b44652ab9df3554e6ea3f9539368a7331a67ffce688c79540006b7f8c623e90b1c745659cbbcc72e663f3180d2853c56a
+  metadata.gz: fd50b87dbe2f27d96d287de362ff8ae19479b3c47793d1700d988597b88b408f2ffa56fd4d29ab5a905336fce67fab4824b6caf342d9175f8ad8e11dad702240
+  data.tar.gz: 1df173eeecc1a8e16640ab1b50c5fe2d406180f381414c6fd1ff606a2a959f56970377f99236c0b9c456b8a1a233c5aa95923af5d5b955cf828bc29cc7951a53

data/.ruby-version

@@ -1 +1 @@
-2.1.5
+2.3.0

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    stitches (3.2.2)
+    stitches (3.2.3)
       apitome
       pg
       rails
@@ -11,36 +11,36 @@ PATH
 GEM
   remote: https://www.rubygems.org/
   specs:
-    actionmailer (4.2.3)
-      actionpack (= 4.2.3)
-      actionview (= 4.2.3)
-      activejob (= 4.2.3)
+    actionmailer (4.2.5.2)
+      actionpack (= 4.2.5.2)
+      actionview (= 4.2.5.2)
+      activejob (= 4.2.5.2)
       mail (~> 2.5, >= 2.5.4)
       rails-dom-testing (~> 1.0, >= 1.0.5)
-    actionpack (4.2.3)
-      actionview (= 4.2.3)
-      activesupport (= 4.2.3)
+    actionpack (4.2.5.2)
+      actionview (= 4.2.5.2)
+      activesupport (= 4.2.5.2)
       rack (~> 1.6)
       rack-test (~> 0.6.2)
       rails-dom-testing (~> 1.0, >= 1.0.5)
       rails-html-sanitizer (~> 1.0, >= 1.0.2)
-    actionview (4.2.3)
-      activesupport (= 4.2.3)
+    actionview (4.2.5.2)
+      activesupport (= 4.2.5.2)
       builder (~> 3.1)
       erubis (~> 2.7.0)
       rails-dom-testing (~> 1.0, >= 1.0.5)
       rails-html-sanitizer (~> 1.0, >= 1.0.2)
-    activejob (4.2.3)
-      activesupport (= 4.2.3)
+    activejob (4.2.5.2)
+      activesupport (= 4.2.5.2)
       globalid (>= 0.3.0)
-    activemodel (4.2.3)
-      activesupport (= 4.2.3)
+    activemodel (4.2.5.2)
+      activesupport (= 4.2.5.2)
       builder (~> 3.1)
-    activerecord (4.2.3)
-      activemodel (= 4.2.3)
-      activesupport (= 4.2.3)
+    activerecord (4.2.5.2)
+      activemodel (= 4.2.5.2)
+      activesupport (= 4.2.5.2)
       arel (~> 6.0)
-    activesupport (4.2.3)
+    activesupport (4.2.5.2)
       i18n (~> 0.7)
       json (~> 1.7, >= 1.7.7)
       minitest (~> 5.1)
@@ -52,84 +52,86 @@ GEM
       rspec_api_documentation
     arel (6.0.3)
     builder (3.2.2)
+    concurrent-ruby (1.0.1)
     diff-lcs (1.2.5)
     erubis (2.7.0)
     globalid (0.3.6)
       activesupport (>= 4.1.0)
     i18n (0.7.0)
     json (1.8.3)
-    kramdown (1.8.0)
-    loofah (2.0.2)
+    kramdown (1.10.0)
+    loofah (2.0.3)
       nokogiri (>= 1.5.9)
     mail (2.6.3)
       mime-types (>= 1.16, < 3)
-    mime-types (2.6.1)
-    mini_portile (0.6.2)
-    minitest (5.8.0)
+    mime-types (2.99.1)
+    mini_portile2 (2.0.0)
+    minitest (5.8.4)
     mustache (0.99.8)
-    nokogiri (1.6.6.2)
-      mini_portile (~> 0.6.0)
-    pg (0.18.2)
+    nokogiri (1.6.7.2)
+      mini_portile2 (~> 2.0.0.rc2)
+    pg (0.18.4)
     rack (1.6.4)
     rack-test (0.6.3)
       rack (>= 1.0)
-    rails (4.2.3)
-      actionmailer (= 4.2.3)
-      actionpack (= 4.2.3)
-      actionview (= 4.2.3)
-      activejob (= 4.2.3)
-      activemodel (= 4.2.3)
-      activerecord (= 4.2.3)
-      activesupport (= 4.2.3)
+    rails (4.2.5.2)
+      actionmailer (= 4.2.5.2)
+      actionpack (= 4.2.5.2)
+      actionview (= 4.2.5.2)
+      activejob (= 4.2.5.2)
+      activemodel (= 4.2.5.2)
+      activerecord (= 4.2.5.2)
+      activesupport (= 4.2.5.2)
       bundler (>= 1.3.0, < 2.0)
-      railties (= 4.2.3)
+      railties (= 4.2.5.2)
       sprockets-rails
     rails-deprecated_sanitizer (1.0.3)
       activesupport (>= 4.2.0.alpha)
-    rails-dom-testing (1.0.6)
+    rails-dom-testing (1.0.7)
       activesupport (>= 4.2.0.beta, < 5.0)
       nokogiri (~> 1.6.0)
       rails-deprecated_sanitizer (>= 1.0.1)
-    rails-html-sanitizer (1.0.2)
+    rails-html-sanitizer (1.0.3)
       loofah (~> 2.0)
-    railties (4.2.3)
-      actionpack (= 4.2.3)
-      activesupport (= 4.2.3)
+    railties (4.2.5.2)
+      actionpack (= 4.2.5.2)
+      activesupport (= 4.2.5.2)
       rake (>= 0.8.7)
       thor (>= 0.18.1, < 2.0)
-    rake (10.4.2)
-    rspec (3.3.0)
-      rspec-core (~> 3.3.0)
-      rspec-expectations (~> 3.3.0)
-      rspec-mocks (~> 3.3.0)
-    rspec-core (3.3.2)
-      rspec-support (~> 3.3.0)
-    rspec-expectations (3.3.1)
+    rake (10.5.0)
+    rspec (3.4.0)
+      rspec-core (~> 3.4.0)
+      rspec-expectations (~> 3.4.0)
+      rspec-mocks (~> 3.4.0)
+    rspec-core (3.4.3)
+      rspec-support (~> 3.4.0)
+    rspec-expectations (3.4.0)
       diff-lcs (>= 1.2.0, < 2.0)
-      rspec-support (~> 3.3.0)
-    rspec-mocks (3.3.2)
+      rspec-support (~> 3.4.0)
+    rspec-mocks (3.4.1)
       diff-lcs (>= 1.2.0, < 2.0)
-      rspec-support (~> 3.3.0)
-    rspec-rails (3.3.3)
+      rspec-support (~> 3.4.0)
+    rspec-rails (3.4.2)
       actionpack (>= 3.0, < 4.3)
       activesupport (>= 3.0, < 4.3)
       railties (>= 3.0, < 4.3)
-      rspec-core (~> 3.3.0)
-      rspec-expectations (~> 3.3.0)
-      rspec-mocks (~> 3.3.0)
-      rspec-support (~> 3.3.0)
-    rspec-support (3.3.0)
-    rspec_api_documentation (4.4.0)
+      rspec-core (~> 3.4.0)
+      rspec-expectations (~> 3.4.0)
+      rspec-mocks (~> 3.4.0)
+      rspec-support (~> 3.4.0)
+    rspec-support (3.4.1)
+    rspec_api_documentation (4.7.0)
       activesupport (>= 3.0.0)
       json (~> 1.4, >= 1.4.6)
       mustache (~> 0.99, >= 0.99.4)
       rspec (>= 3.0.0)
-    sprockets (3.3.0)
-      rack (~> 1.0)
-    sprockets-rails (2.3.2)
-      actionpack (>= 3.0)
-      activesupport (>= 3.0)
-      sprockets (>= 2.8, < 4.0)
+    sprockets (3.5.2)
+      concurrent-ruby (~> 1.0)
+      rack (> 1, < 3)
+    sprockets-rails (3.0.4)
+      actionpack (>= 4.0)
+      activesupport (>= 4.0)
+      sprockets (>= 3.0.0)
     thor (0.19.1)
     thread_safe (0.3.5)
     tzinfo (1.2.2)
@@ -143,4 +145,4 @@ DEPENDENCIES
   stitches!
 
 BUNDLED WITH
-   1.10.6
+   1.11.2

data/README.md

@@ -1,6 +1,6 @@
 You'll be in stitches at how easy it is to get your API service up and running!
 
-![build status](https://travis-ci.org/stitchfix/resque-brain.svg?branch=master)
+![build status](https://travis-ci.org/stitchfix/stitches.svg?branch=master)
 
 This gem provides:
 

data/lib/stitches/spec/have_api_error.rb

@@ -31,16 +31,13 @@ RSpec::Matchers.define :have_api_error do |expected_fields|
   end
 
   failure_message do |response|
-    if response.response_code != (expected_fields[:status] || 422)
-      "HTTP status was #{response.response_code} and not 422"
+    expected_status = (expected_fields[:status] || 422)
+    if response.response_code != expected_status
+      "HTTP status was #{response.response_code} and not #{expected_status}"
     else
       error = extract_error(response,expected_fields)
       if error
-        if error["code"] != expected_fields.fetch(:code)
-          "Expected code to be '#{expected_fields[:code]}', but was '#{error['code']}'"
-        else
-          "Expected message to be '#{expected_fields[:message]}', but was '#{error['message']}'"
-        end
+        "Expected message to be '#{expected_fields[:message]}', but was '#{error['message']}'"
       else
         "Could not find an error for code #{expected_fields[:code]} from #{response.body}"
       end

data/lib/stitches/version.rb

@@ -1,3 +1,3 @@
 module Stitches
-  VERSION = '3.2.2'
+  VERSION = '3.2.3'
 end

data/spec/spec/have_api_error_spec.rb

@@ -8,6 +8,7 @@ describe "have_api_error" do
       { code: "baz", message: "quux" }
     ]
   }
+  let(:response_code) { 422 }
   let(:response) {
     double(
       response_code: response_code,
@@ -60,10 +61,31 @@ describe "have_api_error" do
   context "expected status is specified" do
     context "status is the expected status" do
       let(:response_code) { 404 }
-      it "indicates there is an error" do
-        expect(response).to have_api_error(status: 404,
-                                           code: errors.first[:code],
-                                           message: errors.first[:message])
+      context "there is an error" do
+        it "indicates there is an error" do
+          expect(response).to have_api_error(status: 404,
+                                             code: errors.first[:code],
+                                             message: errors.first[:message])
+        end
+      end
+      context "there is not an error" do
+        context "and the status code is what's wrong" do
+          let(:response) {
+            double(
+              response_code: 401,
+              body: { errors: errors }.to_json)
+          }
+          it "fails the test" do
+            begin
+              expect(response).to have_api_error(status: 404,
+                                                 code: errors.first[:code],
+                                                 message: errors.first[:message])
+            rescue Exception => ex
+              expect(ex.class).to eq(RSpec::Expectations::ExpectationNotMetError)
+              expect(ex.message).to match(/HTTP status was 401 and not 404/i)
+            end
+          end
+        end
       end
     end
     context "status is not the expected status" do
@@ -74,5 +96,57 @@ describe "have_api_error" do
                                                message: errors.first[:bar])
       end
     end
+    context "response errors don't match expectations" do
+      context "because the status code is what's wrong" do
+        let(:response) {
+          double(
+            response_code: 401,
+            body: { errors: errors }.to_json)
+        }
+        it "fails the test" do
+          begin
+            expect(response).to have_api_error(code: errors.first[:code],
+                                               message: errors.first[:message])
+          rescue Exception => ex
+            expect(ex.class).to eq(RSpec::Expectations::ExpectationNotMetError)
+            expect(ex.message).to match(/HTTP status was 401 and not 422/i)
+          end
+        end
+      end
+      context "because there is no matching code" do
+        let(:errors) {
+          [
+            { code: "foo", message: "bar" },
+            { code: "baz", message: "quux" }
+          ]
+        }
+        it "fails the test" do
+          begin
+            expect(response).to have_api_error(code: errors.first[:code] + "blah",
+                                               message: errors.first[:message])
+          rescue Exception => ex
+            expect(ex.class).to eq(RSpec::Expectations::ExpectationNotMetError)
+            expect(ex.message).to match(/Could not find an error for code/i)
+          end
+        end
+      end
+      context "because there is no matching message" do
+        let(:errors) {
+          [
+            { code: "foo", message: "bar" },
+            { code: "baz", message: "quux" }
+          ]
+        }
+        it "fails the test" do
+          begin
+            expect(response).to have_api_error(code: errors.first[:code],
+                                               message: errors.first[:message] + "blah")
+          rescue Exception => ex
+            expect(ex.class).to eq(RSpec::Expectations::ExpectationNotMetError)
+            expect(ex.message).to match(/Expected message to be/i)
+          end
+        end
+      end
+    end
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: stitches
 version: !ruby/object:Gem::Version
-  version: 3.2.2
+  version: 3.2.3
 platform: ruby
 authors:
 - Stitch Fix Engineering
@@ -11,7 +11,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-11-20 00:00:00.000000000 Z
+date: 2016-07-06 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
@@ -179,7 +179,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.3
+rubygems_version: 2.6.6
 signing_key: 
 specification_version: 4
 summary: You'll be in stitches at how easy it is to create a service at Stitch Fix