still_life 0.1.0 → 0.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: e8dc100759230e82f493b0bae7e3c6fc600f854ef6ff77a858037e92a662aaa7
-  data.tar.gz: f432cd88652963f9ffa70a249aa1554d3d0ce37ab5742d84538bcaebdca185e7
+  metadata.gz: 92d2486c2d3db425af9db4c7b0632a5aecadd94ea383e13c51e3e9f0fab1f70f
+  data.tar.gz: 6b8193f48947fec6d8d4bc079582614669ac171b9d87af6bd1c7abc188830469
 SHA512:
-  metadata.gz: 9cdcef43678b79532a812b2bd4d9006ad63fd75b27ed28ddf606bd7ff20e77f1860fb1dd3e13be8dd2f297d4ef140b4eaa7f69b2adf60f3e7c72c02ee6afb725
-  data.tar.gz: 812976cf80fa3b687dd11a3bafcc4642462544019726ad61fd96dc5ed9110724f6ef886b6d3016b09ea9bc35360c866c8ea4c5d60e365056168e1f4e64df8b48
+  metadata.gz: 4c09f261b346364ffb7c0c5e487ae97295cb75cfad7de6f7707cbab45e86ae7b4f210d6656d2e74c221e0a4efaf3396af3b7a5f0db39e7ba139b3aa9ab6e14ab
+  data.tar.gz: b05f324577658154e7c60f1d35b5d919e39ba87a985273056e03197e13733a862361727fa963eb5bd6b2d7691704452e4e722f21c3883f462857a99f7073340f

data/.gitignore

@@ -12,3 +12,4 @@ log/
 *.sqlite3
 /test/dummy_app/tmp/cache/
 /test/dummy_app/tmp/html/
+/test/dummy_app/tmp/development_secret.txt

data/.travis.yml

@@ -1,7 +1,18 @@
----
-sudo: false
+dist: focal
 language: ruby
 cache: bundler
+
+addons:
+  chrome: stable
+
+before_install:
+  - sudo apt update -qq
+  - sudo apt install -y chromium-chromedriver
+
 rvm:
-  - 2.7.0
-before_install: gem install bundler -v 2.0.1
+  - 2.7.2
+
+env:
+  - TEST_FRAMEWORK=test-unit
+  - TEST_FRAMEWORK=minitest
+  - TEST_FRAMEWORK=rspec

data/README.md

@@ -122,20 +122,24 @@ and push some more commits...
 ### 4. Compare the results, and make sure there's no unexpected diffs
 
 ```sh
-% diff -r tmp/html/rails52 tmp/html/rails60
+% git diff --no-index --color-words tmp/html/rails52/ tmp/html/rails60/
 ```
 
 
 ## Notes
+### git diff
+As written in the above example, `git diff --no-index --color-words` should perfectly work for recursively comparing two output directories.
+
 ### Random Values
 
 If your response includes some kind of random values, the test results may change between each test runs.
-In such case, maybe you could specify a random seed, or mock the random source in your app, or `grep -v` is always your friend.
+In such case, maybe you could specify a random seed, or mock the random source in your app.
 
 
 ## TODOs / Known Issues
 - The Capybara monkeypatch sometimes fails to get the `page.body` due to Capybara timing problem
 - Support older versions of Rails, Capybara, and Ruby
+- Fix the CI with RSpec + headless Chrome
 
 
 ## Contributing

data/Rakefile

@@ -7,6 +7,8 @@ Rake::TestTask.new(:test) do |t|
   t.libs << "test"
   t.libs << "lib"
   t.test_files = FileList['test/**/*_test.rb'] - FileList['test/dummy_app/test/**/*_test.rb']
+  t.warning = true
+  t.verbose = true
 end
 
 task default: :test

data/lib/still_life/action_dispatch_extension.rb

@@ -2,32 +2,32 @@
 
 module StillLife
   module ActionDispatchExtension
-    def get(*args)
-      super(*args).tap do
+    def get(*, **)
+      super.tap do
         StillLife.draw(response.body)
       end
     end
 
-    def post(*args)
-      super(*args).tap do
+    def post(*, **)
+      super.tap do
         StillLife.draw(response.body)
       end
     end
 
-    def put(*args)
-      super(*args).tap do
+    def put(*, **)
+      super.tap do
         StillLife.draw(response.body)
       end
     end
 
-    def patch(*args)
-      super(*args).tap do
+    def patch(*, **)
+      super.tap do
         StillLife.draw(response.body)
       end
     end
 
-    def delete(*args)
-      super(*args).tap do
+    def delete(*, **)
+      super.tap do
         StillLife.draw(response.body)
       end
     end

data/lib/still_life/capybara_extension.rb

@@ -8,9 +8,12 @@ module StillLife
 
         body_was = session.body
         super.tap do
-          session.find('body')
-          if session.body.present? && (session.body != body_was)
-            StillLife.draw(session.body)
+          3.times do
+            if session.body.present? && (session.body != body_was)
+              StillLife.draw(session.body)
+            else
+              sleep(0.5) && next
+            end
           end
         end
       end

data/lib/still_life/railtie.rb

@@ -13,16 +13,19 @@ module StillLife
           ActionDispatch::SystemTestCase.include StillLife::CapybaraExtension
         end
 
-        begin
-          require 'rspec-rails'
+        ActiveSupport.on_load :active_support_test_case do
+          begin
+            require 'rspec-rails'
 
-          #TODO maybe we could use some kind of hook instead of directly configuring here?
-          RSpec.configure do |config|
-            # config.prepend StillLife::ActionDispatchExtension, type: :request
-            config.prepend StillLife::ActionDispatchExtension, type: :controller
-            config.include StillLife::CapybaraExtension, type: :feature
+            # TODO: maybe we could use some kind of hook instead of directly configuring here?
+            RSpec.configure do |config|
+              config.prepend StillLife::ActionDispatchExtension, type: :request
+              config.prepend StillLife::ActionDispatchExtension, type: :controller
+              config.include StillLife::CapybaraExtension, type: :feature
+              config.include StillLife::CapybaraExtension, type: :system
+            end
+          rescue LoadError
           end
-        rescue LoadError
         end
       end
     end

data/lib/still_life/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module StillLife
-  VERSION = '0.1.0'
+  VERSION = '0.2.0'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: still_life
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.2.0
 platform: ruby
 authors:
 - Akira Matsuda
-autorequire: 
+autorequire:
 bindir: exe
 cert_chain: []
-date: 2019-03-19 00:00:00.000000000 Z
+date: 2020-10-12 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -91,7 +91,7 @@ homepage: https://github.com/amatsuda/still_life
 licenses:
 - MIT
 metadata: {}
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -106,8 +106,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.3
-signing_key: 
+rubygems_version: 3.2.0.rc.1
+signing_key:
 specification_version: 4
 summary: Test result HTML recorder
 test_files: []