stepper_motor 0.1.12 → 0.1.15

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: dcbfb106c1b6c9c74cef277a3bedec00c970d5264856ae92671b6f2302936eaa
-  data.tar.gz: a351a974b2ed5af98f20c8e816e43aac19982539054c7db1e3b1290d2d6a2538
+  metadata.gz: c62f05b7bc2c994345697f0d403fc6faeaf491c3efa883bfdfe9c3dc7595d52a
+  data.tar.gz: 6fbf7c140444e906ef178af631023022994707c4cf282d954e681c5f6fe07bc1
 SHA512:
-  metadata.gz: 6a7f3190a99a62537b17ccfdfd76f1c4879a5b5c054395ffbd1d4ccaf7da469f96e2198954adbb2db79571b046b772ea37daf3865f27c23ea7d3a2b75f505699
-  data.tar.gz: 8f999b8fb9e599d6cfac817a82cc4640902d9812a296f9643cd80d0632099f94140645f9ad55dcbd1a043e1c6f25df3084a0cc23ab88b24ac206dab2b991c302
+  metadata.gz: f95cd7b0eebf80306a14d04f5ce3cd229e0b4e5ee4aa7fc5f12d902ee027b2d97294ecce7bc0a15e56e8490ea9f4724becc6f817dc6bcc9f10667767292c6b85
+  data.tar.gz: e44253c904ab4cf471216352cdc0ec85790532ecb66d9d401d24a9ee85673c42af6d2aa4301be67824344bd0f1864fc34121713db6499f841765a3e6a3ea602b

data/.github/workflows/ci.yml

@@ -7,6 +7,7 @@ on:
 
 jobs:
   lint:
+    name: "Lint (standardrb)"
     runs-on: ubuntu-latest
     steps:
       - name: Checkout code
@@ -22,17 +23,45 @@ jobs:
         run: bundle exec standardrb
 
   test:
+    name: "Tests (${{ matrix.database.name }})"
     runs-on: ubuntu-latest
+    strategy:
+      matrix:
+        database:
+          - { name: 'PostgreSQL', url: 'postgresql://postgres:postgres@localhost:5432/stepper_motor_test' }
+          - { name: 'MySQL', url: 'mysql2://root:root@127.0.0.1:3306/stepper_motor_test?host=127.0.0.1' }
+          - { name: 'SQLite', url: 'sqlite3:db/test.sqlite3' }
+
+    services:
+      postgres:
+        image: postgres:14
+        env:
+          POSTGRES_USER: postgres
+          POSTGRES_PASSWORD: postgres
+          POSTGRES_DB: stepper_motor_test
+        ports:
+          - 5432:5432
+        options: >-
+          --health-cmd pg_isready
+          --health-interval 10s
+          --health-timeout 5s
+          --health-retries 5
+      mysql:
+        image: mysql:8.0
+        env:
+          MYSQL_ROOT_PASSWORD: root
+          MYSQL_DATABASE: stepper_motor_test
+        ports:
+          - 3306:3306
+        options: >-
+          --health-cmd "mysqladmin ping"
+          --health-interval 10s
+          --health-timeout 5s
+          --health-retries 5
 
-    # services:
-    #  redis:
-    #    image: redis
-    #    ports:
-    #      - 6379:6379
-    #    options: --health-cmd "redis-cli ping" --health-interval 10s --health-timeout 5s --health-retries 5
     steps:
       - name: Install packages
-        run: sudo apt-get update && sudo apt-get install --no-install-recommends -y build-essential git libyaml-dev pkg-config google-chrome-stable
+        run: sudo apt-get update && sudo apt-get install --no-install-recommends -y build-essential git libyaml-dev pkg-config
 
       - name: Checkout code
         uses: actions/checkout@v4
@@ -43,9 +72,22 @@ jobs:
           ruby-version: 3.2.2
           bundler-cache: true
 
+      - name: Remove existing schema.rb
+        run: rm -f test/dummy/db/schema.rb
+
+      - name: Setup database
+        env:
+          RAILS_ENV: test
+          DATABASE_URL: ${{ matrix.database.url }}
+        run: |
+          cd test/dummy
+          bundle exec rails db:create
+          bundle exec rails db:migrate
+          cd ../..
+
       - name: Run tests
         env:
           RAILS_ENV: test
-          # REDIS_URL: redis://localhost:6379/0
+          DATABASE_URL: ${{ matrix.database.url }}
         run: bin/test
 

data/CHANGELOG.md

@@ -1,5 +1,15 @@
 # Changelog
 
+## [0.1.15] - 2025-06-20
+
+- Add `if:` condition allowing steps to be skipped. The `if:` can be a boolean, a callable or a symbol for a method name. The method should be on the Journey.
+  
+## [0.1.14] - 2025-06-10
+
+- Since MySQL does not support partial indexes, use a generated column for the uniqueness checks. Other indexes
+  which are set up as partial indexes just become full indexes - that will make them larger on MySQL but the functionality
+  is going to be the same. This is a tradeoff but it seems sensible for the time being.
+
 ## [0.1.12] - 2025-06-08
 
 - Ensure base job extension gets done via the reloader, so that app classes are available

data/lib/generators/stepper_motor_migration_005.rb.erb

@@ -0,0 +1,58 @@
+class StepperMotorMigration005 < ActiveRecord::Migration[<%= migration_version %>]
+  def up
+    unless mysql?
+      say "Skipping migration as it is only used with MySQL (mysql2 or trilogy)"
+      return
+    end
+
+    # Add generated column that combines the state, type, hero_id, and hero_type
+    # The column will be NULL if any of the components is NULL
+    execute <<-SQL
+      ALTER TABLE stepper_motor_journeys
+      ADD COLUMN journey_uniq_col_generated VARCHAR(255) GENERATED ALWAYS AS (
+        CASE 
+          WHEN state IN ('ready', 'performing', 'paused') 
+          AND allow_multiple = 0 
+          AND type IS NOT NULL 
+          AND hero_id IS NOT NULL 
+          AND hero_type IS NOT NULL
+          THEN CONCAT(type, ':', hero_id, ':', hero_type)
+          ELSE NULL
+        END
+      ) STORED
+    SQL
+
+    # Add unique index on the generated column with MySQL-specific name
+    add_index :stepper_motor_journeys, :journey_uniq_col_generated, 
+              unique: true, 
+              name: :idx_journeys_one_per_hero_mysql_generated
+
+    # Remove old indexes that include 'ready', 'performing', and 'paused' states
+    remove_index :stepper_motor_journeys, name: :idx_journeys_one_per_hero_with_paused
+  end
+
+  def down
+    unless mysql?
+      say "Skipping migration as it is only used with MySQL (mysql2 or trilogy)"
+      return
+    end
+
+    # Remove the generated column and its index
+    remove_index :stepper_motor_journeys, name: :idx_journeys_one_per_hero_mysql_generated
+    remove_column :stepper_motor_journeys, :journey_uniq_col_generated
+
+    # Recreate old indexes
+    quoted_false = connection.quote(false)
+    add_index :stepper_motor_journeys, [:type, :hero_id, :hero_type], 
+              where: "allow_multiple = '#{quoted_false}' AND state IN ('ready', 'performing', 'paused')", 
+              unique: true, 
+              name: :idx_journeys_one_per_hero_with_paused
+  end
+
+  private
+
+  def mysql?
+    adapter = connection.adapter_name.downcase
+    adapter == 'mysql2' || adapter == 'trilogy'
+  end
+end 

data/lib/stepper_motor/journey.rb

@@ -72,15 +72,18 @@ module StepperMotor
     #    When the journey gets scheduled, the triggering job is going to be delayed by this amount of time, and the
     #    `next_step_to_be_performed_at` attribute will be set to the current time plus the wait duration. Mutually exclusive with `after:`
     # @param after[Float,#to_f,ActiveSupport::Duration] the amount of time this step should wait before getting performed
-    #    including all the previous waits. This allows you to set the wait time based on the time after the journey started, as opposed
-    #    to when the previous step has completed. When the journey gets scheduled, the triggering job is going to be delayed by this
-    #    amount of time _minus the `wait` values of the preceding steps, and the
-    #    `next_step_to_be_performed_at` attribute will be set to the current time. The `after` value gets converted into the `wait`
-    #    value and passed to the step definition. Mutually exclusive with `wait:`
+    #    including all the previous waits. This allows you to set the wait time based on the time after the journey started,
+    #    as opposed to when the previous step has completed. When the journey gets scheduled, the triggering job is going to
+    #    be delayed by this amount of time _minus the `wait` values of the preceding steps, and the `next_step_to_be_performed_at`
+    #    attribute will be set to the current time. The `after` value gets converted into the `wait` value and passed to the step definition.
+    #    Mutually exclusive with `wait:`
     # @param on_exception[Symbol] See {StepperMotor::Step#on_exception}
-    # @param additional_step_definition_options Any remaining options get passed to `StepperMotor::Step.new` as keyword arguments.
+    # @param if[TrueClass,FalseClass,Symbol,Proc] condition to check before performing the step. If a symbol is provided,
+    #    it will call the method on the Journey. If a block is provided, it will be executed with the Journey as context.
+    #    The step will only be performed if the condition returns a truthy value.
+    # @param additional_step_definition_options[Hash] Any remaining options get passed to `StepperMotor::Step.new` as keyword arguments.
     # @return [StepperMotor::Step] the step definition that has been created
-    def self.step(name = nil, wait: nil, after: nil, on_exception: :pause!, **additional_step_definition_options, &blk)
+    def self.step(name = nil, wait: nil, after: nil, on_exception: :pause!, if: true, **additional_step_definition_options, &blk)
       wait = if wait && after
         raise StepConfigurationError, "Either wait: or after: can be specified, but not both"
       elsif !wait && !after
@@ -109,7 +112,7 @@ module StepperMotor
       raise StepConfigurationError, "Step named #{name.inspect} already defined" if known_step_names.include?(name)
 
       # Create the step definition
-      StepperMotor::Step.new(name: name, wait: wait, seq: step_definitions.length, on_exception:, **additional_step_definition_options, &blk).tap do |step_definition|
+      StepperMotor::Step.new(name: name, wait: wait, seq: step_definitions.length, on_exception:, if: binding.local_variable_get(:if), **additional_step_definition_options, &blk).tap do |step_definition|
         # As per Rails docs: you need to be aware when using class_attribute with mutable structures
         # as Array or Hash. In such cases, you don't want to do changes in place. Instead use setters.
         # See https://apidock.com/rails/v7.1.3.2/Class/class_attribute

data/lib/stepper_motor/step.rb

@@ -24,12 +24,37 @@ class StepperMotor::Step
   #   The possible values are:
   #   * `:cancel!` - cancels the Journey and re-raises the exception. The Journey will be persisted before re-raising.
   #   * `:reattempt!` - reattempts the Journey and re-raises the exception. The Journey will be persisted before re-raising.
-  def initialize(name:, seq:, on_exception:, wait: 0, &step_block)
+  # @param if[TrueClass,FalseClass,NilClass,Symbol,Proc] condition to check before performing the step. If a boolean is provided,
+  #   it will be used directly. If nil is provided, it will be treated as false. If a symbol is provided,
+  #   it will call the method on the Journey. If a block is provided, it will be executed with the Journey as context.
+  #   The step will only be performed if the condition returns a truthy value.
+  def initialize(name:, seq:, on_exception:, wait: 0, if: true, &step_block)
     @step_block = step_block
     @name = name.to_s
     @wait = wait
     @seq = seq
     @on_exception = on_exception # TODO: Validate?
+    @if_condition = binding.local_variable_get(:if) # Done this way because `if` is a reserved keyword
+
+    # Validate the if condition
+    if ![true, false, nil].include?(@if_condition) && !@if_condition.is_a?(Symbol) && !@if_condition.respond_to?(:call)
+      raise ArgumentError, "if: condition must be a boolean, nil, Symbol or a callable object, but was a #{@if_condition.inspect}"
+    end
+  end
+
+  # Checks if the step should be performed based on the if condition
+  #
+  # @param journey[StepperMotor::Journey] the journey to check the condition for
+  # @return [Boolean] true if the step should be performed, false otherwise
+  def should_perform?(journey)
+    case @if_condition
+    when true, false, nil
+      !!@if_condition
+    when Symbol
+      journey.send(@if_condition) # Allow private methods
+    else
+      journey.instance_exec(&@if_condition)
+    end
   end
 
   # Performs the step on the passed Journey, wrapping the step with the required context.
@@ -40,6 +65,12 @@ class StepperMotor::Step
   #   journey will be called
   # @return void
   def perform_in_context_of(journey)
+    # Return early should the `if` condition be false
+    if !should_perform?(journey)
+      journey.logger.info { "skipping as if: condition was falsey or returned false" }
+      return
+    end
+
     # This is a tricky bit.
     #
     # reattempt!, cancel! (and potentially - future flow control methods) all use `throw` to
@@ -61,21 +92,18 @@ class StepperMotor::Step
       end
     end
   rescue MissingDefinition
-    # This journey won't succeed with any number of reattempts, cancel it. Cancellation also will throw.
+    # This journey won't succeed with any number of reattempts, pause it.
     catch(:abort_step) { journey.pause! }
     raise
   rescue => e
     # Act according to the set policy. The basic 2 for the moment are :reattempt! and :cancel!,
     # and can be applied by just calling the methods on the passed journey
     case @on_exception
-    when :reattempt!
-      catch(:abort_step) { journey.reattempt! }
-    when :cancel!
-      catch(:abort_step) { journey.cancel! }
-    when :pause!
-      catch(:abort_step) { journey.pause! }
+    when :reattempt!, :cancel!, :pause!
+      catch(:abort_step) { journey.public_send(@on_exception) }
     else
       # Leave the journey hanging in the "performing" state
+      journey.logger.warn { "unusual on_exception: value (#{@on_exception.inspect}) - the journey will be left hanging in 'performing' state and will be collected as hung" }
     end
 
     # Re-raise the exception so that the Rails error handling can register it

data/lib/stepper_motor/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module StepperMotor
-  VERSION = "0.1.12"
+  VERSION = "0.1.15"
 end