stepmod-utils 0.3.8 → 0.3.9

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 6201c720f31faffdd6646d74a3c150733f3219bd756d9ba9743e5a27c1db4495
-  data.tar.gz: b1bafce759e91f5923d030fe0b5b0f74f2b719a832d53ac300db6b38e3e221d0
+  metadata.gz: 8838f07a6b887ff87b6067b7a82b02e605bfc97c81ed345642b68c9d8d4e6a5b
+  data.tar.gz: 213824aa6f2b832d941d6575005f7c43c60f5332a1c285f973efa05d52090b86
 SHA512:
-  metadata.gz: 206becea0d17c930418426618aa5234e420a4aba77e63a9448890245dd637ca044ad5540073e509ca8d672a701bc31b1b9576ad671f21a0da7f620f917c83b68
-  data.tar.gz: 4f564a4b188082f6a20e41bb424c50950a2efce588fd1c48adaceb3a1068c7b4d5fa2388c758491f1d8814cceaefaee8f842337ae57d49873cb4e2bcb43933b1
+  metadata.gz: '088fe0671024dd6e5fb69960c379d52e25345546ba5f87b8167d37e26fd8315074ba7b7028757d610a1c18fffe560485cc65937157cad72a32445dfef836a415'
+  data.tar.gz: 176cde1360b6f3a229c05eb50fe606892d106101dab6e3e7c1aafb15467602d9650107151a58eb9f3ac56a2f93411ccd3131e749a3974c247f6c4cdc76f5e414

data/exe/stepmod-extract-terms

@@ -53,6 +53,22 @@ def part_to_title(bibdata)
   end
 end
 
+IMAGE_REPLACEMENTS = {
+  'image::eq01.gif[]' => 'stem:[H(A,B) = max {h(A, B), h(B,A)}]',
+  'image::eq02.gif[]' => 'stem:[max_{a in A} { min_{b in B} d(a,b) }]',
+  'image::vector_z_c.gif[]' => 'stem:[bar z_{c}]',
+  'image::one_direction_repeat_factor_expression.gif[]' => 'stem:[I + k cdot R;  k = -1, 1]',
+  'image::two_direction_repeat_factor_expression.gif[]' => 'stem:[I + k_1 cdot R_1 + k_2 cdot R_2;  k_1, k_2 = -1, 0, 1, k^2_1 + k^2_2 != 0]'
+}
+
+def replace_images(content)
+  IMAGE_REPLACEMENTS.each_pair do |k, v|
+    content.gsub!(k, v)
+  end
+
+  content
+end
+
 def log(message)
   puts "[stepmod-utils] #{message}"
 end
@@ -64,7 +80,7 @@ part_concepts.each do |(bibdata, current_part_concepts)|
   fn = "03x-stepmod-#{bibdata.part}.adoc"
   File.open(fn, "w") do |file|
     file.puts("== #{part_to_title(bibdata)}\n\n")
-    file.puts(current_part_concepts.map(&:to_mn_adoc).join("\n"))
+    file.puts(replace_images(current_part_concepts.map(&:to_mn_adoc).join("\n")))
   end
   log "INFO: written to: #{fn}"
 end
@@ -76,7 +92,7 @@ part_resources.each do |(bibdata, current_part_resources)|
   fn = "04x-stepmod-entities-resources-#{bibdata.part}.adoc"
   File.open(fn, "w") do |file|
     file.puts("== #{part_to_title(bibdata)}\n\n")
-    file.puts(current_part_resources.map(&:to_mn_adoc).join("\n"))
+    file.puts(replace_images(current_part_resources.map(&:to_mn_adoc).join("\n")))
   end
   log "INFO: written to: #{fn}"
 end
@@ -106,23 +122,32 @@ part_modules.each do |(bibdata, part_modules_arm, part_modules_mim)|
         n.localizations["en"]
       end
       file.puts("== #{schema_name}\n\n")
-      file.puts(concepts.map(&:to_mn_adoc).join("\n"))
+      file.puts(replace_images(concepts.map(&:to_mn_adoc).join("\n")))
     end
   end
   log "INFO: written to: #{fn}"
 end
 
 File.open("031-stepmod-general.adoc", "w") do |file|
-  file.puts(general_concepts.to_a.map do |n|
-              n.localizations["en"]
-            end.map(&:to_mn_adoc).join("\n"))
+  file.puts(
+    replace_images(
+      general_concepts.to_a.map do |n|
+        n.localizations["en"]
+      end.map(&:to_mn_adoc).join("\n")
+    )
+  )
 end
+
 log "INFO: written to: 031-stepmod-general.adoc"
 
 File.open("041-stepmod-entities-resources.adoc", "w") do |file|
-  file.puts(resource_concepts.to_a.map do |n|
-              n.localizations["en"]
-            end.map(&:to_mn_adoc).join("\n"))
+  file.puts(
+    replace_images(
+      resource_concepts.to_a.map do |n|
+        n.localizations["en"]
+      end.map(&:to_mn_adoc).join("\n")
+    )
+  )
 end
 log "INFO: written to: 041-stepmod-entities-resources.adoc"
 

data/lib/stepmod/utils/concept.rb

@@ -31,7 +31,10 @@ module Stepmod
               Reference <<#{reference_anchor}>> for the complete definition.
             TEXT
           end
+
           # https://github.com/metanorma/stepmod-utils/issues/86
+
+          # TODO: This portion DOES NOT HANDLE the <synonym> element. WTF??
           if definition_xml.name == "definition"
             designation = definition_designation(definition_xml)
             definition = definition_xml_definition(definition_xml,
@@ -40,6 +43,7 @@ module Stepmod
               designation, definition
             ).strip
           end
+
           new(
             designations: [designation],
             definition: definition,
@@ -53,20 +57,36 @@ module Stepmod
         end
 
         def definition_designation(definition_xml)
-          alts = definition_xml.xpath(".//def/p").map(&:text)
+          # We take the <p> that is an alternative term (length<=20).
+          # Add in the <synonym> elements.
+          alts = definition_xml.xpath(".//synonym").map(&:text) +
+            definition_xml.xpath(".//def/p").map(&:text).reject do |text|
+              text.length > 20
+            end
+
+          term = Stepmod::Utils::Converters::Term
+            .new
+            .convert(
+              definition_xml.xpath(".//term").first
+            )
+
           {
-            accepted: definition_xml.xpath(".//term").first&.text,
+            # [4..-1] because we want to skip the initial `=== {title}`
+            accepted: term[4..-1],
             alt: alts,
           }
         end
 
         def definition_xml_definition(definition_xml, reference_anchor)
+          # We reject the <p> that was considered an alternative term (length<=20)
           text_nodes = definition_xml
             .xpath(".//def")
             .first
             .children
-            .reject { |n| n.name == "p" }
+            .reject { |n| n.name == "p" && n.text.length <= 20 }
+
           wrapper = "<def>#{text_nodes.map(&:to_s).join}</def>"
+
           Stepmod::Utils::Converters::Def
             .new
             .convert(
@@ -83,15 +103,18 @@ module Stepmod
           if designation[:alt].length.positive?
             alt_notation = "alt:[#{designation[:alt].map(&:strip).join(',')}]"
           end
+
           result = <<~TEXT
-            === #{designation[:accepted]}
+            === #{designation[:accepted].strip}
           TEXT
+
           if alt_notation
             result += <<~TEXT
 
               #{alt_notation}
             TEXT
           end
+
           <<~TEXT
             #{result}
             #{definition}

data/lib/stepmod/utils/converters/express_ref.rb

@@ -5,7 +5,7 @@ module Stepmod
     module Converters
       class ExpressRef < ReverseAdoc::Converters::Base
         def convert(node, _state = {})
-          " *#{node['linkend'].to_s.split('.').last}*"
+          " *#{node['linkend'].to_s.split('.').last}* "
         end
       end
       ReverseAdoc::Converters.register :express_ref, ExpressRef.new

data/lib/stepmod/utils/converters/module_ref.rb

@@ -19,7 +19,7 @@ module Stepmod
             " {{#{normalized_ref(ref)}}} "
           elsif
             ref = node["linkend"].split(":").first
-            " *#{ref}*"
+            " *#{ref}* "
           end
         end
 

data/lib/stepmod/utils/converters/ol.rb

@@ -9,10 +9,12 @@ module Stepmod
           anchor = id ? "[[#{id}]]\n" : ""
           ol_count = state.fetch(:ol_count, 0) + 1
           attrs = ol_attrs(node)
-          "\n\n#{anchor}#{attrs}#{treat_children(node,
-                                                 state.merge(
-                                                   ol_count: ol_count, tdsinglepara: true,
-                                                 ))}\n"
+          children_s = treat_children(node, state.merge(
+                                              ol_count: ol_count,
+                                              tdsinglepara: true,
+                                            ))
+
+          "\n\n#{anchor}#{attrs}#{children_s}\n"
           # Why do we add this?
           # res = "\n" + res if node.parent && node.parent.name == 'note'
         end

data/lib/stepmod/utils/converters/stepmod_ext_description.rb

@@ -13,8 +13,11 @@ module Stepmod
           child_text = treat_children(node, state).strip
           return nil if child_text.empty?
 
-          # Only taking the first paragraph of the definition
-          child_text = child_text.split("\n").first
+          # If it contains a list, don't split
+          unless child_text =~ /\n\* /
+            # Only taking the first paragraph of the definition
+            child_text = child_text.split("\n").first
+          end
 
           # # Only taking the first sentence
           # if child_text.contains?(".")

data/lib/stepmod/utils/converters/strong.rb

@@ -11,8 +11,10 @@ module Stepmod
           if content.strip.empty? || state[:already_strong]
             content
           else
-            handle_express_escape_seq(node,
-                                      "#{content[/^\s*/]}*#{content.strip}*#{content[/\s*$/]}")
+            handle_express_escape_seq(
+              node,
+              "#{content[/^\s*/]}*#{content.strip}*#{content[/\s*$/]}"
+            )
           end
         end
 

data/lib/stepmod/utils/converters/term.rb

@@ -6,10 +6,19 @@ module Stepmod
   module Utils
     module Converters
       class Term < ReverseAdoc::Converters::Base
+
+        # We strip all the children in the case for "stem:[d]-manifold"
+        # vs "stem:[d] -manifold"
+        def treat_children(node, state)
+          res = node.children.map { |child| treat(child, state) }
+          res.map(&:strip).reject(&:empty?).join("")
+        end
+
         def convert(node, state = {})
           first_child = node.children.find do |child|
             child.name == "text" && !child.text.to_s.strip.empty?
           end
+
           unless first_child &&
               node.text.split(";").length == 2 &&
               defined?(Stepmod::Utils::Converters::Synonym)
@@ -25,10 +34,10 @@ module Stepmod
         private
 
         def treat_acronym(term_def)
-          return term_def if term_def !~ /.+\(.+?\)$/
+          return term_def.strip if term_def !~ /.+\(.+?\)$/
 
           _, term_text, term_acronym = term_def.match(/(.+?)(\(.+\))$/).to_a
-          "#{term_text}\nalt:[#{term_acronym.gsub(/\(|\)/, '')}]"
+          "#{term_text.strip}\nalt:[#{term_acronym.gsub(/\(|\)/, '')}]"
         end
       end
 

data/lib/stepmod/utils/version.rb

@@ -1,5 +1,5 @@
 module Stepmod
   module Utils
-    VERSION = "0.3.8".freeze
+    VERSION = "0.3.9".freeze
   end
 end

data/stepmod-utils.gemspec

@@ -34,10 +34,9 @@ Gem::Specification.new do |spec|
   spec.add_runtime_dependency "concurrent-ruby"
   spec.add_runtime_dependency "glossarist", "~> 0.1.0"
   spec.add_runtime_dependency "ptools"
-  spec.add_runtime_dependency "reverse_adoc", ">= 0.2.9"
+  spec.add_runtime_dependency "reverse_adoc", ">= 0.3.5"
   spec.add_runtime_dependency "thor", ">= 0.20.3"
-  spec.add_development_dependency "byebug", "~> 11.1"
-  spec.add_development_dependency "rubocop", "1.12"
+  spec.add_development_dependency "rubocop"
   spec.add_development_dependency "rubocop-performance"
   spec.add_development_dependency "rubocop-rails"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: stepmod-utils
 version: !ruby/object:Gem::Version
-  version: 0.3.8
+  version: 0.3.9
 platform: ruby
 authors:
 - Ribose Inc.
@@ -58,14 +58,14 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 0.2.9
+        version: 0.3.5
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 0.2.9
+        version: 0.3.5
 - !ruby/object:Gem::Dependency
   name: thor
   requirement: !ruby/object:Gem::Requirement
@@ -80,34 +80,20 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: 0.20.3
-- !ruby/object:Gem::Dependency
-  name: byebug
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '11.1'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '11.1'
 - !ruby/object:Gem::Dependency
   name: rubocop
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '='
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '1.12'
+        version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '='
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '1.12'
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: rubocop-performance
   requirement: !ruby/object:Gem::Requirement