stellar-sdk 0.28.0 → 0.29.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 16f2babbd6e3fd516c62f8ff0fb2fe264e335dae7bb051721a3f4fefb5195f4d
-  data.tar.gz: dd0d6b370c14ca38ae09a7bcfcfaccfc1214af2115308c9f2574f84f133a85a4
+  metadata.gz: 3829133758963683cfff3f2132c55d8bf53540bd731d9cb2e619d2ae36012112
+  data.tar.gz: d2ec22a621018102dc93c9cb6e89dbaa5029ef29ec4d1b85f5b6cf6a8b1a8ccb
 SHA512:
-  metadata.gz: 5b4ce731f7be3b66a5d1cd0f8a03ebb8ba5ffbcb7c55b0fdc9a45189edd95f2d288a3047d603e222e06f69e7079c418c27bc0b82c3bcd0f25f182573630cba67
-  data.tar.gz: c74630a8193bc6bfd3bd2ce730491c0de96f4b7b49b9b1523d02b191f9c2358cfe1c6ca7e286db28ded3680c6e8d110c003249928f86682cec6da3e4fc91b35d
+  metadata.gz: 53958e7a613b1a8cfa6b7a36a505c3820337b5a696bc16bfe7b7d3da9060fee01b0dd1afd61f4c48cb2eeee8c6a9b8b3b71d75b39afc1681b985a2a266af6231
+  data.tar.gz: b235706bc0f6d4b92298a43dae775d9b7210028c1306171ffd65212478addc929f760e0f6421e795c77d2e58570e6aa81d7665f5d93005695e1c4271e6e074f2

data/CHANGELOG.md

@@ -5,6 +5,13 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](http://keepachangelog.com/)
 and this project adheres to [Semantic Versioning](http://semver.org/).
 
+## [0.29.0](https://www.github.com/astroband/ruby-stellar-sdk/compare/v0.28.0...v0.29.0) (2021-09-07)
+
+### Added
+* support for client domain in SEP-10
+### Deprecated
+* `Stellar::Client` class is marked as deprecated in favour of new `stellar-horizon` gem
+
 ## [0.28.0](https://www.github.com/astroband/ruby-stellar-sdk/compare/v0.27.0...v0.28.0) (2021-07-17)
 
 ### Changed

data/lib/stellar/client.rb

@@ -44,6 +44,8 @@ module Stellar
 
     # @option options [String] :horizon The Horizon server URL.
     def initialize(options)
+      ActiveSupport::Deprecation.warn("`Stellar::Horizon` is deprecated and will be removed from `stellar-sdk` next relase. Use `stellar-horizon` gem for requesting Horizon API")
+
       @options = options
       @horizon = Hyperclient.new(options[:horizon]) { |client|
         client.faraday_block = lambda do |conn|

data/lib/stellar/sep10.rb

@@ -64,6 +64,20 @@ module Stellar
         )
       end
 
+      if options[:client_domain].present?
+        if options[:client_domain_account].blank?
+          raise "`client_domain_account` is required, if `client_domain` is provided"
+        end
+
+        tb.add_operation(
+          Stellar::Operation.manage_data(
+            name: "client_domain",
+            value: options[:client_domain],
+            source_account: options[:client_domain_account]
+          )
+        )
+      end
+
       tb.build.to_envelope(server).to_xdr(:base64)
     end
 
@@ -125,16 +139,14 @@ module Stellar
 
       rest_ops.each do |op|
         body = op.body
+        op_params = body.value
 
         if body.arm != :manage_data_op
           raise InvalidSep10ChallengeError, "The transaction has operations that are not of type 'manageData'"
-        elsif op.source_account != server.muxed_account
+        elsif op.source_account != server.muxed_account && op_params.data_name != "client_domain"
           raise InvalidSep10ChallengeError, "The transaction has operations that are unrecognized"
-        else
-          op_params = body.value
-          if op_params.data_name == "web_auth_domain" && options.key?(:auth_domain) && op_params.data_value != options[:auth_domain]
-            raise InvalidSep10ChallengeError, "The transaction has 'manageData' operation with 'web_auth_domain' key and invalid value"
-          end
+        elsif op_params.data_name == "web_auth_domain" && options.key?(:auth_domain) && op_params.data_value != options[:auth_domain]
+          raise InvalidSep10ChallengeError, "The transaction has 'manageData' operation with 'web_auth_domain' key and invalid value"
         end
       end
 
@@ -210,6 +222,9 @@ module Stellar
       client_signers = signers.select { |s| s =~ /G[A-Z0-9]{55}/ && s != server.address }.to_set
       raise InvalidSep10ChallengeError, "at least one regular signer must be provided" if client_signers.empty?
 
+      client_domain_account_address = extract_client_domain_account(te.tx)
+      client_signers.add(client_domain_account_address) if client_domain_account_address.present?
+
       # verify all signatures in one pass
       client_signers.add(server.address)
       signers_found = verify_tx_signatures(tx_envelope: te, signers: client_signers)
@@ -229,6 +244,10 @@ module Stellar
         raise InvalidSep10ChallengeError, "Transaction has unrecognized signatures."
       end
 
+      if client_domain_account_address.present? && !signers_found.include?(client_domain_account_address)
+        raise InvalidSep10ChallengeError, "Transaction not signed by client domain account."
+      end
+
       signers_found
     end
 
@@ -249,7 +268,7 @@ module Stellar
       to_keypair = Stellar::DSL.method(:KeyPair)
       keys_by_hint = signers.map(&to_keypair).index_by(&:signature_hint)
 
-      tx_envelope.signatures.each.with_object(Set.new) do |sig, result|
+      signatures.each_with_object(Set.new) do |sig, result|
         key = keys_by_hint.delete(sig.hint)
         result.add(key.address) if key&.verify(sig.signature, tx_hash)
       end
@@ -272,5 +291,16 @@ module Stellar
         keypair.verify(sig.signature, tx_hash)
       end
     end
+
+    def self.extract_client_domain_account(transaction)
+      client_domain_account_op =
+        transaction
+          .operations
+          .find { |op| op.body.value.data_name == "client_domain" }
+
+      return if client_domain_account_op.blank?
+
+      Util::StrKey.encode_muxed_account(client_domain_account_op.source_account)
+    end
   end
 end

metadata

@@ -1,16 +1,16 @@
 --- !ruby/object:Gem::Specification
 name: stellar-sdk
 version: !ruby/object:Gem::Version
-  version: 0.28.0
+  version: 0.29.0
 platform: ruby
 authors:
 - Scott Fleckenstein
 - Sergey Nebolsin
 - Timur Ramazanov
-autorequire: 
+autorequire:
 bindir: exe
 cert_chain: []
-date: 2021-07-20 00:00:00.000000000 Z
+date: 2021-09-07 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: stellar-base
@@ -18,14 +18,14 @@ dependencies:
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 0.28.0
+        version: 0.29.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 0.28.0
+        version: 0.29.0
 - !ruby/object:Gem::Dependency
   name: activesupport
   requirement: !ruby/object:Gem::Requirement
@@ -148,8 +148,8 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '3.9'
-description: 
-email: 
+description:
+email:
 executables: []
 extensions: []
 extra_rdoc_files:
@@ -173,12 +173,12 @@ licenses:
 - Apache-2.0
 metadata:
   bug_tracker_uri: https://github.com/astroband/ruby-stellar-sdk/issues
-  changelog_uri: https://github.com/astroband/ruby-stellar-sdk/blob/v0.28.0/sdk/CHANGELOG.md
-  documentation_uri: https://rubydoc.info/gems/stellar-sdk/0.28.0/
+  changelog_uri: https://github.com/astroband/ruby-stellar-sdk/blob/v0.29.0/sdk/CHANGELOG.md
+  documentation_uri: https://rubydoc.info/gems/stellar-sdk/0.29.0/
   github_repo: ssh://github.com/astroband/ruby-stellar-sdk
   homepage_uri: https://github.com/astroband/ruby-stellar-sdk/tree/main/sdk
-  source_code_uri: https://github.com/astroband/ruby-stellar-sdk/tree/v0.28.0/sdk
-post_install_message: 
+  source_code_uri: https://github.com/astroband/ruby-stellar-sdk/tree/v0.29.0/sdk
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -193,8 +193,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.2.22
-signing_key: 
+rubygems_version: 3.1.4
+signing_key:
 specification_version: 4
 summary: Stellar client library
 test_files: []