stellar-base 0.14.0 → 0.15.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: 6d155c06a6614979a0ea9eba7e5dcd903066c724
-  data.tar.gz: 0c64ccb007896ef7ce617b19aff2d542f9fe40cb
+SHA256:
+  metadata.gz: fa23fad0329efcda8cb73f539a3adc91b735d573937b0ba392fd9c992dc3e067
+  data.tar.gz: 24d04f5f147f3c28cb3bcaed0388b4400746893b1fda8148a1da1eee690bbf80
 SHA512:
-  metadata.gz: 00a096af9c978b25848d9a2efd572cc279e52e4860c5db26dee72a7ab954693b09b9e5178b6d63f1c0ff977de8ea0ee83cfd07c58332ce0045b67dbf86eb2706
-  data.tar.gz: f19a0bad6a1489411bb673ecf060a5232aa3c76ee029f6f24c901769501c709dc3058c693bb19fc4ba2defba259b24faa55b844e66b76c8ef5ce8d536b4d89d4
+  metadata.gz: a03b5ee1650f1c98d93f014d6d5e3ceabdd0470913a76704e590a770359b3881e0d841ce7da0fd9136affd7b950a3819a3cc7bb5d4f285c83414f43ce408c532
+  data.tar.gz: f81d001d2cb2da33752e039419d0ae151ab55820f41c8a7e06fbb3b4ac631eb9010aee5bd4252dce0cfa552281cdda986a2f35d862fb9098257d27a057ee57ec

data/CHANGELOG.md

@@ -6,7 +6,14 @@ file.  This project adheres to [Semantic Versioning](http://semver.org/).
 As this project is pre 1.0, breaking changes may happen for minor version
 bumps.  A breaking change will get clearly notified in this log.
 
-## [unreleased](https://github.com/stellar/ruby-stellar-base/compare/v0.14.0...master)
+## [unreleased](https://github.com/stellar/ruby-stellar-base/compare/v0.15.0...master)
+
+## [0.15.0](https://github.com/stellar/ruby-stellar-base/compare/v0.14.0...v0.15.0)
+### Added
+- `Stellar::Operation.change_trust` can accept `Stellar::Asset` instance for `line`
+
+### Fixed
+- Protect `Stellar::Operation.change_trust` against malicious arguments, in the event that developers pass this argument directly from user input
 
 ## [0.14.0](https://github.com/stellar/ruby-stellar-base/compare/v0.13.0...v0.14.0)
 

data/lib/stellar/asset.rb

@@ -1,5 +1,7 @@
 module Stellar
   class Asset
+    TYPES = %i(native alphanum4 alphanum12)
+
     def self.native
       new(:asset_type_native)
     end

data/lib/stellar/base/version.rb

@@ -1,5 +1,5 @@
 module Stellar
   module Base
-    VERSION = "0.14.0"
+    VERSION = "0.15.0"
   end
 end

data/lib/stellar/operation.rb

@@ -115,14 +115,21 @@ module Stellar
     # transactions `operations` array.
     #
     # @param [Hash] attributes the attributes to create the operation with
-    # @option attributes [Stellar::Currrency] :line the asset to trust
+    # @option attributes [Stellar::Asset] :line the asset to trust
     # @option attributes [Fixnum] :limit the maximum amount to trust, defaults to max int64,
     #                                    if the limit is set to 0 it deletes the trustline.
     #
     # @return [Stellar::Operation] the built operation, containing a
     #                              Stellar::ChangeTrustOp body
     def self.change_trust(attributes={})
-      line  = Asset.send(*attributes[:line])
+      line = attributes[:line]
+      if !line.is_a?(Asset)
+        if !Asset::TYPES.include?(line[0])
+          fail ArgumentError, "must be one of #{Asset::TYPES}"
+        end
+        line = Asset.send(*line)
+      end
+
       limit = attributes.key?(:limit) ? interpret_amount(attributes[:limit]) : MAX_INT64
 
       raise ArgumentError, "Bad :limit #{limit}" unless limit.is_a?(Integer)

data/spec/lib/stellar/operation_spec.rb

@@ -41,6 +41,20 @@ describe Stellar::Operation, ".change_trust" do
     expect(op.body.value.limit).to eq(9223372036854775807)
   end
 
+  it "creates a ChangeTrustOp with an asset" do
+    asset = Stellar::Asset.alphanum4("USD", issuer)
+    op = Stellar::Operation.change_trust(line: asset, limit: 1234.75)
+    expect(op.body.value).to be_an_instance_of(Stellar::ChangeTrustOp)
+    expect(op.body.value.line).to eq(Stellar::Asset.alphanum4("USD", issuer))
+    expect(op.body.value.limit).to eq(12347500000)
+  end
+
+  it "only allow sound `line` arguments" do
+    expect {
+      Stellar::Operation.change_trust(line: [:harmful_call, "USD", issuer])
+    }.to raise_error(ArgumentError, "must be one of #{Stellar::Asset::TYPES}")
+  end
+
   it "creates a ChangeTrustOp with limit" do
     op = Stellar::Operation.change_trust(line: [:alphanum4, "USD", issuer], limit: 1234.75)
     expect(op.body.value).to be_an_instance_of(Stellar::ChangeTrustOp)
@@ -54,4 +68,4 @@ describe Stellar::Operation, ".change_trust" do
     }.to raise_error(ArgumentError)
   end
 
-end
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: stellar-base
 version: !ruby/object:Gem::Version
-  version: 0.14.0
+  version: 0.15.0
 platform: ruby
 authors:
 - Scott Fleckenstein
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-04-06 00:00:00.000000000 Z
+date: 2018-06-05 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: xdr
@@ -451,7 +451,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.6.8
+rubygems_version: 2.7.6
 signing_key: 
 specification_version: 4
 summary: 'Stellar client library: XDR'