steep 1.2.0 → 1.2.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 93e3e37cfc8107518827a5b5e7126618c6189fae7804456e706b8ee810941ad7
-  data.tar.gz: c80ef32b93abb3f0c1f6f77eba1a675c993a2eb94632825f9057f76a39edb0ce
+  metadata.gz: 350eb85d965ebe0f830b76a4866e2380fbc03d19bdafb5c683e5cf426fff35f4
+  data.tar.gz: 6be02c8f8628ea4a4c3f701fb4066d678a0237c3079245e2738380a41975dff0
 SHA512:
-  metadata.gz: 72d8aadb1ea9454f47f4ab98dbd353c8372aa676096923c05d13d87f3b226fc7102c573bf02d563a5adbb2a072747ff5e9ea282e33cf0654ad3d3f562ebe81a5
-  data.tar.gz: 15fe6ea35cb298337440074e188178c6fdf73a03b5104fbca92863f8863862bfbb9d8e942e0b2482394307a19061185335da442af29d878c7d98f904ee52d2ab
+  metadata.gz: 8d18a11bf1ee0e927651727dde99a9db70e99669c91b37e361b0c4cf1dff6d0b4aab914a63480a4db8477fe49694ab4ba74e99aad4b27f6df64e664ec3d53ca2
+  data.tar.gz: 0cf526b1068660ffc759b41f1f197bf85b4f1590619bd2198b6f5fb5e770d26a2c617d53d00aa475cdacfd154eab1fcc1de5ff394da4ef804873b29f5fd9794a

data/CHANGELOG.md

@@ -2,6 +2,12 @@
 
 ## master
 
+## 1.2.1 (2022-10-22)
+
+### Type checker core
+
+* Fix type narrowing on case-when ([#662](https://github.com/soutaro/steep/pull/662))
+
 ## 1.2.0 (2022-10-08)
 
 ### Commandline tool
@@ -20,8 +26,7 @@
 * Support type checking block/proc self type binding ([#637](https://github.com/soutaro/steep/pull/637))
 * Type check multiple assignment on block parameters ([#641](https://github.com/soutaro/steep/pull/641), [#643](https://github.com/soutaro/steep/pull/643))
 * Make more multiple assignments type check ([#630](https://github.com/soutaro/steep/pull/630))
-* Refactor *shape* calculation ([#635](https://github.com/soutaro/steep/pull/635), [#649
-](https://github.com/soutaro/steep/pull/649))
+* Refactor *shape* calculation ([#635](https://github.com/soutaro/steep/pull/635), [#649](https://github.com/soutaro/steep/pull/649))
 * Report type errors if argument mismatch on yield ([#640](https://github.com/soutaro/steep/pull/640))
 * Relax caching requirements to cache more results ([#651](https://github.com/soutaro/steep/pull/651))
 

data/Gemfile.lock

@@ -1,15 +1,20 @@
 PATH
   remote: .
   specs:
-    steep (1.2.0)
+    steep (1.2.1)
       activesupport (>= 5.1)
+      csv (>= 3.0.9)
+      fileutils (>= 1.1.0)
+      json (>= 2.1.0)
       language_server-protocol (>= 3.15, < 4.0)
       listen (~> 3.0)
+      logger (>= 1.3.0)
       parallel (>= 1.0.0)
       parser (>= 3.1)
       rainbow (>= 2.2.2, < 4.0)
       rbs (>= 2.7.0)
       securerandom (>= 0.1)
+      strscan (>= 1.0.0)
       terminal-table (>= 2, < 4)
 
 GEM
@@ -22,16 +27,20 @@ GEM
       tzinfo (~> 2.0)
     ast (2.4.2)
     concurrent-ruby (1.1.10)
+    csv (3.2.5)
     debase (0.2.5.beta2)
       debase-ruby_core_source (>= 0.10.12)
     debase-ruby_core_source (0.10.16)
     ffi (1.15.5)
+    fileutils (1.6.0)
     i18n (1.12.0)
       concurrent-ruby (~> 1.0)
+    json (2.6.2)
     language_server-protocol (3.17.0.1)
     listen (3.7.1)
       rb-fsevent (~> 0.10, >= 0.10.3)
       rb-inotify (~> 0.9, >= 0.9.10)
+    logger (1.5.1)
     minitest (5.16.3)
     minitest-hooks (1.5.0)
       minitest (> 5.3)
@@ -50,6 +59,7 @@ GEM
       rake (>= 0.8.1)
     securerandom (0.2.0)
     stackprof (0.2.21)
+    strscan (3.0.4)
     terminal-table (3.0.2)
       unicode-display_width (>= 1.1.1, < 3)
     tzinfo (2.0.5)

data/Gemfile.steep

@@ -1,4 +1,4 @@
 source "https://rubygems.org"
 
-gem 'steep', '~> 1.1.0'
-gem "rbs", "~> 2.7.pre"
+gem 'steep', '~> 1.2.0'
+gem "rbs"

data/Gemfile.steep.lock

@@ -23,15 +23,17 @@ GEM
     rb-fsevent (0.11.2)
     rb-inotify (0.10.1)
       ffi (~> 1.0)
-    rbs (2.7.0.pre.2)
-    steep (1.1.1)
+    rbs (2.7.0)
+    securerandom (0.2.0)
+    steep (1.2.0)
       activesupport (>= 5.1)
       language_server-protocol (>= 3.15, < 4.0)
       listen (~> 3.0)
       parallel (>= 1.0.0)
       parser (>= 3.1)
       rainbow (>= 2.2.2, < 4.0)
-      rbs (>= 2.3.2)
+      rbs (>= 2.7.0)
+      securerandom (>= 0.1)
       terminal-table (>= 2, < 4)
     terminal-table (3.0.2)
       unicode-display_width (>= 1.1.1, < 3)
@@ -43,8 +45,8 @@ PLATFORMS
   arm64-darwin-21
 
 DEPENDENCIES
-  rbs (~> 2.7.pre)
-  steep (~> 1.1.0)
+  rbs
+  steep (~> 1.2.0)
 
 BUNDLED WITH
    2.3.15

data/Steepfile

@@ -1,30 +1,29 @@
+D = Steep::Diagnostic
+
 target :app do
   check "lib"
   signature "sig"
 
   collection_config "rbs_collection.steep.yaml"
 
+  configure_code_diagnostics do |hash|             # You can setup everything yourself
+    hash[D::Ruby::MethodDefinitionMissing] = :hint
+  end
+
   signature "../rbs/sig", "../rbs/stdlib/rdoc/0"
   library(
     "set",
     "pathname",
-    "json",
-    "logger",
     "monitor",
     "tsort",
     "uri",
     'yaml',
-    'dbm',
     'pstore',
     'singleton',
     'shellwords',
-    'fileutils',
     'find',
     'digest',
-    "strscan",
-    "rubygems",
     "optparse",
-    "securerandom",
-    "csv"
+    "securerandom"
   )
 end

data/lib/steep/type_inference/logic_type_interpreter.rb

@@ -373,17 +373,41 @@ module Steep
           ]
 
         else
+          # There are four possible relations between `type` and `instance_type`
+          #
+          # ```ruby
+          # case object      # object: T
+          # when K           # K: singleton(K)
+          # when ...
+          # end
+          # ````
+          #
+          # 1. T <: K && K <: T (T == K, T = Integer, K = Numeric)
+          # 2. T <: K           (example: T = Integer, K = Numeric)
+          # 3. K <: T           (example: T = Numeric, K = Integer)
+          # 4. none of the above (example: T = String, K = Integer)
+
           relation = Subtyping::Relation.new(sub_type: type, super_type: instance_type)
           if subtyping.check(relation, constraints: Subtyping::Constraints.empty, self_type: AST::Types::Self.new, instance_type: AST::Types::Instance.new, class_type: AST::Types::Class.new).success?
+            # 1 or 2. Satisfies the condition, no narrowing because `type` is already more specific than/equals to `instance_type`
             [
               [type],
               []
             ]
           else
-            [
-              [],
-              [type]
-            ]
+            if subtyping.check(relation.flip, constraints: Subtyping::Constraints.empty, self_type: AST::Types::Self.new, instance_type: AST::Types::Instance.new, class_type: AST::Types::Class.new).success?
+              # 3. Satisfied the condition, narrows to `instance_type`, but cannot remove it from *falsy* list
+              [
+                [instance_type],
+                [type]
+              ]
+            else
+              # 4
+              [
+                [],
+                [type]
+              ]
+            end
           end
         end
       end

data/lib/steep/version.rb

@@ -1,3 +1,3 @@
 module Steep
-  VERSION = "1.2.0"
+  VERSION = "1.2.1"
 end

data/rbs_collection.steep.lock.yaml

@@ -10,12 +10,16 @@ gems:
   version: '0'
   source:
     type: stdlib
+- name: dbm
+  version: '0'
+  source:
+    type: stdlib
 - name: activesupport
   version: '6.0'
   source:
     type: git
     name: ruby/gem_rbs_collection
-    revision: dc7059ea0cdf67f486ca9cea2b01d53f04724652
+    revision: 84a7431af1db405ef827bfdd171a37a1416f6099
     remote: https://github.com/ruby/gem_rbs_collection.git
     repo_dir: gems
 - name: ast
@@ -23,25 +27,41 @@ gems:
   source:
     type: git
     name: ruby/gem_rbs_collection
-    revision: dc7059ea0cdf67f486ca9cea2b01d53f04724652
+    revision: 84a7431af1db405ef827bfdd171a37a1416f6099
     remote: https://github.com/ruby/gem_rbs_collection.git
     repo_dir: gems
+- name: csv
+  version: '0'
+  source:
+    type: stdlib
+- name: fileutils
+  version: '0'
+  source:
+    type: stdlib
 - name: i18n
   version: '1.10'
   source:
     type: git
     name: ruby/gem_rbs_collection
-    revision: dc7059ea0cdf67f486ca9cea2b01d53f04724652
+    revision: 84a7431af1db405ef827bfdd171a37a1416f6099
     remote: https://github.com/ruby/gem_rbs_collection.git
     repo_dir: gems
+- name: json
+  version: '0'
+  source:
+    type: stdlib
 - name: listen
   version: '3.2'
   source:
     type: git
     name: ruby/gem_rbs_collection
-    revision: dc7059ea0cdf67f486ca9cea2b01d53f04724652
+    revision: 84a7431af1db405ef827bfdd171a37a1416f6099
     remote: https://github.com/ruby/gem_rbs_collection.git
     repo_dir: gems
+- name: logger
+  version: '0'
+  source:
+    type: stdlib
 - name: minitest
   version: '0'
   source:
@@ -51,7 +71,7 @@ gems:
   source:
     type: git
     name: ruby/gem_rbs_collection
-    revision: dc7059ea0cdf67f486ca9cea2b01d53f04724652
+    revision: 84a7431af1db405ef827bfdd171a37a1416f6099
     remote: https://github.com/ruby/gem_rbs_collection.git
     repo_dir: gems
 - name: rainbow
@@ -59,26 +79,26 @@ gems:
   source:
     type: git
     name: ruby/gem_rbs_collection
-    revision: dc7059ea0cdf67f486ca9cea2b01d53f04724652
+    revision: 84a7431af1db405ef827bfdd171a37a1416f6099
     remote: https://github.com/ruby/gem_rbs_collection.git
     repo_dir: gems
 - name: securerandom
   version: '0'
   source:
     type: stdlib
-- name: monitor
+- name: strscan
   version: '0'
   source:
     type: stdlib
-- name: date
+- name: monitor
   version: '0'
   source:
     type: stdlib
-- name: singleton
+- name: date
   version: '0'
   source:
     type: stdlib
-- name: logger
+- name: singleton
   version: '0'
   source:
     type: stdlib
@@ -94,3 +114,7 @@ gems:
   version: '0'
   source:
     type: stdlib
+- name: forwardable
+  version: '0'
+  source:
+    type: stdlib

data/rbs_collection.steep.yaml

@@ -18,3 +18,4 @@ gems:
     ignore: true
   - name: with_steep_types
     ignore: true
+  - name: dbm

data/steep.gemspec

@@ -37,4 +37,9 @@ Gem::Specification.new do |spec|
   spec.add_runtime_dependency "parallel", ">= 1.0.0"
   spec.add_runtime_dependency "terminal-table", ">= 2", "< 4"
   spec.add_runtime_dependency "securerandom", ">= 0.1"
+  spec.add_runtime_dependency "json", ">= 2.1.0"
+  spec.add_runtime_dependency "logger", ">= 1.3.0"
+  spec.add_runtime_dependency "fileutils", ">= 1.1.0"
+  spec.add_runtime_dependency "strscan", ">= 1.0.0"
+  spec.add_runtime_dependency "csv", ">= 3.0.9"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: steep
 version: !ruby/object:Gem::Version
-  version: 1.2.0
+  version: 1.2.1
 platform: ruby
 authors:
 - Soutaro Matsumoto
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2022-10-07 00:00:00.000000000 Z
+date: 2022-10-22 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: parser
@@ -154,6 +154,76 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0.1'
+- !ruby/object:Gem::Dependency
+  name: json
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 2.1.0
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 2.1.0
+- !ruby/object:Gem::Dependency
+  name: logger
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 1.3.0
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 1.3.0
+- !ruby/object:Gem::Dependency
+  name: fileutils
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 1.1.0
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 1.1.0
+- !ruby/object:Gem::Dependency
+  name: strscan
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 1.0.0
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 1.0.0
+- !ruby/object:Gem::Dependency
+  name: csv
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 3.0.9
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 3.0.9
 description: Gradual Typing for Ruby
 email:
 - matsumoto@soutaro.com