steep 0.43.0 → 0.43.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: '0568c96d6a39d5c6db14e2259b5cdf3cd39bfaf5f2a4368ce060de4c803c0c96'
-  data.tar.gz: d820c5f0c0d6394893a907999d4fdbd0f3a90b4821380c20598e9251d29852e6
+  metadata.gz: 7af0aaa9c4c7b0dd2bae9104603131370d976133d866e3d7760c4b2fa581e694
+  data.tar.gz: eb1421e3b07c1f06e427073bb72d55138eda935e2269874f5727eecb035a00fb
 SHA512:
-  metadata.gz: 8f4f17d938d9f7f462f3db8aff1e48f8bf4118ab66bf40b35abd9b38ea3585014a0d8d372277e5589e9697043946b0e646193e4d7413c55fcf490d6065494203
-  data.tar.gz: d7ece354f2e50faa86b65ed4a62c14f97dc74550fb81326142b8932f8c58deb2da40679a34e1869183e15ab4a90e939fb0041c44c63a5149b8234c82058481b0
+  metadata.gz: 815776632903ca2679af4ae7e7b4a22fa4388956b56706b862f21d76bea6edbbb928d8423504a99a352db71bf7d777e1148a57fe803b582814f1f1526cc45358
+  data.tar.gz: 70839258fe699f8b246b66cf5e865cb33a9231b5d34e12b40f880bc6b3c50566fe53e0df74645785a3bf1091cbbe34ad4e216ac9d37fdcc3bb3ef32532ab5363

data/CHANGELOG.md

@@ -2,6 +2,10 @@
 
 ## master
 
+## 0.43.1 (2021-04-01)
+
+* Fix LSP `textDocument/didSave` notification handling ([#368](https://github.com/soutaro/steep/issues/368))
+
 ## 0.43.0 (2021-03-30)
 
 * LSP responsiveness improvements ([\#352](https://github.com/soutaro/steep/issues/352))

data/lib/steep/server/master.rb

@@ -509,8 +509,9 @@ module Steep
 
         when "initialized"
           if typecheck_automatically
-            request = controller.make_request(include_unchanged: true)
-            start_type_check(request, last_request: nil, start_progress: request.total > 10)
+            if request = controller.make_request(include_unchanged: true)
+              start_type_check(request, last_request: nil, start_progress: request.total > 10)
+            end
           end
 
         when "textDocument/didChange"
@@ -520,12 +521,13 @@ module Steep
 
         when "textDocument/didSave"
           if typecheck_automatically
-            request = controller.make_request(last_request: current_type_check_request)
-            start_type_check(
-              request,
-              last_request: current_type_check_request,
-              start_progress: request.total > 10
-            )
+            if request = controller.make_request(last_request: current_type_check_request)
+              start_type_check(
+                request,
+                last_request: current_type_check_request,
+                start_progress: request.total > 10
+              )
+            end
           end
 
         when "textDocument/didOpen"
@@ -588,11 +590,14 @@ module Steep
             last_request: current_type_check_request,
             include_unchanged: true
           )
-          start_type_check(
-            request,
-            last_request: current_type_check_request,
-            start_progress: true
-          )
+
+          if request
+            start_type_check(
+              request,
+              last_request: current_type_check_request,
+              start_progress: true
+            )
+          end
 
         when "shutdown"
           result_controller << group_request do |group|
@@ -637,11 +642,6 @@ module Steep
 
       def start_type_check(request, last_request:, start_progress:)
         Steep.logger.tagged "#start_type_check(#{request.guid}, #{last_request&.guid}" do
-          unless request
-            Steep.logger.info "Skip start type checking"
-            return
-          end
-
           if last_request
             Steep.logger.info "Cancelling last request"
 

data/lib/steep/version.rb

@@ -1,3 +1,3 @@
 module Steep
-  VERSION = "0.43.0"
+  VERSION = "0.43.1"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: steep
 version: !ruby/object:Gem::Version
-  version: 0.43.0
+  version: 0.43.1
 platform: ruby
 authors:
 - Soutaro Matsumoto
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2021-03-30 00:00:00.000000000 Z
+date: 2021-04-01 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: parser