steep 0.37.0 → 0.42.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: f3d9186b6988081611f8bf060700ad97eb408ab605ab11ab32b717b9a0e9b8b9
-  data.tar.gz: 6f308f7bd551472237d5857614b765468782290733514793b2dfe35a3ac232cf
+  metadata.gz: 3bed885aa8ba3f60076879eb1ca1572c56ae59aae2a9ee3745affbbd1f3f93d2
+  data.tar.gz: 344c77c6676f8c6772d28bab9598c8fa45835100f24603985750de076ebe57f3
 SHA512:
-  metadata.gz: 1fee308a7783a6e54c974c71c78189492c0f557528bccb0da530927cfdb4e4a16f4ff6cd2ec9f8c3292dd9839bb1637f68fd3aff9da0fef6783e3f4b5d838984
-  data.tar.gz: 7cd72caf879d339e5fec0bed219957befd40d5dc2466b345435f4b523c8028a9264404b1d9c695c11ca638b8e6bbeb1d1ad8f600367cd87bf9b3c4fade99eeaa
+  metadata.gz: dce04d256960ee738d029a9c66187a1ef5f11beb3fd0613cbb02dde6494eeafde8aa0bf12aadc02d07bb6a64a785444f18636df1eaa3f1be02bce1d24ad63385
+  data.tar.gz: df9772b46abe7c2acd10cf497ded086b3614016d74b26578d2da6720f26afa01a73a7b43c6a0170b67157e7615e2ec989597ed1081a3f6e4ac69553adc338589

data/.github/workflows/ruby.yml

@@ -16,7 +16,7 @@ jobs:
         - 2.7.0-bionic
         task:
         - test
-        - smoke
+        - test:output
         - build
     container:
       image: rubylang/ruby:${{ matrix.container_tag }}

data/CHANGELOG.md

@@ -2,6 +2,40 @@
 
 ## master
 
+## 0.42.0 (2021-03-08)
+
+* Type checking performance improvement ([\#309](https://github.com/soutaro/steep/pull/309), [\#311](https://github.com/soutaro/steep/pull/311), [\#312](https://github.com/soutaro/steep/pull/312), [\#313](https://github.com/soutaro/steep/pull/313), [\#314](https://github.com/soutaro/steep/pull/314), [\#315](https://github.com/soutaro/steep/pull/315), [\#316](https://github.com/soutaro/steep/pull/316), [\#320](https://github.com/soutaro/steep/pull/320), [\#322](https://github.com/soutaro/steep/pull/322))
+* Let `watch` command support files ([\#323](https://github.com/soutaro/steep/pull/323))
+* Validate _module-self-type_ constraints ([\#308](https://github.com/soutaro/steep/pull/308))
+* Add `-j` option to specify number of worker processes ([\#318](https://github.com/soutaro/steep/pull/318), [\#325](https://github.com/soutaro/steep/pull/325))
+* Fix `code` of RBS diagnostics ([\#306](https://github.com/soutaro/steep/pull/306))
+* Skip printing source code from out of date _expectations_ file ([\#305](https://github.com/soutaro/steep/pull/305))
+
+## 0.41.0 (2021-02-07)
+
+* Add `--with-expectations` and `--save-expectations` option ([#303](https://github.com/soutaro/steep/pull/303))
+
+## 0.40.0 (2021-01-31)
+
+* Report progress with dots ([#287](https://github.com/soutaro/steep/pull/287))
+* Diagnostics message improvements ([#297](https://github.com/soutaro/steep/pull/297), [#301](https://github.com/soutaro/steep/pull/301))
+* Fix error on implicit `to_proc` syntax when `untyped` is yielded ([#291](https://github.com/soutaro/steep/pull/291))
+
+## 0.39.0 (2020-12-25)
+
+* Update RBS to 1.0.0 ([#282](https://github.com/soutaro/steep/pull/282))
+* Better `&&` and `||` typing ([#276](https://github.com/soutaro/steep/pull/276))
+* Type case based on literals ([#277](https://github.com/soutaro/steep/pull/277))
+* Type case improvements ([#279](https://github.com/soutaro/steep/pull/279), [#283](https://github.com/soutaro/steep/pull/283))
+* Improvements on untyped classes/modules, unsupported syntax error handling, and argument types in untyped methods ([#280](https://github.com/soutaro/steep/pull/280))
+* Fix `bot` and `top` type format ([#278](https://github.com/soutaro/steep/pull/278))
+* Colorfull error messages ([#273](https://github.com/soutaro/steep/pull/273))
+
+## 0.38.0 (2020-12-10)
+
+* Improve `break`/`next` typing ([#271](https://github.com/soutaro/steep/pull/271))
+* Add LSP `workspace/symbol` feature ([#267](https://github.com/soutaro/steep/pull/267))
+
 ## 0.37.0 (2020-12-06)
 
 * Update to RBS 0.20.0 with _singleton attribute_ syntax and _proc types with blocks_. ([#264](https://github.com/soutaro/steep/pull/264))

data/Rakefile

@@ -9,6 +9,9 @@ end
 
 task :default => :test
 
-task :smoke do
-  sh "bundle", "exec", "bin/smoke_runner.rb", *Dir.glob("smoke/*")
+namespace :test do
+  desc "Run output test"
+  task :output do
+    sh "ruby", "bin/output_test.rb"
+  end
 end

data/bin/output_rebaseline.rb

@@ -0,0 +1,34 @@
+require "pathname"
+require "yaml"
+require "open3"
+require "tempfile"
+
+if ARGV.empty?
+  test_dirs = (Pathname(__dir__) + "../smoke").children
+else
+  test_dirs = ARGV.map {|p| Pathname.pwd + p }
+end
+
+failed_tests = []
+
+test_dirs.each do |dir|
+  puts "Rebaselining #{dir}..."
+
+  command = %w(steep check --save-expectations=test_expectations.yml)
+  puts "  command: #{command.join(" ")}"
+
+  output, status = Open3.capture2(*command, chdir: dir.to_s)
+
+  unless status.success?
+    puts "Error!!! 👺"
+    failed_tests << dir.basename
+  end
+end
+
+if failed_tests.empty?
+  puts "Successfully updated output expectations! 🤡"
+else
+  puts "Failed to update the following tests! 💀"
+  puts "  #{failed_tests.join(", ")}"
+  exit 1
+end

data/bin/output_test.rb

@@ -0,0 +1,53 @@
+require "pathname"
+require "yaml"
+require "open3"
+require "tempfile"
+require "optparse"
+
+OptionParser.new do |opts|
+  opts.on("--verbose", "-v") { @verbose = true }
+end.parse!(ARGV)
+
+if ARGV.empty?
+  test_dirs = (Pathname(__dir__) + "../smoke").children
+else
+  test_dirs = ARGV.map {|p| Pathname.pwd + p }
+end
+
+failed_tests = []
+
+test_dirs.each do |dir|
+  puts "Running test #{dir}..."
+
+  unless (dir + "test_expectations.yml").file?
+    puts "Skipped ⛹️‍♀️"
+    next
+  end
+
+  command = %w(steep check --with-expectations=test_expectations.yml)
+  puts "  command: #{command.join(" ")}"
+
+  output, status = Open3.capture2(*command, chdir: dir.to_s)
+
+  unless status.success?
+    failed_tests << dir.basename
+    puts "  Failed! 🤕"
+  else
+    puts "  Succeed! 👍"
+  end
+
+  if @verbose
+    puts "  Raw output:"
+    output.split(/\n/).each do |line|
+      puts "  > #{line.chomp}"
+    end
+  end
+end
+
+if failed_tests.empty?
+  puts "All tests ok! 👏"
+else
+  puts "Errors detected! 🤮"
+  puts "  #{failed_tests.join(", ")}"
+  exit 1
+end

data/lib/steep.rb

@@ -4,6 +4,7 @@ require "pathname"
 require "parser/ruby27"
 require "ast_utils"
 require "active_support/core_ext/object/try"
+require "active_support/core_ext/string/inflections"
 require "logger"
 require "active_support/tagged_logging"
 require "rainbow"
@@ -13,6 +14,9 @@ require "etc"
 require "open3"
 require "stringio"
 require 'uri'
+require "yaml"
+
+require "parallel/processor_count"
 
 require "rbs"
 
@@ -42,6 +46,8 @@ require "steep/ast/annotation/collection"
 require "steep/ast/builtin"
 require "steep/ast/types/factory"
 
+require "steep/range_extension"
+
 require "steep/interface/function"
 require "steep/interface/block"
 require "steep/interface/method_type"
@@ -56,12 +62,14 @@ require "steep/subtyping/constraints"
 require "steep/subtyping/variable_variance"
 require "steep/subtyping/variable_occurrence"
 
-require "steep/signature/errors"
+require "steep/diagnostic/helper"
+require "steep/diagnostic/ruby"
+require "steep/diagnostic/signature"
+require "steep/diagnostic/lsp_formatter"
 require "steep/signature/validator"
 require "steep/source"
 require "steep/annotation_parser"
 require "steep/typing"
-require "steep/errors"
 require "steep/module_helper"
 require "steep/type_construction"
 require "steep/type_inference/context"
@@ -76,36 +84,47 @@ require "steep/type_inference/logic_type_interpreter"
 require "steep/type_inference/method_call"
 require "steep/ast/types"
 
-require "steep/server/utils"
+require "steep/index/rbs_index"
+require "steep/index/signature_symbol_provider"
+require "steep/index/source_index"
+
+require "steep/server/change_buffer"
 require "steep/server/base_worker"
-require "steep/server/code_worker"
-require "steep/server/signature_worker"
 require "steep/server/worker_process"
 require "steep/server/interaction_worker"
+require "steep/server/type_check_worker"
 require "steep/server/master"
 
+require "steep/services/content_change"
+require "steep/services/path_assignment"
+require "steep/services/signature_service"
+require "steep/services/type_check_service"
+require "steep/services/hover_content"
+require "steep/services/completion_provider"
+require "steep/services/stats_calculator"
+require "steep/services/file_loader"
+
 require "steep/project"
-require "steep/project/signature_file"
-require "steep/project/source_file"
+require "steep/project/pattern"
 require "steep/project/options"
 require "steep/project/target"
 require "steep/project/dsl"
-require "steep/project/file_loader"
-require "steep/project/hover_content"
-require "steep/project/completion_provider"
+
+require "steep/expectations"
 require "steep/drivers/utils/driver_helper"
+require "steep/drivers/utils/jobs_count"
 require "steep/drivers/check"
 require "steep/drivers/stats"
 require "steep/drivers/validate"
 require "steep/drivers/annotations"
 require "steep/drivers/watch"
 require "steep/drivers/langserver"
-require "steep/drivers/signature_error_printer"
 require "steep/drivers/trace_printer"
 require "steep/drivers/print_project"
 require "steep/drivers/init"
 require "steep/drivers/vendor"
 require "steep/drivers/worker"
+require "steep/drivers/diagnostic_printer"
 
 if ENV["NO_COLOR"]
   Rainbow.enabled = false
@@ -121,7 +140,7 @@ module Steep
   def self.new_logger(output, prev_level)
     ActiveSupport::TaggedLogging.new(Logger.new(output)).tap do |logger|
       logger.push_tags "Steep #{VERSION}"
-      logger.level = prev_level || Logger::WARN
+      logger.level = prev_level || Logger::ERROR
     end
   end
 
@@ -138,11 +157,14 @@ module Steep
   @logger = nil
   self.log_output = STDERR
 
-  def self.measure(message)
+  def self.measure(message, level: :warn)
     start = Time.now
     yield.tap do
       time = Time.now - start
-      self.logger.info "#{message} took #{time} seconds"
+      if level.is_a?(Symbol)
+        level = Logger.const_get(level.to_s.upcase)
+      end
+      self.logger.log(level) { "#{message} took #{time} seconds" }
     end
   end
 
@@ -152,4 +174,63 @@ module Steep
       Steep.logger.warn "  #{loc}"
     end
   end
+
+  class Sampler
+    def initialize()
+      @samples = []
+    end
+
+    def sample(message)
+      start = Time.now
+      yield.tap do
+        time = Time.now - start
+        @samples << [message, time]
+      end
+    end
+
+    def count
+      @samples.count
+    end
+
+    def total
+      @samples.sum(&:last)
+    end
+
+    def slowests(num)
+      @samples.sort_by(&:last).reverse.take(num)
+    end
+
+    def average
+      if count > 0
+        total/count
+      else
+        0
+      end
+    end
+
+    def percentile(p)
+      slowests(count - count * p / 100r).last&.last || 0
+    end
+  end
+
+  def self.measure2(message, level: :warn)
+    sampler = Sampler.new
+    result = yield(sampler)
+
+    if level.is_a?(Symbol)
+      level = Logger.const_get(level.to_s.upcase)
+    end
+    logger.log(level) { "#{sampler.total}secs for \"#{message}\"" }
+    logger.log(level) { "  Average: #{sampler.average}secs"}
+    logger.log(level) { "  Median: #{sampler.percentile(50)}secs"}
+    logger.log(level) { "  Samples: #{sampler.count}"}
+    logger.log(level) { "  99 percentile: #{sampler.percentile(99)}secs"}
+    logger.log(level) { "  90 percentile: #{sampler.percentile(90)}secs"}
+    logger.log(level) { "  10 Slowests:"}
+    sampler.slowests(10).each do |message, time|
+      logger.log(level) { "    #{message} (#{time}secs)"}
+    end
+
+    result
+  end
 end

data/lib/steep/ast/types/bot.rb

@@ -23,7 +23,7 @@ module Steep
         end
 
         def to_s
-          "⟘"
+          "bot"
         end
 
         include Helper::NoFreeVariables

data/lib/steep/ast/types/class.rb

@@ -8,6 +8,10 @@ module Steep
           @location = location
         end
 
+        def to_s
+          "class"
+        end
+
         def ==(other)
           other.is_a?(Class)
         end

data/lib/steep/ast/types/factory.rb

@@ -368,6 +368,8 @@ module Steep
             ]
           when AST::Types::Name::Alias
             unwrap_optional(expand_alias(type))
+          when AST::Types::Boolean
+            [AST::Builtin.true_type, AST::Builtin.false_type]
           else
             [type, nil]
           end
@@ -421,6 +423,14 @@ module Steep
                     return_type: AST::Types::Logic::ArgIsReceiver.new(location: method_type.type.return_type.location)
                   )
                 )
+              when RBS::BuiltinNames::Object.name, RBS::BuiltinNames::String.name, RBS::BuiltinNames::Integer.name, RBS::BuiltinNames::Symbol.name,
+                RBS::BuiltinNames::TrueClass.name, RBS::BuiltinNames::FalseClass.name, TypeName("::NilClass")
+                # Value based type-case works on literal types which is available for String, Integer, Symbol, TrueClass, FalseClass, and NilClass
+                return method_type.with(
+                  type: method_type.type.with(
+                    return_type: AST::Types::Logic::ArgEqualsReceiver.new(location: method_type.type.return_type.location)
+                  )
+                )
               end
             end
           end

data/lib/steep/ast/types/logic.rb

@@ -58,16 +58,23 @@ module Steep
           end
         end
 
+        class ArgEqualsReceiver < Base
+          def initialize(location: nil)
+            @location = location
+          end
+        end
+
         class Env < Base
-          attr_reader :truthy, :falsy
+          attr_reader :truthy, :falsy, :type
 
-          def initialize(truthy:, falsy:, location: nil)
+          def initialize(truthy:, falsy:, type:, location: nil)
             @truthy = truthy
             @falsy = falsy
+            @type = type
           end
 
           def ==(other)
-            other.is_a?(Env) && other.truthy == truthy && other.falsy == falsy
+            other.is_a?(Env) && other.truthy == truthy && other.falsy == falsy && other.type == type
           end
 
           alias eql? ==
@@ -75,6 +82,12 @@ module Steep
           def hash
             self.class.hash ^ truthy.hash ^ falsy.hash
           end
+
+          def inspect
+            "#<Steep::AST::Types::Env @type=#{type}, @truthy=..., @falsy=...>"
+          end
+
+          alias to_s inspect
         end
       end
     end

data/lib/steep/ast/types/top.rb

@@ -23,7 +23,7 @@ module Steep
         end
 
         def to_s
-          "⟙"
+          "top"
         end
 
         include Helper::NoFreeVariables