steam-prices 0.1.6 → 0.1.8

data/Gemfile

@@ -0,0 +1,4 @@
+source "http://rubygems.org"
+gem "nokogiri", '1.5.0'
+gem "money"
+gem "rspec"

data/Gemfile.lock

@@ -0,0 +1,24 @@
+GEM
+  remote: http://rubygems.org/
+  specs:
+    diff-lcs (1.1.2)
+    i18n (0.6.0)
+    money (3.7.1)
+      i18n (~> 0.4)
+    nokogiri (1.5.0)
+    rspec (2.6.0)
+      rspec-core (~> 2.6.0)
+      rspec-expectations (~> 2.6.0)
+      rspec-mocks (~> 2.6.0)
+    rspec-core (2.6.4)
+    rspec-expectations (2.6.0)
+      diff-lcs (~> 1.1.2)
+    rspec-mocks (2.6.0)
+
+PLATFORMS
+  ruby
+
+DEPENDENCIES
+  money
+  nokogiri (= 1.5.0)
+  rspec

data/README.md

@@ -1,5 +1,18 @@
 ## changelog
 
+**v0.1.8**
+
+- issues with nokogiri
+- saves sale prices in :original_price
+
+**v0.1.7**
+
+- dealing with free games
+- limited countries
+- trailing slash removed
+- should update all prices if nil is passed
+- special exception wasn't of Money class
+
 **v0.1.6**
 
 - forgot to handle a case for retribution, where it would update a single one

data/lib/{steam_prices.rb → steam-prices.rb}

@@ -1,3 +1,6 @@
+require "rubygems"
+require "bundler/setup"
+
 require 'steam_prices/steam_updater'
 require 'steam_prices/steam_country'
 require 'steam_prices/steam_game'

data/lib/steam_prices/steam_country.rb

@@ -5,9 +5,8 @@ module SteamPrices
       'usd'       => 'us',
       'gbp'       => 'uk',
       'aud'       => 'au',
-      'eur'       => 'at',
-      'eur'       => 'de',
-      'nok'       => 'no' }
+      'eur'       => 'fr'
+    }
 
     class << self; attr_reader :currencies; end
     

data/lib/steam_prices/steam_game.rb

@@ -4,17 +4,18 @@ module SteamPrices
       include Updater
     
       attr_reader :app_id, :app_name, :store_link, :logo_link, :date_released, :status, :category
-      attr_accessor :price
+      attr_accessor :price, :original_price
     
-      def initialize(app_name = nil, app_id = nil, store_link = nil, logo_link = nil, date_released = nil, price = nil)
+      def initialize(app_name = nil, app_id = nil, store_link = nil, logo_link = nil, date_released = nil, price = nil, original_price = nil)
         @app_id = app_id.to_i
         @app_name = app_name.to_s
         @store_link = store_link ||= "http://store.steampowered.com/app/12312312"
-        @category = (@store_link.match(/(.*store\.steampowered\.com\/app\/[\d]+\/)/) ? GAME : PACK)
+        @category = (@store_link.match(/(.*store\.steampowered\.com\/app\/[\d]+)/) ? GAME : PACK)
         @logo_link = logo_link
         @date_released = date_released
         raise ArgumentError, "Expected: Money()" if price.class.name != 'Money' && price != nil
         @price = price
+        @original_price = original_price
       end
       
       def update(currency = nil)

data/lib/steam_prices/version.rb

@@ -1,3 +1,3 @@
 module SteamPrices
-  VERSION = "0.1.6"
+  VERSION = "0.1.8"
 end

data/spec/spec_helper.rb

@@ -1,5 +1,5 @@
 $LOAD_PATH << File.join(File.dirname(__FILE__), '..', 'lib')
 $LOAD_PATH << File.join(File.dirname(__FILE__))
 
-require 'steam_prices'
+require 'steam-prices'
 require 'rspec'

data/spec/steam_game_spec.rb

@@ -3,15 +3,16 @@ require 'spec_helper'
 describe SteamPrices::Game do
 
   it "should be able to have an app id, app name, logo, and store link" do
-    g = SteamPrices::Game.new('brink', 31314, '', '', '', Money.new(1499, 'USD'))
+    g = SteamPrices::Game.new('brink', 31314, '', '', '', Money.new(1499, 'USD'), Money.new(1299, 'USD'))
     g.app_name.should == 'brink'
     g.app_id.should == 31314
   end
 
   it "should have a valid price of the money class" do
     lambda { g = SteamPrices::Game.new('brink', 31314, '', '', '', '') }.should raise_error
-    g = SteamPrices::Game.new('brink', 31314, '', '', '', Money.new(1499, 'USD'))
+    g = SteamPrices::Game.new('brink', 31314, '', '', '', Money.new(1499, 'USD'), Money.new(1299, 'USD'))
     g.price.should == 14.99
+    g.original_price.should == 12.99
   end
 
 

data/spec/steam_updater_spec.rb

@@ -1,5 +1,15 @@
 require 'spec_helper'
 
+puts Nokogiri::VERSION_INFO
+
+def find_game(games, currency, app_id, category = 998)
+  games[app_id].each do |game|
+    return game if (game[:game].price == nil || game[:game].price.currency.iso_code.upcase == currency.upcase) && game[:game].category == category
+  end
+  return nil
+  
+end
+
 describe SteamPrices::Updater do
 
   before(:each) do
@@ -13,10 +23,25 @@ describe SteamPrices::Updater do
       URI.should_receive(:encode).exactly(1).times.and_return(File.dirname(__FILE__) + '/support/packs.html')
     end
 
+
+    it "should not find any duplicates" do
+      games = SteamPrices::Game.update_all_packs('usd', false)
+      games.each do |k,v|
+        v.collect { |g| g[:game].category if g[:game].category == SteamPrices::Updater::PACK }.size.should == 1
+        v.collect { |g| g[:game].category if g[:game].category == SteamPrices::Updater::GAME }.size.should == 1
+      end
+    end
+
+    it "should be able to tell whether it's a pack or a game" do
+      games = SteamPrices::Game.update_all_packs('usd', false)
+      find_game(games, 'usd', 6433, 996)[:type].should == SteamPrices::Updater::PACK
+    end
+
+
     it "should be able to scrape steam and give a bunch of prices for a pack" do
       games = SteamPrices::Game.update_all_packs('usd', false)
       games.size.should == 25
-      games[6433]['usd'][:game].price.should == 39.99
+      find_game(games, 'usd', 6433, 996)[:game].price.should == 39.99
     end
     
     it "should be able to find a single pack" do
@@ -25,20 +50,46 @@ describe SteamPrices::Updater do
     end
   end
   
-  it "should be able to update EVERYTHING", :everything => true do
+  it "should be able to update EVERYTHING (usd)", :everything => true do
     URI.should_receive(:encode).exactly(5).times.and_return(File.dirname(__FILE__) + '/support/us.html')
     URI.should_receive(:encode).exactly(1).times.and_return(File.dirname(__FILE__) + '/support/packs.html')
     games = SteamPrices::Game.update_everything('usd', false)
-    games.size.should == 25+19
+    games.size.should == 25+18
     #pack
-    games[6433]['usd'][:game].price.should == 39.99
-    games[6433]['usd'][:status].should == :ok
+    find_game(games, 'usd', 6433, 996)[:game].price.to_f.should == 39.99
+    find_game(games, 'usd', 6433, 996)[:status].should == :ok
+    
+    find_game(games, 'usd', 15540, 998)[:game].price.to_f.should == 8.99
+    find_game(games, 'usd', 15540, 998)[:status].should == :ok
     #game
-    games[22350]['usd'][:game].price.should == 49.99
-    games[22350]['usd'][:status].should == :ok
+    find_game(games, 'usd', 22350, 998)[:game].price.to_f.should == 49.99
+    find_game(games, 'usd', 22350, 998)[:status].should == :ok
     
   end
   
+  it "should be able to update EVERYTHING (gbp)", :gbp => true do
+    URI.should_receive(:encode).exactly(1).times.and_return(File.dirname(__FILE__) + '/support/uk.html')
+    URI.should_receive(:encode).exactly(1).times.and_return(File.dirname(__FILE__) + '/support/packs.html')
+    games = SteamPrices::Game.update_everything('gbp', true)
+    # because thisis the total of theapp ids
+    games.size.should == 25+25-1
+    #pack
+    find_game(games, 'gbp', 15540, 998)[:game].price.to_f.should == 5.99
+    find_game(games, 'gbp', 15540, 998)[:status].should == :ok
+    #game
+    find_game(games, 'gbp', 12520, 998)[:game].price.to_f.should == 5.99
+    find_game(games, 'gbp', 12520, 998)[:status].should == :ok
+    
+  end
+  
+  it "should be able to tell whether it's a pack or a game" do
+    URI.should_receive(:encode).exactly(1).times.and_return(File.dirname(__FILE__) + '/support/uk.html')
+    URI.should_receive(:encode).exactly(1).times.and_return(File.dirname(__FILE__) + '/support/packs.html')
+    games = SteamPrices::Game.update_everything('gbp', true)
+    find_game(games, 'gbp', 6433, 998)[:type].should == SteamPrices::Updater::GAME
+    find_game(games, 'gbp', 6433, 996)[:type].should == SteamPrices::Updater::PACK
+  end
+  
   context "all prices" do
 
     before(:each) do
@@ -51,29 +102,36 @@ describe SteamPrices::Updater do
       @games.size.should == 19
     end  
   
+
+  
+  
   
     context "exceptions" do
       it "should be able to handle games like lost coast, which are part of a pack only and list the pack price" do
-        @games[340]['usd'][:game].price.should == 0.00
+        find_game(@games, 'usd', 340, 998)[:game].price.should == 0.00
+        find_game(@games, 'usd', 340, 998)[:game].price.class.name.should == "Money"
       end
-      
-      it "should be able to handle games like warhammer retribution where it points to a different app id" do
-        @games[56400]['usd'][:game].price.should == 29.99
+  
+      it "should find games with a sale price" do
+        find_game(@games, 'usd', 39170, 998)[:game].price.should == 44.99
+        find_game(@games, 'usd', 39170, 998)[:game].original_price.should == 49.99        
       end
       
       it "should have an ok status if the price is ok" do
-        @games[22350]['usd'][:game].price.should == 49.99
-        @games[22350]['usd'][:status].should == :ok
+        find_game(@games, 'usd', 22350, 998)[:game].price.should == 49.99
+        find_game(@games, 'usd', 22350, 998)[:status].should == :ok
       end
       
       it "should have a not found status if the price is empty but the url is found (preorder)" do
-        @games[55150]['usd'][:game].price.should == nil
-        @games[55150]['usd'][:status].should == :not_found
+        find_game(@games, 'usd', 55150, 998)[:game].price.should == nil
+        find_game(@games, 'usd', 55150, 998)[:status].should == :not_found
       end
 
 
+
+
       it "should have a bad request status if the url is invalid or some other crazy error" do
-        @games['http://store.steampowered.com/sale/magic2011?snr=1_7_7_230_150_27']['usd'][:status].should == :bad_request
+        @games['http://store.steampowered.com/sale/magic2011?snr=1_7_7_230_150_27'][0][:status].should == :bad_request
       end
 
     end
@@ -89,6 +147,14 @@ describe SteamPrices::Updater do
     end
 
 
+    it "should find games with a sale price" do
+      g = SteamPrices::Game.new('somename', 39170)
+      p = g.update('usd')['usd']
+      p[:original_price].should == 49.99
+      p[:price].should == 44.99
+    end
+
+
     it "should be able to return a status if it was ok" do
       g = SteamPrices::Game.new('brink', 22350)
       p = g.update('usd')['usd']
@@ -96,13 +162,15 @@ describe SteamPrices::Updater do
       p[:status].should == :ok
     end
 
-
-    it "should be able to deal with a game like retribution where it redirects to an id", :ret => true do
-      g = SteamPrices::Game.new('Warhammer® 40,000®: Dawn of War® II – Retribution™', 56400)
+    it "should be able to return a price even if the price was 0" do
+      g = SteamPrices::Game.new('brink', 10650)
       p = g.update('usd')['usd']
-      p[:price].should == 29.99
+      p[:price].should == 0.00      
+      p[:status].should == :ok      
     end
 
+
+
     it "should be able to return not found if it wasn't ok" do
       g = SteamPrices::Game.new('Warhammer 40,000: Space Marine', 55150)
       p = g.update('usd')['usd']

metadata

@@ -1,99 +1,75 @@
---- !ruby/object:Gem::Specification 
+--- !ruby/object:Gem::Specification
 name: steam-prices
-version: !ruby/object:Gem::Version 
-  hash: 23
+version: !ruby/object:Gem::Version
+  version: 0.1.8
   prerelease: 
-  segments: 
-  - 0
-  - 1
-  - 6
-  version: 0.1.6
 platform: ruby
-authors: 
+authors:
 - scott tesoriere
 autorequire: 
 bindir: bin
 cert_chain: []
-
-date: 2011-05-25 00:00:00 -04:00
+date: 2011-07-02 00:00:00.000000000 -04:00
 default_executable: 
-dependencies: 
-- !ruby/object:Gem::Dependency 
+dependencies:
+- !ruby/object:Gem::Dependency
   name: rspec
-  prerelease: false
-  requirement: &id001 !ruby/object:Gem::Requirement 
+  requirement: &2153226700 !ruby/object:Gem::Requirement
     none: false
-    requirements: 
-    - - ">="
-      - !ruby/object:Gem::Version 
-        hash: 62196475
-        segments: 
-        - 2
-        - 0
-        - 0
-        - beta
-        - 12
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
         version: 2.0.0.beta.12
   type: :development
-  version_requirements: *id001
-- !ruby/object:Gem::Dependency 
-  name: nokogiri
   prerelease: false
-  requirement: &id002 !ruby/object:Gem::Requirement 
+  version_requirements: *2153226700
+- !ruby/object:Gem::Dependency
+  name: nokogiri
+  requirement: &2153226040 !ruby/object:Gem::Requirement
     none: false
-    requirements: 
-    - - ">="
-      - !ruby/object:Gem::Version 
-        hash: 3
-        segments: 
-        - 0
-        version: "0"
+    requirements:
+    - - =
+      - !ruby/object:Gem::Version
+        version: 1.5.0
   type: :development
-  version_requirements: *id002
-- !ruby/object:Gem::Dependency 
-  name: money
   prerelease: false
-  requirement: &id003 !ruby/object:Gem::Requirement 
+  version_requirements: *2153226040
+- !ruby/object:Gem::Dependency
+  name: money
+  requirement: &2153221400 !ruby/object:Gem::Requirement
     none: false
-    requirements: 
-    - - ">="
-      - !ruby/object:Gem::Version 
-        hash: 3
-        segments: 
-        - 0
-        version: "0"
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
   type: :development
-  version_requirements: *id003
-- !ruby/object:Gem::Dependency 
-  name: open-uri
   prerelease: false
-  requirement: &id004 !ruby/object:Gem::Requirement 
+  version_requirements: *2153221400
+- !ruby/object:Gem::Dependency
+  name: open-uri
+  requirement: &2153220820 !ruby/object:Gem::Requirement
     none: false
-    requirements: 
-    - - ">="
-      - !ruby/object:Gem::Version 
-        hash: 3
-        segments: 
-        - 0
-        version: "0"
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
   type: :development
-  version_requirements: *id004
+  prerelease: false
+  version_requirements: *2153220820
 description: 
-email: 
-- scott@tesoriere.com
+email: scott@tesoriere.com
 executables: []
-
 extensions: []
-
 extra_rdoc_files: []
-
-files: 
+files:
+- Gemfile
+- Gemfile.lock
 - README.md
+- lib/steam-prices.rb
 - lib/steam_prices/steam_country.rb
 - lib/steam_prices/steam_game.rb
 - lib/steam_prices/steam_updater.rb
 - lib/steam_prices/version.rb
-- lib/steam_prices.rb
 - spec/spec_helper.rb
 - spec/steam_country_spec.rb
 - spec/steam_game_spec.rb
@@ -101,38 +77,29 @@ files:
 has_rdoc: true
 homepage: http://github.com/scottkf/steam_prices
 licenses: []
-
 post_install_message: 
 rdoc_options: []
-
-require_paths: 
+require_paths:
 - lib
-required_ruby_version: !ruby/object:Gem::Requirement 
+required_ruby_version: !ruby/object:Gem::Requirement
   none: false
-  requirements: 
-  - - ">="
-    - !ruby/object:Gem::Version 
-      hash: 3
-      segments: 
-      - 0
-      version: "0"
-required_rubygems_version: !ruby/object:Gem::Requirement 
+  requirements:
+  - - ! '>='
+    - !ruby/object:Gem::Version
+      version: '0'
+required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
-  requirements: 
-  - - ">="
-    - !ruby/object:Gem::Version 
-      hash: 3
-      segments: 
-      - 0
-      version: "0"
+  requirements:
+  - - ! '>='
+    - !ruby/object:Gem::Version
+      version: '0'
 requirements: []
-
 rubyforge_project: 
 rubygems_version: 1.6.2
 signing_key: 
 specification_version: 3
 summary: Prices for steam.
-test_files: 
+test_files:
 - spec/steam_country_spec.rb
 - spec/steam_game_spec.rb
 - spec/steam_updater_spec.rb