steam-prices 0.1.3 → 0.1.5

data/README.md

@@ -1,5 +1,14 @@
 ## changelog
 
+**v0.1.5**
+
+- refactoring
+
+**v0.1.4**
+
+- can update packs
+- handles special exceptions, like lost coast
+
 **v0.1.3** 
 
 - fixed problem when dealing with sale prices

data/lib/steam_prices/steam_game.rb

@@ -3,12 +3,14 @@ module SteamPrices
     
       include Updater
     
-      attr_reader :app_id, :app_name, :store_link, :logo_link, :date_released, :price
+      attr_reader :app_id, :app_name, :store_link, :logo_link, :date_released, :status, :category
+      attr_accessor :price
     
       def initialize(app_name = nil, app_id = nil, store_link = nil, logo_link = nil, date_released = nil, price = nil)
         @app_id = app_id.to_i
         @app_name = app_name.to_s
-        @store_link = store_link
+        @store_link = store_link ||= "http://store.steampowered.com/app/12312312"
+        @category = (@store_link.match(/(.*store\.steampowered\.com\/app\/[\d]+\/)/) ? GAME : PACK)
         @logo_link = logo_link
         @date_released = date_released
         raise ArgumentError, "Expected: Money()" if price.class.name != 'Money' && price != nil
@@ -17,7 +19,7 @@ module SteamPrices
       
       def update(currency = nil)
         return nil if !@app_name or @app_id == 0
-        self.class.update_one(@app_name, @app_id, currency)
+        self.class.update_one(@category, @app_name, @app_id, currency)
       end
       
     end

data/lib/steam_prices/steam_updater.rb

@@ -7,6 +7,16 @@ module SteamPrices
       base.extend ClassMethods
     end
     
+    
+    EXCEPTIONS = {
+      #warhammer retribution
+      56400 => 56437,
+      #lost coast
+      340 => 0.00,
+    }
+    
+    PACK = 996
+    GAME = 998
   
 
 
@@ -16,37 +26,74 @@ module SteamPrices
       end
     
 
+      def status(price)
+        (price.empty? ? :not_found : :ok)
+      end
+      
+      def get_price(node)
+        # remove strikethrough prices
+        node.search('span').remove
+        price = node.text.gsub(/[\W_]/, '')
+      end
+      
+      
+
+      def update_one_game(name, app_id, currency = nil)
+        self.update_one(GAME, name, app_id, currency)
+      end
+      
+      def update_one_pack(name, app_id, currency = nil)
+        self.update_one(PACK, name, app_id, currency)
+      end
+
       # update a single one
-      def update_one(name, app_id, currency = nil)      
+      def update_one(category, name, app_id, currency = nil)      
         prices = Hash.new
 
         @countries = self.currency(currency) if !currency.nil?
 
         @countries.each do |curr, country|
-          doc = Nokogiri::HTML(open(URI.encode("http://store.steampowered.com/search/results?sort_by=Name&sort_order=ASC&category1=998&cc=#{country}&v6=1&page=1&term=#{name}")))
-          price = doc.xpath('.//a[regex(., "/store\.steampowered\.com\/app\/' + app_id.to_s + '/")]', Class.new {
+          doc = Nokogiri::HTML(open(URI.encode("http://store.steampowered.com/search/results?sort_by=Name&sort_order=ASC&category1=#{category}&cc=#{country}&v6=1&page=1&term=#{name}")))
+          node = doc.xpath('.//a[regex(., "/store\.steampowered\.com\/(app|sub)\/' + app_id.to_s + '/")]', Class.new {
             def regex node_set, regex
               node_set.find_all { |node| node['href'] =~ /#{regex}/ }
             end
-          }.new).search('.search_price').text.gsub(/[\W_]/, '').to_i
-          prices[curr] = Money.new(price, curr)
+          }.new).search('.search_price')
+          price = self.get_price(node)
+          status = (node.empty? ? :bad_request : self.status(price))
+          prices[curr] = { :price => (status == :ok ? Money.new(price.to_f, curr) : nil), :status => status }
         end
         prices
       end
       
+      def update_everything(currency = nil, display = true)
+        #combine the two hashes
+        self.update_all_games(currency, display).merge!(self.update_all_packs(currency, display))
+      end
+      
+      def update_all_games(currency = nil, display = true)
+        self.update_all(GAME, currency, display)
+      end
+      
+      def update_all_packs(currency = nil, display = true)
+        self.update_all(PACK, currency, display)
+      end
       
       # display stolen from https://github.com/spezifanta/SteamCalculator-Scripts/blob/master/getGames
-      def update_all(currency = nil, display = true)
-        games = Array.new
+      def update_all(category, currency = nil, display = true)
+        games = Hash.new
       
         @countries = self.currency(currency) if !currency.nil?
       
         @countries.each do |curr, country|
-          doc = Nokogiri::HTML(open(URI.encode("http://store.steampowered.com/search/results?sort_by=Name&sort_order=ASC&category1=998&cc=#{country}&v6=1&page=1")))
+          doc = Nokogiri::HTML(open(URI.encode("http://store.steampowered.com/search/results?sort_by=Name&sort_order=ASC&category1=#{category}&cc=#{country}&v6=1&page=1")))
           gamesPerPage, totalGames = doc.search('.search_pagination_left')[0].text.match(/showing\s\d+\s-\s(\d+)\sof\s(\d+)/m).captures
 
           totalPages = (totalGames.to_i / gamesPerPage.to_i).ceil
 
+          exceptions = Array.new
+
+
           for i in 1..totalPages
 
             if display then
@@ -58,21 +105,27 @@ module SteamPrices
             end
             
             doc.search('.search_result_row').each do |game|
-              url = game.attr('href').match(/(.*store\.steampowered\.com\/app\/([\d]+)\/)/)
+              url = game.attr('href').match(/(.*store\.steampowered\.com\/(app|sub)\/([\d]+)\/)/)
+              # for things like /sale/
               if !url then
-                games << nil
+                games[game.attr('href')] = Hash.new if !games[game.attr('href')]
+                games[game.attr('href')][curr] = { :status => :bad_request, :game => nil}
               else
-                link, app_id = url.captures
+                link, type, app_id = url.captures
+                
                 #remove retail price and put sale price
-                game.search('.search_price').search('span').remove
-                price = game.search('.search_price').text.gsub(/[\W_]/, '').to_f
+                price = self.get_price(game.search('.search_price'))
                 date = game.search('.search_released').text
                 name = game.search('h4').text
                 logo = game.search('.search_capsule img').attr('src').value
 
                 print "|% 8s |" % app_id + "% 8.2f |" % (price.to_f / 100) + "% 14s |" % date if display
                 printf " %s%" + (43 - name[0,43].length).to_s + "s\n", name[0,42], " " if display
-                games << SteamPrices::Game.new(name, app_id, link, logo, date, Money.new(price.to_f, curr))
+                status = self.status(price)
+                game = SteamPrices::Game.new(name, app_id, link, logo, date, (status == :ok ? Money.new(price.to_f, curr) : nil))
+                
+                games[app_id.to_i] = Hash.new if !games[app_id.to_i]
+                games[app_id.to_i][curr] = { :game => game, :status => status }
               end
             end
 
@@ -82,6 +135,28 @@ module SteamPrices
 
           end
           
+          # check if there are any special cases
+          EXCEPTIONS.each do |app_id, v|
+            if games.key? app_id then
+              
+              games[app_id].each do |currency, game|
+                if v.class.name == 'Fixnum' then
+                  # it's an app id, so we need to either fetch the real price, or get it if we already have it
+                  price = (games.key?(v) ? games[v][currency][:game].price : self.update_one(game[:game].app_name, v, currency)[currency][:price])
+                elsif v.class.name == 'Float' then
+                  # it's a price
+                  price = v
+                else
+                  # it's a sub
+                  # get the price of the sub
+                end
+                # update the price
+                game[:game].price = price
+                
+              end
+            end
+          end
+          
         end
         games      
       end

data/lib/steam_prices/version.rb

@@ -1,3 +1,3 @@
 module SteamPrices
-  VERSION = "0.1.3"
+  VERSION = "0.1.5"
 end

data/spec/steam_updater_spec.rb

@@ -5,35 +5,119 @@ describe SteamPrices::Updater do
   before(:each) do
     URI.stub!(:encode)
   end
+  
+  
+  context "packs", :packs => true do
+    before(:each) do
+      # it says there are 5 pages
+      URI.should_receive(:encode).exactly(1).times.and_return(File.dirname(__FILE__) + '/support/packs.html')
+    end
+
+    it "should be able to scrape steam and give a bunch of prices for a pack" do
+      games = SteamPrices::Game.update_all_packs('usd', true)
+      games.size.should == 25
+      games[6433]['usd'][:game].price.should == 39.99
+    end
+    
+    it "should be able to find a single pack" do
+      g = SteamPrices::Game.new('1C Action Collection', 6433, 'http://store.steampowered.com/sub/6433/?snr=1_7_7_230_150_1')
+      g.update('usd')['usd'][:price].should == 39.99
+    end
+  end
+  
+  it "should be able to update EVERYTHING", :everything => true do
+    URI.should_receive(:encode).exactly(5).times.and_return(File.dirname(__FILE__) + '/support/us.html')
+    URI.should_receive(:encode).exactly(1).times.and_return(File.dirname(__FILE__) + '/support/packs.html')
+    games = SteamPrices::Game.update_everything('usd', false)
+    games.size.should == 25+19
+    #pack
+    games[6433]['usd'][:game].price.should == 39.99
+    games[6433]['usd'][:status].should == :ok
+    #game
+    games[22350]['usd'][:game].price.should == 49.99
+    games[22350]['usd'][:status].should == :ok
+    
+  end
+  
   context "all prices" do
 
-    it "should be able to scrape steam and give a bunch of prices" do
+    before(:each) do
+      # it says there are 5 pages
       URI.should_receive(:encode).exactly(5).times.and_return(File.dirname(__FILE__) + '/support/us.html')
-      games = SteamPrices::Game.update_all('usd', true)
-      # the pages are set to 5 in the example, and there are 19 items on the page
-      5.times do |i|
-        games[i*19].price.should == 9.99
-      end
-      games.size.should == 95
+      @games = SteamPrices::Game.update_all_games('usd', true)
+    end
+
+    it "should be able to scrape steam and give a bunch of prices" do
+      @games.size.should == 19
     end  
+  
+  
+    context "exceptions" do
+      it "should be able to handle games like lost coast, which are part of a pack only and list the pack price" do
+        @games[340]['usd'][:game].price.should == 0.00
+      end
+      
+      it "should be able to handle games like warhammer retribution where it points to a different app id" do
+        @games[56400]['usd'][:game].price.should == 29.99
+      end
+      
+      it "should have an ok status if the price is ok" do
+        @games[22350]['usd'][:game].price.should == 49.99
+        @games[22350]['usd'][:status].should == :ok
+      end
+      
+      it "should have a not found status if the price is empty but the url is found (preorder)" do
+        @games[55150]['usd'][:game].price.should == nil
+        @games[55150]['usd'][:status].should == :not_found
+      end
+
+
+      it "should have a bad request status if the url is invalid or some other crazy error" do
+        @games['http://store.steampowered.com/sale/magic2011?snr=1_7_7_230_150_27']['usd'][:status].should == :bad_request
+      end
+
+    end
+  
     
   end
   
+  
+  
   context "a single price" do
     before(:each) do
       URI.should_receive(:encode).and_return(File.dirname(__FILE__) + '/support/us.html')
+    end
+
+
+    it "should be able to return a status if it was ok" do
+      g = SteamPrices::Game.new('brink', 22350)
+      p = g.update('usd')['usd']
+      p[:price].should == 49.99      
+      p[:status].should == :ok
+    end
+
+
+    it "should be able to return not found if it wasn't ok" do
+      g = SteamPrices::Game.new('Warhammer 40,000: Space Marine', 55150)
+      p = g.update('usd')['usd']
+      p[:price].should == nil 
+      p[:status].should == :not_found
+    end
 
+    it "should be able to get confused if something went crazy or wasn't there" do
+      g = SteamPrices::Game.new('awdwad', 21231232350)
+      g.update('usd')['usd'][:status].should == :bad_request   
     end
 
     it "should be able to find a single game and update it's price (instance)" do
       g = SteamPrices::Game.new('brink', 22350)
-      g.update('usd')['usd'].should == 49.99
+      g.update('usd')['usd'][:price].should == 49.99
 
     end
 
     it "should be able to find a single game and update it's price (class)" do
-      prices = SteamPrices::Game.update_one('brink', 22350, 'usd')
-      prices['usd'].should == 49.99
+      prices = SteamPrices::Game.update_one_game('brink', 22350, 'usd')
+      prices['usd'][:price].should == 49.99
     end    
   end
 

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification 
 name: steam-prices
 version: !ruby/object:Gem::Version 
-  hash: 29
+  hash: 17
   prerelease: 
   segments: 
   - 0
   - 1
-  - 3
-  version: 0.1.3
+  - 5
+  version: 0.1.5
 platform: ruby
 authors: 
 - scott tesoriere
@@ -15,7 +15,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2011-05-23 00:00:00 Z
+date: 2011-05-25 00:00:00 Z
 dependencies: 
 - !ruby/object:Gem::Dependency 
   name: rspec
@@ -126,7 +126,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
 requirements: []
 
 rubyforge_project: 
-rubygems_version: 1.7.2
+rubygems_version: 1.8.3
 signing_key: 
 specification_version: 3
 summary: Prices for steam.