statsd-instrument 3.5.1 → 3.5.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 45499b5743c8202fb33807dfbea271ce432b9e28cf4cb360ecde628b4aacee1d
-  data.tar.gz: 9faea13d1feb7b2d26d1f26334a306e881c87d12df52fece199047af0ecf62b9
+  metadata.gz: f7ef9b0c6e5682818fc957cbe2cf4cd37180aa8178329577d5e3d53845784073
+  data.tar.gz: f965e44fc446ff14a96ab0818871b97c9fe5980fad1dc45be32726b2d3b2d368
 SHA512:
-  metadata.gz: 9d75637c2b6761835723a8dd343a7238c29137c5ca082784e859a6c79303432639d2be9f55cc98a3188fb45b2cd163c9b82086c256d8d4f673e3bae918807a40
-  data.tar.gz: 986d8661bdd02ba809ea03a56bde2fefee5d98e4c73ef823c62fc5dff4efc616ba0f881e6f1b9be8a295da3649e48a2cc74b159f8c9380db2b0ae658b72e385b
+  metadata.gz: e3830d435e3b3fc30412a0319dd58534bf4b871c40d5707a7471cd92a4d5327cc4c45a28287df14342e7402c609f8b98d36ba5a39cc3a07c1199f4e05389581d
+  data.tar.gz: 2b06036a80cfb1c5dcfdc16ee21a848fe2fe3165b3f05d4d64e1c9620c2fb84bab3eb48518117c3b11daea0b6d0ace2a692c78e58b1686272933e5f14626438d

data/CHANGELOG.md

@@ -6,6 +6,10 @@ section below.
 
 ## Unreleased changes
 
+## Version 3.5.2
+
+- Fix bug on assertions to allow the user passes `times: 0` as expectation.
+
 ## Version 3.5.1
 
 - Fix bug when passing a lambda function to dynamically set the tags in the strict mode.

data/README.md

@@ -265,6 +265,8 @@ metric_tagger = lambda { |object, args| { "key": args.first } }
 GoogleBase.statsd_count(:insert, 'GoogleBase.insert', tags: metric_tagger)
 ```
 
+> You can only use the dynamic tag while using the instrumentation through metaprogramming methods
+
 ## Testing
 
 This library comes with a module called `StatsD::Instrument::Assertions` and `StatsD::Instrument::Matchers` to help you write tests

data/lib/statsd/instrument/assertions.rb

@@ -165,6 +165,8 @@ module StatsD
           filtered_datagrams = datagrams.select { |m| m.type == expectation.type && m.name == expectation.name }
 
           if filtered_datagrams.empty?
+            next if expectation_times == 0
+
             flunk("No StatsD calls for metric #{expectation.name} of type #{expectation.type} were made.")
           end
 
@@ -193,7 +195,7 @@ module StatsD
         end
         expectations -= matched_expectations
 
-        unless expectations.empty?
+        if expectations.any? { |m| m.times != 0 }
           flunk("Unexpected StatsD calls; the following metric expectations " \
             "were not satisfied: #{expectations.inspect}")
         end

data/lib/statsd/instrument/version.rb

@@ -2,6 +2,6 @@
 
 module StatsD
   module Instrument
-    VERSION = "3.5.1"
+    VERSION = "3.5.2"
   end
 end

data/test/assertions_test.rb

@@ -303,6 +303,23 @@ class AssertionsTest < Minitest::Test
       StatsD.increment("counter", tags: { foo: 1 })
       StatsD.increment("counter", tags: { foo: 2 })
     end
+
+    foo_1_metric = StatsD::Instrument::Expectation.increment("counter", times: 2, tags: ["foo:1"])
+    foo_2_metric = StatsD::Instrument::Expectation.increment("counter", times: 0, tags: ["foo:2"])
+    @test_case.assert_statsd_expectations([foo_1_metric, foo_2_metric]) do
+      StatsD.increment("counter", tags: { foo: 1 })
+      StatsD.increment("counter", tags: { foo: 1 })
+    end
+
+    assert_raises(Minitest::Assertion) do
+      foo_1_metric = StatsD::Instrument::Expectation.increment("counter", times: 2, tags: ["foo:1"])
+      foo_2_metric = StatsD::Instrument::Expectation.increment("counter", times: 0, tags: ["foo:2"])
+      @test_case.assert_statsd_expectations([foo_1_metric, foo_2_metric]) do
+        StatsD.increment("counter", tags: { foo: 1 })
+        StatsD.increment("counter", tags: { foo: 1 })
+        StatsD.increment("counter", tags: { foo: 2 })
+      end
+    end
   end
 
   def test_assert_statsd_increment_with_tags

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: statsd-instrument
 version: !ruby/object:Gem::Version
-  version: 3.5.1
+  version: 3.5.2
 platform: ruby
 authors:
 - Jesse Storimer
@@ -10,7 +10,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2023-01-03 00:00:00.000000000 Z
+date: 2023-01-05 00:00:00.000000000 Z
 dependencies: []
 description: A StatsD client for Ruby apps. Provides metaprogramming methods to inject
   StatsD instrumentation into your code.