statsd-instrument 3.0.0.pre2 → 3.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 9d300be8b2e40d3b175eff237d7991949c962b284603c8e16852247171177965
-  data.tar.gz: d3e43a58dec356b4606be2c0c39321db12223672f7caa02dd2b09331ebae9b02
+  metadata.gz: 9e941d77f1b0893b2a919f8c36e902e119c657338e6a4e8b45fc5eaa7b5a05a3
+  data.tar.gz: f80105adf47e4379a59716bd7bb46080db3ed9751edf9ef21ef64689ce39920a
 SHA512:
-  metadata.gz: f269fec546184d3cee07a3cb365babb87bc739c126985bb9218a63f3ec86a58bf22e0f4cbf73fade2f1618cca58b9c32c9d442ebf29f3d81ca0bcfbfc1e024b1
-  data.tar.gz: 0ee20bb6244d8403cd8c4441e9d35cafbff82c8d58b76b7c53a91c2b3d510944769a945f5a151d1b760e6d1799789c79248102a34734806eaaeded24394f8238
+  metadata.gz: 3518393ed260edb75f138168afad1e0f1cbd604bf12511dd73596b84d1721d0008cae138cfdef03291895bd4f8b861dd18b641dcfda093e84976a0d446da5bd3
+  data.tar.gz: 4fd2bc2646b88b497802103eaed1538234e37619ef35363ed061b43ce100dd4d59f03de037b5b766c46e8937b7c926fbba2a0dba7f10d5610fae43e2c31f17f2

data/.github/workflows/ci.yml

@@ -11,7 +11,7 @@ jobs:
       matrix:
         # Windows on macOS builds started failing, so they are disabled for noew
 
-        ruby: [2.3, 2.4, 2.5, 2.6]
+        ruby: [2.4, 2.5, 2.6]
         # platform: [windows-2019, macOS-10.14, ubuntu-18.04]
 
         # exclude:

data/.rubocop-https---shopify-github-io-ruby-style-guide-rubocop-yml

@@ -20,7 +20,7 @@ Style/Alias:
   - prefer_alias
   - prefer_alias_method
 
-Layout/AlignHash:
+Layout/HashAlignment:
   EnforcedHashRocketStyle: key
   EnforcedColonStyle: key
   EnforcedLastArgumentHashStyle: ignore_implicit
@@ -30,7 +30,7 @@ Layout/AlignHash:
   - ignore_implicit
   - ignore_explicit
 
-Layout/AlignParameters:
+Layout/ParameterAlignment:
   EnforcedStyle: with_fixed_indentation
   SupportedStyles:
   - with_first_parameter
@@ -172,7 +172,7 @@ Naming/FileName:
   Regex:
   IgnoreExecutableScripts: true
 
-Layout/IndentFirstArgument:
+Layout/FirstArgumentIndentation:
   EnforcedStyle: consistent
   SupportedStyles:
   - consistent
@@ -225,7 +225,7 @@ Layout/IndentationConsistency:
 Layout/IndentationWidth:
   Width: 2
 
-Layout/IndentFirstArrayElement:
+Layout/FirstArrayElementIndentation:
   EnforcedStyle: consistent
   SupportedStyles:
   - special_inside_parentheses
@@ -233,10 +233,10 @@ Layout/IndentFirstArrayElement:
   - align_brackets
   IndentationWidth:
 
-Layout/IndentAssignment:
+Layout/AssignmentIndentation:
   IndentationWidth:
 
-Layout/IndentFirstHashElement:
+Layout/FirstHashElementIndentation:
   EnforcedStyle: consistent
   SupportedStyles:
   - special_inside_parentheses
@@ -340,9 +340,9 @@ Style/PercentQLiterals:
 Naming/PredicateName:
   NamePrefix:
   - is_
-  NamePrefixBlacklist:
+  ForbiddenPrefixes:
   - is_
-  NameWhitelist:
+  AllowedMethods:
   - is_a?
   Exclude:
   - 'spec/**/*'
@@ -467,7 +467,7 @@ Style/TernaryParentheses:
   - require_no_parentheses
   AllowSafeAssignment: true
 
-Layout/TrailingBlankLines:
+Layout/TrailingEmptyLines:
   EnforcedStyle: final_newline
   SupportedStyles:
   - final_newline
@@ -478,7 +478,7 @@ Style/TrivialAccessors:
   AllowPredicates: true
   AllowDSLWriters: false
   IgnoreClassMethods: false
-  Whitelist:
+  AllowedMethods:
   - to_ary
   - to_a
   - to_c
@@ -561,7 +561,7 @@ Lint/UnusedMethodArgument:
 Naming/AccessorMethodName:
   Enabled: true
 
-Layout/AlignArray:
+Layout/ArrayAlignment:
   Enabled: true
 
 Style/ArrayJoin:
@@ -840,7 +840,7 @@ Style/WhileUntilDo:
 Style/ZeroLengthPredicate:
   Enabled: true
 
-Layout/IndentHeredoc:
+Layout/HeredocIndentation:
   EnforcedStyle: squiggly
 
 Lint/AmbiguousOperator:
@@ -864,7 +864,7 @@ Lint/DeprecatedClassMethods:
 Lint/DuplicateMethods:
   Enabled: true
 
-Lint/DuplicatedKey:
+Lint/DuplicateHashKey:
   Enabled: true
 
 Lint/EachWithObjectArgument:
@@ -891,7 +891,7 @@ Lint/FloatOutOfRange:
 Lint/FormatParameterMismatch:
   Enabled: true
 
-Lint/HandleExceptions:
+Lint/SuppressedException:
   AllowComments: true
 
 Lint/ImplicitStringConcatenation:
@@ -947,7 +947,7 @@ Lint/ShadowedException:
 Lint/ShadowingOuterLocalVariable:
   Enabled: true
 
-Lint/StringConversionInInterpolation:
+Lint/RedundantStringCoercion:
   Enabled: true
 
 Lint/UnderscorePrefixedVariableName:

data/CHANGELOG.md

@@ -8,6 +8,29 @@ section below.
 
 _Nothing yet_
 
+## Version 3.0.0
+
+This version makes the new client that was added in version 2.6+ the default
+client, and removes the legacy client.
+
+- All previously deprecated functionality has been removed (since version 2.5,
+  see below).
+- Support for the StatSite implementation has been dropped.
+- Support for Ruby version older than 2.4 has been dropped.
+- The default implementation has been changed to DataDog. To use the standard
+  StatsD implementation (which was the default in v2), set the
+  `STATSD_IMPLEMENTATION` environment variable to `statsd`.
+
+To upgrade, follow the following process:
+
+1. Upgrade to version 2.9.2.
+2. Switch to the new client by setting the `STATSD_USE_NEW_CLIENT` environment
+   variable to 1.
+   - You may want to use the Rubocop rules that ship with this library, and
+     strict mode to find and fix deprecated usage patterns. See below for more
+     information about strict mode and the available Rubocop rules.
+3. Upgrade to version 3.0.0, and unset `STATSD_USE_NEW_CLIENT`.
+
 ## Version 2.9.2
 
 - Allow providing a value as second positional argument to `assert_statsd_*`

data/benchmark/send-metrics-to-dev-null-log

@@ -2,6 +2,7 @@
 # frozen_string_literal: true
 
 require 'bundler/setup'
+require 'tmpdir'
 require 'benchmark/ips'
 
 revision = %x(git rev-parse HEAD).rstrip

data/benchmark/send-metrics-to-local-udp-receiver

@@ -3,6 +3,7 @@
 
 require 'bundler/setup'
 require 'benchmark/ips'
+require 'tmpdir'
 require 'socket'
 require 'statsd-instrument'
 

data/lib/statsd/instrument.rb

@@ -4,86 +4,14 @@ require 'socket'
 require 'logger'
 require 'forwardable'
 
-# The StatsD module contains low-level metrics for collecting metrics and sending them to the backend.
+# The `StatsD` module contains low-level metrics for collecting metrics and
+# sending them to the backend.
 #
-# @!attribute client
-#   @return [StatsD::Instrument::Backend] The client that will handle singleton method calls in the next
-#     major version of this library.
-#   @note This new Client implementation is intended to become the new default in
-#     the next major release of this library. While this class may already be functional,
-#     we provide no guarantees about the API and the behavior may change.
-#
-# @!attribute backend
-#   The backend that is being used to emit the metrics.
-#   @return [StatsD::Instrument::Backend] the currently active backend. If there is no active backend
-#     yet, it will call {StatsD::Instrument::Environment#default_backend} to obtain a
-#     default backend for the environment.
-#   @see StatsD::Instrument::Environment#default_backend
-#   @deprecated
-#
-# @!attribute prefix
-#   The prefix to apply to metric names. This can be useful to group all the metrics
-#   for an application in a shared StatsD server.
-#
-#   When using a prefix a dot will be included automatically to separate the prefix
-#   from the metric name.
-#
-#   @return [String, nil] The prefix, or <tt>nil</tt> when no prefix is used
-#   @see StatsD::Instrument::Metric#name
-#   @deprecated
-#
-# @!attribute default_sample_rate
-#   The sample rate to use if the sample rate is unspecified for a metric call.
-#   @return [Float] Default is 1.0.
-#   @deprecated
-#
-# @!attribute logger
-#   The logger to use in case of any errors. The logger is also used as default logger
-#   for the LoggerBackend (although this can be overwritten).
-#   @see StatsD::Instrument::Backends::LoggerBackend
-#   @return [Logger]
-#
-# @!attribute default_tags
-#   The tags to apply to all metrics.
-#   @return [Array<String>, Hash<String, String>, nil] The default tags, or <tt>nil</tt> when no default tags is used
-#   @deprecated
-#
-# @!attribute singleton_client
-#   @nodoc
-#   @deprecated
-#
-# @!method measure(name, value = nil, sample_rate: nil, tags: nil, &block)
-#   (see StatsD::Instrument::Client#measure)
-#
-# @!method increment(name, value = 1, sample_rate: nil, tags: nil)
-#   (see StatsD::Instrument::Client#increment)
-#
-# @!method gauge(name, value, sample_rate: nil, tags: nil)
-#   (see StatsD::Instrument::Client#gauge)
-#
-# @!method set(name, value, sample_rate: nil, tags: nil)
-#   (see StatsD::Instrument::Client#set)
-#
-# @!method histogram(name, value, sample_rate: nil, tags: nil)
-#   (see StatsD::Instrument::Client#histogram)
-#
-# @!method distribution(name, value = nil, sample_rate: nil, tags: nil, &block)
-#   (see StatsD::Instrument::Client#distribution)
-#
-# @!method key_value(name, value)
-#   (see StatsD::Instrument::Client#key_value)
-#
-# @!method event(title, text, tags: nil, hostname: nil, timestamp: nil, aggregation_key: nil, priority: nil, source_type_name: nil, alert_type: nil) # rubocop:disable Metrics/LineLength
-#   (see StatsD::Instrument::Client#event)
-#
-# @!method service_check(name, status, tags: nil, hostname: nil, timestamp: nil, message: nil)
-#   (see StatsD::Instrument::Client#service_check)
-#
-# @see StatsD::Instrument <tt>StatsD::Instrument</tt> contains module to instrument
+# @see .singleton_client Metric method calls on the `StatsD` singleton will
+#   be handled by the client assigned to `StatsD.singleton_client`.
+# @see StatsD::Instrument `StatsD::Instrument` contains module to instrument
 #    existing methods with StatsD metrics
 module StatsD
-  extend self
-
   # The StatsD::Instrument module provides metaprogramming methods to instrument your methods with
   # StatsD metrics. E.g., you can create counters on how often a method is called, how often it is
   # successful, the duration of the methods call, etc.
@@ -99,7 +27,9 @@ module StatsD
       end
     end
 
+    # Generates a metric name for an instrumented method.
     # @private
+    # @return [String]
     def self.generate_metric_name(name, callee, *args)
       name.respond_to?(:call) ? name.call(callee, args).gsub('::', '.') : name.gsub('::', '.')
     end
@@ -363,18 +293,55 @@ module StatsD
     end
   end
 
-  attr_accessor :logger
-  attr_writer :singleton_client
+  class << self
+    extend Forwardable
 
-  extend Forwardable
+    # The logger to use in case of any errors.
+    #
+    # @return [Logger]
+    # @see StatsD::Instrument::LogSink
+    attr_accessor :logger
 
-  def singleton_client
-    @singleton_client ||= StatsD::Instrument::Environment.current.client
-  end
+    # The StatsD client that handles method calls on the StatsD singleton.
+    #
+    # E.g. a call to `StatsD.increment` will be handled by this client.
+    #
+    # @return [StatsD::Instrument::Client]
+    attr_writer :singleton_client
+
+    # The StatsD client that handles method calls on the StatsD singleton
+    # @return [StatsD::Instrument::Client]
+    def singleton_client
+      @singleton_client ||= StatsD::Instrument::Environment.current.client
+    end
 
-  # Singleton methods will be delegated to the singleton client.
-  def_delegators :singleton_client, :increment, :gauge, :set, :measure,
-    :histogram, :distribution, :key_value, :event, :service_check
+    # @!method measure(name, value = nil, sample_rate: nil, tags: nil, &block)
+    #   (see StatsD::Instrument::Client#measure)
+    #
+    # @!method increment(name, value = 1, sample_rate: nil, tags: nil)
+    #   (see StatsD::Instrument::Client#increment)
+    #
+    # @!method gauge(name, value, sample_rate: nil, tags: nil)
+    #   (see StatsD::Instrument::Client#gauge)
+    #
+    # @!method set(name, value, sample_rate: nil, tags: nil)
+    #   (see StatsD::Instrument::Client#set)
+    #
+    # @!method histogram(name, value, sample_rate: nil, tags: nil)
+    #   (see StatsD::Instrument::Client#histogram)
+    #
+    # @!method distribution(name, value = nil, sample_rate: nil, tags: nil, &block)
+    #   (see StatsD::Instrument::Client#distribution)
+    #
+    # @!method event(title, text, tags: nil, hostname: nil, timestamp: nil, aggregation_key: nil, priority: nil, source_type_name: nil, alert_type: nil) # rubocop:disable Metrics/LineLength
+    #   (see StatsD::Instrument::Client#event)
+    #
+    # @!method service_check(name, status, tags: nil, hostname: nil, timestamp: nil, message: nil)
+    #   (see StatsD::Instrument::Client#service_check)
+
+    def_delegators :singleton_client, :increment, :gauge, :set, :measure,
+      :histogram, :distribution, :event, :service_check
+  end
 end
 
 require 'statsd/instrument/version'

data/lib/statsd/instrument/assertions.rb

@@ -136,18 +136,6 @@ module StatsD::Instrument::Assertions
     assert_statsd_expectation(expectation, datagrams: datagrams, client: client, &block)
   end
 
-  # Asserts that a given key/value metric occurred inside the provided block.
-  #
-  # @param metric_name (see #assert_statsd_increment)
-  # @param options (see #assert_statsd_increment)
-  # @yield (see #assert_statsd_increment)
-  # @return [void]
-  # @raise (see #assert_statsd_increment)
-  def assert_statsd_key_value(metric_name, value = nil, datagrams: nil, client: nil, **options, &block)
-    expectation = StatsD::Instrument::Expectation.key_value(metric_name, value, **options)
-    assert_statsd_expectation(expectation, datagrams: datagrams, client: client, &block)
-  end
-
   # Asserts that the set of provided metric expectations came true.
   #
   # Generally, it's recommended to  use more specific assertion methods, like

data/lib/statsd/instrument/client.rb

@@ -1,12 +1,27 @@
 # frozen_string_literal: true
 
-# The Client is the main interface for using StatsD.
+# The Client is the main interface for using StatsD. It defines the metric
+# methods that you would normally call from your application.
 #
-# @note This new Client implementation is intended to become the new default in the
-#   next major release of this library. While this class may already be functional,
-#   we provide no guarantees about the API and the behavior may change.
+# The client set to {StatsD.singleton_client} will handle all metric calls made
+# against the StatsD singleton, e.g. `StatsD.increment`.
+#
+# We recommend that the configuration of the StatsD setup is provided through
+# environment variables
+#
+# You are encouraged to instantiate multiple clients, and instantiate variants
+# of an existing clients using {#clone_with_options}. We recommend instantiating
+# a separate client for every logical component of your application using
+# `clone_with_options`, and setting a different metric `prefix`.
+#
+# @see StatsD.singleton_client
+# @see #clone_with_options
 class StatsD::Instrument::Client
   class << self
+    # Instantiates a StatsD::Instrument::Client using configuration values provided in
+    # environment variables.
+    #
+    # @see StatsD::Instrument::Environment
     def from_env(
       env = StatsD::Instrument::Environment.current,
       prefix: env.statsd_prefix,
@@ -26,7 +41,14 @@ class StatsD::Instrument::Client
       )
     end
 
+    # Finds the right DatagramBuilder class for a given implementation.
     # @private
+    # @param [Symbol, String] implementation The name of the implementation, e.g.
+    #   `"statsd"` or `:datadog`.
+    # @return [Class] The subclass of {StatsD::Instrument::DatagramBuilder}
+    #   builder to use to generate UDP datagrams for the given implementation.
+    # @raise `NotImplementedError` if the implementation is not recognized or
+    #   supported.
     def datagram_builder_class_for_implementation(implementation)
       case implementation.to_s
       when 'statsd'
@@ -39,8 +61,87 @@ class StatsD::Instrument::Client
     end
   end
 
-  attr_reader :sink, :datagram_builder_class, :prefix, :default_tags, :default_sample_rate
+  # The class to use to build StatsD datagrams. To build the actual datagrams,
+  # the class will be instantiated, potentially multiple times, by the client.
+  #
+  # @return [Class] A subclass of {StatsD::Instrument::DatagramBuilder}
+  # @see .datagram_builder_class_for_implementation
+  attr_reader :datagram_builder_class
+
+  # The sink to send UDP datagrams to.
+  #
+  # This can be set to any object that responds to the following methods:
+  #
+  # - `sample?` which should return true if the metric should be sampled, i.e.
+  #   actually sent to the sink.
+  # - `#<<` which takes a UDP datagram as string to emit the datagram. This
+  #   method will only be called if `sample?` returned `true`.
+  #
+  # Generally, you should use an instance of one of the following classes that
+  # ship with this library:
+  #
+  # - {StatsD::Instrument::UDPSink} A sink that will actually emit the provided
+  #   datagrams over UDP.
+  # - {StatsD::Instrument::NullSink} A sink that will simply swallow every
+  #   datagram. This sink is for use when testing your application.
+  # - {StatsD::Instrument::LogSink} A sink that log all provided datagrams to
+  #   a Logger, normally {StatsD.logger}.
+  #
+  # @return [#sample?, #<<]
+  attr_reader :sink
 
+  # The prefix to prepend to the metric names that are emitted through this
+  # client, using a dot (`.`) as namespace separator. E.g. when the prefix is
+  # set to `foo`, and you emit a metric named `bar`, the metric name will be
+  # `foo.bar`.
+  #
+  # Generally all the metrics you emit to the same StatsD server will share a
+  # single, global namespace. If you are emitting metrics from multiple
+  # applications, using a prefix is recommended to prevent metric name
+  # collisions.
+  #
+  # You can also leave this value to be `nil` if you don't want to prefix your
+  # metric names.
+  #
+  # @return [String, nil]
+  #
+  # @note The `prefix` can be overriden by any metric call by setting the
+  #   `no_prefix` keyword argument to `true`. We recommend against doing this,
+  #   but this behavior is retained for backwards compatibility.
+  #   Rather, when you feel the need to do this, we recommend instantiating
+  #   a new client without prefix (using {#clone_with_options}), and using it
+  #   to emit the metric.
+  attr_reader :prefix
+
+  # The tags to apply to all the metrics emitted through this client.
+  #
+  # The tags can be supplied in normal form: an array of strings. You can also
+  # provide a hash, which will be turned into normal form by concatanting the
+  # key and the value using a colon. To not use any default tags, set to `nil`.
+  # Note that other components of your StatsD metric pipeline may also add tags
+  # to metrics. E.g. the DataDog agent may add add tags like `hostname`.
+  #
+  # We generally recommend to not use default tags, or use them sparingly.
+  # Adding tags to every metric easily introduces carninality explosions, which
+  # will make metrics less precise due to the lossy nature of aggregation. It
+  # also makes your infrastructure more expsnive to run, and the user interface
+  # of your metric explorer less responsive.
+  #
+  # @return [Array<String>, Hash, nil]
+  attr_reader :default_tags
+
+  # The default sample rate to use for metrics that are emitted without a
+  # sample rate set. This should be a value between 0 (never emit a metric) and
+  # 1.0 (always emit). If it is not set, the default value 1.0 is used.
+  #
+  # We generally recommend setting sample rates on individual metrics based
+  # on their frequency, rather than changing the default sample rate.
+  #
+  # @return [Float] (default: 1.0) A value between 0.0 and 1.0.
+  attr_reader :default_sample_rate
+
+  # Instantiates a new client.
+  # @see .from_env to instantiate a client using environment variables.
   def initialize(
     prefix: nil,
     default_sample_rate: 1.0,
@@ -216,18 +317,15 @@ class StatsD::Instrument::Client
     end
   end
 
-  # Emits a service check.
-  #
-  # @param [String] title Event title.
-  # @param [String] text Event description. Newlines are allowed.
-  # @param [Time] timestamp The of the event. If not provided,
-  #   Datadog will interpret it as the current timestamp.
-  # @param [String] hostname A hostname to associate with the event.
-  # @param [String] aggregation_key An aggregation key to group events with the same key.
-  # @param [String] priority Priority of the event. Either "normal" (default) or "low".
-  # @param [String] source_type_name The source type of the event.
-  # @param [String] alert_type Either "error", "warning", "info" (default) or "success".
-  # @param [Array, Hash] tags Tags to associate with the event.
+  # Emits a service check. Services Checks allow you to characterize the status
+  # of a service in order to monitor it within Datadog.
+  #
+  # @param name (see StatsD::Instrument::DogStatsDDatagramBuilder#_sc)
+  # @param status (see StatsD::Instrument::DogStatsDDatagramBuilder#_sc)
+  # @param timestamp (see StatsD::Instrument::DogStatsDDatagramBuilder#_sc)
+  # @param hostname (see StatsD::Instrument::DogStatsDDatagramBuilder#_sc)
+  # @param tags (see StatsD::Instrument::DogStatsDDatagramBuilder#_sc)
+  # @param message (see StatsD::Instrument::DogStatsDDatagramBuilder#_sc)
   # @return [void]
   #
   # @note Supported by the Datadog implementation only.
@@ -236,15 +334,17 @@ class StatsD::Instrument::Client
       timestamp: timestamp, hostname: hostname, tags: tags, message: message))
   end
 
-  # Emits an event.
+  # Emits an event. An event represents any record of activity noteworthy for engineers.
   #
-  # @param [String] name Name of the service
-  # @param [Symbol] status Either `:ok`, `:warning`, `:critical` or `:unknown`
-  # @param [Time] timestamp The moment when the service was checked. If not provided,
-  #   Datadog will interpret it as the current timestamp.
-  # @param [String] hostname A hostname to associate with the check.
-  # @param [Array, Hash] tags Tags to associate with the check.
-  # @param [String] message A message describing the current state of the service check.
+  # @param title (see StatsD::Instrument::DogStatsDDatagramBuilder#_e)
+  # @param text (see StatsD::Instrument::DogStatsDDatagramBuilder#_e)
+  # @param timestamp (see StatsD::Instrument::DogStatsDDatagramBuilder#_e)
+  # @param hostname (see StatsD::Instrument::DogStatsDDatagramBuilder#_e)
+  # @param aggregation_key (see StatsD::Instrument::DogStatsDDatagramBuilder#_e)
+  # @param priority (see StatsD::Instrument::DogStatsDDatagramBuilder#_e)
+  # @param source_type_name (see StatsD::Instrument::DogStatsDDatagramBuilder#_e)
+  # @param alert_type (see StatsD::Instrument::DogStatsDDatagramBuilder#_e)
+  # @param tags (see StatsD::Instrument::DogStatsDDatagramBuilder#_e)
   # @return [void]
   #
   # @note Supported by the Datadog implementation only.

data/lib/statsd/instrument/expectation.rb

@@ -19,10 +19,6 @@ class StatsD::Instrument::Expectation
       new(type: :s, name: name, value: value, **options)
     end
 
-    def key_value(name, value = nil, **options)
-      new(type: :kv, name: name, value: value, **options)
-    end
-
     def distribution(name, value = nil, **options)
       new(type: :d, name: name, value: value, **options)
     end

data/lib/statsd/instrument/matchers.rb

@@ -11,7 +11,6 @@ module StatsD::Instrument::Matchers
     histogram: :h,
     distribution: :d,
     set: :s,
-    key_value: :kv,
   }
 
   class Matcher

data/lib/statsd/instrument/strict.rb

@@ -79,11 +79,6 @@ module StatsD
         super
       end
 
-      def key_value(*)
-        raise NotImplementedError, "The key_value metric type will be removed " \
-          "from the next major version of statsd-instrument"
-      end
-
       private
 
       def check_block_or_numeric_value(value)

data/lib/statsd/instrument/version.rb

@@ -2,6 +2,6 @@
 
 module StatsD
   module Instrument
-    VERSION = "3.0.0.pre2"
+    VERSION = "3.0.0"
   end
 end

data/test/statsd_test.rb

@@ -55,7 +55,8 @@ class StatsDTest < Minitest::Test
 
       begin
         result = lambda.call
-      rescue # rubocop:disable Lint/HandleExceptions:
+      rescue
+        # noop
       end
     end
 
@@ -146,7 +147,8 @@ class StatsDTest < Minitest::Test
 
       begin
         result = lambda.call
-      rescue # rubocop:disable Lint/HandleExceptions
+      rescue
+        # noop
       end
     end
 

data/test/test_helper.rb

@@ -4,7 +4,7 @@ ENV['ENV'] = 'test'
 
 require 'minitest/autorun'
 require 'minitest/pride'
-require 'mocha/setup'
+require 'mocha/minitest'
 require 'statsd-instrument'
 
 require_relative 'helpers/rubocop_helper'

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: statsd-instrument
 version: !ruby/object:Gem::Version
-  version: 3.0.0.pre2
+  version: 3.0.0
 platform: ruby
 authors:
 - Jesse Storimer
@@ -10,7 +10,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-11-22 00:00:00.000000000 Z
+date: 2020-01-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake
@@ -211,9 +211,9 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ">"
+  - - ">="
     - !ruby/object:Gem::Version
-      version: 1.3.1
+      version: '0'
 requirements: []
 rubygems_version: 3.0.3
 signing_key: