statsd-instrument 2.2.0 → 2.2.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 1888f7964454431b2167c0c253ea7c53de3c1afb
-  data.tar.gz: 74c6d0f9f44eb989bcfdc44cfea912fb07c1447a
+  metadata.gz: c90b5a926408cac6e7ddb08b2828626eabb890f3
+  data.tar.gz: b006fad637fb15c07f9167e9fbe06bc889ec539f
 SHA512:
-  metadata.gz: b2faeaa7145f89905c966f08b044bb90b544f53f9bc5de0b1aa29bcf7731e3807f70ad114692a31481e19693d761f74253702791c24212f173c3254dc466f9dc
-  data.tar.gz: 8f7d60c2a4144afb033adbb18435373d7bba35702782e835642923a09dff7ec8028fbf7de655c7031aa6102a8df698685af0b71b6bca4195ca17e86cb20d01fa
+  metadata.gz: 89b66de0c70a829a3d5e884ac93b4885958c50a0e84dd157230bc798afe4b014fa836b47af5fe8cae099cd56b15b6751b20d262c453a507b70e9ee9ca858eca5
+  data.tar.gz: 2754ba8ae91ced3221bbabc16b97b6272d8cbc269888caed3e9842a5ac69433b4f444cc57cc92cd61aa7bf4becd07bffba68af6df905da1f4c4db67fd1383678

data/CHANGELOG.md

@@ -5,6 +5,10 @@ please at an entry to the "unreleased changes" section below.
 
 ### Unreleased changes
 
+### Version 2.2.1
+
+- Fix performance regression from v2.2.0
+
 ### Version 2.2.0
 
 - Add support for two new datadog specific metric types: events and service checks.

data/lib/statsd/instrument/backends/udp_backend.rb

@@ -3,6 +3,8 @@ require 'monitor'
 module StatsD::Instrument::Backends
   class UDPBackend < StatsD::Instrument::Backend
 
+    BASE_SUPPORTED_METRIC_TYPES = { c: true, ms: true, g: true, s: true }
+
     class DogStatsDProtocol
       EVENT_OPTIONS = {
         date_happened: 'd',
@@ -19,9 +21,7 @@ module StatsD::Instrument::Backends
         message: 'm',
       }
 
-      def supported?(metric)
-        [:c, :ms, :g, :h, :s, :_e, :_sc].include?(metric.type)
-      end
+      SUPPORTED_METRIC_TYPES = BASE_SUPPORTED_METRIC_TYPES.merge(h: true, _e: true, _sc: true)
 
       def generate_packet(metric)
         packet = ""
@@ -54,9 +54,7 @@ module StatsD::Instrument::Backends
     end
 
     class StatsiteStatsDProtocol
-      def supported?(metric)
-        [:c, :ms, :g, :s, :kv].include?(metric.type)
-      end
+      SUPPORTED_METRIC_TYPES = BASE_SUPPORTED_METRIC_TYPES.merge(kv: true)
 
       def generate_packet(metric)
         packet = "#{metric.name}:#{metric.value}|#{metric.type}"
@@ -67,9 +65,7 @@ module StatsD::Instrument::Backends
     end
 
     class StatsDProtocol
-      def supported?(metric)
-        [:c, :ms, :g, :s].include?(metric.type)
-      end
+      SUPPORTED_METRIC_TYPES = BASE_SUPPORTED_METRIC_TYPES
 
       def generate_packet(metric)
         packet = "#{metric.name}:#{metric.value}|#{metric.type}"
@@ -103,7 +99,7 @@ module StatsD::Instrument::Backends
     end
 
     def collect_metric(metric)
-      unless @packet_factory.supported?(metric)
+      unless @packet_factory.class::SUPPORTED_METRIC_TYPES[metric.type]
         StatsD.logger.warn("[StatsD] Metric type #{metric.type.inspect} not supported on #{implementation} implementation.")
         return false
       end

data/lib/statsd/instrument/version.rb

@@ -1,5 +1,5 @@
 module StatsD
   module Instrument
-    VERSION = "2.2.0"
+    VERSION = "2.2.1"
   end
 end

data/test/benchmark/metrics.rb

@@ -0,0 +1,38 @@
+require 'statsd-instrument'
+require 'benchmark/ips'
+
+def helperFunction()
+    a = 10
+    a += a
+    a -= a
+    a *= a
+end
+
+Benchmark.ips do |bench|
+  bench.report("increment metric benchmark") do
+    StatsD.increment('GoogleBase.insert', 10)
+  end
+
+  bench.report("measure metric benchmark") do
+    StatsD.measure('helperFunction') do
+        helperFunction()
+    end
+  end
+
+  bench.report("gauge metric benchmark") do
+    StatsD.gauge('GoogleBase.insert', 12)
+  end
+
+  bench.report("set metric benchmark") do
+    StatsD.set('GoogleBase.customers', "12345", sample_rate: 1.0)
+  end
+
+  bench.report("event metric benchmark") do
+    StatsD.event('Event Title', "12345")
+  end
+
+  bench.report("service check metric benchmark") do
+    StatsD.service_check('shipit.redis_connection', 'ok')
+  end
+
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: statsd-instrument
 version: !ruby/object:Gem::Version
-  version: 2.2.0
+  version: 2.2.1
 platform: ruby
 authors:
 - Jesse Storimer
@@ -10,7 +10,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-05-18 00:00:00.000000000 Z
+date: 2018-05-23 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake
@@ -130,6 +130,7 @@ files:
 - shipit.rubygems.yml
 - statsd-instrument.gemspec
 - test/assertions_test.rb
+- test/benchmark/metrics.rb
 - test/benchmark/tags.rb
 - test/capture_backend_test.rb
 - test/environment_test.rb
@@ -168,6 +169,7 @@ specification_version: 4
 summary: A StatsD client for Ruby apps
 test_files:
 - test/assertions_test.rb
+- test/benchmark/metrics.rb
 - test/benchmark/tags.rb
 - test/capture_backend_test.rb
 - test/environment_test.rb