statsd-instrument 1.6.1 → 1.6.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: eafc53f3cd8857fd2bc0f1de1f00c8d4802426c5
-  data.tar.gz: 993e07dfc30fd46a5543e24a7068d058bcf97937
+  metadata.gz: 4332f173929c941bac2a915fed3be82bc447dec3
+  data.tar.gz: 52aa66f9144a09740da7767d59e4846ff38d5ffe
 SHA512:
-  metadata.gz: 21c9947c51f5882d1abcfb489b717652f17935d0c8c3884efc33a582cdc85cb33199ff3d71d0751078c3a061dd526a0702d5a68989d52a9046328fcb8615b47d
-  data.tar.gz: 07c43360b7bce08753d2f8455000a7bad26bda5a3b5e0366b37b10f5e8cca9a87028067d1e469d107973aea0c56a9abc2411f0faf29eb9fddaae4b22145ec5f0
+  metadata.gz: 57f6a5a32129aa3b62d76565e42d941bba4c83602454f4e05fb1383b201b826a1fd6aa120d74da5e1cd10340a528ed51ab0bcfb3e7eedc343ad8f3f2571033b9
+  data.tar.gz: 8b76f2cdf7d83ce7dd9054b882129797b5d884cabd16c699fb6e29c7e3692723ecb6d361b6df91dca4b53be6e0b9de755735fd0df356fc6c880522f79a88cd18

data/.travis.yml

@@ -2,6 +2,6 @@ language: ruby
 rvm:
   - 1.8.7
   - ree
-  - 1.9.2
   - 1.9.3
   - 2.0.0
+  - 2.1.0

data/README.md

@@ -19,16 +19,29 @@ This is the same as what Etsy uses (mentioned in the README for http://github.co
 ## Configuration
 
 ``` ruby
-StatsD.server = 'statsd.myservice.com:8125'
-StatsD.logger = Rails.logger
+# The UDP endpoint to which you want to submit your metrics.
+# This is set to the environment variable STATSD_ADDR if it is set.
+StatsD.server = 'statsd.myservice.com:8125' 
+
+# Events are only actually submitted in production mode. For any other value, thewy are logged instead
+# This value is set by to the value of the RAILS_ENV or RACK_ENV environment variable if it is set.
 StatsD.mode = :production
-StatsD.prefix = 'my_app' # An optional prefix to be added to each stat.
-StatsD.default_sample_rate = 0.1 # Sample 10% of events. By default all events are reported.
-```
 
-If you set the mode to anything besides production then the library will print its calls to the logger, rather than sending them over the wire.
+# Logger to which commands are logged when not in :production mode.
+# In  production only errors are logged to the console.
+StatsD.logger = Rails.logger
+
+# An optional prefix to be added to each stat.
+StatsD.prefix = 'my_app' 
+
+# Sample 10% of events. By default all events are reported, which may overload your network or server.
+# You can, and should vary this on a per metric basis, depending on frequency and accuracy requirements
+StatsD.default_sample_rate = 0.1 
+
+
+```
 
-There are several implementations of StatsD out there, all with slight protocol variations. You can this library to use the proper protocol by informing it about what implementation you use. By default, it will use the protocol of the original Etsy implementation.
+There are several implementations of StatsD out there, all with slight protocol variations. You can this library to use the proper protocol by informing it about what implementation you use. By default, it will use the `STATSD_IMPLEMENTATION` environment variable, if it is not set it will use the protocol of the original Etsy implementation.
 
 ```
 StatsD.implementation = :datadog  # Enable datadog extensions: tags and histograms
@@ -41,7 +54,9 @@ StatsD keys look like 'admin.logins.api.success'. Each dot in the key represents
 
 ## Usage
 
-### StatsD.measure
+You can either use the basic methods to submit stats over StatsD, or you can use the metaprogramming methods to instrument your methods with some basic stats (call counts, successes & failures, and timings).
+
+#### StatsD.measure
 
 Lets you benchmark how long the execution of a specific method takes.
 
@@ -54,15 +69,8 @@ StatsD.measure('GoogleBase.insert') do
   GoogleBase.insert(product)
 end
 ```
-
-Rather than using this method directly it's more common to use the metaprogramming methods made available.
-
-``` ruby
-GoogleBase.extend StatsD::Instrument
-GoogleBase.statsd_measure :insert, 'GoogleBase.insert'
-```
 		
-### StatsD.increment
+#### StatsD.increment
 
 Lets you increment a key in statsd to keep a count of something. If the specified key doesn't exist it will create it for you.
 
@@ -76,9 +84,28 @@ StatsD.increment('GoogleBase.insert', 10)
 StatsD.increment('GoogleBase.insert', 1, 0.1)
 ```
 
-Again it's more common to use the metaprogramming methods.
+#### StatsD.gauge
 
-## Metaprogramming Methods
+A gauge is a single numerical value value that tells you the state of the system at a point in time. A good example would be the number of messages in a queue.
+
+``` ruby
+StatsD.gauge('GoogleBase.queued', 12, 1.0)
+```
+
+Normally, you shouldn't update this value too often, and therefore there is no need to sample this kind metric.
+
+#### StatsD.set
+
+A set keeps track of the number of unique values that have been seen. This is a good fit for keeping track of the number of unique visitors. The value can be a string.
+
+``` ruby
+# Submit the customer ID to the set. It will only be counted if it hasn't been seen before.
+StatsD.set('GoogleBase.customers', "12345", 1.0)
+```
+
+Because you are counting unique values, the results of using a sampling value less than 1.0 can lead to unexpected, hard to interpret results.
+
+### Metaprogramming Methods
 
 As mentioned, it's most common to use the provided metaprogramming methods. This lets you define all of your instrumentation in one file and not litter your code with instrumentation details. You should enable a class for instrumentation by extending it with the `StatsD::Instrument` class.
 
@@ -88,7 +115,15 @@ GoogleBase.extend StatsD::Instrument
 
 Then use the methods provided below to instrument methods in your class.
 
-### statsd\_count
+#### statsd\_measure
+
+This will measure how long a method takes to run, and submits the result to the given key.
+
+``` ruby
+GoogleBase.statsd_measure :insert, 'GoogleBase.insert'
+```
+
+#### statsd\_count
 
 This will increment the given key even if the method doesn't finish (ie. raises).
 
@@ -98,7 +133,7 @@ GoogleBase.statsd_count :insert, 'GoogleBase.insert'
 
 Note how I used the 'GoogleBase.insert' key above when measuring this method, and I reused here when counting the method calls. StatsD automatically separates these two kinds of stats into namespaces so there won't be a key collision here.
 
-### statsd\_count\_if
+#### statsd\_count\_if
 
 This will only increment the given key if the method executes successfully.
 
@@ -116,7 +151,7 @@ end
 
 In the above example we will only increment the key in statsd if the result of the block returns true. So the method is returning a Net::HTTP response and we're checking the status code.
 
-### statsd\_count\_success
+#### statsd\_count\_success
 
 Similar to statsd_count_if, except this will increment one key in the case of success and another key in the case of failure.
 
@@ -170,8 +205,16 @@ Tested on several Ruby versions using Travis CI:
 
 * Ruby 1.8.7
 * Ruby Enterprise Edition 1.8.7
-* Ruby 1.9.2
 * Ruby 1.9.3
 * Ruby 2.0.0
+* Ruby 2.1.0
+
+## Contributing
+
+This project is MIT licensed and welcomes outside contributions.
 
-Ruby 2.0 compatibility is planned for the long term. Your mileage may vary with other Ruby environments.
+1. Fork the repository, and create a feature branch.
+2. Implement the feature, and add tests that cover the new changes functionality.
+3. Update the README.
+4. Create a pull request. Make sure that you get a CI pass on it.
+5. Ping @jstorimer and/or @wvanbergen for review.

data/lib/statsd/instrument.rb

@@ -156,6 +156,11 @@ module StatsD
     collect(key, value, :h, sample_rate_or_epoch, tags)
   end  
 
+  # uniques:765|s
+  def self.set(key, value, sample_rate_or_epoch = default_sample_rate, tags = nil)
+    collect(key, value, :s, sample_rate_or_epoch, tags)
+  end
+
   private
 
   def self.invalidate_socket
@@ -209,6 +214,8 @@ module StatsD
     when :h
       raise NotImplementedError, "Histograms only supported on DataDog implementation." unless self.implementation == :datadog
       command << '|h'
+    when :s
+      command << '|s'
     end
 
     command << "|@#{sample_rate}" if sample_rate < 1 || (self.implementation == :statsite && sample_rate > 1)
@@ -226,3 +233,4 @@ StatsD.enabled = true
 StatsD.default_sample_rate = 1.0
 StatsD.implementation = ENV.fetch('STATSD_IMPLEMENTATION', 'statsd').to_sym
 StatsD.server = ENV['STATSD_ADDR'] if ENV.has_key?('STATSD_ADDR')
+StatsD.mode = ENV['RAILS_ENV'] || ENV['RACK_ENV'] || 'development'

data/lib/statsd/instrument/version.rb

@@ -1,5 +1,5 @@
 module StatsD
   module Instrument
- 	  VERSION = "1.6.1"
+    VERSION = "1.6.2"
   end
 end

data/test/statsd_test.rb

@@ -38,6 +38,11 @@ class StatsDTest < Test::Unit::TestCase
     StatsD.gauge('values.foobar', 12)
   end
 
+  def test_statsd_set
+    StatsD.expects(:collect).with('values.foobar', 12, :s, 1.0, nil)
+    StatsD.set('values.foobar', 12)
+  end
+
   def test_statsd_histogram_on_datadog
     StatsD.stubs(:implementation).returns(:datadog)
     StatsD.expects(:collect).with('values.hg', 12.33, :h, 0.2, ['tag_123', 'key-name:value123'])
@@ -76,6 +81,14 @@ class StatsDTest < Test::Unit::TestCase
     StatsD.gauge('fooy', 42, 0.01)
   end
 
+  def test_supports_set_syntax
+    StatsD.expects(:write_packet).with('unique:10.0.0.10|s')
+    StatsD.set('unique', '10.0.0.10')
+
+    StatsD.expects(:write_packet).with('unique:10.0.0.10|s|@0.01')
+    StatsD.set('unique', '10.0.0.10', 0.01)
+  end
+
   def test_support_timing_syntax
     StatsD.expects(:write_packet).with('duration:1.23|ms')
     StatsD.measure('duration', 1.23)

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: statsd-instrument
 version: !ruby/object:Gem::Version
-  version: 1.6.1
+  version: 1.6.2
 platform: ruby
 authors:
 - Jesse Storimer
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-02-05 00:00:00.000000000 Z
+date: 2014-02-06 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake