stats 0.1.0 → 0.2.0

data/Rakefile

@@ -30,7 +30,7 @@ begin
     gemspec.email = "matt@mattduncan.org"
     gemspec.homepage = "http://github.com/mrduncan/stats"
     gemspec.authors = ["Matt Duncan"]
-    gemspec.version = '0.1.0'
+    gemspec.version = '0.2.0'
     gemspec.add_dependency 'redis'
     gemspec.description = <<description
 The stats gem is a simple way to keep track of different statistics using

data/lib/stats.rb

@@ -29,6 +29,11 @@ module Stats
     Stats.redis.decrby(name, by)
   end
 
+  # Returns the value of the counter with the specified name.
+  def counter(name)
+    Stats.redis.get(name).to_i
+  end
+
   # Clears the stat with the specified name.
   def clear(name)
     Stats.redis.del(name)

data/lib/stats/times.rb

@@ -2,8 +2,7 @@ module Stats
   module Times
     # Returns the timing data for the stat with the specified name.
     def get_times(name)
-      times = Stats.redis.lrange(name, 0, -1)
-      TimingStat.new(times.map { |t| t.to_f })
+      TimingStat.new(Stats.redis.lrange(name, 0, -1).map { |time| time.to_f })
     end
 
     # Adds a new time for the stat with the specified name.

data/lib/stats/timing_stat.rb

@@ -1,19 +1,22 @@
 module Stats
   class TimingStat < Array
     # Returns the average value.
-    def average
+    def avg
+      return nil if length == 0
       sum / length.to_f
     end
 
-    # Returns the sample variance of the values.
-    def population_variance
-      avg = average
-      1 / length.to_f * inject(0) { |acc, i| acc + (i - avg) ** 2 }
+    # Returns the population variance of the values.
+    def pop_var
+      return nil if length == 0
+      average = avg
+      1 / length.to_f * inject(0) { |acc, i| acc + (i - average) ** 2 }
     end
 
     # Returns the standard deviation of the values.
-    def standard_deviation
-      Math.sqrt(population_variance)
+    def std_dev
+      return nil if length == 0
+      Math.sqrt(pop_var)
     end
 
     private

data/test/integration/test_stats.rb

@@ -5,7 +5,7 @@ require 'stats'
 class TestStats < Test::Unit::TestCase
   def setup
     Stats.redis = 'localhost:6379:stats_test'
-    Stats.redis.flush_db
+    Stats.redis.flushdb
   end
 
   def test_should_set
@@ -16,19 +16,19 @@ class TestStats < Test::Unit::TestCase
   end
 
   def test_should_increment
-    assert_equal 0, Stats.get("downloads").to_i
+    assert_equal 0, Stats.counter("downloads")
     Stats.incr("downloads")
-    assert_equal 1, Stats.get("downloads").to_i
+    assert_equal 1, Stats.counter("downloads")
     Stats.incr("downloads", 2)
-    assert_equal 3, Stats.get("downloads").to_i
+    assert_equal 3, Stats.counter("downloads")
   end
 
   def test_should_decrement
     Stats.set("invitations", 100)
     Stats.decr("invitations")
-    assert_equal 99, Stats.get("invitations").to_i
+    assert_equal 99, Stats.counter("invitations")
     Stats.decr("invitations", 4)
-    assert_equal 95, Stats.get("invitations").to_i
+    assert_equal 95, Stats.counter("invitations")
   end
 
   def test_should_clear

data/test/unit/test_stats.rb

@@ -67,6 +67,12 @@ class TestStats < Test::Unit::TestCase
     Stats.decr("tickets_left", 4)
   end
 
+  def test_should_get_counter
+    Stats.redis = mock('redis')
+    Stats.redis.expects(:get).with("downloads").returns("10")
+    assert_equal 10, Stats.counter("downloads")
+  end
+
   def test_should_clear
     Stats.redis = mock('redis')
     Stats.redis.expects(:del).with("downloads")

data/test/unit/test_timing_stat.rb

@@ -3,15 +3,27 @@ require 'mocha'
 require 'stats'
 
 class TestStats < Test::Unit::TestCase
-  def test_should_average
-    assert_equal 2.0, Stats::TimingStat.new([1, 2, 2, 3]).average
+  def test_should_avg
+    assert_equal 2.0, Stats::TimingStat.new([1, 2, 2, 3]).avg
   end
 
-  def test_should_get_population_variance
-    assert_equal 0.25, Stats::TimingStat.new([1, 1, 2, 2]).population_variance
+  def test_should_have_avg_of_nil_with_no_data
+    assert_nil Stats::TimingStat.new([]).avg
   end
 
-  def test_should_get_standard_deviation
-    assert_equal 0.5, Stats::TimingStat.new([1, 1, 2, 2]).standard_deviation
+  def test_should_get_pop_var
+    assert_equal 0.25, Stats::TimingStat.new([1, 1, 2, 2]).pop_var
+  end
+
+  def test_should_have_pop_var_of_nil_with_no_data
+    assert_nil Stats::TimingStat.new([]).pop_var
+  end
+
+  def test_should_get_std_dev
+    assert_equal 0.5, Stats::TimingStat.new([1, 1, 2, 2]).std_dev
+  end
+
+  def test_should_have_std_dev_of_nil_with_no_data
+    assert_nil Stats::TimingStat.new([]).std_dev
   end
 end

metadata

@@ -4,9 +4,9 @@ version: !ruby/object:Gem::Version
   prerelease: false
   segments: 
   - 0
-  - 1
+  - 2
   - 0
-  version: 0.1.0
+  version: 0.2.0
 platform: ruby
 authors: 
 - Matt Duncan
@@ -14,7 +14,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2010-04-17 00:00:00 -04:00
+date: 2010-05-09 00:00:00 -04:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency