statisfy 0.0.2 → 0.0.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 42017075ea6e11814c69273dad495fed1143fe56c84cca652f52c45e44f58be6
-  data.tar.gz: 855f430c83b255b10228675c387947689cfd4dc3147073f65e56c15acb2bd485
+  metadata.gz: e3a10099a0ae5de62cc548fc5eed38c6d05c06b3bc04f4e32846627024260325
+  data.tar.gz: bc282b5f30c8ae07565ae24f8352f2724860a76b763c8be4d1e18484c76d4a3e
 SHA512:
-  metadata.gz: 8b716fee4967f50c59a19a4becfffa8097593bb22cd5ffbe60bea6dcae0d6a0fe4bc1be017e91c38c4f1f465f87a765e51d097e14ac8bb02ba344887a5bd9565
-  data.tar.gz: 21b5db159bc50e44c42b67b8ccbbb4d7b8f7f650f52f273983afcf4bc9ac5c5cc5be2553ed9ce3a2190fbc97e16c4b2dc521ae5c3f943cc1186a0e3093ba6494
+  metadata.gz: bfc687b9a1f56733ccb8c484e39f6b7d79c7844bedc5f46963eeb478568ee45c7c8278d3725aec189058d2076aff4deb304a905c23d770d22b9d76a95f3dbf3e
+  data.tar.gz: 4115d693fda17370ebe46a34088159ac39986b77280c7e8894bc39b1cf060562dd0c00adfac6743e0429918cdfc164a5f1ccee3dee0463a9246bc35f87409bed

data/lib/statisfy/counter.rb

@@ -46,7 +46,9 @@ module Statisfy
         define_method(:value, args[:value] || -> {})
         define_method(:should_run?, args[:if] || -> { true })
         define_method(:on_destroy, args[:on_destroy]) if args[:on_destroy].present?
-        define_method(:decrement_on_destroy?, args[:decrement_on_destroy].is_a?(Proc) ? args[:decrement_on_destroy] : -> { args[:decrement_on_destroy] || false })
+        define_method(:decrement_on_destroy?, args[:decrement_on_destroy].is_a?(Proc) ? args[:decrement_on_destroy] : lambda {
+                                                                                                                        args[:decrement_on_destroy] || true
+                                                                                                                      })
       end
 
       #
@@ -64,14 +66,10 @@ module Statisfy
         if const_get(:COUNTER_TYPE) == :aggregate
           average(scope:, month:)
         else
-          size(scope:, month:)
+          elements_in(scope:, month:).uniq.size
         end
       end
 
-      def size(scope: nil, month: nil)
-        redis_client.scard(key_for(scope:, month:))
-      end
-
       #
       # Returns the list of elements in the set (in case you use .append and not .increment)
       #
@@ -173,11 +171,7 @@ module Statisfy
       return if destroy_event_handled?
       return unless if_async
 
-      if value.present?
-        append(value:)
-      else
-        decrement? ? decrement : increment
-      end
+      decrement? ? decrement : increment
     end
 
     def destroy_event_handled?
@@ -201,29 +195,20 @@ module Statisfy
     def all_counters
       [month_to_set, nil].each do |month|
         scopes_with_global.each do |scope|
-          yield self.class.key_for(scope:, month:), identifier
+          yield self.class.key_for(scope:, month:)
         end
       end
     end
 
     def increment
-      all_counters do |key, id|
-        self.class.redis_client.sadd?(key, id)
+      all_counters do |key|
+        self.class.redis_client.rpush(key, value || identifier)
       end
     end
 
     def decrement
-      all_counters do |key, id|
-        self.class.redis_client.srem?(key, id)
-      end
-    end
-
-    #
-    # To be used to store a list of values instead of a basic counter
-    #
-    def append(value:)
       all_counters do |key|
-        self.class.redis_client.rpush(key, value)
+        self.class.redis_client.lrem(key, 1, value || identifier)
       end
     end
   end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: statisfy
 version: !ruby/object:Gem::Version
-  version: 0.0.2
+  version: 0.0.3
 platform: ruby
 authors:
 - Michaël Villeneuve